All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OCFS2: remove dlm_lock_is_remote
@ 2020-01-21  3:43 Alex Shi
  2020-01-26  1:48   ` [Ocfs2-devel] " Joseph Qi
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Shi @ 2020-01-21  3:43 UTC (permalink / raw)
  Cc: Mark Fasheh, Joel Becker, Joseph Qi, Kate Stewart,
	Greg Kroah-Hartman, Thomas Gleixner, Richard Fontana,
	ocfs2-devel, linux-kernel

This macros is also not used from it was introduced. better to remove
it.

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com> 
Cc: Joel Becker <jlbec@evilplan.org> 
Cc: Joseph Qi <joseph.qi@linux.alibaba.com> 
Cc: Kate Stewart <kstewart@linuxfoundation.org> 
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
Cc: Thomas Gleixner <tglx@linutronix.de> 
Cc: Richard Fontana <rfontana@redhat.com> 
Cc: ocfs2-devel@oss.oracle.com 
Cc: linux-kernel@vger.kernel.org 
---
 fs/ocfs2/dlm/dlmthread.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
index 2dd9727537fe..0da9ffc40a88 100644
--- a/fs/ocfs2/dlm/dlmthread.c
+++ b/fs/ocfs2/dlm/dlmthread.c
@@ -39,8 +39,6 @@
 static int dlm_thread(void *data);
 static void dlm_flush_asts(struct dlm_ctxt *dlm);
 
-#define dlm_lock_is_remote(dlm, lock)     ((lock)->ml.node != (dlm)->node_num)
-
 /* will exit holding res->spinlock, but may drop in function */
 /* waits until flags are cleared on res->state */
 void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OCFS2: remove dlm_lock_is_remote
  2020-01-21  3:43 [PATCH] OCFS2: remove dlm_lock_is_remote Alex Shi
@ 2020-01-26  1:48   ` Joseph Qi
  0 siblings, 0 replies; 3+ messages in thread
From: Joseph Qi @ 2020-01-26  1:48 UTC (permalink / raw)
  To: Alex Shi, Andrew Morton
  Cc: Mark Fasheh, Joel Becker, Kate Stewart, Greg Kroah-Hartman,
	Thomas Gleixner, Richard Fontana, ocfs2-devel, linux-kernel



On 20/1/21 11:43, Alex Shi wrote:
> This macros is also not used from it was introduced. better to remove
> it.
> 
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Mark Fasheh <mark@fasheh.com> 
> Cc: Joel Becker <jlbec@evilplan.org> 
> Cc: Joseph Qi <joseph.qi@linux.alibaba.com> 
> Cc: Kate Stewart <kstewart@linuxfoundation.org> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
> Cc: Thomas Gleixner <tglx@linutronix.de> 
> Cc: Richard Fontana <rfontana@redhat.com> 
> Cc: ocfs2-devel@oss.oracle.com 
> Cc: linux-kernel@vger.kernel.org

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com> 
> ---
>  fs/ocfs2/dlm/dlmthread.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
> index 2dd9727537fe..0da9ffc40a88 100644
> --- a/fs/ocfs2/dlm/dlmthread.c
> +++ b/fs/ocfs2/dlm/dlmthread.c
> @@ -39,8 +39,6 @@
>  static int dlm_thread(void *data);
>  static void dlm_flush_asts(struct dlm_ctxt *dlm);
>  
> -#define dlm_lock_is_remote(dlm, lock)     ((lock)->ml.node != (dlm)->node_num)
> -
>  /* will exit holding res->spinlock, but may drop in function */
>  /* waits until flags are cleared on res->state */
>  void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Ocfs2-devel] [PATCH] OCFS2: remove dlm_lock_is_remote
@ 2020-01-26  1:48   ` Joseph Qi
  0 siblings, 0 replies; 3+ messages in thread
From: Joseph Qi @ 2020-01-26  1:48 UTC (permalink / raw)
  To: Alex Shi, Andrew Morton
  Cc: Mark Fasheh, Joel Becker, Kate Stewart, Greg Kroah-Hartman,
	Thomas Gleixner, Richard Fontana, ocfs2-devel, linux-kernel



On 20/1/21 11:43, Alex Shi wrote:
> This macros is also not used from it was introduced. better to remove
> it.
> 
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Mark Fasheh <mark@fasheh.com> 
> Cc: Joel Becker <jlbec@evilplan.org> 
> Cc: Joseph Qi <joseph.qi@linux.alibaba.com> 
> Cc: Kate Stewart <kstewart@linuxfoundation.org> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
> Cc: Thomas Gleixner <tglx@linutronix.de> 
> Cc: Richard Fontana <rfontana@redhat.com> 
> Cc: ocfs2-devel at oss.oracle.com 
> Cc: linux-kernel at vger.kernel.org

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com> 
> ---
>  fs/ocfs2/dlm/dlmthread.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
> index 2dd9727537fe..0da9ffc40a88 100644
> --- a/fs/ocfs2/dlm/dlmthread.c
> +++ b/fs/ocfs2/dlm/dlmthread.c
> @@ -39,8 +39,6 @@
>  static int dlm_thread(void *data);
>  static void dlm_flush_asts(struct dlm_ctxt *dlm);
>  
> -#define dlm_lock_is_remote(dlm, lock)     ((lock)->ml.node != (dlm)->node_num)
> -
>  /* will exit holding res->spinlock, but may drop in function */
>  /* waits until flags are cleared on res->state */
>  void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-26  1:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21  3:43 [PATCH] OCFS2: remove dlm_lock_is_remote Alex Shi
2020-01-26  1:48 ` Joseph Qi
2020-01-26  1:48   ` [Ocfs2-devel] " Joseph Qi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.