All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] runner: Clean up quickly if the kernel OOPSed during a test
@ 2020-01-21 11:17 Chris Wilson
  2020-01-21 11:55 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Chris Wilson @ 2020-01-21 11:17 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala

If the kernel OOPSed during the test, it is unlikely to ever complete.
Furthermore, we have the reason why it won't complete and so do not need
to burden ourselves with the full stacktrace of every process -- or at
least we have a more pressing bug to fix before worrying about the
system deadlock.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Petri Latvala <petri.latvala@intel.com>
---
 runner/executor.c | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index f36bfd3dd..00cd3b08a 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -314,13 +314,28 @@ static const struct {
   {(1 << 9), "TAINT_WARN: WARN_ON has happened."},
   {0, 0}};
 
+static unsigned long bad_taints(void)
+{
+	static unsigned long __bad_taints;
+
+	if (!__bad_taints) {
+		for (typeof(*abort_taints) *taint = abort_taints;
+		     taint->bit;
+		     taint++)
+			__bad_taints |= taint->bit;
+	}
+
+	return __bad_taints;
+}
+
+static unsigned long is_tainted(unsigned long taints)
+{
+	return taints & bad_taints();
+}
+
 static unsigned long tainted(unsigned long *taints)
 {
 	FILE *f;
-	unsigned long bad_taints = 0;
-
-	for (typeof(*abort_taints) *taint = abort_taints; taint->bit; taint++)
-		bad_taints |= taint->bit;
 
 	*taints = 0;
 
@@ -330,7 +345,7 @@ static unsigned long tainted(unsigned long *taints)
 		fclose(f);
 	}
 
-	return *taints & bad_taints;
+	return is_tainted(*taints);
 }
 
 static char *handle_taint(void)
@@ -744,13 +759,17 @@ static int monitor_output(pid_t child,
 			return -1;
 		}
 
+		if (tainted(&taints)) /* cancel children after a kernel OOPS */
+			n = 0, intervals_left = 1;
+
 		if (n == 0) {
 			if (--intervals_left)
 				continue;
 
 			switch (killed) {
 			case 0:
-				show_kernel_task_state();
+				if (!is_tainted(taints))
+					show_kernel_task_state();
 
 				if (settings->log_level >= LOG_LEVEL_NORMAL) {
 					outf("Timeout. Killing the current test with SIGQUIT.\n");
@@ -791,7 +810,7 @@ static int monitor_output(pid_t child,
 				intervals_left = 1; /* Intervals handled separately for sigkill */
 				break;
 			case SIGKILL:
-				if (!tainted(&taints) && --sigkill_intervals_left) {
+				if (!is_tainted(taints) && --sigkill_intervals_left) {
 					intervals_left = 1;
 					break;
 				}
-- 
2.25.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-01-22 13:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 11:17 [igt-dev] [PATCH i-g-t] runner: Clean up quickly if the kernel OOPSed during a test Chris Wilson
2020-01-21 11:55 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-21 12:28 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2020-01-21 12:59 ` Chris Wilson
2020-01-21 13:45   ` Petri Latvala
2020-01-21 14:05 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Clean up quickly if the kernel OOPSed during a test (rev2) Patchwork
2020-01-22  8:50 ` [igt-dev] ✓ Fi.CI.IGT: success for runner: Clean up quickly if the kernel OOPSed during a test Patchwork
2020-01-22 13:39 ` [igt-dev] ✗ Fi.CI.IGT: failure for runner: Clean up quickly if the kernel OOPSed during a test (rev2) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.