* [PATCH] drm: Release filp before global lock
@ 2020-01-22 15:56 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2020-01-22 15:56 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
The file is not part of the global drm resource and can be released
prior to take the global mutex to drop the open_count (and potentially
close) the drm device.
However, inside drm_close_helper() there are a number of dev->driver
callbacks that take the drm_device as the first parameter... Worryingly
some of those callbacks may be (implicitly) depending on the global
mutex.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/drm_file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 92d16724f949..84ed313ee2e9 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
struct drm_minor *minor = file_priv->minor;
struct drm_device *dev = minor->dev;
- mutex_lock(&drm_global_mutex);
-
DRM_DEBUG("open_count = %d\n", dev->open_count);
drm_close_helper(filp);
+ mutex_lock(&drm_global_mutex);
+
if (!--dev->open_count)
drm_lastclose(dev);
--
2.25.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH] drm: Release filp before global lock
@ 2020-01-22 15:56 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2020-01-22 15:56 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx
The file is not part of the global drm resource and can be released
prior to take the global mutex to drop the open_count (and potentially
close) the drm device.
However, inside drm_close_helper() there are a number of dev->driver
callbacks that take the drm_device as the first parameter... Worryingly
some of those callbacks may be (implicitly) depending on the global
mutex.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/drm_file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 92d16724f949..84ed313ee2e9 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
struct drm_minor *minor = file_priv->minor;
struct drm_device *dev = minor->dev;
- mutex_lock(&drm_global_mutex);
-
DRM_DEBUG("open_count = %d\n", dev->open_count);
drm_close_helper(filp);
+ mutex_lock(&drm_global_mutex);
+
if (!--dev->open_count)
drm_lastclose(dev);
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] drm: Release filp before global lock
2020-01-22 15:56 ` [Intel-gfx] " Chris Wilson
@ 2020-01-22 21:52 ` Thomas Hellström (VMware)
-1 siblings, 0 replies; 15+ messages in thread
From: Thomas Hellström (VMware) @ 2020-01-22 21:52 UTC (permalink / raw)
To: Chris Wilson, dri-devel; +Cc: intel-gfx
Hi, Chris,
On 1/22/20 4:56 PM, Chris Wilson wrote:
> The file is not part of the global drm resource and can be released
> prior to take the global mutex to drop the open_count (and potentially
> close) the drm device.
>
> However, inside drm_close_helper() there are a number of dev->driver
> callbacks that take the drm_device as the first parameter... Worryingly
> some of those callbacks may be (implicitly) depending on the global
> mutex.
I read this as you suspect that there are driver callbacks inside
drm_close_helper() that might need the global mutex held? But then it
wouldn't be safe to move the lock? Is there a strong motivation for
moving the locking in the first place? Also a minor nit below:
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/drm_file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 92d16724f949..84ed313ee2e9 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
> struct drm_minor *minor = file_priv->minor;
> struct drm_device *dev = minor->dev;
>
> - mutex_lock(&drm_global_mutex);
> -
> DRM_DEBUG("open_count = %d\n", dev->open_count);
The read of dev->open_count should still be inside the lock to be
consistent with the value that is decremented below. Perhaps move the
DRM_DEBUG()?
>
> drm_close_helper(filp);
>
> + mutex_lock(&drm_global_mutex);
> +
> if (!--dev->open_count)
> drm_lastclose(dev);
>
Thanks,
Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: Release filp before global lock
@ 2020-01-22 21:52 ` Thomas Hellström (VMware)
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Hellström (VMware) @ 2020-01-22 21:52 UTC (permalink / raw)
To: Chris Wilson, dri-devel; +Cc: intel-gfx
Hi, Chris,
On 1/22/20 4:56 PM, Chris Wilson wrote:
> The file is not part of the global drm resource and can be released
> prior to take the global mutex to drop the open_count (and potentially
> close) the drm device.
>
> However, inside drm_close_helper() there are a number of dev->driver
> callbacks that take the drm_device as the first parameter... Worryingly
> some of those callbacks may be (implicitly) depending on the global
> mutex.
I read this as you suspect that there are driver callbacks inside
drm_close_helper() that might need the global mutex held? But then it
wouldn't be safe to move the lock? Is there a strong motivation for
moving the locking in the first place? Also a minor nit below:
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/drm_file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 92d16724f949..84ed313ee2e9 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
> struct drm_minor *minor = file_priv->minor;
> struct drm_device *dev = minor->dev;
>
> - mutex_lock(&drm_global_mutex);
> -
> DRM_DEBUG("open_count = %d\n", dev->open_count);
The read of dev->open_count should still be inside the lock to be
consistent with the value that is decremented below. Perhaps move the
DRM_DEBUG()?
>
> drm_close_helper(filp);
>
> + mutex_lock(&drm_global_mutex);
> +
> if (!--dev->open_count)
> drm_lastclose(dev);
>
Thanks,
Thomas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm: Release filp before global lock
2020-01-22 21:52 ` [Intel-gfx] " Thomas Hellström (VMware)
@ 2020-01-22 22:00 ` Chris Wilson
-1 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2020-01-22 22:00 UTC (permalink / raw)
To: Thomas Hellström (VMware), dri-devel; +Cc: intel-gfx
Quoting Thomas Hellström (VMware) (2020-01-22 21:52:23)
> Hi, Chris,
>
> On 1/22/20 4:56 PM, Chris Wilson wrote:
> > The file is not part of the global drm resource and can be released
> > prior to take the global mutex to drop the open_count (and potentially
> > close) the drm device.
> >
> > However, inside drm_close_helper() there are a number of dev->driver
> > callbacks that take the drm_device as the first parameter... Worryingly
> > some of those callbacks may be (implicitly) depending on the global
> > mutex.
>
> I read this as you suspect that there are driver callbacks inside
> drm_close_helper() that might need the global mutex held? But then it
> wouldn't be safe to move the lock? Is there a strong motivation for
> moving the locking in the first place? Also a minor nit below:
The number of processes stuck on 'D' due to mutex_lock(&global) caught my
attention while they were cleaning up files. I think everyone else will
be less impressed if their driver was stuck because i915 was freeing a
user's filp.
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/drm_file.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> > index 92d16724f949..84ed313ee2e9 100644
> > --- a/drivers/gpu/drm/drm_file.c
> > +++ b/drivers/gpu/drm/drm_file.c
> > @@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
> > struct drm_minor *minor = file_priv->minor;
> > struct drm_device *dev = minor->dev;
> >
> > - mutex_lock(&drm_global_mutex);
> > -
> > DRM_DEBUG("open_count = %d\n", dev->open_count);
>
> The read of dev->open_count should still be inside the lock to be
> consistent with the value that is decremented below. Perhaps move the
> DRM_DEBUG()?
Sure. Is it even worth a debug?
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: Release filp before global lock
@ 2020-01-22 22:00 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2020-01-22 22:00 UTC (permalink / raw)
To: Thomas Hellström (VMware), dri-devel; +Cc: intel-gfx
Quoting Thomas Hellström (VMware) (2020-01-22 21:52:23)
> Hi, Chris,
>
> On 1/22/20 4:56 PM, Chris Wilson wrote:
> > The file is not part of the global drm resource and can be released
> > prior to take the global mutex to drop the open_count (and potentially
> > close) the drm device.
> >
> > However, inside drm_close_helper() there are a number of dev->driver
> > callbacks that take the drm_device as the first parameter... Worryingly
> > some of those callbacks may be (implicitly) depending on the global
> > mutex.
>
> I read this as you suspect that there are driver callbacks inside
> drm_close_helper() that might need the global mutex held? But then it
> wouldn't be safe to move the lock? Is there a strong motivation for
> moving the locking in the first place? Also a minor nit below:
The number of processes stuck on 'D' due to mutex_lock(&global) caught my
attention while they were cleaning up files. I think everyone else will
be less impressed if their driver was stuck because i915 was freeing a
user's filp.
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > drivers/gpu/drm/drm_file.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> > index 92d16724f949..84ed313ee2e9 100644
> > --- a/drivers/gpu/drm/drm_file.c
> > +++ b/drivers/gpu/drm/drm_file.c
> > @@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
> > struct drm_minor *minor = file_priv->minor;
> > struct drm_device *dev = minor->dev;
> >
> > - mutex_lock(&drm_global_mutex);
> > -
> > DRM_DEBUG("open_count = %d\n", dev->open_count);
>
> The read of dev->open_count should still be inside the lock to be
> consistent with the value that is decremented below. Perhaps move the
> DRM_DEBUG()?
Sure. Is it even worth a debug?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Release filp before global lock
2020-01-22 15:56 ` [Intel-gfx] " Chris Wilson
(?)
(?)
@ 2020-01-22 22:12 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2020-01-22 22:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm: Release filp before global lock
URL : https://patchwork.freedesktop.org/series/72408/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7797 -> Patchwork_16214
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16214 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16214, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16214:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_parallel@contexts:
- fi-byt-j1900: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-tgl-y: NOTRUN -> [SKIP][2] +29 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-tgl-y/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
Known issues
------------
Here are the changes found in Patchwork_16214 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-cml-s: [PASS][3] -> [INCOMPLETE][4] ([i915#283])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-lmem: [PASS][5] -> [DMESG-WARN][6] ([i915#889])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111096] / [i915#323])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [INCOMPLETE][9] ([i915#45]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [TIMEOUT][11] ([fdo#112271]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
* igt@gem_exec_store@basic-all:
- fi-byt-n2820: [FAIL][13] ([i915#694]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-byt-n2820/igt@gem_exec_store@basic-all.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-byt-n2820/igt@gem_exec_store@basic-all.html
* igt@gem_exec_suspend@basic-s3:
- fi-byt-n2820: [TIMEOUT][15] ([fdo#112271] / [i915#895]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-byt-n2820/igt@gem_exec_suspend@basic-s3.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-byt-n2820/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][17] ([i915#725]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-hsw-4770/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][19] ([i915#44]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7797/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
[i915#895]: https://gitlab.freedesktop.org/drm/intel/issues/895
Participating hosts (51 -> 45)
------------------------------
Additional (1): fi-tgl-y
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7797 -> Patchwork_16214
CI-20190529: 20190529
CI_DRM_7797: c6751dc645f51c3058592c615770ecefd9899672 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5377: 1e6cb3e75925cf623df04f78430ae9299632ec3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16214: 9b36fdfb1e5800e7c5616edb7ab52abfaa8f7425 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9b36fdfb1e58 drm: Release filp before global lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16214/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm: Release filp before global lock
2020-01-22 22:00 ` [Intel-gfx] " Chris Wilson
@ 2020-01-22 22:23 ` Thomas Hellström (VMware)
-1 siblings, 0 replies; 15+ messages in thread
From: Thomas Hellström (VMware) @ 2020-01-22 22:23 UTC (permalink / raw)
To: Chris Wilson, dri-devel; +Cc: intel-gfx
On 1/22/20 11:00 PM, Chris Wilson wrote:
> Quoting Thomas Hellström (VMware) (2020-01-22 21:52:23)
>> Hi, Chris,
>>
>> On 1/22/20 4:56 PM, Chris Wilson wrote:
>>> The file is not part of the global drm resource and can be released
>>> prior to take the global mutex to drop the open_count (and potentially
>>> close) the drm device.
>>>
>>> However, inside drm_close_helper() there are a number of dev->driver
>>> callbacks that take the drm_device as the first parameter... Worryingly
>>> some of those callbacks may be (implicitly) depending on the global
>>> mutex.
>> I read this as you suspect that there are driver callbacks inside
>> drm_close_helper() that might need the global mutex held? But then it
>> wouldn't be safe to move the lock? Is there a strong motivation for
>> moving the locking in the first place? Also a minor nit below:
> The number of processes stuck on 'D' due to mutex_lock(&global) caught my
> attention while they were cleaning up files. I think everyone else will
> be less impressed if their driver was stuck because i915 was freeing a
> user's filp.
Understood. Perhaps a short motivation in the log message?
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>> drivers/gpu/drm/drm_file.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
>>> index 92d16724f949..84ed313ee2e9 100644
>>> --- a/drivers/gpu/drm/drm_file.c
>>> +++ b/drivers/gpu/drm/drm_file.c
>>> @@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
>>> struct drm_minor *minor = file_priv->minor;
>>> struct drm_device *dev = minor->dev;
>>>
>>> - mutex_lock(&drm_global_mutex);
>>> -
>>> DRM_DEBUG("open_count = %d\n", dev->open_count);
>> The read of dev->open_count should still be inside the lock to be
>> consistent with the value that is decremented below. Perhaps move the
>> DRM_DEBUG()?
> Sure. Is it even worth a debug?
Probably an old relic. I'm fine with letting it go.
Thanks,
Thomas
> -Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH] drm: Release filp before global lock
@ 2020-01-22 22:23 ` Thomas Hellström (VMware)
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Hellström (VMware) @ 2020-01-22 22:23 UTC (permalink / raw)
To: Chris Wilson, dri-devel; +Cc: intel-gfx
On 1/22/20 11:00 PM, Chris Wilson wrote:
> Quoting Thomas Hellström (VMware) (2020-01-22 21:52:23)
>> Hi, Chris,
>>
>> On 1/22/20 4:56 PM, Chris Wilson wrote:
>>> The file is not part of the global drm resource and can be released
>>> prior to take the global mutex to drop the open_count (and potentially
>>> close) the drm device.
>>>
>>> However, inside drm_close_helper() there are a number of dev->driver
>>> callbacks that take the drm_device as the first parameter... Worryingly
>>> some of those callbacks may be (implicitly) depending on the global
>>> mutex.
>> I read this as you suspect that there are driver callbacks inside
>> drm_close_helper() that might need the global mutex held? But then it
>> wouldn't be safe to move the lock? Is there a strong motivation for
>> moving the locking in the first place? Also a minor nit below:
> The number of processes stuck on 'D' due to mutex_lock(&global) caught my
> attention while they were cleaning up files. I think everyone else will
> be less impressed if their driver was stuck because i915 was freeing a
> user's filp.
Understood. Perhaps a short motivation in the log message?
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> ---
>>> drivers/gpu/drm/drm_file.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
>>> index 92d16724f949..84ed313ee2e9 100644
>>> --- a/drivers/gpu/drm/drm_file.c
>>> +++ b/drivers/gpu/drm/drm_file.c
>>> @@ -438,12 +438,12 @@ int drm_release(struct inode *inode, struct file *filp)
>>> struct drm_minor *minor = file_priv->minor;
>>> struct drm_device *dev = minor->dev;
>>>
>>> - mutex_lock(&drm_global_mutex);
>>> -
>>> DRM_DEBUG("open_count = %d\n", dev->open_count);
>> The read of dev->open_count should still be inside the lock to be
>> consistent with the value that is decremented below. Perhaps move the
>> DRM_DEBUG()?
> Sure. Is it even worth a debug?
Probably an old relic. I'm fine with letting it go.
Thanks,
Thomas
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2] drm: Release filp before global lock
2020-01-22 15:56 ` [Intel-gfx] " Chris Wilson
@ 2020-01-23 22:21 ` Chris Wilson
-1 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2020-01-23 22:21 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Thomas Hellström
The file is not part of the global drm resource and can be released
prior to take the global mutex to drop the open_count (and potentially
close) the drm device. As the global mutex is indeed global, not only
within the device but across devices, a slow file release mechanism can
bottleneck the entire system.
However, inside drm_close_helper() there are a number of dev->driver
callbacks that take the drm_device as the first parameter... Worryingly
some of those callbacks may be (implicitly) depending on the global
mutex.
v2: Drop the debug message for the open-count, it's included with the
drm_file_free() debug message -- and for good measure make that up as
reading outside of the mutex.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Thomas Hellström (VMware) <thomas_os@shipmail.org>
---
drivers/gpu/drm/drm_file.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 92d16724f949..777b450870a5 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -220,7 +220,7 @@ void drm_file_free(struct drm_file *file)
DRM_DEBUG("pid = %d, device = 0x%lx, open_count = %d\n",
task_pid_nr(current),
(long)old_encode_dev(file->minor->kdev->devt),
- dev->open_count);
+ READ_ONCE(dev->open_count));
if (drm_core_check_feature(dev, DRIVER_LEGACY) &&
dev->driver->preclose)
@@ -438,12 +438,10 @@ int drm_release(struct inode *inode, struct file *filp)
struct drm_minor *minor = file_priv->minor;
struct drm_device *dev = minor->dev;
- mutex_lock(&drm_global_mutex);
-
- DRM_DEBUG("open_count = %d\n", dev->open_count);
-
drm_close_helper(filp);
+ mutex_lock(&drm_global_mutex);
+
if (!--dev->open_count)
drm_lastclose(dev);
--
2.25.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH v2] drm: Release filp before global lock
@ 2020-01-23 22:21 ` Chris Wilson
0 siblings, 0 replies; 15+ messages in thread
From: Chris Wilson @ 2020-01-23 22:21 UTC (permalink / raw)
To: dri-devel; +Cc: intel-gfx, Thomas Hellström
The file is not part of the global drm resource and can be released
prior to take the global mutex to drop the open_count (and potentially
close) the drm device. As the global mutex is indeed global, not only
within the device but across devices, a slow file release mechanism can
bottleneck the entire system.
However, inside drm_close_helper() there are a number of dev->driver
callbacks that take the drm_device as the first parameter... Worryingly
some of those callbacks may be (implicitly) depending on the global
mutex.
v2: Drop the debug message for the open-count, it's included with the
drm_file_free() debug message -- and for good measure make that up as
reading outside of the mutex.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Thomas Hellström (VMware) <thomas_os@shipmail.org>
---
drivers/gpu/drm/drm_file.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 92d16724f949..777b450870a5 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -220,7 +220,7 @@ void drm_file_free(struct drm_file *file)
DRM_DEBUG("pid = %d, device = 0x%lx, open_count = %d\n",
task_pid_nr(current),
(long)old_encode_dev(file->minor->kdev->devt),
- dev->open_count);
+ READ_ONCE(dev->open_count));
if (drm_core_check_feature(dev, DRIVER_LEGACY) &&
dev->driver->preclose)
@@ -438,12 +438,10 @@ int drm_release(struct inode *inode, struct file *filp)
struct drm_minor *minor = file_priv->minor;
struct drm_device *dev = minor->dev;
- mutex_lock(&drm_global_mutex);
-
- DRM_DEBUG("open_count = %d\n", dev->open_count);
-
drm_close_helper(filp);
+ mutex_lock(&drm_global_mutex);
+
if (!--dev->open_count)
drm_lastclose(dev);
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Release filp before global lock (rev2)
2020-01-22 15:56 ` [Intel-gfx] " Chris Wilson
` (3 preceding siblings ...)
(?)
@ 2020-01-24 4:24 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2020-01-24 4:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm: Release filp before global lock (rev2)
URL : https://patchwork.freedesktop.org/series/72408/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> Patchwork_16245
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/index.html
Known issues
------------
Here are the changes found in Patchwork_16245 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [PASS][1] -> [TIMEOUT][2] ([fdo#112271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-byt-n2820/igt@gem_exec_parallel@fds.html
* igt@gem_render_linear_blits@basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-tgl-y/igt@gem_render_linear_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-tgl-y/igt@gem_render_linear_blits@basic.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-8700k: [PASS][5] -> [DMESG-WARN][6] ([i915#889])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html
- fi-skl-6700k2: [PASS][7] -> [DMESG-WARN][8] ([i915#889])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-skl-6700k2/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6700k2: [PASS][9] -> [INCOMPLETE][10] ([i915#151])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-skl-6700k2/igt@i915_pm_rpm@module-reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-skl-6700k2/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [PASS][11] -> [DMESG-FAIL][12] ([i915#722])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_mman:
- fi-bxt-dsi: [PASS][13] -> [DMESG-WARN][14] ([i915#889]) +23 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-bxt-dsi/igt@i915_selftest@live_mman.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-bxt-dsi/igt@i915_selftest@live_mman.html
* igt@i915_selftest@live_reset:
- fi-bxt-dsi: [PASS][15] -> [DMESG-FAIL][16] ([i915#889]) +7 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-bxt-dsi/igt@i915_selftest@live_reset.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-bxt-dsi/igt@i915_selftest@live_reset.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [TIMEOUT][17] ([fdo#112271] / [i915#816]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@gem_exec_parallel@fds:
- fi-byt-j1900: [INCOMPLETE][19] ([i915#45]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-byt-j1900/igt@gem_exec_parallel@fds.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-byt-j1900/igt@gem_exec_parallel@fds.html
* igt@gem_exec_suspend@basic-s3:
- fi-cml-s: [INCOMPLETE][21] ([i915#283]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-cml-s/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][23] ([i915#563]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-ivb-3770: [DMESG-FAIL][25] ([i915#725]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-ivb-3770/igt@i915_selftest@live_blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-ivb-3770/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [DMESG-FAIL][27] ([i915#770]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-hsw-4770/igt@i915_selftest@live_blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][29] ([fdo#111407]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][31] ([CI#94] / [i915#402]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][33] ([fdo#109271]) -> [FAIL][34] ([i915#579])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
Participating hosts (52 -> 39)
------------------------------
Additional (1): fi-snb-2520m
Missing (14): fi-ilk-m540 fi-bsw-n3050 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-whl-u fi-gdg-551 fi-bsw-kefka fi-kbl-7560u fi-byt-clapper fi-bsw-nick fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7806 -> Patchwork_16245
CI-20190529: 20190529
CI_DRM_7806: 0b551226df5e5b84044705d5fd76571da70f3163 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5382: 8dbe5ce61baa2d563d4dd7c56a018bb1e1077467 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16245: b2f530d40d7c09b739db8ab77875375ca86b3f80 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b2f530d40d7c drm: Release filp before global lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] drm: Release filp before global lock
2020-01-23 22:21 ` [Intel-gfx] " Chris Wilson
@ 2020-01-24 12:29 ` Thomas Hellström (VMware)
-1 siblings, 0 replies; 15+ messages in thread
From: Thomas Hellström (VMware) @ 2020-01-24 12:29 UTC (permalink / raw)
To: Chris Wilson, dri-devel; +Cc: intel-gfx
On 1/23/20 11:21 PM, Chris Wilson wrote:
> The file is not part of the global drm resource and can be released
> prior to take the global mutex to drop the open_count (and potentially
> close) the drm device. As the global mutex is indeed global, not only
> within the device but across devices, a slow file release mechanism can
> bottleneck the entire system.
>
> However, inside drm_close_helper() there are a number of dev->driver
> callbacks that take the drm_device as the first parameter... Worryingly
> some of those callbacks may be (implicitly) depending on the global
> mutex.
From a quick audit, via, sis and vmwgfx are safe, so for those
Acked-by: Thomas Hellstrom <thellstrom@vmware.com>
Savage appears to be unsafe, due to unprotected access in the dma device
member. Haven't audited i810 or potential other drivers affected.
Perhaps it makes sense to enable lockfree filp release on a per-driver
basis to begin with?
/Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm: Release filp before global lock
@ 2020-01-24 12:29 ` Thomas Hellström (VMware)
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Hellström (VMware) @ 2020-01-24 12:29 UTC (permalink / raw)
To: Chris Wilson, dri-devel; +Cc: intel-gfx
On 1/23/20 11:21 PM, Chris Wilson wrote:
> The file is not part of the global drm resource and can be released
> prior to take the global mutex to drop the open_count (and potentially
> close) the drm device. As the global mutex is indeed global, not only
> within the device but across devices, a slow file release mechanism can
> bottleneck the entire system.
>
> However, inside drm_close_helper() there are a number of dev->driver
> callbacks that take the drm_device as the first parameter... Worryingly
> some of those callbacks may be (implicitly) depending on the global
> mutex.
From a quick audit, via, sis and vmwgfx are safe, so for those
Acked-by: Thomas Hellstrom <thellstrom@vmware.com>
Savage appears to be unsafe, due to unprotected access in the dma device
member. Haven't audited i810 or potential other drivers affected.
Perhaps it makes sense to enable lockfree filp release on a per-driver
basis to begin with?
/Thomas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm: Release filp before global lock (rev2)
2020-01-22 15:56 ` [Intel-gfx] " Chris Wilson
` (4 preceding siblings ...)
(?)
@ 2020-01-25 23:52 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2020-01-25 23:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm: Release filp before global lock (rev2)
URL : https://patchwork.freedesktop.org/series/72408/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806_full -> Patchwork_16245_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_16245_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb5/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_exec_schedule@preempt-self-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112146]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb7/igt@gem_exec_schedule@preempt-self-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb4/igt@gem_exec_schedule@preempt-self-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb5/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [PASS][7] -> [INCOMPLETE][8] ([i915#140])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb8/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-hsw: [PASS][9] -> [INCOMPLETE][10] ([i915#61])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-apl: [PASS][11] -> [INCOMPLETE][12] ([fdo#103927] / [i915#970])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-apl4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-glk: [PASS][13] -> [INCOMPLETE][14] ([i915#58] / [k.org#198133])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk8/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-glk6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#644])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-glk2/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [PASS][17] -> [INCOMPLETE][18] ([i915#69])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl7/igt@gem_softpin@noreloc-s3.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl9/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_rps@reset:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#413])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb6/igt@i915_pm_rps@reset.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-tglb3/igt@i915_pm_rps@reset.html
* igt@i915_selftest@mock_requests:
- shard-kbl: [PASS][21] -> [INCOMPLETE][22] ([fdo#103665])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-kbl2/igt@i915_selftest@mock_requests.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-kbl3/igt@i915_selftest@mock_requests.html
* igt@kms_color@pipe-b-ctm-green-to-red:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#129])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl3/igt@kms_color@pipe-b-ctm-green-to-red.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl2/igt@kms_color@pipe-b-ctm-green-to-red.html
* igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#54])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][27] -> [FAIL][28] ([i915#96])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][29] -> [FAIL][30] ([IGT#5])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#79])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: [PASS][35] -> [FAIL][36] ([i915#49]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +8 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb2/igt@kms_psr@psr2_dpms.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb5/igt@kms_psr@psr2_dpms.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][43] -> [FAIL][44] ([i915#31])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl4/igt@kms_setmode@basic.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-apl8/igt@kms_setmode@basic.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112080]) +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@perf_pmu@busy-vcs1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb6/igt@perf_pmu@busy-vcs1.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][47] ([fdo#112080]) -> [PASS][48] +10 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb3/igt@gem_busy@busy-vcs1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb2/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50] +5 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][51] ([fdo#109276] / [fdo#112080]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb8/igt@gem_ctx_persistence@vcs1-queued.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb4/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_ctx_persistence@vecs0-mixed-process:
- shard-glk: [FAIL][53] ([i915#679]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk3/igt@gem_ctx_persistence@vecs0-mixed-process.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-glk7/igt@gem_ctx_persistence@vecs0-mixed-process.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][55] ([fdo#110841]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [SKIP][57] ([i915#677]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb4/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb5/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +8 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-hsw: [INCOMPLETE][61] ([i915#530] / [i915#61]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-apl: [INCOMPLETE][63] ([fdo#103927]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl8/igt@gem_persistent_relocs@forked-thrashing.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-apl1/igt@gem_persistent_relocs@forked-thrashing.html
- shard-hsw: [INCOMPLETE][65] ([i915#61]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw5/igt@gem_persistent_relocs@forked-thrashing.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw7/igt@gem_persistent_relocs@forked-thrashing.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][67] ([i915#454]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][69] ([i915#413]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb3/igt@i915_pm_rps@waitboost.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb6/igt@i915_pm_rps@waitboost.html
* igt@i915_selftest@mock_requests:
- shard-glk: [INCOMPLETE][71] ([i915#58] / [k.org#198133]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk7/igt@i915_selftest@mock_requests.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-glk9/igt@i915_selftest@mock_requests.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][73] ([i915#109]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl10/igt@kms_color@pipe-a-ctm-0-5.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl1/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][75] ([i915#72]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-skl: [FAIL][77] ([IGT#5] / [i915#697]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_flip@flip-vs-suspend:
- shard-apl: [DMESG-WARN][79] ([i915#180]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl8/igt@kms_flip@flip-vs-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-apl7/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: [FAIL][81] ([i915#407]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk6/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-glk3/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: [FAIL][83] ([i915#49]) -> [PASS][84] +5 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [FAIL][87] ([i915#831]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw2/igt@prime_mmap_coherency@ioctl-errors.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw5/igt@prime_mmap_coherency@ioctl-errors.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][89] ([fdo#109276]) -> [PASS][90] +22 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][91] ([fdo#109276] / [fdo#112080]) -> [FAIL][92] ([IGT#28])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb6/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv-switch.html
* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][93] ([i915#818]) -> [FAIL][94] ([i915#694]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw8/igt@gem_tiled_blits@normal.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw8/igt@gem_tiled_blits@normal.html
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-hsw: [SKIP][95] ([fdo#109271] / [i915#439]) -> [SKIP][96] ([fdo#109271])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw5/igt@kms_atomic_transition@3x-modeset-transitions.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/shard-hsw1/igt@kms_atomic_transition@3x-modeset-transitions.html
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#129]: https://gitlab.freedesktop.org/drm/intel/issues/129
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#439]: https://gitlab.freedesktop.org/drm/intel/issues/439
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#697]: https://gitlab.freedesktop.org/drm/intel/issues/697
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[i915#970]: https://gitlab.freedesktop.org/drm/intel/issues/970
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7806 -> Patchwork_16245
CI-20190529: 20190529
CI_DRM_7806: 0b551226df5e5b84044705d5fd76571da70f3163 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5382: 8dbe5ce61baa2d563d4dd7c56a018bb1e1077467 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16245: b2f530d40d7c09b739db8ab77875375ca86b3f80 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16245/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-01-25 23:52 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 15:56 [PATCH] drm: Release filp before global lock Chris Wilson
2020-01-22 15:56 ` [Intel-gfx] " Chris Wilson
2020-01-22 21:52 ` Thomas Hellström (VMware)
2020-01-22 21:52 ` [Intel-gfx] " Thomas Hellström (VMware)
2020-01-22 22:00 ` Chris Wilson
2020-01-22 22:00 ` [Intel-gfx] " Chris Wilson
2020-01-22 22:23 ` Thomas Hellström (VMware)
2020-01-22 22:23 ` [Intel-gfx] " Thomas Hellström (VMware)
2020-01-22 22:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-01-23 22:21 ` [PATCH v2] " Chris Wilson
2020-01-23 22:21 ` [Intel-gfx] " Chris Wilson
2020-01-24 12:29 ` Thomas Hellström (VMware)
2020-01-24 12:29 ` [Intel-gfx] " Thomas Hellström (VMware)
2020-01-24 4:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm: Release filp before global lock (rev2) Patchwork
2020-01-25 23:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.