* [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp
@ 2020-01-28 16:38 Jani Nikula
2020-01-28 23:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2020-01-28 16:38 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
The DDI encoder code shouln't have to know about the guts of
HDCP. Abstract the pipe update code to a new intel_hdcp_update_pipe() in
intel_hdcp.c. No functional changes.
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 34 +------------------
drivers/gpu/drm/i915/display/intel_hdcp.c | 40 +++++++++++++++++++++++
drivers/gpu/drm/i915/display/intel_hdcp.h | 5 +++
3 files changed, 46 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index b1100950dd0d..142b2f5e5522 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4058,43 +4058,11 @@ static void intel_ddi_update_pipe(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
const struct drm_connector_state *conn_state)
{
- struct intel_connector *connector =
- to_intel_connector(conn_state->connector);
- struct intel_hdcp *hdcp = &connector->hdcp;
- bool content_protection_type_changed =
- (conn_state->hdcp_content_type != hdcp->content_type &&
- conn_state->content_protection !=
- DRM_MODE_CONTENT_PROTECTION_UNDESIRED);
if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
intel_ddi_update_pipe_dp(encoder, crtc_state, conn_state);
- /*
- * During the HDCP encryption session if Type change is requested,
- * disable the HDCP and reenable it with new TYPE value.
- */
- if (conn_state->content_protection ==
- DRM_MODE_CONTENT_PROTECTION_UNDESIRED ||
- content_protection_type_changed)
- intel_hdcp_disable(connector);
-
- /*
- * Mark the hdcp state as DESIRED after the hdcp disable of type
- * change procedure.
- */
- if (content_protection_type_changed) {
- mutex_lock(&hdcp->mutex);
- hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
- schedule_work(&hdcp->prop_work);
- mutex_unlock(&hdcp->mutex);
- }
-
- if (conn_state->content_protection ==
- DRM_MODE_CONTENT_PROTECTION_DESIRED ||
- content_protection_type_changed)
- intel_hdcp_enable(connector,
- crtc_state->cpu_transcoder,
- (u8)conn_state->hdcp_content_type);
+ intel_hdcp_update_pipe(encoder, crtc_state, conn_state);
}
static void
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 33dc40a63fce..3cd74951a34c 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -2034,6 +2034,46 @@ int intel_hdcp_disable(struct intel_connector *connector)
return ret;
}
+void intel_hdcp_update_pipe(struct intel_encoder *encoder,
+ const struct intel_crtc_state *crtc_state,
+ const struct drm_connector_state *conn_state)
+{
+ struct intel_connector *connector =
+ to_intel_connector(conn_state->connector);
+ struct intel_hdcp *hdcp = &connector->hdcp;
+ bool content_protection_type_changed =
+ (conn_state->hdcp_content_type != hdcp->content_type &&
+ conn_state->content_protection !=
+ DRM_MODE_CONTENT_PROTECTION_UNDESIRED);
+
+ /*
+ * During the HDCP encryption session if Type change is requested,
+ * disable the HDCP and reenable it with new TYPE value.
+ */
+ if (conn_state->content_protection ==
+ DRM_MODE_CONTENT_PROTECTION_UNDESIRED ||
+ content_protection_type_changed)
+ intel_hdcp_disable(connector);
+
+ /*
+ * Mark the hdcp state as DESIRED after the hdcp disable of type
+ * change procedure.
+ */
+ if (content_protection_type_changed) {
+ mutex_lock(&hdcp->mutex);
+ hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
+ schedule_work(&hdcp->prop_work);
+ mutex_unlock(&hdcp->mutex);
+ }
+
+ if (conn_state->content_protection ==
+ DRM_MODE_CONTENT_PROTECTION_DESIRED ||
+ content_protection_type_changed)
+ intel_hdcp_enable(connector,
+ crtc_state->cpu_transcoder,
+ (u8)conn_state->hdcp_content_type);
+}
+
void intel_hdcp_component_fini(struct drm_i915_private *dev_priv)
{
mutex_lock(&dev_priv->hdcp_comp_mutex);
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.h b/drivers/gpu/drm/i915/display/intel_hdcp.h
index f3c3272e712a..1b2eacaf8949 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.h
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.h
@@ -14,6 +14,8 @@ struct drm_connector;
struct drm_connector_state;
struct drm_i915_private;
struct intel_connector;
+struct intel_crtc_state;
+struct intel_encoder;
struct intel_hdcp_shim;
enum port;
enum transcoder;
@@ -26,6 +28,9 @@ int intel_hdcp_init(struct intel_connector *connector,
int intel_hdcp_enable(struct intel_connector *connector,
enum transcoder cpu_transcoder, u8 content_type);
int intel_hdcp_disable(struct intel_connector *connector);
+void intel_hdcp_update_pipe(struct intel_encoder *encoder,
+ const struct intel_crtc_state *crtc_state,
+ const struct drm_connector_state *conn_state);
bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port);
bool intel_hdcp_capable(struct intel_connector *connector);
bool intel_hdcp2_capable(struct intel_connector *connector);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: move update pipe code to hdcp
2020-01-28 16:38 [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp Jani Nikula
@ 2020-01-28 23:59 ` Patchwork
2020-01-29 13:40 ` [Intel-gfx] [PATCH] " Anshuman Gupta
2020-01-30 18:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-28 23:59 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/hdcp: move update pipe code to hdcp
URL : https://patchwork.freedesktop.org/series/72679/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7833 -> Patchwork_16301
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/index.html
Known issues
------------
Here are the changes found in Patchwork_16301 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][1] -> [DMESG-FAIL][2] ([i915#725])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-ivb-3770/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [PASS][3] -> [DMESG-FAIL][4] ([i915#722])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-icl-u2: [FAIL][5] ([fdo#103375]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-icl-u2/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u2: [FAIL][7] ([fdo#111550]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-icl-u2/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][9] ([i915#563]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-icl-guc: [INCOMPLETE][11] ([i915#140]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-icl-guc/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-icl-guc/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@gem_close_race@basic-threads:
- fi-hsw-peppy: [INCOMPLETE][13] ([i915#816]) -> [TIMEOUT][14] ([fdo#112271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [FAIL][15] ([i915#579]) -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][17] ([i915#725]) -> [DMESG-FAIL][18] ([i915#553] / [i915#725])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-hsw-4770/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [FAIL][19] ([fdo#103375]) -> [DMESG-WARN][20] ([IGT#4] / [i915#263])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
[IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111550]: https://bugs.freedesktop.org/show_bug.cgi?id=111550
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
Participating hosts (50 -> 43)
------------------------------
Additional (1): fi-snb-2520m
Missing (8): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7833 -> Patchwork_16301
CI-20190529: 20190529
CI_DRM_7833: 8210f0f999e2d396a8611e0cabc2f6c6a52468de @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5394: 991fd07bcd7add7a5beca2c95b72a994e62fbb75 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16301: c957043623a4fa0e2a5ea4bc9b540ffc1ed22a39 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c957043623a4 drm/i915/hdcp: move update pipe code to hdcp
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp
2020-01-28 16:38 [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp Jani Nikula
2020-01-28 23:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-01-29 13:40 ` Anshuman Gupta
2020-01-29 14:48 ` Jani Nikula
2020-01-30 18:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Anshuman Gupta @ 2020-01-29 13:40 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On 2020-01-28 at 18:38:03 +0200, Jani Nikula wrote:
> The DDI encoder code shouln't have to know about the guts of
> HDCP. Abstract the pipe update code to a new intel_hdcp_update_pipe() in
> intel_hdcp.c. No functional changes.
>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 34 +------------------
> drivers/gpu/drm/i915/display/intel_hdcp.c | 40 +++++++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_hdcp.h | 5 +++
> 3 files changed, 46 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index b1100950dd0d..142b2f5e5522 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4058,43 +4058,11 @@ static void intel_ddi_update_pipe(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> const struct drm_connector_state *conn_state)
> {
> - struct intel_connector *connector =
> - to_intel_connector(conn_state->connector);
> - struct intel_hdcp *hdcp = &connector->hdcp;
> - bool content_protection_type_changed =
> - (conn_state->hdcp_content_type != hdcp->content_type &&
> - conn_state->content_protection !=
> - DRM_MODE_CONTENT_PROTECTION_UNDESIRED);
>
> if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
> intel_ddi_update_pipe_dp(encoder, crtc_state, conn_state);
>
> - /*
> - * During the HDCP encryption session if Type change is requested,
> - * disable the HDCP and reenable it with new TYPE value.
> - */
> - if (conn_state->content_protection ==
> - DRM_MODE_CONTENT_PROTECTION_UNDESIRED ||
> - content_protection_type_changed)
> - intel_hdcp_disable(connector);
> -
> - /*
> - * Mark the hdcp state as DESIRED after the hdcp disable of type
> - * change procedure.
> - */
> - if (content_protection_type_changed) {
> - mutex_lock(&hdcp->mutex);
> - hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
> - schedule_work(&hdcp->prop_work);
> - mutex_unlock(&hdcp->mutex);
> - }
> -
> - if (conn_state->content_protection ==
> - DRM_MODE_CONTENT_PROTECTION_DESIRED ||
> - content_protection_type_changed)
> - intel_hdcp_enable(connector,
> - crtc_state->cpu_transcoder,
> - (u8)conn_state->hdcp_content_type);
> + intel_hdcp_update_pipe(encoder, crtc_state, conn_state);
> }
>
> static void
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 33dc40a63fce..3cd74951a34c 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -2034,6 +2034,46 @@ int intel_hdcp_disable(struct intel_connector *connector)
> return ret;
> }
>
> +void intel_hdcp_update_pipe(struct intel_encoder *encoder,
encoder arg is not getting used in this function, it can be removed.
With above comment,
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
Thanks ,
Anshuman Gupta.
> + const struct intel_crtc_state *crtc_state,
> + const struct drm_connector_state *conn_state)
> +{
> + struct intel_connector *connector =
> + to_intel_connector(conn_state->connector);
> + struct intel_hdcp *hdcp = &connector->hdcp;
> + bool content_protection_type_changed =
> + (conn_state->hdcp_content_type != hdcp->content_type &&
> + conn_state->content_protection !=
> + DRM_MODE_CONTENT_PROTECTION_UNDESIRED);
> +
> + /*
> + * During the HDCP encryption session if Type change is requested,
> + * disable the HDCP and reenable it with new TYPE value.
> + */
> + if (conn_state->content_protection ==
> + DRM_MODE_CONTENT_PROTECTION_UNDESIRED ||
> + content_protection_type_changed)
> + intel_hdcp_disable(connector);
> +
> + /*
> + * Mark the hdcp state as DESIRED after the hdcp disable of type
> + * change procedure.
> + */
> + if (content_protection_type_changed) {
> + mutex_lock(&hdcp->mutex);
> + hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
> + schedule_work(&hdcp->prop_work);
> + mutex_unlock(&hdcp->mutex);
> + }
> +
> + if (conn_state->content_protection ==
> + DRM_MODE_CONTENT_PROTECTION_DESIRED ||
> + content_protection_type_changed)
> + intel_hdcp_enable(connector,
> + crtc_state->cpu_transcoder,
> + (u8)conn_state->hdcp_content_type);
> +}
> +
> void intel_hdcp_component_fini(struct drm_i915_private *dev_priv)
> {
> mutex_lock(&dev_priv->hdcp_comp_mutex);
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.h b/drivers/gpu/drm/i915/display/intel_hdcp.h
> index f3c3272e712a..1b2eacaf8949 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.h
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.h
> @@ -14,6 +14,8 @@ struct drm_connector;
> struct drm_connector_state;
> struct drm_i915_private;
> struct intel_connector;
> +struct intel_crtc_state;
> +struct intel_encoder;
> struct intel_hdcp_shim;
> enum port;
> enum transcoder;
> @@ -26,6 +28,9 @@ int intel_hdcp_init(struct intel_connector *connector,
> int intel_hdcp_enable(struct intel_connector *connector,
> enum transcoder cpu_transcoder, u8 content_type);
> int intel_hdcp_disable(struct intel_connector *connector);
> +void intel_hdcp_update_pipe(struct intel_encoder *encoder,
> + const struct intel_crtc_state *crtc_state,
> + const struct drm_connector_state *conn_state);
> bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port);
> bool intel_hdcp_capable(struct intel_connector *connector);
> bool intel_hdcp2_capable(struct intel_connector *connector);
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp
2020-01-29 13:40 ` [Intel-gfx] [PATCH] " Anshuman Gupta
@ 2020-01-29 14:48 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2020-01-29 14:48 UTC (permalink / raw)
To: Anshuman Gupta; +Cc: intel-gfx
On Wed, 29 Jan 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> On 2020-01-28 at 18:38:03 +0200, Jani Nikula wrote:
>> The DDI encoder code shouln't have to know about the guts of
>> HDCP. Abstract the pipe update code to a new intel_hdcp_update_pipe() in
>> intel_hdcp.c. No functional changes.
>>
>> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_ddi.c | 34 +------------------
>> drivers/gpu/drm/i915/display/intel_hdcp.c | 40 +++++++++++++++++++++++
>> drivers/gpu/drm/i915/display/intel_hdcp.h | 5 +++
>> 3 files changed, 46 insertions(+), 33 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>> index b1100950dd0d..142b2f5e5522 100644
>> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>> @@ -4058,43 +4058,11 @@ static void intel_ddi_update_pipe(struct intel_encoder *encoder,
>> const struct intel_crtc_state *crtc_state,
>> const struct drm_connector_state *conn_state)
>> {
>> - struct intel_connector *connector =
>> - to_intel_connector(conn_state->connector);
>> - struct intel_hdcp *hdcp = &connector->hdcp;
>> - bool content_protection_type_changed =
>> - (conn_state->hdcp_content_type != hdcp->content_type &&
>> - conn_state->content_protection !=
>> - DRM_MODE_CONTENT_PROTECTION_UNDESIRED);
>>
>> if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_HDMI))
>> intel_ddi_update_pipe_dp(encoder, crtc_state, conn_state);
>>
>> - /*
>> - * During the HDCP encryption session if Type change is requested,
>> - * disable the HDCP and reenable it with new TYPE value.
>> - */
>> - if (conn_state->content_protection ==
>> - DRM_MODE_CONTENT_PROTECTION_UNDESIRED ||
>> - content_protection_type_changed)
>> - intel_hdcp_disable(connector);
>> -
>> - /*
>> - * Mark the hdcp state as DESIRED after the hdcp disable of type
>> - * change procedure.
>> - */
>> - if (content_protection_type_changed) {
>> - mutex_lock(&hdcp->mutex);
>> - hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
>> - schedule_work(&hdcp->prop_work);
>> - mutex_unlock(&hdcp->mutex);
>> - }
>> -
>> - if (conn_state->content_protection ==
>> - DRM_MODE_CONTENT_PROTECTION_DESIRED ||
>> - content_protection_type_changed)
>> - intel_hdcp_enable(connector,
>> - crtc_state->cpu_transcoder,
>> - (u8)conn_state->hdcp_content_type);
>> + intel_hdcp_update_pipe(encoder, crtc_state, conn_state);
>> }
>>
>> static void
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> index 33dc40a63fce..3cd74951a34c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
>> @@ -2034,6 +2034,46 @@ int intel_hdcp_disable(struct intel_connector *connector)
>> return ret;
>> }
>>
>> +void intel_hdcp_update_pipe(struct intel_encoder *encoder,
> encoder arg is not getting used in this function, it can be removed.
> With above comment,
> Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
Thanks for the review. I opted to include encoder to have the same
function type (or "signature") as encoder->update_pipe hook. *shrug*.
BR,
Jani.
> Thanks ,
> Anshuman Gupta.
>> + const struct intel_crtc_state *crtc_state,
>> + const struct drm_connector_state *conn_state)
>> +{
>> + struct intel_connector *connector =
>> + to_intel_connector(conn_state->connector);
>> + struct intel_hdcp *hdcp = &connector->hdcp;
>> + bool content_protection_type_changed =
>> + (conn_state->hdcp_content_type != hdcp->content_type &&
>> + conn_state->content_protection !=
>> + DRM_MODE_CONTENT_PROTECTION_UNDESIRED);
>> +
>> + /*
>> + * During the HDCP encryption session if Type change is requested,
>> + * disable the HDCP and reenable it with new TYPE value.
>> + */
>> + if (conn_state->content_protection ==
>> + DRM_MODE_CONTENT_PROTECTION_UNDESIRED ||
>> + content_protection_type_changed)
>> + intel_hdcp_disable(connector);
>> +
>> + /*
>> + * Mark the hdcp state as DESIRED after the hdcp disable of type
>> + * change procedure.
>> + */
>> + if (content_protection_type_changed) {
>> + mutex_lock(&hdcp->mutex);
>> + hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
>> + schedule_work(&hdcp->prop_work);
>> + mutex_unlock(&hdcp->mutex);
>> + }
>> +
>> + if (conn_state->content_protection ==
>> + DRM_MODE_CONTENT_PROTECTION_DESIRED ||
>> + content_protection_type_changed)
>> + intel_hdcp_enable(connector,
>> + crtc_state->cpu_transcoder,
>> + (u8)conn_state->hdcp_content_type);
>> +}
>> +
>> void intel_hdcp_component_fini(struct drm_i915_private *dev_priv)
>> {
>> mutex_lock(&dev_priv->hdcp_comp_mutex);
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.h b/drivers/gpu/drm/i915/display/intel_hdcp.h
>> index f3c3272e712a..1b2eacaf8949 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdcp.h
>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.h
>> @@ -14,6 +14,8 @@ struct drm_connector;
>> struct drm_connector_state;
>> struct drm_i915_private;
>> struct intel_connector;
>> +struct intel_crtc_state;
>> +struct intel_encoder;
>> struct intel_hdcp_shim;
>> enum port;
>> enum transcoder;
>> @@ -26,6 +28,9 @@ int intel_hdcp_init(struct intel_connector *connector,
>> int intel_hdcp_enable(struct intel_connector *connector,
>> enum transcoder cpu_transcoder, u8 content_type);
>> int intel_hdcp_disable(struct intel_connector *connector);
>> +void intel_hdcp_update_pipe(struct intel_encoder *encoder,
>> + const struct intel_crtc_state *crtc_state,
>> + const struct drm_connector_state *conn_state);
>> bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port);
>> bool intel_hdcp_capable(struct intel_connector *connector);
>> bool intel_hdcp2_capable(struct intel_connector *connector);
>> --
>> 2.20.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: move update pipe code to hdcp
2020-01-28 16:38 [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp Jani Nikula
2020-01-28 23:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-29 13:40 ` [Intel-gfx] [PATCH] " Anshuman Gupta
@ 2020-01-30 18:56 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-30 18:56 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/hdcp: move update pipe code to hdcp
URL : https://patchwork.freedesktop.org/series/72679/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7833_full -> Patchwork_16301_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16301_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16301_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16301_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ringfill@basic-default-hang:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb5/igt@gem_ringfill@basic-default-hang.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb7/igt@gem_ringfill@basic-default-hang.html
Known issues
------------
Here are the changes found in Patchwork_16301_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_caching@read-writes:
- shard-hsw: [PASS][3] -> [FAIL][4] ([i915#694])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-hsw7/igt@gem_caching@read-writes.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-hsw8/igt@gem_caching@read-writes.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@vcs1-persistence:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276] / [fdo#112080])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb4/igt@gem_ctx_persistence@vcs1-persistence.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb3/igt@gem_ctx_persistence@vcs1-persistence.html
* igt@gem_ctx_shared@exec-shared-gtt-bsd:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#616])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-tglb7/igt@gem_ctx_shared@exec-shared-gtt-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-tglb5/igt@gem_ctx_shared@exec-shared-gtt-bsd.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#110854])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb1/igt@gem_exec_balancer@smoke.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb5/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109276]) +9 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb8/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][15] -> [SKIP][16] ([i915#677]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb2/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb5/igt@gem_exec_schedule@wide-bsd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_largeobject:
- shard-glk: [PASS][19] -> [DMESG-WARN][20] ([i915#109])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-glk9/igt@gem_largeobject.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-glk4/igt@gem_largeobject.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#520])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl10/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl9/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#644])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-glk3/igt@gem_ppgtt@flink-and-close-vma-leak.html
- shard-apl: [PASS][25] -> [FAIL][26] ([i915#644])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-apl2/igt@gem_ppgtt@flink-and-close-vma-leak.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-apl7/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_tiled_blits@interruptible:
- shard-hsw: [PASS][27] -> [FAIL][28] ([i915#818])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-hsw8/igt@gem_tiled_blits@interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-hsw1/igt@gem_tiled_blits@interruptible.html
* igt@i915_pm_rps@reset:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#39])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl9/igt@i915_pm_rps@reset.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl7/igt@i915_pm_rps@reset.html
* igt@kms_color@pipe-b-ctm-0-75:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#109]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl6/igt@kms_color@pipe-b-ctm-0-75.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl4/igt@kms_color@pipe-b-ctm-0-75.html
* igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#54])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#221])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl6/igt@kms_flip@flip-vs-suspend-interruptible.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([i915#69])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#108145])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109642] / [fdo#111068])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][43] -> [FAIL][44] ([i915#173])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb4/igt@kms_psr@no_drrs.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb8/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][47] -> [DMESG-WARN][48] ([i915#180]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-apl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf_pmu@busy-start-vcs1:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#112080]) +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb2/igt@perf_pmu@busy-start-vcs1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb8/igt@perf_pmu@busy-start-vcs1.html
* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [PASS][51] -> [FAIL][52] ([i915#831])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-hsw4/igt@prime_mmap_coherency@ioctl-errors.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-hsw5/igt@prime_mmap_coherency@ioctl-errors.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb3/igt@gem_busy@busy-vcs1.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb4/igt@gem_busy@busy-vcs1.html
* {igt@gem_ctx_persistence@hostile}:
- shard-iclb: [FAIL][55] ([i915#1081]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb4/igt@gem_ctx_persistence@hostile.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb3/igt@gem_ctx_persistence@hostile.html
* igt@gem_ctx_persistence@vcs0-queued:
- shard-tglb: [INCOMPLETE][57] ([i915#472]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-tglb6/igt@gem_ctx_persistence@vcs0-queued.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-tglb7/igt@gem_ctx_persistence@vcs0-queued.html
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [SKIP][59] ([fdo#109276] / [fdo#112080]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb2/igt@gem_ctx_persistence@vcs1-queued.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +4 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-hsw: [FAIL][63] ([i915#694]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-hsw2/igt@gem_partial_pwrite_pread@writes-after-reads.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-hsw1/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][65] ([i915#69]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl5/igt@gem_softpin@noreloc-s3.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl6/igt@gem_softpin@noreloc-s3.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [DMESG-WARN][67] ([i915#109]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl7/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-tglb: [FAIL][69] ([IGT#5]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-tglb4/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
- shard-skl: [FAIL][71] ([IGT#5] / [i915#697]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][73] ([i915#79]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-panning-vs-hang-interruptible:
- shard-iclb: [SKIP][75] ([i915#1082]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb4/igt@kms_flip@flip-vs-panning-vs-hang-interruptible.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb3/igt@kms_flip@flip-vs-panning-vs-hang-interruptible.html
* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-skl: [FAIL][77] ([fdo#107931] / [i915#699]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl4/igt@kms_flip_tiling@flip-changes-tiling-y.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl5/igt@kms_flip_tiling@flip-changes-tiling-y.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-tglb: [SKIP][79] ([i915#668]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][81] ([i915#180]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][83] ([fdo#108145]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86] +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb7/igt@kms_psr@psr2_suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][87] ([i915#31]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-apl3/igt@kms_setmode@basic.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-apl1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][89] ([i915#180]) -> [PASS][90] +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][91] ([fdo#109276]) -> [PASS][92] +17 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-iclb8/igt@prime_busy@hang-bsd2.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-iclb2/igt@prime_busy@hang-bsd2.html
#### Warnings ####
* igt@gem_eio@kms:
- shard-skl: [INCOMPLETE][93] ([i915#198]) -> [INCOMPLETE][94] ([CI#80] / [i915#198])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-skl1/igt@gem_eio@kms.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-skl10/igt@gem_eio@kms.html
* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][95] ([i915#694]) -> [FAIL][96] ([i915#818])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-hsw8/igt@gem_tiled_blits@normal.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-hsw7/igt@gem_tiled_blits@normal.html
* igt@perf@gen12-mi-rpc:
- shard-tglb: [TIMEOUT][97] ([fdo#112271] / [i915#472]) -> [TIMEOUT][98] ([fdo#112271] / [i915#1085] / [i915#472])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7833/shard-tglb6/igt@perf@gen12-mi-rpc.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/shard-tglb2/igt@perf@gen12-mi-rpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#107931]: https://bugs.freedesktop.org/show_bug.cgi?id=107931
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1081]: https://gitlab.freedesktop.org/drm/intel/issues/1081
[i915#1082]: https://gitlab.freedesktop.org/drm/intel/issues/1082
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#616]: https://gitlab.freedesktop.org/drm/intel/issues/616
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#697]: https://gitlab.freedesktop.org/drm/intel/issues/697
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7833 -> Patchwork_16301
CI-20190529: 20190529
CI_DRM_7833: 8210f0f999e2d396a8611e0cabc2f6c6a52468de @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5394: 991fd07bcd7add7a5beca2c95b72a994e62fbb75 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16301: c957043623a4fa0e2a5ea4bc9b540ffc1ed22a39 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16301/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-30 18:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-28 16:38 [Intel-gfx] [PATCH] drm/i915/hdcp: move update pipe code to hdcp Jani Nikula
2020-01-28 23:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-29 13:40 ` [Intel-gfx] [PATCH] " Anshuman Gupta
2020-01-29 14:48 ` Jani Nikula
2020-01-30 18:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.