* [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch
@ 2020-01-31 9:26 Mika Kahola
2020-01-31 9:26 ` [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: " Mika Kahola
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Mika Kahola @ 2020-01-31 9:26 UTC (permalink / raw)
To: igt-dev
On newer gens we experience CRC mismatch errors. These are caused by
comparison between HDR and SDR planes. This patch series proposes
a fix that compares HDR primary plane to HDR overlay planes and
SDR primary plane to SDR overlay planes.
Yf tiling is not supported by GEN12. We should intentionally skip
a test with that tiling mode.
v2: HDR planes are not defined for gen9 and older (CI)
Drop platform spesific check for tiling (Jani)
Mika Kahola (1):
tests/kms_plane_lowres: Fix CRC mismatch
tests/kms_plane_lowres.c | 142 +++++++++++++++++++++++++--------------
1 file changed, 90 insertions(+), 52 deletions(-)
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: Fix CRC mismatch
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
@ 2020-01-31 9:26 ` Mika Kahola
2020-01-31 10:55 ` Petri Latvala
2020-02-03 15:06 ` Juha-Pekka Heikkila
2020-01-31 10:29 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev3) Patchwork
` (4 subsequent siblings)
5 siblings, 2 replies; 11+ messages in thread
From: Mika Kahola @ 2020-01-31 9:26 UTC (permalink / raw)
To: igt-dev
Mixing SDR and HDR planes yields to CRC mismatch. The patch computes the
reference image and CRC with the main plane matching the SDR/HDR plane type.
v2: HDR planes are not defined for gen9 and older (CI)
References: https://gitlab.freedesktop.org/drm/intel/issues/899
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_plane_lowres.c | 142 +++++++++++++++++++++++++--------------
1 file changed, 90 insertions(+), 52 deletions(-)
diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
index 4c3f5636..012b25e3 100644
--- a/tests/kms_plane_lowres.c
+++ b/tests/kms_plane_lowres.c
@@ -32,11 +32,15 @@
IGT_TEST_DESCRIPTION("Test atomic mode setting with a plane by switching between high and low resolutions");
+#define SDR_PLANE_BASE 3
#define SIZE 64
typedef struct {
int drm_fd;
igt_display_t display;
+ uint32_t devid;
+ igt_output_t *output;
+ enum pipe pipe;
struct igt_fb fb_primary;
struct igt_fb fb_plane[2];
struct {
@@ -77,11 +81,44 @@ get_lowres_mode(int drmfd, igt_output_t *output,
return *mode;
}
+static igt_plane_t *first_sdr_plane(igt_output_t *output, uint32_t devid)
+{
+ int index;
+
+ index = intel_gen(devid) <= 9 ? 0 : SDR_PLANE_BASE;
+
+ return igt_output_get_plane(output, index);
+}
+
+static bool is_sdr_plane(const igt_plane_t *plane, uint32_t devid)
+{
+ if (intel_gen(devid) <= 9)
+ return true;
+
+ return plane->index >= SDR_PLANE_BASE;
+}
+/*
+ * Mixing SDR and HDR planes results in a CRC mismatch, so use the first
+ * SDR/HDR plane as the main plane matching the SDR/HDR type of the sprite
+ * plane under test.
+ */
+static igt_plane_t *compatible_main_plane(igt_plane_t *plane,
+ igt_output_t *output,
+ uint32_t devid)
+{
+ if (is_sdr_plane(plane, devid))
+ return first_sdr_plane(output, devid);
+
+ return igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+}
+
static bool setup_plane(data_t *data, igt_plane_t *plane)
{
struct igt_fb *fb;
- if (plane->type == DRM_PLANE_TYPE_PRIMARY)
+ if (plane->type == DRM_PLANE_TYPE_PRIMARY ||
+ plane == first_sdr_plane(data->output, data->devid) ||
+ plane->type == DRM_PLANE_TYPE_CURSOR)
return false;
fb = &data->fb_plane[0];
@@ -125,25 +162,20 @@ static void create_ref_fb(data_t *data, uint64_t modifier,
}
static unsigned
-test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
- igt_output_t *output, uint64_t modifier)
+test_planes_on_pipe_with_output(data_t *data, igt_plane_t *plane, uint64_t modifier)
{
- igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
const drmModeModeInfo *mode;
drmModeModeInfo mode_lowres;
igt_pipe_crc_t *pipe_crc;
unsigned tested = 0;
- igt_plane_t *plane;
igt_plane_t *primary;
+ igt_crc_t crc_lowres, crc_hires1, crc_hires2;
- primary = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_PRIMARY);
-
- igt_info("Testing connector %s using pipe %s\n",
- igt_output_name(output), kmstest_pipe_name(pipe));
+ igt_output_set_pipe(data->output, data->pipe);
- igt_output_set_pipe(output, pipe);
- mode = igt_output_get_mode(output);
- mode_lowres = get_lowres_mode(data->drm_fd, output, mode);
+ primary = compatible_main_plane(plane, data->output, data->devid);
+ mode = igt_output_get_mode(data->output);
+ mode_lowres = get_lowres_mode(data->drm_fd, data->output, mode);
igt_create_color_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
DRM_FORMAT_XRGB8888, modifier, 0.0, 0.0, 1.0,
@@ -164,15 +196,15 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
create_ref_fb(data, modifier, mode, &data->ref_hires.fb);
create_ref_fb(data, modifier, &mode_lowres, &data->ref_lowres.fb);
- pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
+ pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
INTEL_PIPE_CRC_SOURCE_AUTO);
- igt_output_override_mode(output, &mode_lowres);
+ igt_output_override_mode(data->output, &mode_lowres);
igt_plane_set_fb(primary, &data->ref_lowres.fb);
igt_display_commit2(&data->display, COMMIT_ATOMIC);
igt_pipe_crc_collect_crc(pipe_crc, &data->ref_lowres.crc);
- igt_output_override_mode(output, NULL);
+ igt_output_override_mode(data->output, NULL);
igt_plane_set_fb(primary, &data->ref_hires.fb);
igt_display_commit2(&data->display, COMMIT_ATOMIC);
igt_pipe_crc_collect_crc(pipe_crc, &data->ref_hires.crc);
@@ -181,40 +213,36 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
igt_display_commit2(&data->display, COMMIT_ATOMIC);
/* yellow sprite plane in lower left corner */
- for_each_plane_on_pipe(&data->display, pipe, plane) {
- igt_crc_t crc_lowres, crc_hires1, crc_hires2;
-
- if (!setup_plane(data, plane))
- continue;
+ if (!setup_plane(data, plane))
+ return 0;
- igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
- igt_pipe_crc_collect_crc(pipe_crc, &crc_hires1);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_hires1);
- /* switch to lower resolution */
- igt_output_override_mode(output, &mode_lowres);
- igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ /* switch to lower resolution */
+ igt_output_override_mode(data->output, &mode_lowres);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
- igt_pipe_crc_collect_crc(pipe_crc, &crc_lowres);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_lowres);
- /* switch back to higher resolution */
- igt_output_override_mode(output, NULL);
- igt_display_commit2(&data->display, COMMIT_ATOMIC);
+ /* switch back to higher resolution */
+ igt_output_override_mode(data->output, NULL);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
- igt_pipe_crc_collect_crc(pipe_crc, &crc_hires2);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_hires2);
- igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires1);
- igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires2);
- igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
+ igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires1);
+ igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires2);
+ igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
- igt_plane_set_fb(plane, NULL);
- tested++;
- }
+ igt_plane_set_fb(plane, NULL);
+ tested++;
igt_pipe_crc_free(pipe_crc);
igt_plane_set_fb(primary, NULL);
- igt_output_set_pipe(output, PIPE_NONE);
+ igt_output_set_pipe(data->output, PIPE_NONE);
igt_remove_fb(data->drm_fd, &data->fb_plane[1]);
igt_remove_fb(data->drm_fd, &data->fb_plane[0]);
@@ -226,21 +254,32 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
}
static void
-test_planes_on_pipe(data_t *data, enum pipe pipe, uint64_t modifier)
+test_planes_on_pipe(data_t *data, uint64_t modifier)
{
- igt_output_t *output;
+ igt_plane_t *plane;
unsigned tested = 0;
- igt_skip_on(pipe >= data->display.n_pipes);
- igt_display_require_output_on_pipe(&data->display, pipe);
+ igt_skip_on(data->pipe >= data->display.n_pipes);
+ igt_display_require_output_on_pipe(&data->display, data->pipe);
igt_skip_on(!igt_display_has_format_mod(&data->display,
DRM_FORMAT_XRGB8888, modifier));
- for_each_valid_output_on_pipe(&data->display, pipe, output)
- tested += test_planes_on_pipe_with_output(data, pipe, output,
- modifier);
+ data->output = igt_get_single_output_for_pipe(&data->display, data->pipe);
+ igt_require(data->output);
+
+ igt_info("Testing connector %s using pipe %s\n",
+ igt_output_name(data->output), kmstest_pipe_name(data->pipe));
+
+ for_each_plane_on_pipe(&data->display, data->pipe, plane) {
+ data->output = igt_get_single_output_for_pipe(&data->display, data->pipe);
+ igt_require(data->output);
+
+ tested += test_planes_on_pipe_with_output(data, plane, modifier);
+ }
igt_assert(tested > 0);
+ igt_output_set_pipe(data->output, PIPE_NONE);
+ igt_display_commit2(&data->display, COMMIT_ATOMIC);
}
igt_main
@@ -250,6 +289,8 @@ igt_main
igt_fixture {
data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+ data.devid = is_i915_device(data.drm_fd) ?
+ intel_get_drm_devid(data.drm_fd) : 0;
kmstest_set_vt_graphics_mode();
@@ -259,21 +300,18 @@ igt_main
}
for_each_pipe_static(pipe) {
+ data.pipe = pipe;
igt_subtest_f("pipe-%s-tiling-none", kmstest_pipe_name(pipe))
- test_planes_on_pipe(&data, pipe,
- LOCAL_DRM_FORMAT_MOD_NONE);
+ test_planes_on_pipe(&data, LOCAL_DRM_FORMAT_MOD_NONE);
igt_subtest_f("pipe-%s-tiling-x", kmstest_pipe_name(pipe))
- test_planes_on_pipe(&data, pipe,
- LOCAL_I915_FORMAT_MOD_X_TILED);
+ test_planes_on_pipe(&data, LOCAL_I915_FORMAT_MOD_X_TILED);
igt_subtest_f("pipe-%s-tiling-y", kmstest_pipe_name(pipe))
- test_planes_on_pipe(&data, pipe,
- LOCAL_I915_FORMAT_MOD_Y_TILED);
+ test_planes_on_pipe(&data, LOCAL_I915_FORMAT_MOD_Y_TILED);
igt_subtest_f("pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
- test_planes_on_pipe(&data, pipe,
- LOCAL_I915_FORMAT_MOD_Yf_TILED);
+ test_planes_on_pipe(&data, LOCAL_I915_FORMAT_MOD_Yf_TILED);
}
igt_fixture {
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev3)
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
2020-01-31 9:26 ` [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: " Mika Kahola
@ 2020-01-31 10:29 ` Patchwork
2020-01-31 11:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev4) Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-01-31 10:29 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
== Series Details ==
Series: Fix CRC mismatch (rev3)
URL : https://patchwork.freedesktop.org/series/72625/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7850 -> IGTPW_4055
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4055 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4055, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4055:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s0:
- fi-bsw-n3050: NOTRUN -> [TIMEOUT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-bsw-n3050/igt@gem_exec_suspend@basic-s0.html
Known issues
------------
Here are the changes found in IGTPW_4055 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_self_import@basic-with_fd_dup:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([CI#94] / [i915#402]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7850/fi-tgl-y/igt@prime_self_import@basic-with_fd_dup.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-tgl-y/igt@prime_self_import@basic-with_fd_dup.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-byt-n2820: [TIMEOUT][4] ([fdo#112271] / [i915#1084] / [i915#816]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7850/fi-byt-n2820/igt@gem_close_race@basic-threads.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-byt-n2820/igt@gem_close_race@basic-threads.html
* igt@gem_exec_store@basic-all:
- fi-apl-guc: [TIMEOUT][6] ([fdo#112271]) -> [PASS][7] +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7850/fi-apl-guc/igt@gem_exec_store@basic-all.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-apl-guc/igt@gem_exec_store@basic-all.html
* igt@gem_tiled_fence_blits@basic:
- fi-apl-guc: [SKIP][8] ([fdo#109271]) -> [PASS][9] +47 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7850/fi-apl-guc/igt@gem_tiled_fence_blits@basic.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-apl-guc/igt@gem_tiled_fence_blits@basic.html
* igt@kms_addfb_basic@bad-pitch-32:
- fi-tgl-y: [DMESG-WARN][10] ([CI#94] / [i915#402]) -> [PASS][11] +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7850/fi-tgl-y/igt@kms_addfb_basic@bad-pitch-32.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-tgl-y/igt@kms_addfb_basic@bad-pitch-32.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][12] ([fdo#111407]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7850/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
Participating hosts (43 -> 47)
------------------------------
Additional (11): fi-bdw-5557u fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-snb-2520m fi-whl-u fi-gdg-551 fi-ivb-3770 fi-elk-e7500 fi-kbl-r fi-snb-2600
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5407 -> IGTPW_4055
CI-20190529: 20190529
CI_DRM_7850: ae66f2257648ce52c51298506977baa32873c9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4055: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/index.html
IGT_5407: a9d69f51dadbcbc53527671f87572d05c3370cba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4055/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: Fix CRC mismatch
2020-01-31 9:26 ` [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: " Mika Kahola
@ 2020-01-31 10:55 ` Petri Latvala
2020-01-31 12:11 ` Kahola, Mika
2020-02-03 15:06 ` Juha-Pekka Heikkila
1 sibling, 1 reply; 11+ messages in thread
From: Petri Latvala @ 2020-01-31 10:55 UTC (permalink / raw)
To: Mika Kahola; +Cc: igt-dev
On Fri, Jan 31, 2020 at 11:26:03AM +0200, Mika Kahola wrote:
> Mixing SDR and HDR planes yields to CRC mismatch. The patch computes the
> reference image and CRC with the main plane matching the SDR/HDR plane type.
>
> v2: HDR planes are not defined for gen9 and older (CI)
>
> References: https://gitlab.freedesktop.org/drm/intel/issues/899
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_lowres.c | 142 +++++++++++++++++++++++++--------------
> 1 file changed, 90 insertions(+), 52 deletions(-)
>
> diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> index 4c3f5636..012b25e3 100644
> --- a/tests/kms_plane_lowres.c
> +++ b/tests/kms_plane_lowres.c
> @@ -32,11 +32,15 @@
>
> IGT_TEST_DESCRIPTION("Test atomic mode setting with a plane by switching between high and low resolutions");
>
> +#define SDR_PLANE_BASE 3
> #define SIZE 64
>
> typedef struct {
> int drm_fd;
> igt_display_t display;
> + uint32_t devid;
> + igt_output_t *output;
> + enum pipe pipe;
> struct igt_fb fb_primary;
> struct igt_fb fb_plane[2];
> struct {
> @@ -77,11 +81,44 @@ get_lowres_mode(int drmfd, igt_output_t *output,
> return *mode;
> }
>
> +static igt_plane_t *first_sdr_plane(igt_output_t *output, uint32_t devid)
> +{
> + int index;
> +
> + index = intel_gen(devid) <= 9 ? 0 : SDR_PLANE_BASE;
> +
> + return igt_output_get_plane(output, index);
> +}
> +
> +static bool is_sdr_plane(const igt_plane_t *plane, uint32_t devid)
> +{
> + if (intel_gen(devid) <= 9)
> + return true;
> +
> + return plane->index >= SDR_PLANE_BASE;
> +}
kms_plane.c has similar HDR plane finder code by Ville. For some
values of similar. At least it had comments explaining why the SDR plane base is 3. :P
Any takers for refactoring to shared code?
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev4)
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
2020-01-31 9:26 ` [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: " Mika Kahola
2020-01-31 10:29 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev3) Patchwork
@ 2020-01-31 11:55 ` Patchwork
2020-01-31 15:11 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-01-31 11:55 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
== Series Details ==
Series: Fix CRC mismatch (rev4)
URL : https://patchwork.freedesktop.org/series/72625/
State : failure
== Summary ==
CI Bug Log - changes from IGT_5408 -> IGTPW_4056
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4056 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4056, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4056:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_workarounds:
- fi-apl-guc: NOTRUN -> [DMESG-FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-apl-guc/igt@i915_selftest@live_workarounds.html
* igt@runner@aborted:
- fi-hsw-peppy: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-hsw-peppy/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_4056 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-pnv-d510: [PASS][3] -> [INCOMPLETE][4] ([i915#299])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-pnv-d510/igt@gem_exec_suspend@basic-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-pnv-d510/igt@gem_exec_suspend@basic-s3.html
* igt@gem_flink_basic@bad-open:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([CI#94] / [i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-tgl-y/igt@gem_flink_basic@bad-open.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-tgl-y/igt@gem_flink_basic@bad-open.html
* igt@i915_selftest@live_gtt:
- fi-bdw-5557u: [PASS][7] -> [TIMEOUT][8] ([fdo#112271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][9] -> [FAIL][10] ([fdo#111096] / [i915#323])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [TIMEOUT][11] ([fdo#112271] / [i915#1084] / [i915#816]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@gem_exec_store@basic-all:
- fi-apl-guc: [TIMEOUT][13] ([fdo#112271]) -> [PASS][14] +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-apl-guc/igt@gem_exec_store@basic-all.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-apl-guc/igt@gem_exec_store@basic-all.html
* igt@gem_tiled_fence_blits@basic:
- fi-apl-guc: [SKIP][15] ([fdo#109271]) -> [PASS][16] +47 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-apl-guc/igt@gem_tiled_fence_blits@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-apl-guc/igt@gem_tiled_fence_blits@basic.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][17] ([i915#553] / [i915#725]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-hsw-4770/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_addfb_basic@addfb25-bad-modifier:
- fi-tgl-y: [DMESG-WARN][19] ([CI#94] / [i915#402]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-tgl-y/igt@kms_addfb_basic@addfb25-bad-modifier.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-tgl-y/igt@kms_addfb_basic@addfb25-bad-modifier.html
* igt@kms_chamelium@dp-edid-read:
- fi-cml-u2: [FAIL][21] -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][23] ([fdo#109635] / [i915#217]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Warnings ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][25] ([i915#694]) -> [TIMEOUT][26] ([fdo#112271])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
Participating hosts (47 -> 45)
------------------------------
Additional (5): fi-kbl-soraka fi-bsw-n3050 fi-hsw-peppy fi-elk-e7500 fi-bsw-kefka
Missing (7): fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bsw-nick
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5408 -> IGTPW_4056
CI-20190529: 20190529
CI_DRM_7850: ae66f2257648ce52c51298506977baa32873c9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4056: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
IGT_5408: 8980bcd421744fb63d38270e1fcc9c7432d70d00 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: Fix CRC mismatch
2020-01-31 10:55 ` Petri Latvala
@ 2020-01-31 12:11 ` Kahola, Mika
0 siblings, 0 replies; 11+ messages in thread
From: Kahola, Mika @ 2020-01-31 12:11 UTC (permalink / raw)
To: Latvala, Petri; +Cc: igt-dev
On Fri, 2020-01-31 at 12:55 +0200, Petri Latvala wrote:
> On Fri, Jan 31, 2020 at 11:26:03AM +0200, Mika Kahola wrote:
> > Mixing SDR and HDR planes yields to CRC mismatch. The patch
> > computes the
> > reference image and CRC with the main plane matching the SDR/HDR
> > plane type.
> >
> > v2: HDR planes are not defined for gen9 and older (CI)
> >
> > References: https://gitlab.freedesktop.org/drm/intel/issues/899
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > tests/kms_plane_lowres.c | 142 +++++++++++++++++++++++++--------
> > ------
> > 1 file changed, 90 insertions(+), 52 deletions(-)
> >
> > diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> > index 4c3f5636..012b25e3 100644
> > --- a/tests/kms_plane_lowres.c
> > +++ b/tests/kms_plane_lowres.c
> > @@ -32,11 +32,15 @@
> >
> > IGT_TEST_DESCRIPTION("Test atomic mode setting with a plane by
> > switching between high and low resolutions");
> >
> > +#define SDR_PLANE_BASE 3
> > #define SIZE 64
> >
> > typedef struct {
> > int drm_fd;
> > igt_display_t display;
> > + uint32_t devid;
> > + igt_output_t *output;
> > + enum pipe pipe;
> > struct igt_fb fb_primary;
> > struct igt_fb fb_plane[2];
> > struct {
> > @@ -77,11 +81,44 @@ get_lowres_mode(int drmfd, igt_output_t
> > *output,
> > return *mode;
> > }
> >
> > +static igt_plane_t *first_sdr_plane(igt_output_t *output, uint32_t
> > devid)
> > +{
> > + int index;
> > +
> > + index = intel_gen(devid) <= 9 ? 0 : SDR_PLANE_BASE;
> > +
> > + return igt_output_get_plane(output, index);
> > +}
> > +
> > +static bool is_sdr_plane(const igt_plane_t *plane, uint32_t devid)
> > +{
> > + if (intel_gen(devid) <= 9)
> > + return true;
> > +
> > + return plane->index >= SDR_PLANE_BASE;
> > +}
>
> kms_plane.c has similar HDR plane finder code by Ville. For some
> values of similar. At least it had comments explaining why the SDR
> plane base is 3. :P
>
> Any takers for refactoring to shared code?
I'm planning to put these on lib. Similar code is also used in kms_ccs
test.
-Mika-
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Fix CRC mismatch (rev4)
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
` (2 preceding siblings ...)
2020-01-31 11:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev4) Patchwork
@ 2020-01-31 15:11 ` Patchwork
2020-02-03 9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix CRC mismatch (rev5) Patchwork
2020-02-03 11:57 ` [igt-dev] ✓ Fi.CI.IGT: success for Fix CRC mismatch (rev4) Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-01-31 15:11 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
== Series Details ==
Series: Fix CRC mismatch (rev4)
URL : https://patchwork.freedesktop.org/series/72625/
State : success
== Summary ==
CI Bug Log - changes from IGT_5408 -> IGTPW_4056
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
Known issues
------------
Here are the changes found in IGTPW_4056 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-pnv-d510: [PASS][1] -> [INCOMPLETE][2] ([i915#299])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-pnv-d510/igt@gem_exec_suspend@basic-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-pnv-d510/igt@gem_exec_suspend@basic-s3.html
* igt@gem_flink_basic@bad-open:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([CI#94] / [i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-tgl-y/igt@gem_flink_basic@bad-open.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-tgl-y/igt@gem_flink_basic@bad-open.html
* igt@i915_selftest@live_gtt:
- fi-bdw-5557u: [PASS][5] -> [TIMEOUT][6] ([fdo#112271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-bdw-5557u/igt@i915_selftest@live_gtt.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([fdo#111096] / [i915#323])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [TIMEOUT][9] ([fdo#112271] / [i915#1084] / [i915#816]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@gem_exec_store@basic-all:
- fi-apl-guc: [TIMEOUT][11] ([fdo#112271]) -> [PASS][12] +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-apl-guc/igt@gem_exec_store@basic-all.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-apl-guc/igt@gem_exec_store@basic-all.html
* igt@gem_tiled_fence_blits@basic:
- fi-apl-guc: [SKIP][13] ([fdo#109271]) -> [PASS][14] +47 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-apl-guc/igt@gem_tiled_fence_blits@basic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-apl-guc/igt@gem_tiled_fence_blits@basic.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770: [DMESG-FAIL][15] ([i915#553] / [i915#725]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-hsw-4770/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@kms_addfb_basic@addfb25-bad-modifier:
- fi-tgl-y: [DMESG-WARN][17] ([CI#94] / [i915#402]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-tgl-y/igt@kms_addfb_basic@addfb25-bad-modifier.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-tgl-y/igt@kms_addfb_basic@addfb25-bad-modifier.html
* igt@kms_chamelium@dp-edid-read:
- fi-cml-u2: [FAIL][19] ([i915#976]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][21] ([fdo#109635] / [i915#217]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Warnings ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][23] ([i915#694]) -> [TIMEOUT][24] ([fdo#112271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976
Participating hosts (47 -> 45)
------------------------------
Additional (5): fi-kbl-soraka fi-bsw-n3050 fi-hsw-peppy fi-elk-e7500 fi-bsw-kefka
Missing (7): fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-kbl-7560u fi-byt-clapper fi-bsw-nick
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5408 -> IGTPW_4056
CI-20190529: 20190529
CI_DRM_7850: ae66f2257648ce52c51298506977baa32873c9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4056: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
IGT_5408: 8980bcd421744fb63d38270e1fcc9c7432d70d00 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Fix CRC mismatch (rev5)
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
` (3 preceding siblings ...)
2020-01-31 15:11 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-02-03 9:35 ` Patchwork
2020-02-03 11:57 ` [igt-dev] ✓ Fi.CI.IGT: success for Fix CRC mismatch (rev4) Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-02-03 9:35 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
== Series Details ==
Series: Fix CRC mismatch (rev5)
URL : https://patchwork.freedesktop.org/series/72625/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7857 -> IGTPW_4075
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/index.html
Known issues
------------
Here are the changes found in IGTPW_4075 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-icl-y: [PASS][1] -> [DMESG-FAIL][2] ([fdo#108569])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-icl-y/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-icl-y/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [PASS][3] -> [DMESG-FAIL][4] ([i915#722])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-byt-n2820: [PASS][5] -> [DMESG-FAIL][6] ([i915#722])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][7] ([i915#694]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-byt-n2820/igt@gem_exec_parallel@fds.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][9] ([i915#553] / [i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [DMESG-FAIL][11] ([i915#553] / [i915#725]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-hsw-4770/igt@i915_selftest@live_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [INCOMPLETE][13] ([fdo#106070] / [i915#424]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [FAIL][15] ([i915#694]) -> [TIMEOUT][16] ([fdo#112271] / [i915#1084])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7857/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
Participating hosts (47 -> 45)
------------------------------
Additional (4): fi-skl-6770hq fi-bdw-5557u fi-bwr-2160 fi-bsw-nick
Missing (6): fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5411 -> IGTPW_4075
CI-20190529: 20190529
CI_DRM_7857: 8ec40a15b9a930df9e445f17c5e01cdb6f80353a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4075: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/index.html
IGT_5411: 86c6ab8a0b6696bdb2153febd350af7fa02fbb00 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4075/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Fix CRC mismatch (rev4)
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
` (4 preceding siblings ...)
2020-02-03 9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix CRC mismatch (rev5) Patchwork
@ 2020-02-03 11:57 ` Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2020-02-03 11:57 UTC (permalink / raw)
To: Kahola, Mika; +Cc: igt-dev
== Series Details ==
Series: Fix CRC mismatch (rev4)
URL : https://patchwork.freedesktop.org/series/72625/
State : success
== Summary ==
CI Bug Log - changes from IGT_5408_full -> IGTPW_4056_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4056_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_ctx_persistence@engines-hang@rcs0}:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl8/igt@gem_ctx_persistence@engines-hang@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl2/igt@gem_ctx_persistence@engines-hang@rcs0.html
Known issues
------------
Here are the changes found in IGTPW_4056_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vecs0-s3:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#180])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl8/igt@gem_ctx_isolation@vecs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl1/igt@gem_ctx_isolation@vecs0-s3.html
* igt@gem_exec_balancer@hang:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([fdo#112271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-tglb1/igt@gem_exec_balancer@hang.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-tglb5/igt@gem_exec_balancer@hang.html
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb3/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb2/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +10 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl1/igt@gem_exec_suspend@basic-s3.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_whisper@normal:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#118] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-glk3/igt@gem_exec_whisper@normal.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-glk7/igt@gem_exec_whisper@normal.html
* igt@gem_linear_blits@interruptible:
- shard-hsw: [PASS][15] -> [FAIL][16] ([i915#694])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-hsw7/igt@gem_linear_blits@interruptible.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-hsw1/igt@gem_linear_blits@interruptible.html
* igt@gen9_exec_parse@allowed-all:
- shard-kbl: [PASS][17] -> [TIMEOUT][18] ([i915#716])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl4/igt@gen9_exec_parse@allowed-all.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl3/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#413])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb1/igt@i915_pm_rps@waitboost.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb2/igt@i915_pm_rps@waitboost.html
* igt@kms_cursor_crc@pipe-a-cursor-256x256-random:
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#54]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-256x256-random.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-256x256-random.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#54])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-glk6/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-glk3/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
- shard-apl: [PASS][25] -> [FAIL][26] ([i915#54]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-tglb: [PASS][27] -> [SKIP][28] ([i915#668]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@perf_pmu@busy-check-all-vcs1:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#112080]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb1/igt@perf_pmu@busy-check-all-vcs1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb7/igt@perf_pmu@busy-check-all-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109276]) +12 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb2/igt@prime_busy@hang-bsd2.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb5/igt@prime_busy@hang-bsd2.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][35] ([fdo#112080]) -> [PASS][36] +12 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb5/igt@gem_busy@busy-vcs1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb4/igt@gem_busy@busy-vcs1.html
* {igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd}:
- shard-apl: [FAIL][37] -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl6/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
* {igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1}:
- shard-apl: [INCOMPLETE][39] ([fdo#103927]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl6/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][41] ([fdo#110854]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb5/igt@gem_exec_balancer@smoke.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-hsw: [FAIL][43] ([i915#694]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-hsw2/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-hsw5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_exec_schedule@out-order-bsd2:
- shard-iclb: [SKIP][45] ([fdo#109276]) -> [PASS][46] +23 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb6/igt@gem_exec_schedule@out-order-bsd2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb4/igt@gem_exec_schedule@out-order-bsd2.html
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][47] ([i915#677]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb7/igt@gem_exec_schedule@pi-common-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][49] ([fdo#112146]) -> [PASS][50] +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][51] ([i915#644]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-glk8/igt@gem_ppgtt@flink-and-close-vma-leak.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-glk7/igt@gem_ppgtt@flink-and-close-vma-leak.html
- shard-tglb: [FAIL][53] ([i915#644]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-tglb3/igt@gem_ppgtt@flink-and-close-vma-leak.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-tglb5/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-kbl: [FAIL][55] -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl2/igt@kms_big_fb@linear-64bpp-rotate-180.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl6/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_flip@2x-flip-vs-modeset:
- shard-hsw: [DMESG-WARN][57] ([i915#44]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-hsw5/igt@kms_flip@2x-flip-vs-modeset.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-hsw2/igt@kms_flip@2x-flip-vs-modeset.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [INCOMPLETE][59] ([i915#61]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-hsw5/igt@kms_flip@flip-vs-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-hsw5/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-kbl: [FAIL][61] ([i915#160]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][65] ([i915#180]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-tglb: [FAIL][67] ([i915#899]) -> [PASS][68] +11 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-tglb2/igt@kms_plane_lowres@pipe-a-tiling-none.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-tglb5/igt@kms_plane_lowres@pipe-a-tiling-none.html
* igt@kms_plane_lowres@pipe-b-tiling-x:
- shard-glk: [FAIL][69] ([i915#899]) -> [PASS][70] +8 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-glk2/igt@kms_plane_lowres@pipe-b-tiling-x.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-glk6/igt@kms_plane_lowres@pipe-b-tiling-x.html
* igt@kms_plane_lowres@pipe-c-tiling-none:
- shard-iclb: [FAIL][71] ([i915#899]) -> [PASS][72] +11 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb6/igt@kms_plane_lowres@pipe-c-tiling-none.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb8/igt@kms_plane_lowres@pipe-c-tiling-none.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@suspend:
- shard-tglb: [SKIP][75] ([i915#668]) -> [PASS][76] +4 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-tglb1/igt@kms_psr@suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-tglb7/igt@kms_psr@suspend.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][77] ([i915#31]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl1/igt@kms_setmode@basic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl8/igt@kms_setmode@basic.html
- shard-glk: [FAIL][79] ([i915#31]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-glk8/igt@kms_setmode@basic.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-glk2/igt@kms_setmode@basic.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][81] ([fdo#112080]) -> [FAIL][82] ([IGT#28])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-iclb5/igt@gem_ctx_isolation@vcs1-nonpriv.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_eio@kms:
- shard-kbl: [TIMEOUT][83] ([fdo#112271]) -> [INCOMPLETE][84] ([CI#80] / [fdo#103665])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-kbl2/igt@gem_eio@kms.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-kbl4/igt@gem_eio@kms.html
* igt@gem_eio@reset-stress:
- shard-apl: [TIMEOUT][85] ([fdo#112271]) -> [INCOMPLETE][86] ([CI#80] / [fdo#103927])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl2/igt@gem_eio@reset-stress.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl7/igt@gem_eio@reset-stress.html
* igt@gem_eio@unwedge-stress:
- shard-glk: [INCOMPLETE][87] ([CI#80] / [i915#58] / [k.org#198133]) -> [TIMEOUT][88] ([fdo#112271])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-glk1/igt@gem_eio@unwedge-stress.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-glk2/igt@gem_eio@unwedge-stress.html
* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][89] ([i915#694]) -> [FAIL][90] ([i915#818])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-hsw2/igt@gem_tiled_blits@normal.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-hsw5/igt@gem_tiled_blits@normal.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [SKIP][91] ([i915#468]) -> [FAIL][92] ([i915#454])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-tglb5/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][93] ([i915#180]) -> [FAIL][94] ([i915#54])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5408/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#160]: https://gitlab.freedesktop.org/drm/intel/issues/160
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5408 -> IGTPW_4056
CI-20190529: 20190529
CI_DRM_7850: ae66f2257648ce52c51298506977baa32873c9d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4056: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
IGT_5408: 8980bcd421744fb63d38270e1fcc9c7432d70d00 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4056/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: Fix CRC mismatch
2020-01-31 9:26 ` [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: " Mika Kahola
2020-01-31 10:55 ` Petri Latvala
@ 2020-02-03 15:06 ` Juha-Pekka Heikkila
2020-02-04 7:31 ` Kahola, Mika
1 sibling, 1 reply; 11+ messages in thread
From: Juha-Pekka Heikkila @ 2020-02-03 15:06 UTC (permalink / raw)
To: Mika Kahola, igt-dev
On 31.1.2020 11.26, Mika Kahola wrote:
> Mixing SDR and HDR planes yields to CRC mismatch. The patch computes the
> reference image and CRC with the main plane matching the SDR/HDR plane type.
>
> v2: HDR planes are not defined for gen9 and older (CI)
>
> References: https://gitlab.freedesktop.org/drm/intel/issues/899
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_plane_lowres.c | 142 +++++++++++++++++++++++++--------------
> 1 file changed, 90 insertions(+), 52 deletions(-)
>
> diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> index 4c3f5636..012b25e3 100644
> --- a/tests/kms_plane_lowres.c
> +++ b/tests/kms_plane_lowres.c
> @@ -32,11 +32,15 @@
>
> IGT_TEST_DESCRIPTION("Test atomic mode setting with a plane by switching between high and low resolutions");
>
> +#define SDR_PLANE_BASE 3
> #define SIZE 64
>
> typedef struct {
> int drm_fd;
> igt_display_t display;
> + uint32_t devid;
> + igt_output_t *output;
> + enum pipe pipe;
> struct igt_fb fb_primary;
> struct igt_fb fb_plane[2];
> struct {
> @@ -77,11 +81,44 @@ get_lowres_mode(int drmfd, igt_output_t *output,
> return *mode;
> }
>
> +static igt_plane_t *first_sdr_plane(igt_output_t *output, uint32_t devid)
> +{
> + int index;
> +
> + index = intel_gen(devid) <= 9 ? 0 : SDR_PLANE_BASE;
> +
> + return igt_output_get_plane(output, index);
> +}
> +
> +static bool is_sdr_plane(const igt_plane_t *plane, uint32_t devid)
> +{
> + if (intel_gen(devid) <= 9)
> + return true;
> +
> + return plane->index >= SDR_PLANE_BASE;
> +}
> +/*
> + * Mixing SDR and HDR planes results in a CRC mismatch, so use the first
> + * SDR/HDR plane as the main plane matching the SDR/HDR type of the sprite
> + * plane under test.
> + */
> +static igt_plane_t *compatible_main_plane(igt_plane_t *plane,
> + igt_output_t *output,
> + uint32_t devid)
> +{
> + if (is_sdr_plane(plane, devid))
> + return first_sdr_plane(output, devid);
> +
> + return igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> +}
> +
> static bool setup_plane(data_t *data, igt_plane_t *plane)
> {
> struct igt_fb *fb;
>
> - if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> + if (plane->type == DRM_PLANE_TYPE_PRIMARY ||
> + plane == first_sdr_plane(data->output, data->devid) ||
> + plane->type == DRM_PLANE_TYPE_CURSOR)
> return false;
>
> fb = &data->fb_plane[0];
> @@ -125,25 +162,20 @@ static void create_ref_fb(data_t *data, uint64_t modifier,
> }
>
> static unsigned
> -test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> - igt_output_t *output, uint64_t modifier)
> +test_planes_on_pipe_with_output(data_t *data, igt_plane_t *plane, uint64_t modifier)
> {
> - igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> const drmModeModeInfo *mode;
> drmModeModeInfo mode_lowres;
> igt_pipe_crc_t *pipe_crc;
> unsigned tested = 0;
> - igt_plane_t *plane;
> igt_plane_t *primary;
> + igt_crc_t crc_lowres, crc_hires1, crc_hires2;
>
> - primary = igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_PRIMARY);
> -
> - igt_info("Testing connector %s using pipe %s\n",
> - igt_output_name(output), kmstest_pipe_name(pipe));
> + igt_output_set_pipe(data->output, data->pipe);
>
> - igt_output_set_pipe(output, pipe);
> - mode = igt_output_get_mode(output);
> - mode_lowres = get_lowres_mode(data->drm_fd, output, mode);
> + primary = compatible_main_plane(plane, data->output, data->devid);
> + mode = igt_output_get_mode(data->output);
> + mode_lowres = get_lowres_mode(data->drm_fd, data->output, mode);
>
> igt_create_color_pattern_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
> DRM_FORMAT_XRGB8888, modifier, 0.0, 0.0, 1.0,
> @@ -164,15 +196,15 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> create_ref_fb(data, modifier, mode, &data->ref_hires.fb);
> create_ref_fb(data, modifier, &mode_lowres, &data->ref_lowres.fb);
>
> - pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
> + pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
> INTEL_PIPE_CRC_SOURCE_AUTO);
>
> - igt_output_override_mode(output, &mode_lowres);
> + igt_output_override_mode(data->output, &mode_lowres);
> igt_plane_set_fb(primary, &data->ref_lowres.fb);
> igt_display_commit2(&data->display, COMMIT_ATOMIC);
> igt_pipe_crc_collect_crc(pipe_crc, &data->ref_lowres.crc);
>
> - igt_output_override_mode(output, NULL);
> + igt_output_override_mode(data->output, NULL);
> igt_plane_set_fb(primary, &data->ref_hires.fb);
> igt_display_commit2(&data->display, COMMIT_ATOMIC);
> igt_pipe_crc_collect_crc(pipe_crc, &data->ref_hires.crc);
> @@ -181,40 +213,36 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> /* yellow sprite plane in lower left corner */
> - for_each_plane_on_pipe(&data->display, pipe, plane) {
> - igt_crc_t crc_lowres, crc_hires1, crc_hires2;
> -
> - if (!setup_plane(data, plane))
> - continue;
> + if (!setup_plane(data, plane))
> + return 0;
>
> - igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> - igt_pipe_crc_collect_crc(pipe_crc, &crc_hires1);
> + igt_pipe_crc_collect_crc(pipe_crc, &crc_hires1);
>
> - /* switch to lower resolution */
> - igt_output_override_mode(output, &mode_lowres);
> - igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + /* switch to lower resolution */
> + igt_output_override_mode(data->output, &mode_lowres);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> - igt_pipe_crc_collect_crc(pipe_crc, &crc_lowres);
> + igt_pipe_crc_collect_crc(pipe_crc, &crc_lowres);
>
> - /* switch back to higher resolution */
> - igt_output_override_mode(output, NULL);
> - igt_display_commit2(&data->display, COMMIT_ATOMIC);
> + /* switch back to higher resolution */
> + igt_output_override_mode(data->output, NULL);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> - igt_pipe_crc_collect_crc(pipe_crc, &crc_hires2);
> + igt_pipe_crc_collect_crc(pipe_crc, &crc_hires2);
>
> - igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires1);
> - igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires2);
> - igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
> + igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires1);
> + igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires2);
> + igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
>
> - igt_plane_set_fb(plane, NULL);
> - tested++;
> - }
> + igt_plane_set_fb(plane, NULL);
> + tested++;
>
> igt_pipe_crc_free(pipe_crc);
>
> igt_plane_set_fb(primary, NULL);
> - igt_output_set_pipe(output, PIPE_NONE);
> + igt_output_set_pipe(data->output, PIPE_NONE);
>
> igt_remove_fb(data->drm_fd, &data->fb_plane[1]);
> igt_remove_fb(data->drm_fd, &data->fb_plane[0]);
> @@ -226,21 +254,32 @@ test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> }
>
> static void
> -test_planes_on_pipe(data_t *data, enum pipe pipe, uint64_t modifier)
> +test_planes_on_pipe(data_t *data, uint64_t modifier)
> {
> - igt_output_t *output;
> + igt_plane_t *plane;
> unsigned tested = 0;
>
> - igt_skip_on(pipe >= data->display.n_pipes);
> - igt_display_require_output_on_pipe(&data->display, pipe);
> + igt_skip_on(data->pipe >= data->display.n_pipes);
> + igt_display_require_output_on_pipe(&data->display, data->pipe);
> igt_skip_on(!igt_display_has_format_mod(&data->display,
> DRM_FORMAT_XRGB8888, modifier));
>
> - for_each_valid_output_on_pipe(&data->display, pipe, output)
> - tested += test_planes_on_pipe_with_output(data, pipe, output,
> - modifier);
> + data->output = igt_get_single_output_for_pipe(&data->display, data->pipe);
> + igt_require(data->output);
> +
> + igt_info("Testing connector %s using pipe %s\n",
> + igt_output_name(data->output), kmstest_pipe_name(data->pipe));
> +
> + for_each_plane_on_pipe(&data->display, data->pipe, plane) {
> + data->output = igt_get_single_output_for_pipe(&data->display, data->pipe);
> + igt_require(data->output);
> +
> + tested += test_planes_on_pipe_with_output(data, plane, modifier);
> + }
>
> igt_assert(tested > 0);
> + igt_output_set_pipe(data->output, PIPE_NONE);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> }
>
> igt_main
> @@ -250,6 +289,8 @@ igt_main
>
> igt_fixture {
> data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> + data.devid = is_i915_device(data.drm_fd) ?
> + intel_get_drm_devid(data.drm_fd) : 0;
>
> kmstest_set_vt_graphics_mode();
>
> @@ -259,21 +300,18 @@ igt_main
> }
>
> for_each_pipe_static(pipe) {
> + data.pipe = pipe;
> igt_subtest_f("pipe-%s-tiling-none", kmstest_pipe_name(pipe))
> - test_planes_on_pipe(&data, pipe,
> - LOCAL_DRM_FORMAT_MOD_NONE);
> + test_planes_on_pipe(&data, LOCAL_DRM_FORMAT_MOD_NONE);
>
> igt_subtest_f("pipe-%s-tiling-x", kmstest_pipe_name(pipe))
> - test_planes_on_pipe(&data, pipe,
> - LOCAL_I915_FORMAT_MOD_X_TILED);
> + test_planes_on_pipe(&data, LOCAL_I915_FORMAT_MOD_X_TILED);
>
> igt_subtest_f("pipe-%s-tiling-y", kmstest_pipe_name(pipe))
> - test_planes_on_pipe(&data, pipe,
> - LOCAL_I915_FORMAT_MOD_Y_TILED);
> + test_planes_on_pipe(&data, LOCAL_I915_FORMAT_MOD_Y_TILED);
>
> igt_subtest_f("pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
> - test_planes_on_pipe(&data, pipe,
> - LOCAL_I915_FORMAT_MOD_Yf_TILED);
> + test_planes_on_pipe(&data, LOCAL_I915_FORMAT_MOD_Yf_TILED);
> }
>
> igt_fixture {
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: Fix CRC mismatch
2020-02-03 15:06 ` Juha-Pekka Heikkila
@ 2020-02-04 7:31 ` Kahola, Mika
0 siblings, 0 replies; 11+ messages in thread
From: Kahola, Mika @ 2020-02-04 7:31 UTC (permalink / raw)
To: juhapekka.heikkila, igt-dev
On Mon, 2020-02-03 at 17:06 +0200, Juha-Pekka Heikkila wrote:
> On 31.1.2020 11.26, Mika Kahola wrote:
> > Mixing SDR and HDR planes yields to CRC mismatch. The patch
> > computes the
> > reference image and CRC with the main plane matching the SDR/HDR
> > plane type.
> >
> > v2: HDR planes are not defined for gen9 and older (CI)
> >
> > References: https://gitlab.freedesktop.org/drm/intel/issues/899
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>
> Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Pushed. Thanks for the review!
-Mika-
>
> > ---
> > tests/kms_plane_lowres.c | 142 +++++++++++++++++++++++++---------
> > -----
> > 1 file changed, 90 insertions(+), 52 deletions(-)
> >
> > diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> > index 4c3f5636..012b25e3 100644
> > --- a/tests/kms_plane_lowres.c
> > +++ b/tests/kms_plane_lowres.c
> > @@ -32,11 +32,15 @@
> >
> > IGT_TEST_DESCRIPTION("Test atomic mode setting with a plane by
> > switching between high and low resolutions");
> >
> > +#define SDR_PLANE_BASE 3
> > #define SIZE 64
> >
> > typedef struct {
> > int drm_fd;
> > igt_display_t display;
> > + uint32_t devid;
> > + igt_output_t *output;
> > + enum pipe pipe;
> > struct igt_fb fb_primary;
> > struct igt_fb fb_plane[2];
> > struct {
> > @@ -77,11 +81,44 @@ get_lowres_mode(int drmfd, igt_output_t
> > *output,
> > return *mode;
> > }
> >
> > +static igt_plane_t *first_sdr_plane(igt_output_t *output, uint32_t
> > devid)
> > +{
> > + int index;
> > +
> > + index = intel_gen(devid) <= 9 ? 0 : SDR_PLANE_BASE;
> > +
> > + return igt_output_get_plane(output, index);
> > +}
> > +
> > +static bool is_sdr_plane(const igt_plane_t *plane, uint32_t devid)
> > +{
> > + if (intel_gen(devid) <= 9)
> > + return true;
> > +
> > + return plane->index >= SDR_PLANE_BASE;
> > +}
> > +/*
> > + * Mixing SDR and HDR planes results in a CRC mismatch, so use the
> > first
> > + * SDR/HDR plane as the main plane matching the SDR/HDR type of
> > the sprite
> > + * plane under test.
> > + */
> > +static igt_plane_t *compatible_main_plane(igt_plane_t *plane,
> > + igt_output_t *output,
> > + uint32_t devid)
> > +{
> > + if (is_sdr_plane(plane, devid))
> > + return first_sdr_plane(output, devid);
> > +
> > + return igt_output_get_plane_type(output,
> > DRM_PLANE_TYPE_PRIMARY);
> > +}
> > +
> > static bool setup_plane(data_t *data, igt_plane_t *plane)
> > {
> > struct igt_fb *fb;
> >
> > - if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> > + if (plane->type == DRM_PLANE_TYPE_PRIMARY ||
> > + plane == first_sdr_plane(data->output, data->devid) ||
> > + plane->type == DRM_PLANE_TYPE_CURSOR)
> > return false;
> >
> > fb = &data->fb_plane[0];
> > @@ -125,25 +162,20 @@ static void create_ref_fb(data_t *data,
> > uint64_t modifier,
> > }
> >
> > static unsigned
> > -test_planes_on_pipe_with_output(data_t *data, enum pipe pipe,
> > - igt_output_t *output, uint64_t
> > modifier)
> > +test_planes_on_pipe_with_output(data_t *data, igt_plane_t *plane,
> > uint64_t modifier)
> > {
> > - igt_pipe_t *pipe_obj = &data->display.pipes[pipe];
> > const drmModeModeInfo *mode;
> > drmModeModeInfo mode_lowres;
> > igt_pipe_crc_t *pipe_crc;
> > unsigned tested = 0;
> > - igt_plane_t *plane;
> > igt_plane_t *primary;
> > + igt_crc_t crc_lowres, crc_hires1, crc_hires2;
> >
> > - primary = igt_pipe_get_plane_type(pipe_obj,
> > DRM_PLANE_TYPE_PRIMARY);
> > -
> > - igt_info("Testing connector %s using pipe %s\n",
> > - igt_output_name(output), kmstest_pipe_name(pipe));
> > + igt_output_set_pipe(data->output, data->pipe);
> >
> > - igt_output_set_pipe(output, pipe);
> > - mode = igt_output_get_mode(output);
> > - mode_lowres = get_lowres_mode(data->drm_fd, output, mode);
> > + primary = compatible_main_plane(plane, data->output, data-
> > >devid);
> > + mode = igt_output_get_mode(data->output);
> > + mode_lowres = get_lowres_mode(data->drm_fd, data->output,
> > mode);
> >
> > igt_create_color_pattern_fb(data->drm_fd, mode->hdisplay, mode-
> > >vdisplay,
> > DRM_FORMAT_XRGB8888, modifier, 0.0,
> > 0.0, 1.0,
> > @@ -164,15 +196,15 @@ test_planes_on_pipe_with_output(data_t *data,
> > enum pipe pipe,
> > create_ref_fb(data, modifier, mode, &data->ref_hires.fb);
> > create_ref_fb(data, modifier, &mode_lowres, &data-
> > >ref_lowres.fb);
> >
> > - pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
> > + pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
> > INTEL_PIPE_CRC_SOURCE_AUTO);
> >
> > - igt_output_override_mode(output, &mode_lowres);
> > + igt_output_override_mode(data->output, &mode_lowres);
> > igt_plane_set_fb(primary, &data->ref_lowres.fb);
> > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > igt_pipe_crc_collect_crc(pipe_crc, &data->ref_lowres.crc);
> >
> > - igt_output_override_mode(output, NULL);
> > + igt_output_override_mode(data->output, NULL);
> > igt_plane_set_fb(primary, &data->ref_hires.fb);
> > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > igt_pipe_crc_collect_crc(pipe_crc, &data->ref_hires.crc);
> > @@ -181,40 +213,36 @@ test_planes_on_pipe_with_output(data_t *data,
> > enum pipe pipe,
> > igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> > /* yellow sprite plane in lower left corner */
> > - for_each_plane_on_pipe(&data->display, pipe, plane) {
> > - igt_crc_t crc_lowres, crc_hires1, crc_hires2;
> > -
> > - if (!setup_plane(data, plane))
> > - continue;
> > + if (!setup_plane(data, plane))
> > + return 0;
> >
> > - igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> > - igt_pipe_crc_collect_crc(pipe_crc, &crc_hires1);
> > + igt_pipe_crc_collect_crc(pipe_crc, &crc_hires1);
> >
> > - /* switch to lower resolution */
> > - igt_output_override_mode(output, &mode_lowres);
> > - igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > + /* switch to lower resolution */
> > + igt_output_override_mode(data->output, &mode_lowres);
> > + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> > - igt_pipe_crc_collect_crc(pipe_crc, &crc_lowres);
> > + igt_pipe_crc_collect_crc(pipe_crc, &crc_lowres);
> >
> > - /* switch back to higher resolution */
> > - igt_output_override_mode(output, NULL);
> > - igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > + /* switch back to higher resolution */
> > + igt_output_override_mode(data->output, NULL);
> > + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> > - igt_pipe_crc_collect_crc(pipe_crc, &crc_hires2);
> > + igt_pipe_crc_collect_crc(pipe_crc, &crc_hires2);
> >
> > - igt_assert_crc_equal(&data->ref_hires.crc,
> > &crc_hires1);
> > - igt_assert_crc_equal(&data->ref_hires.crc,
> > &crc_hires2);
> > - igt_assert_crc_equal(&data->ref_lowres.crc,
> > &crc_lowres);
> > + igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires1);
> > + igt_assert_crc_equal(&data->ref_hires.crc, &crc_hires2);
> > + igt_assert_crc_equal(&data->ref_lowres.crc, &crc_lowres);
> >
> > - igt_plane_set_fb(plane, NULL);
> > - tested++;
> > - }
> > + igt_plane_set_fb(plane, NULL);
> > + tested++;
> >
> > igt_pipe_crc_free(pipe_crc);
> >
> > igt_plane_set_fb(primary, NULL);
> > - igt_output_set_pipe(output, PIPE_NONE);
> > + igt_output_set_pipe(data->output, PIPE_NONE);
> >
> > igt_remove_fb(data->drm_fd, &data->fb_plane[1]);
> > igt_remove_fb(data->drm_fd, &data->fb_plane[0]);
> > @@ -226,21 +254,32 @@ test_planes_on_pipe_with_output(data_t *data,
> > enum pipe pipe,
> > }
> >
> > static void
> > -test_planes_on_pipe(data_t *data, enum pipe pipe, uint64_t
> > modifier)
> > +test_planes_on_pipe(data_t *data, uint64_t modifier)
> > {
> > - igt_output_t *output;
> > + igt_plane_t *plane;
> > unsigned tested = 0;
> >
> > - igt_skip_on(pipe >= data->display.n_pipes);
> > - igt_display_require_output_on_pipe(&data->display, pipe);
> > + igt_skip_on(data->pipe >= data->display.n_pipes);
> > + igt_display_require_output_on_pipe(&data->display, data->pipe);
> > igt_skip_on(!igt_display_has_format_mod(&data->display,
> > DRM_FORMAT_XRGB8888,
> > modifier));
> >
> > - for_each_valid_output_on_pipe(&data->display, pipe, output)
> > - tested += test_planes_on_pipe_with_output(data, pipe,
> > output,
> > - modifier);
> > + data->output = igt_get_single_output_for_pipe(&data->display,
> > data->pipe);
> > + igt_require(data->output);
> > +
> > + igt_info("Testing connector %s using pipe %s\n",
> > + igt_output_name(data->output), kmstest_pipe_name(data-
> > >pipe));
> > +
> > + for_each_plane_on_pipe(&data->display, data->pipe, plane) {
> > + data->output = igt_get_single_output_for_pipe(&data-
> > >display, data->pipe);
> > + igt_require(data->output);
> > +
> > + tested += test_planes_on_pipe_with_output(data, plane,
> > modifier);
> > + }
> >
> > igt_assert(tested > 0);
> > + igt_output_set_pipe(data->output, PIPE_NONE);
> > + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> > }
> >
> > igt_main
> > @@ -250,6 +289,8 @@ igt_main
> >
> > igt_fixture {
> > data.drm_fd = drm_open_driver_master(DRIVER_ANY);
> > + data.devid = is_i915_device(data.drm_fd) ?
> > + intel_get_drm_devid(data.drm_fd) : 0;
> >
> > kmstest_set_vt_graphics_mode();
> >
> > @@ -259,21 +300,18 @@ igt_main
> > }
> >
> > for_each_pipe_static(pipe) {
> > + data.pipe = pipe;
> > igt_subtest_f("pipe-%s-tiling-none",
> > kmstest_pipe_name(pipe))
> > - test_planes_on_pipe(&data, pipe,
> > - LOCAL_DRM_FORMAT_MOD_NONE);
> > + test_planes_on_pipe(&data,
> > LOCAL_DRM_FORMAT_MOD_NONE);
> >
> > igt_subtest_f("pipe-%s-tiling-x",
> > kmstest_pipe_name(pipe))
> > - test_planes_on_pipe(&data, pipe,
> > - LOCAL_I915_FORMAT_MOD_X_TIL
> > ED);
> > + test_planes_on_pipe(&data,
> > LOCAL_I915_FORMAT_MOD_X_TILED);
> >
> > igt_subtest_f("pipe-%s-tiling-y",
> > kmstest_pipe_name(pipe))
> > - test_planes_on_pipe(&data, pipe,
> > - LOCAL_I915_FORMAT_MOD_Y_TIL
> > ED);
> > + test_planes_on_pipe(&data,
> > LOCAL_I915_FORMAT_MOD_Y_TILED);
> >
> > igt_subtest_f("pipe-%s-tiling-yf",
> > kmstest_pipe_name(pipe))
> > - test_planes_on_pipe(&data, pipe,
> > - LOCAL_I915_FORMAT_MOD_Yf_TI
> > LED);
> > + test_planes_on_pipe(&data,
> > LOCAL_I915_FORMAT_MOD_Yf_TILED);
> > }
> >
> > igt_fixture {
> >
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-02-04 7:31 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 9:26 [igt-dev] [PATCH i-g-t v2 0/1] Fix CRC mismatch Mika Kahola
2020-01-31 9:26 ` [igt-dev] [PATCH i-g-t v2 1/1] tests/kms_plane_lowres: " Mika Kahola
2020-01-31 10:55 ` Petri Latvala
2020-01-31 12:11 ` Kahola, Mika
2020-02-03 15:06 ` Juha-Pekka Heikkila
2020-02-04 7:31 ` Kahola, Mika
2020-01-31 10:29 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev3) Patchwork
2020-01-31 11:55 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix CRC mismatch (rev4) Patchwork
2020-01-31 15:11 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-02-03 9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix CRC mismatch (rev5) Patchwork
2020-02-03 11:57 ` [igt-dev] ✓ Fi.CI.IGT: success for Fix CRC mismatch (rev4) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.