* [Intel-gfx] [CI] drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk()
@ 2020-02-03 13:38 Chris Wilson
2020-02-04 17:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk() (rev2) Patchwork
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wilson @ 2020-02-03 13:38 UTC (permalink / raw)
To: intel-gfx
[ 23.419442] BUG: KASAN: null-ptr-deref in intel_plane_calc_min_cdclk+0x82/0x440 [i915]
[ 23.419527] Read of size 4 at addr 00000000000000f8 by task insmod/735
[ 23.419578]
[ 23.419644] CPU: 2 PID: 735 Comm: insmod Not tainted 5.5.0+ #114
[ 23.419716] Hardware name: ��������������������������������� ���������������������������������/���������������������������������, BIOS RYBDWi35.86A.0246.2
[ 23.419793] Call Trace:
[ 23.419864] dump_stack+0xef/0x16e
[ 23.419927] __kasan_report.cold+0x60/0x90
[ 23.420157] ? intel_plane_calc_min_cdclk+0x82/0x440 [i915]
[ 23.420397] intel_plane_calc_min_cdclk+0x82/0x440 [i915]
[ 23.420630] intel_atomic_check+0x455f/0x65a0 [i915]
[ 23.420708] ? mark_held_locks+0x90/0x90
[ 23.420929] ? intel_crtc_duplicate_state+0x2e/0x1b0 [i915]
[ 23.421172] ? intel_plane_duplicate_state+0x2d/0xc0 [i915]
[ 23.421239] ? __drm_dbg+0xa4/0x120
[ 23.421303] ? __kasan_kmalloc.constprop.0+0xc2/0xd0
[ 23.421355] ? __kmalloc_track_caller+0x23a/0x320
[ 23.421602] ? intel_calc_active_pipes+0x1c0/0x1c0 [i915]
[ 23.421852] sanitize_watermarks+0x220/0x510 [i915]
[ 23.422092] ? intel_atomic_check+0x65a0/0x65a0 [i915]
[ 23.422164] ? drm_modeset_unlock_all+0x88/0x130
[ 23.422402] intel_modeset_init+0x1b76/0x3c90 [i915]
[ 23.422647] ? intel_finish_reset+0x2d0/0x2d0 [i915]
[ 23.422851] ? intel_irq_install+0x12c/0x210 [i915]
[ 23.423076] i915_driver_probe+0x13e7/0x2930 [i915]
v2: No crtc is implied by an invisible plane, so the extra !crtc check
is redundant.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 91ab6e2ab1fd..c86d7a35c816 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -165,14 +165,15 @@ int intel_plane_calc_min_cdclk(struct intel_atomic_state *state,
intel_atomic_get_new_plane_state(state, plane);
struct intel_crtc *crtc = to_intel_crtc(plane_state->hw.crtc);
const struct intel_cdclk_state *cdclk_state;
- struct intel_crtc_state *new_crtc_state =
- intel_atomic_get_new_crtc_state(state, crtc);
- const struct intel_crtc_state *old_crtc_state =
- intel_atomic_get_old_crtc_state(state, crtc);
+ const struct intel_crtc_state *old_crtc_state;
+ struct intel_crtc_state *new_crtc_state;
if (!plane_state->uapi.visible || !plane->min_cdclk)
return 0;
+ old_crtc_state = intel_atomic_get_old_crtc_state(state, crtc);
+ new_crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
+
new_crtc_state->min_cdclk[plane->id] =
plane->min_cdclk(new_crtc_state, plane_state);
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk() (rev2)
2020-02-03 13:38 [Intel-gfx] [CI] drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk() Chris Wilson
@ 2020-02-04 17:10 ` Patchwork
0 siblings, 0 replies; 2+ messages in thread
From: Patchwork @ 2020-02-04 17:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk() (rev2)
URL : https://patchwork.freedesktop.org/series/72875/
State : failure
== Summary ==
Applying: drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk()
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_atomic_plane.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-04 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 13:38 [Intel-gfx] [CI] drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk() Chris Wilson
2020-02-04 17:10 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix NULL-crtc deref in calc_min_cdclk() (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.