* [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size
@ 2020-02-06 0:33 Chris Wilson
2020-02-06 3:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Chris Wilson @ 2020-02-06 0:33 UTC (permalink / raw)
To: intel-gfx
Reduce the amount of work we do to verify client blt correctness as
currently our 0.5s subtests takes about 15s on slower devices!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../i915/gem/selftests/i915_gem_object_blt.c | 24 ++++++++++++-------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 62077fe46715..cebbe3c3ca86 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -226,7 +226,7 @@ static int igt_fill_blt_thread(void *arg)
GEM_BUG_ON(IS_ERR(ce));
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ const u32 max_block_size = SZ_64M; /* max S16_MAX * PAGE_SIZE */
u32 val = prandom_u32_state(prng);
u64 total = ce->vm->total;
u32 phys_sz;
@@ -276,13 +276,16 @@ static int igt_fill_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(obj);
- err = i915_gem_object_set_to_cpu_domain(obj, false);
- i915_gem_object_unlock(obj);
+ err = i915_gem_object_wait(obj, I915_WAIT_ALL, HZ / 2);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); i += 17) {
+ if (!(obj->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
@@ -335,7 +338,7 @@ static int igt_copy_blt_thread(void *arg)
GEM_BUG_ON(IS_ERR(ce));
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ const u32 max_block_size = SZ_64M; /* max S16_MAX * PAGE_SIZE */
u32 val = prandom_u32_state(prng);
u64 total = ce->vm->total;
u32 phys_sz;
@@ -397,13 +400,16 @@ static int igt_copy_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(dst);
- err = i915_gem_object_set_to_cpu_domain(dst, false);
- i915_gem_object_unlock(dst);
+ err = i915_gem_object_wait(dst, I915_WAIT_ALL, HZ / 2);
if (err)
goto err_unpin;
for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); ++i) {
+ if (!(dst->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size
2020-02-06 0:33 [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
@ 2020-02-06 3:04 ` Patchwork
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-06 12:52 ` [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
2 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-02-06 3:04 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Trim blitter block size
URL : https://patchwork.freedesktop.org/series/73066/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b4454179762f drm/i915/selftests: Trim blitter block size
-:39: WARNING:MEMORY_BARRIER: memory barrier without comment
#39: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:286:
+ mb();
-:68: WARNING:MEMORY_BARRIER: memory barrier without comment
#68: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:410:
+ mb();
total: 0 errors, 2 warnings, 0 checks, 55 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Trim blitter block size
2020-02-06 0:33 [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
2020-02-06 3:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-02-06 3:33 ` Patchwork
2020-02-06 9:20 ` [Intel-gfx] [PATCH] " Chris Wilson
` (4 more replies)
2020-02-06 12:52 ` [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
2 siblings, 5 replies; 10+ messages in thread
From: Patchwork @ 2020-02-06 3:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Trim blitter block size
URL : https://patchwork.freedesktop.org/series/73066/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7874 -> Patchwork_16448
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16448 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16448, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16448:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_blt:
- fi-whl-u: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-whl-u/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-whl-u/igt@i915_selftest@live_blt.html
- fi-bdw-5557u: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-bdw-5557u/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-bdw-5557u/igt@i915_selftest@live_blt.html
- fi-icl-u3: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u3/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-icl-u3/igt@i915_selftest@live_blt.html
- fi-cfl-8109u: [PASS][7] -> [INCOMPLETE][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cfl-8109u/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-cfl-8109u/igt@i915_selftest@live_blt.html
- fi-kbl-7500u: [PASS][9] -> [INCOMPLETE][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-7500u/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-kbl-7500u/igt@i915_selftest@live_blt.html
- fi-kbl-guc: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-guc/igt@i915_selftest@live_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-kbl-guc/igt@i915_selftest@live_blt.html
- fi-kbl-8809g: [PASS][13] -> [INCOMPLETE][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-8809g/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-kbl-8809g/igt@i915_selftest@live_blt.html
- fi-icl-guc: [PASS][15] -> [INCOMPLETE][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-guc/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-icl-guc/igt@i915_selftest@live_blt.html
- fi-kbl-r: [PASS][17] -> [INCOMPLETE][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-r/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-kbl-r/igt@i915_selftest@live_blt.html
- fi-cfl-8700k: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cfl-8700k/igt@i915_selftest@live_blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-cfl-8700k/igt@i915_selftest@live_blt.html
- fi-icl-u2: [PASS][21] -> [INCOMPLETE][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u2/igt@i915_selftest@live_blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-icl-u2/igt@i915_selftest@live_blt.html
- fi-kbl-x1275: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-x1275/igt@i915_selftest@live_blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-kbl-x1275/igt@i915_selftest@live_blt.html
- fi-icl-dsi: [PASS][25] -> [INCOMPLETE][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-dsi/igt@i915_selftest@live_blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-icl-dsi/igt@i915_selftest@live_blt.html
- fi-cfl-guc: [PASS][27] -> [INCOMPLETE][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cfl-guc/igt@i915_selftest@live_blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-cfl-guc/igt@i915_selftest@live_blt.html
- fi-skl-6600u: [PASS][29] -> [DMESG-FAIL][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-6600u/igt@i915_selftest@live_blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-skl-6600u/igt@i915_selftest@live_blt.html
- fi-icl-y: [PASS][31] -> [INCOMPLETE][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-y/igt@i915_selftest@live_blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-icl-y/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][33] -> [INCOMPLETE][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-hsw-4770/igt@i915_selftest@live_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-hsw-4770/igt@i915_selftest@live_blt.html
Known issues
------------
Here are the changes found in Patchwork_16448 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-hsw-peppy: [PASS][35] -> [INCOMPLETE][36] ([i915#694] / [i915#816])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-skl-6770hq: [PASS][37] -> [INCOMPLETE][38] ([fdo#112429])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-6770hq/igt@i915_selftest@live_blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-skl-6770hq/igt@i915_selftest@live_blt.html
- fi-glk-dsi: [PASS][39] -> [INCOMPLETE][40] ([i915#58] / [k.org#198133])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-glk-dsi/igt@i915_selftest@live_blt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-glk-dsi/igt@i915_selftest@live_blt.html
- fi-apl-guc: [PASS][41] -> [INCOMPLETE][42] ([fdo#103927])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-apl-guc/igt@i915_selftest@live_blt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-apl-guc/igt@i915_selftest@live_blt.html
- fi-skl-guc: [PASS][43] -> [INCOMPLETE][44] ([fdo#112429])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-guc/igt@i915_selftest@live_blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-skl-guc/igt@i915_selftest@live_blt.html
- fi-tgl-y: [PASS][45] -> [INCOMPLETE][46] ([CI#94] / [i915#472])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-tgl-y/igt@i915_selftest@live_blt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-tgl-y/igt@i915_selftest@live_blt.html
- fi-cml-u2: [PASS][47] -> [INCOMPLETE][48] ([i915#283])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cml-u2/igt@i915_selftest@live_blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-cml-u2/igt@i915_selftest@live_blt.html
- fi-bxt-dsi: [PASS][49] -> [INCOMPLETE][50] ([fdo#103927])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-bxt-dsi/igt@i915_selftest@live_blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-bxt-dsi/igt@i915_selftest@live_blt.html
- fi-skl-6700k2: [PASS][51] -> [INCOMPLETE][52] ([fdo#112429])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-6700k2/igt@i915_selftest@live_blt.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-skl-6700k2/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][53] -> [DMESG-FAIL][54] ([i915#1052])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
* igt@prime_self_import@basic-llseek-bad:
- fi-tgl-y: [PASS][55] -> [DMESG-WARN][56] ([CI#94] / [i915#402]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html
#### Possible fixes ####
* igt@gem_exec_parallel@contexts:
- fi-byt-j1900: [TIMEOUT][57] ([fdo#112271] / [i915#1084]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][59] ([i915#694]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-byt-n2820/igt@gem_exec_parallel@fds.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][61] ([CI#94]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [DMESG-FAIL][63] ([i915#722]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
* igt@kms_addfb_basic@addfb25-bad-modifier:
- fi-tgl-y: [DMESG-WARN][65] ([CI#94] / [i915#402]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-tgl-y/igt@kms_addfb_basic@addfb25-bad-modifier.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-tgl-y/igt@kms_addfb_basic@addfb25-bad-modifier.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][67] ([fdo#109635] / [i915#217]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
#### Warnings ####
* igt@gem_exec_parallel@contexts:
- fi-byt-n2820: [TIMEOUT][69] ([fdo#112271] / [i915#1084]) -> [FAIL][70] ([i915#694])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][71] ([fdo#111096] / [i915#323]) -> [FAIL][72] ([fdo#111407])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[fdo#112429]: https://bugs.freedesktop.org/show_bug.cgi?id=112429
[i915#1052]: https://gitlab.freedesktop.org/drm/intel/issues/1052
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (51 -> 42)
------------------------------
Missing (9): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-bsw-kefka fi-kbl-7560u fi-byt-clapper fi-bsw-nick fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7874 -> Patchwork_16448
CI-20190529: 20190529
CI_DRM_7874: 3f234d1ab91ec2321312150116c1285bcb0a260b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5420: 497e13d2b4c1053bcd01bd15739fef55e7694a03 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16448: b4454179762f2834d20162d34661643c84031684 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b4454179762f drm/i915/selftests: Trim blitter block size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16448/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-02-06 9:20 ` Chris Wilson
2020-02-06 10:38 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-02-06 9:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev2) Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Chris Wilson @ 2020-02-06 9:20 UTC (permalink / raw)
To: intel-gfx
Reduce the amount of work we do to verify client blt correctness as
currently our 0.5s subtests takes about 15s on slower devices!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../i915/gem/selftests/i915_gem_object_blt.c | 40 ++++++++++++-------
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 62077fe46715..674f4298f9a6 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -226,7 +226,9 @@ static int igt_fill_blt_thread(void *arg)
GEM_BUG_ON(IS_ERR(ce));
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ /* Aim to keep the runtime under reasonable bounds! */
+ const u32 max_block_size = SZ_64M; /* max S16_MAX * PAGE_SIZE */
+ const u32 max_phys_size = SZ_64K;
u32 val = prandom_u32_state(prng);
u64 total = ce->vm->total;
u32 phys_sz;
@@ -240,9 +242,10 @@ static int igt_fill_blt_thread(void *arg)
*/
if (i915_is_ggtt(ce->vm))
total = div64_u64(total, thread->n_cpus);
+ total = min_t(u64, total, max_block_size);
- sz = min_t(u64, total >> 4, prandom_u32_state(prng));
- phys_sz = sz % (max_block_size + 1);
+ sz = i915_prandom_u32_max_state(total, prng);
+ phys_sz = sz % max_phys_size;
sz = round_up(sz, PAGE_SIZE);
phys_sz = round_up(phys_sz, PAGE_SIZE);
@@ -276,13 +279,16 @@ static int igt_fill_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(obj);
- err = i915_gem_object_set_to_cpu_domain(obj, false);
- i915_gem_object_unlock(obj);
+ err = i915_gem_object_wait(obj, I915_WAIT_ALL, HZ / 2);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); i += 17) {
+ if (!(obj->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
@@ -335,7 +341,9 @@ static int igt_copy_blt_thread(void *arg)
GEM_BUG_ON(IS_ERR(ce));
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ /* Aim to keep the runtime under reasonable bounds! */
+ const u32 max_block_size = SZ_64M; /* max S16_MAX * PAGE_SIZE */
+ const u32 max_phys_size = SZ_64K;
u32 val = prandom_u32_state(prng);
u64 total = ce->vm->total;
u32 phys_sz;
@@ -345,9 +353,10 @@ static int igt_copy_blt_thread(void *arg)
if (i915_is_ggtt(ce->vm))
total = div64_u64(total, thread->n_cpus);
+ total = min_t(u64, total, max_block_size);
- sz = min_t(u64, total >> 4, prandom_u32_state(prng));
- phys_sz = sz % (max_block_size + 1);
+ sz = i915_prandom_u32_max_state(total, prng);
+ phys_sz = sz % max_phys_size;
sz = round_up(sz, PAGE_SIZE);
phys_sz = round_up(phys_sz, PAGE_SIZE);
@@ -397,13 +406,16 @@ static int igt_copy_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(dst);
- err = i915_gem_object_set_to_cpu_domain(dst, false);
- i915_gem_object_unlock(dst);
+ err = i915_gem_object_wait(dst, I915_WAIT_ALL, HZ / 2);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); i += 17) {
+ if (!(dst->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev2)
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-06 9:20 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-02-06 9:49 ` Patchwork
2020-02-06 10:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-02-06 9:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Trim blitter block size (rev2)
URL : https://patchwork.freedesktop.org/series/73066/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c015b6f11a83 drm/i915/selftests: Trim blitter block size
-:54: WARNING:MEMORY_BARRIER: memory barrier without comment
#54: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:289:
+ mb();
-:99: WARNING:MEMORY_BARRIER: memory barrier without comment
#99: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:416:
+ mb();
total: 0 errors, 2 warnings, 0 checks, 84 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Trim blitter block size (rev2)
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-06 9:20 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-06 9:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev2) Patchwork
@ 2020-02-06 10:19 ` Patchwork
2020-02-06 11:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev3) Patchwork
2020-02-06 12:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-02-06 10:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Trim blitter block size (rev2)
URL : https://patchwork.freedesktop.org/series/73066/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7874 -> Patchwork_16454
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16454 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16454, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16454:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_blt:
- fi-whl-u: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-whl-u/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-whl-u/igt@i915_selftest@live_blt.html
- fi-skl-6770hq: [PASS][3] -> [DMESG-FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-6770hq/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-skl-6770hq/igt@i915_selftest@live_blt.html
- fi-kbl-7500u: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-7500u/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-kbl-7500u/igt@i915_selftest@live_blt.html
- fi-kbl-guc: [PASS][7] -> [DMESG-FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-guc/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-kbl-guc/igt@i915_selftest@live_blt.html
- fi-kbl-8809g: [PASS][9] -> [DMESG-FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-8809g/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-kbl-8809g/igt@i915_selftest@live_blt.html
- fi-icl-guc: [PASS][11] -> [DMESG-FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-guc/igt@i915_selftest@live_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-guc/igt@i915_selftest@live_blt.html
- fi-kbl-r: [PASS][13] -> [DMESG-FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-r/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-kbl-r/igt@i915_selftest@live_blt.html
- fi-cfl-8700k: [PASS][15] -> [DMESG-FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cfl-8700k/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-cfl-8700k/igt@i915_selftest@live_blt.html
- fi-icl-u2: [PASS][17] -> [DMESG-FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u2/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-u2/igt@i915_selftest@live_blt.html
- fi-kbl-x1275: [PASS][19] -> [DMESG-FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-x1275/igt@i915_selftest@live_blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-kbl-x1275/igt@i915_selftest@live_blt.html
- fi-icl-dsi: [PASS][21] -> [DMESG-FAIL][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-dsi/igt@i915_selftest@live_blt.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-dsi/igt@i915_selftest@live_blt.html
- fi-skl-guc: [PASS][23] -> [DMESG-FAIL][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-guc/igt@i915_selftest@live_blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-skl-guc/igt@i915_selftest@live_blt.html
- fi-cfl-guc: [PASS][25] -> [DMESG-FAIL][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cfl-guc/igt@i915_selftest@live_blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-cfl-guc/igt@i915_selftest@live_blt.html
- fi-icl-y: [PASS][27] -> [DMESG-FAIL][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-y/igt@i915_selftest@live_blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-y/igt@i915_selftest@live_blt.html
- fi-cml-u2: [PASS][29] -> [DMESG-FAIL][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cml-u2/igt@i915_selftest@live_blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-cml-u2/igt@i915_selftest@live_blt.html
- fi-skl-6700k2: [PASS][31] -> [DMESG-FAIL][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-skl-6700k2/igt@i915_selftest@live_blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-skl-6700k2/igt@i915_selftest@live_blt.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live_blt:
- {fi-ehl-1}: [PASS][33] -> [DMESG-FAIL][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-ehl-1/igt@i915_selftest@live_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-ehl-1/igt@i915_selftest@live_blt.html
- {fi-tgl-u}: [PASS][35] -> [DMESG-FAIL][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-tgl-u/igt@i915_selftest@live_blt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-tgl-u/igt@i915_selftest@live_blt.html
Known issues
------------
Here are the changes found in Patchwork_16454 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-icl-u3: [PASS][37] -> [INCOMPLETE][38] ([i915#1090])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u3/igt@gem_exec_suspend@basic-s0.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-u3/igt@gem_exec_suspend@basic-s0.html
* igt@i915_selftest@live_execlists:
- fi-icl-y: [PASS][39] -> [DMESG-FAIL][40] ([fdo#108569])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-y/igt@i915_selftest@live_execlists.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-y/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-j1900: [PASS][41] -> [DMESG-FAIL][42] ([i915#1052])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-byt-j1900/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-u2: [PASS][43] -> [INCOMPLETE][44] ([fdo#108569])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@dp-edid-read:
- fi-cml-u2: [PASS][45] -> [FAIL][46] ([i915#217] / [i915#976])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* igt@gem_exec_parallel@fds:
- fi-byt-n2820: [FAIL][47] ([i915#694]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-n2820/igt@gem_exec_parallel@fds.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-byt-n2820/igt@gem_exec_parallel@fds.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][49] ([fdo#109635] / [i915#217]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][51] ([fdo#111096] / [i915#323]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@gem_exec_parallel@contexts:
- fi-byt-j1900: [TIMEOUT][53] ([fdo#112271] / [i915#1084]) -> [FAIL][54] ([i915#694])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-byt-j1900/igt@gem_exec_parallel@contexts.html
- fi-byt-n2820: [TIMEOUT][55] ([fdo#112271] / [i915#1084]) -> [FAIL][56] ([i915#694])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
* igt@i915_selftest@live_gem_contexts:
- fi-byt-n2820: [DMESG-FAIL][57] ([i915#722]) -> [DMESG-FAIL][58] ([i915#1052])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7874/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#1052]: https://gitlab.freedesktop.org/drm/intel/issues/1052
[i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084
[i915#1090]: https://gitlab.freedesktop.org/drm/intel/issues/1090
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976
Participating hosts (51 -> 41)
------------------------------
Missing (10): fi-bdw-5557u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-bsw-kefka fi-kbl-7560u fi-tgl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7874 -> Patchwork_16454
CI-20190529: 20190529
CI_DRM_7874: 3f234d1ab91ec2321312150116c1285bcb0a260b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5420: 497e13d2b4c1053bcd01bd15739fef55e7694a03 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16454: c015b6f11a83afdc8b363957ca8aaa726203cf7b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c015b6f11a83 drm/i915/selftests: Trim blitter block size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16454/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/selftests: Trim blitter block size
2020-02-06 9:20 ` [Intel-gfx] [PATCH] " Chris Wilson
@ 2020-02-06 10:38 ` Chris Wilson
0 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2020-02-06 10:38 UTC (permalink / raw)
To: intel-gfx
Reduce the amount of work we do to verify client blt correctness as
currently our 0.5s subtests takes about 15s on slower devices!
v2: Grow the maximum block size until we run out of time
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../i915/gem/selftests/i915_gem_object_blt.c | 54 +++++++++++--------
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 62077fe46715..d7bc5b1b6989 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -210,6 +210,7 @@ static int igt_fill_blt_thread(void *arg)
struct intel_context *ce;
unsigned int prio;
IGT_TIMEOUT(end);
+ u64 total;
int err;
ctx = thread->ctx;
@@ -225,10 +226,11 @@ static int igt_fill_blt_thread(void *arg)
ce = i915_gem_context_get_engine(ctx, BCS0);
GEM_BUG_ON(IS_ERR(ce));
+ total = PAGE_SIZE;
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ /* Aim to keep the runtime under reasonable bounds! */
+ const u32 max_phys_size = SZ_64K;
u32 val = prandom_u32_state(prng);
- u64 total = ce->vm->total;
u32 phys_sz;
u32 sz;
u32 *vaddr;
@@ -238,11 +240,9 @@ static int igt_fill_blt_thread(void *arg)
* If we have a tiny shared address space, like for the GGTT
* then we can't be too greedy.
*/
- if (i915_is_ggtt(ce->vm))
- total = div64_u64(total, thread->n_cpus);
-
- sz = min_t(u64, total >> 4, prandom_u32_state(prng));
- phys_sz = sz % (max_block_size + 1);
+ total = min(total, ce->vm->total);
+ sz = i915_prandom_u32_max_state(total, prng);
+ phys_sz = sz % max_phys_size;
sz = round_up(sz, PAGE_SIZE);
phys_sz = round_up(phys_sz, PAGE_SIZE);
@@ -276,13 +276,16 @@ static int igt_fill_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(obj);
- err = i915_gem_object_set_to_cpu_domain(obj, false);
- i915_gem_object_unlock(obj);
+ err = i915_gem_object_wait(obj, 0, MAX_SCHEDULE_TIMEOUT);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); i += 17) {
+ if (!(obj->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
@@ -293,6 +296,8 @@ static int igt_fill_blt_thread(void *arg)
i915_gem_object_unpin_map(obj);
i915_gem_object_put(obj);
+
+ total <<= 1;
} while (!time_after(jiffies, end));
goto err_flush;
@@ -319,6 +324,7 @@ static int igt_copy_blt_thread(void *arg)
struct intel_context *ce;
unsigned int prio;
IGT_TIMEOUT(end);
+ u64 total;
int err;
ctx = thread->ctx;
@@ -334,20 +340,19 @@ static int igt_copy_blt_thread(void *arg)
ce = i915_gem_context_get_engine(ctx, BCS0);
GEM_BUG_ON(IS_ERR(ce));
+ total = PAGE_SIZE;
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ /* Aim to keep the runtime under reasonable bounds! */
+ const u32 max_phys_size = SZ_64K;
u32 val = prandom_u32_state(prng);
- u64 total = ce->vm->total;
u32 phys_sz;
u32 sz;
u32 *vaddr;
u32 i;
- if (i915_is_ggtt(ce->vm))
- total = div64_u64(total, thread->n_cpus);
-
- sz = min_t(u64, total >> 4, prandom_u32_state(prng));
- phys_sz = sz % (max_block_size + 1);
+ total = min(total, ce->vm->total);
+ sz = i915_prandom_u32_max_state(total, prng);
+ phys_sz = sz % max_phys_size;
sz = round_up(sz, PAGE_SIZE);
phys_sz = round_up(phys_sz, PAGE_SIZE);
@@ -397,13 +402,16 @@ static int igt_copy_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(dst);
- err = i915_gem_object_set_to_cpu_domain(dst, false);
- i915_gem_object_unlock(dst);
+ err = i915_gem_object_wait(dst, 0, MAX_SCHEDULE_TIMEOUT);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); i += 17) {
+ if (!(dst->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
@@ -416,6 +424,8 @@ static int igt_copy_blt_thread(void *arg)
i915_gem_object_put(src);
i915_gem_object_put(dst);
+
+ total <<= 1;
} while (!time_after(jiffies, end));
goto err_flush;
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev3)
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (2 preceding siblings ...)
2020-02-06 10:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-02-06 11:55 ` Patchwork
2020-02-06 12:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-02-06 11:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Trim blitter block size (rev3)
URL : https://patchwork.freedesktop.org/series/73066/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e67f881c2575 drm/i915/selftests: Trim blitter block size
-:69: WARNING:MEMORY_BARRIER: memory barrier without comment
#69: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:286:
+ mb();
-:134: WARNING:MEMORY_BARRIER: memory barrier without comment
#134: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:412:
+ mb();
total: 0 errors, 2 warnings, 0 checks, 123 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Trim blitter block size (rev3)
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (3 preceding siblings ...)
2020-02-06 11:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev3) Patchwork
@ 2020-02-06 12:33 ` Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2020-02-06 12:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Trim blitter block size (rev3)
URL : https://patchwork.freedesktop.org/series/73066/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7876 -> Patchwork_16455
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16455 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16455, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16455:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_blt:
- fi-whl-u: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-whl-u/igt@i915_selftest@live_blt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-whl-u/igt@i915_selftest@live_blt.html
- fi-snb-2600: NOTRUN -> [DMESG-FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-snb-2600/igt@i915_selftest@live_blt.html
- fi-bdw-5557u: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-bdw-5557u/igt@i915_selftest@live_blt.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-bdw-5557u/igt@i915_selftest@live_blt.html
- fi-icl-u3: [PASS][6] -> [INCOMPLETE][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-icl-u3/igt@i915_selftest@live_blt.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-icl-u3/igt@i915_selftest@live_blt.html
- fi-cfl-8109u: [PASS][8] -> [INCOMPLETE][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-cfl-8109u/igt@i915_selftest@live_blt.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-cfl-8109u/igt@i915_selftest@live_blt.html
- fi-kbl-7500u: [PASS][10] -> [INCOMPLETE][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-kbl-7500u/igt@i915_selftest@live_blt.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-kbl-7500u/igt@i915_selftest@live_blt.html
- fi-kbl-guc: [PASS][12] -> [INCOMPLETE][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-kbl-guc/igt@i915_selftest@live_blt.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-kbl-guc/igt@i915_selftest@live_blt.html
- fi-kbl-8809g: [PASS][14] -> [INCOMPLETE][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-kbl-8809g/igt@i915_selftest@live_blt.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-kbl-8809g/igt@i915_selftest@live_blt.html
- fi-hsw-4770r: [PASS][16] -> [DMESG-FAIL][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-icl-guc: [PASS][18] -> [INCOMPLETE][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-icl-guc/igt@i915_selftest@live_blt.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-icl-guc/igt@i915_selftest@live_blt.html
- fi-kbl-r: [PASS][20] -> [INCOMPLETE][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-kbl-r/igt@i915_selftest@live_blt.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-kbl-r/igt@i915_selftest@live_blt.html
- fi-cfl-8700k: [PASS][22] -> [INCOMPLETE][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-cfl-8700k/igt@i915_selftest@live_blt.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-cfl-8700k/igt@i915_selftest@live_blt.html
- fi-icl-u2: [PASS][24] -> [INCOMPLETE][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-icl-u2/igt@i915_selftest@live_blt.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-icl-u2/igt@i915_selftest@live_blt.html
- fi-kbl-x1275: [PASS][26] -> [INCOMPLETE][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-kbl-x1275/igt@i915_selftest@live_blt.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-kbl-x1275/igt@i915_selftest@live_blt.html
- fi-snb-2520m: NOTRUN -> [DMESG-FAIL][28]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-snb-2520m/igt@i915_selftest@live_blt.html
- fi-icl-dsi: [PASS][29] -> [INCOMPLETE][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-icl-dsi/igt@i915_selftest@live_blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-icl-dsi/igt@i915_selftest@live_blt.html
- fi-cfl-guc: [PASS][31] -> [INCOMPLETE][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-cfl-guc/igt@i915_selftest@live_blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-cfl-guc/igt@i915_selftest@live_blt.html
- fi-bsw-n3050: [PASS][33] -> [DMESG-FAIL][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-bsw-n3050/igt@i915_selftest@live_blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-bsw-n3050/igt@i915_selftest@live_blt.html
- fi-ivb-3770: NOTRUN -> [DMESG-FAIL][35]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-ivb-3770/igt@i915_selftest@live_blt.html
- fi-icl-y: [PASS][36] -> [INCOMPLETE][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-icl-y/igt@i915_selftest@live_blt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-icl-y/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][38] -> [DMESG-FAIL][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-4770/igt@i915_selftest@live_blt.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_execlists:
- fi-bsw-nick: NOTRUN -> [DMESG-FAIL][40]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-bsw-nick/igt@i915_selftest@live_execlists.html
Known issues
------------
Here are the changes found in Patchwork_16455 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][41] -> [INCOMPLETE][42] ([i915#45])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-skl-6770hq: [PASS][43] -> [INCOMPLETE][44] ([fdo#112429])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-skl-6770hq/igt@i915_selftest@live_blt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-skl-6770hq/igt@i915_selftest@live_blt.html
- fi-hsw-peppy: [PASS][45] -> [DMESG-FAIL][46] ([i915#563])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-peppy/igt@i915_selftest@live_blt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-hsw-peppy/igt@i915_selftest@live_blt.html
- fi-glk-dsi: [PASS][47] -> [INCOMPLETE][48] ([i915#58] / [k.org#198133])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-glk-dsi/igt@i915_selftest@live_blt.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-glk-dsi/igt@i915_selftest@live_blt.html
- fi-bsw-kefka: [PASS][49] -> [DMESG-FAIL][50] ([i915#723])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-bsw-kefka/igt@i915_selftest@live_blt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-bsw-kefka/igt@i915_selftest@live_blt.html
- fi-skl-guc: [PASS][51] -> [INCOMPLETE][52] ([fdo#112429])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-skl-guc/igt@i915_selftest@live_blt.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-skl-guc/igt@i915_selftest@live_blt.html
- fi-cml-u2: [PASS][53] -> [INCOMPLETE][54] ([i915#283])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-cml-u2/igt@i915_selftest@live_blt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-cml-u2/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gem_contexts:
- fi-hsw-peppy: [PASS][55] -> [DMESG-FAIL][56] ([i915#722])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-bsw-nick: [INCOMPLETE][57] ([i915#392]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-bsw-nick/igt@i915_selftest@live_blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-bsw-nick/igt@i915_selftest@live_blt.html
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][59] ([i915#44]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7876/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#112429]: https://bugs.freedesktop.org/show_bug.cgi?id=112429
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#392]: https://gitlab.freedesktop.org/drm/intel/issues/392
[i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
[i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (41 -> 46)
------------------------------
Additional (8): fi-kbl-7560u fi-snb-2520m fi-gdg-551 fi-ivb-3770 fi-skl-6700k2 fi-blb-e6850 fi-skl-6600u fi-snb-2600
Missing (3): fi-byt-squawks fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7876 -> Patchwork_16455
CI-20190529: 20190529
CI_DRM_7876: 6ac39d9964f464065511d439afcf4da065ff96db @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5421: 40946e61f9c47e23fdf1fff8090fadee8a4d7d3b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16455: e67f881c2575d21072e5559eb52d6495066b95f0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e67f881c2575 drm/i915/selftests: Trim blitter block size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16455/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size
2020-02-06 0:33 [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
2020-02-06 3:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2020-02-06 12:52 ` Chris Wilson
2 siblings, 0 replies; 10+ messages in thread
From: Chris Wilson @ 2020-02-06 12:52 UTC (permalink / raw)
To: intel-gfx
Reduce the amount of work we do to verify client blt correctness as
currently our 0.5s subtests takes about 15s on slower devices!
v2: Grow the maximum block size until we run out of time
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
.../i915/gem/selftests/i915_gem_object_blt.c | 54 +++++++++++--------
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 62077fe46715..b98705821b84 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -210,6 +210,7 @@ static int igt_fill_blt_thread(void *arg)
struct intel_context *ce;
unsigned int prio;
IGT_TIMEOUT(end);
+ u64 total;
int err;
ctx = thread->ctx;
@@ -225,10 +226,11 @@ static int igt_fill_blt_thread(void *arg)
ce = i915_gem_context_get_engine(ctx, BCS0);
GEM_BUG_ON(IS_ERR(ce));
+ total = PAGE_SIZE;
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ /* Aim to keep the runtime under reasonable bounds! */
+ const u32 max_phys_size = SZ_64K;
u32 val = prandom_u32_state(prng);
- u64 total = ce->vm->total;
u32 phys_sz;
u32 sz;
u32 *vaddr;
@@ -238,11 +240,9 @@ static int igt_fill_blt_thread(void *arg)
* If we have a tiny shared address space, like for the GGTT
* then we can't be too greedy.
*/
- if (i915_is_ggtt(ce->vm))
- total = div64_u64(total, thread->n_cpus);
-
- sz = min_t(u64, total >> 4, prandom_u32_state(prng));
- phys_sz = sz % (max_block_size + 1);
+ total = min(total, ce->vm->total / 2);
+ sz = i915_prandom_u32_max_state(total, prng) + 1;
+ phys_sz = sz % max_phys_size;
sz = round_up(sz, PAGE_SIZE);
phys_sz = round_up(phys_sz, PAGE_SIZE);
@@ -276,13 +276,16 @@ static int igt_fill_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(obj);
- err = i915_gem_object_set_to_cpu_domain(obj, false);
- i915_gem_object_unlock(obj);
+ err = i915_gem_object_wait(obj, 0, MAX_SCHEDULE_TIMEOUT);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(obj) / sizeof(u32); i += 17) {
+ if (!(obj->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
@@ -293,6 +296,8 @@ static int igt_fill_blt_thread(void *arg)
i915_gem_object_unpin_map(obj);
i915_gem_object_put(obj);
+
+ total <<= 1;
} while (!time_after(jiffies, end));
goto err_flush;
@@ -319,6 +324,7 @@ static int igt_copy_blt_thread(void *arg)
struct intel_context *ce;
unsigned int prio;
IGT_TIMEOUT(end);
+ u64 total;
int err;
ctx = thread->ctx;
@@ -334,20 +340,19 @@ static int igt_copy_blt_thread(void *arg)
ce = i915_gem_context_get_engine(ctx, BCS0);
GEM_BUG_ON(IS_ERR(ce));
+ total = PAGE_SIZE;
do {
- const u32 max_block_size = S16_MAX * PAGE_SIZE;
+ /* Aim to keep the runtime under reasonable bounds! */
+ const u32 max_phys_size = SZ_64K;
u32 val = prandom_u32_state(prng);
- u64 total = ce->vm->total;
u32 phys_sz;
u32 sz;
u32 *vaddr;
u32 i;
- if (i915_is_ggtt(ce->vm))
- total = div64_u64(total, thread->n_cpus);
-
- sz = min_t(u64, total >> 4, prandom_u32_state(prng));
- phys_sz = sz % (max_block_size + 1);
+ total = min(total, ce->vm->total / 2);
+ sz = i915_prandom_u32_max_state(total, prng) + 1;
+ phys_sz = sz % max_phys_size;
sz = round_up(sz, PAGE_SIZE);
phys_sz = round_up(phys_sz, PAGE_SIZE);
@@ -397,13 +402,16 @@ static int igt_copy_blt_thread(void *arg)
if (err)
goto err_unpin;
- i915_gem_object_lock(dst);
- err = i915_gem_object_set_to_cpu_domain(dst, false);
- i915_gem_object_unlock(dst);
+ err = i915_gem_object_wait(dst, 0, MAX_SCHEDULE_TIMEOUT);
if (err)
goto err_unpin;
- for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); ++i) {
+ for (i = 0; i < huge_gem_object_phys_size(dst) / sizeof(u32); i += 17) {
+ if (!(dst->cache_coherent & I915_BO_CACHE_COHERENT_FOR_READ)) {
+ clflush(&vaddr[i]);
+ mb();
+ }
+
if (vaddr[i] != val) {
pr_err("vaddr[%u]=%x, expected=%x\n", i,
vaddr[i], val);
@@ -416,6 +424,8 @@ static int igt_copy_blt_thread(void *arg)
i915_gem_object_put(src);
i915_gem_object_put(dst);
+
+ total <<= 1;
} while (!time_after(jiffies, end));
goto err_flush;
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-06 12:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 0:33 [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
2020-02-06 3:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-06 3:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-06 9:20 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-02-06 10:38 ` [Intel-gfx] [PATCH v2] " Chris Wilson
2020-02-06 9:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev2) Patchwork
2020-02-06 10:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-06 11:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Trim blitter block size (rev3) Patchwork
2020-02-06 12:33 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-02-06 12:52 ` [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.