[igt-dev] [PATCH i-g-t v2 1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt

[igt-dev] [PATCH i-g-t v2 1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt

[Ramalingam C]

As tiling is not used we use the device coherent mapping instead of
mmap_gtt.

v2:
  instead of skipping device coherent mapping is used. [Ashutosh]

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
 tools/intel_dp_compliance.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c
index 5cc3d37a71d6..2d42cb1a7b6f 100644
--- a/tools/intel_dp_compliance.c
+++ b/tools/intel_dp_compliance.c
@@ -451,9 +451,9 @@ static int setup_framebuffers(struct connector *dp_conn)
 	igt_assert(dp_conn->fb);
 
 	/* Map the mapping of GEM object into the virtual address space */
-	dp_conn->pixmap = gem_mmap__gtt(drm_fd,
+	dp_conn->pixmap = gem_mmap__device_coherent(drm_fd,
 					dp_conn->fb_video_pattern.gem_handle,
-					dp_conn->fb_video_pattern.size,
+					0, dp_conn->fb_video_pattern.size,
 					PROT_READ | PROT_WRITE);
 	if (dp_conn->pixmap == NULL)
 		return -1;
@@ -481,9 +481,9 @@ static int setup_failsafe_framebuffer(struct connector *dp_conn)
 	igt_assert(dp_conn->failsafe_fb);
 
 	/* Map the mapping of GEM object into the virtual address space */
-	dp_conn->failsafe_pixmap = gem_mmap__gtt(drm_fd,
+	dp_conn->failsafe_pixmap = gem_mmap__device_coherent(drm_fd,
 						 dp_conn->fb_failsafe_pattern.gem_handle,
-						 dp_conn->fb_failsafe_pattern.size,
+						 0, dp_conn->fb_failsafe_pattern.size,
 						 PROT_READ | PROT_WRITE);
 	if (dp_conn->failsafe_pixmap == NULL)
 		return -1;
@@ -518,9 +518,9 @@ static int setup_video_pattern_framebuffer(struct connector *dp_conn)
 	igt_assert(dp_conn->test_pattern.fb);
 
 	/* Map the mapping of GEM object into the virtual address space */
-	dp_conn->test_pattern.pixmap = gem_mmap__gtt(drm_fd,
+	dp_conn->test_pattern.pixmap = gem_mmap__device_coherent(drm_fd,
 						     dp_conn->test_pattern.fb_pattern.gem_handle,
-						     dp_conn->test_pattern.fb_pattern.size,
+						     0, dp_conn->test_pattern.fb_pattern.size,
 						     PROT_READ | PROT_WRITE);
 	if (dp_conn->test_pattern.pixmap == NULL)
 		return -1;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

[Ramalingam C]

Since on new discrete GPUs we dont have the mappable aperture, if that
is acceptable for the test purpose, we should use GEM_MMAP_OFFSET.
Hence using gem_mmap_device_coherent() which wraps the mmap options in
the order of gem_mmap_offset / gem_mmap / mmap_gtt

Incase of fencing/gtt related tests, we mandate the existance of the
mmap_gtt.

v2:
  3 tests are skipped based on mappable aperture and tiling support

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
 tests/i915/i915_pm_rpm.c | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 3d7343240802..5ad2d833d53b 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -1535,7 +1535,7 @@ static void fill_igt_fb(struct igt_fb *fb, uint32_t color)
 	int i;
 	uint32_t *ptr;
 
-	ptr = gem_mmap__gtt(drm_fd, fb->gem_handle, fb->size, PROT_WRITE);
+	ptr = gem_mmap__device_coherent(drm_fd, fb->gem_handle, 0, fb->size, PROT_WRITE);
 	for (i = 0; i < fb->size/sizeof(uint32_t); i++)
 		ptr[i] = color;
 	igt_assert(munmap(ptr, fb->size) == 0);
@@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 	/* GEM */
 	igt_subtest("gem-mmap-cpu")
 		gem_mmap_subtest(false);
-	igt_subtest("gem-mmap-gtt")
+	igt_subtest("gem-mmap-gtt") {
+		gem_require_mappable_ggtt(drm_fd);
 		gem_mmap_subtest(true);
+	}
 	igt_subtest("gem-pread")
 		gem_pread_subtest();
 	igt_subtest("gem-execbuf")
 		gem_execbuf_subtest();
 	igt_subtest("gem-idle")
 		gem_idle_subtest();
-	igt_subtest("gem-evict-pwrite")
+	igt_subtest("gem-evict-pwrite") {
+		gem_require_mappable_ggtt(drm_fd);
 		gem_evict_pwrite_subtest();
+	}
 
 	/* Planes and cursors */
 	igt_subtest("cursor")
@@ -2058,10 +2062,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		dpms_mode_unset_subtest(SCREEN_TYPE_LPSP);
 	igt_subtest("dpms-mode-unset-non-lpsp")
 		dpms_mode_unset_subtest(SCREEN_TYPE_NON_LPSP);
-	igt_subtest("fences")
+	igt_subtest("fences") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(false);
-	igt_subtest("fences-dpms")
+	}
+	igt_subtest("fences-dpms") {
+		gem_require_mappable_ggtt(drm_fd);
 		fences_subtest(true);
+	}
 
 	/* Modeset stress */
 	igt_subtest("modeset-lpsp-stress")
@@ -2102,10 +2110,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		gem_execbuf_stress_subtest(rounds, WAIT_STATUS | WAIT_EXTRA);
 
 	/* power-wake reference tests */
-	igt_subtest("pm-tiling")
+	igt_subtest("pm-tiling") {
+		gem_require_mappable_ggtt(drm_fd);
 		pm_test_tiling();
-	igt_subtest("pm-caching")
+	}
+	igt_subtest("pm-caching") {
+		gem_require_mappable_ggtt(drm_fd);
 		pm_test_caching();
+	}
 
 	igt_fixture
 		teardown_environment();
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

[Chris Wilson]

Quoting Ramalingam C (2020-02-07 13:45:27)
> @@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>         /* GEM */
>         igt_subtest("gem-mmap-cpu")
>                 gem_mmap_subtest(false);
> -       igt_subtest("gem-mmap-gtt")
> +       igt_subtest("gem-mmap-gtt") {
> +               gem_require_mappable_ggtt(drm_fd);
>                 gem_mmap_subtest(true);

Would not the lmem bar also be susceptible to power management
artefacts?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

[Ramalingam C]

On 2020-02-07 at 14:44:36 +0000, Chris Wilson wrote:
> Quoting Ramalingam C (2020-02-07 13:45:27)
> > @@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> >         /* GEM */
> >         igt_subtest("gem-mmap-cpu")
> >                 gem_mmap_subtest(false);
> > -       igt_subtest("gem-mmap-gtt")
> > +       igt_subtest("gem-mmap-gtt") {
> > +               gem_require_mappable_ggtt(drm_fd);
> >                 gem_mmap_subtest(true);
> 
> Would not the lmem bar also be susceptible to power management
> artefacts?
Chris,

I think "gem-mmap-cpu" would do the same test with lmem, but that
can be done when we have the uAPI for allocating from lmem, through
another subtest say "gem-mmap-cpu-lmem"

But at present "gem-mmap-gtt" will fail at platforms where mmap_gtt is
not present. So to avoid that, could you please approve this change?

-Ram
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

[Dixit, Ashutosh]

On Sun, 09 Feb 2020 21:47:55 -0800, Ramalingam C wrote:
>
> On 2020-02-07 at 14:44:36 +0000, Chris Wilson wrote:
> > Quoting Ramalingam C (2020-02-07 13:45:27)
> > > @@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> > >         /* GEM */
> > >         igt_subtest("gem-mmap-cpu")
> > >                 gem_mmap_subtest(false);
> > > -       igt_subtest("gem-mmap-gtt")
> > > +       igt_subtest("gem-mmap-gtt") {
> > > +               gem_require_mappable_ggtt(drm_fd);
> > >                 gem_mmap_subtest(true);
> >
> > Would not the lmem bar also be susceptible to power management
> > artefacts?
> Chris,
>
> I think "gem-mmap-cpu" would do the same test with lmem, but that
> can be done when we have the uAPI for allocating from lmem, through
> another subtest say "gem-mmap-cpu-lmem"
>
> But at present "gem-mmap-gtt" will fail at platforms where mmap_gtt is
> not present. So to avoid that, could you please approve this change?

My reading was Chris is referring to using for_each_mmap_offset_type(), see
973bbbff.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests

[Ramalingam C]

Tests for gem_mmap_gtt/cpu are replaced with dynamic subtests with
the array of mmap_types passed to gem_mmap_offset.

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/i915_pm_rpm.c | 34 ++++++++++++++--------------------
 1 file changed, 14 insertions(+), 20 deletions(-)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 3d7343240802..0c2821122956 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -1007,7 +1007,7 @@ static void debugfs_forcewake_user_subtest(void)
 	igt_assert(wait_for_suspended());
 }
 
-static void gem_mmap_subtest(bool gtt_mmap)
+static void gem_mmap_args(const struct mmap_offset *t)
 {
 	int i;
 	uint32_t handle;
@@ -1019,14 +1019,9 @@ static void gem_mmap_subtest(bool gtt_mmap)
 
 	handle = gem_create(drm_fd, buf_size);
 
-	if (gtt_mmap) {
-		gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
-					PROT_READ | PROT_WRITE);
-	}
-	else {
-		gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
-	}
-
+	gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
+				    PROT_READ | PROT_WRITE, t->type);
+	igt_require(gem_buf);
 
 	for (i = 0; i < buf_size; i++)
 		gem_buf[i] = i & 0xFF;
@@ -1056,13 +1051,9 @@ static void gem_mmap_subtest(bool gtt_mmap)
 	 * suspended. */
 	disable_all_screens_and_wait(&ms_data);
 
-	if (gtt_mmap) {
-		gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
-					PROT_READ | PROT_WRITE);
-	}
-	else {
-		gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
-	}
+	gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
+				    PROT_READ | PROT_WRITE, t->type);
+	igt_require(gem_buf);
 
 	igt_assert(wait_for_suspended());
 
@@ -2014,10 +2005,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		modeset_subtest(SCREEN_TYPE_NON_LPSP, 1, WAIT_STATUS | USE_DPMS);
 
 	/* GEM */
-	igt_subtest("gem-mmap-cpu")
-		gem_mmap_subtest(false);
-	igt_subtest("gem-mmap-gtt")
-		gem_mmap_subtest(true);
+	igt_subtest_with_dynamic("gem-mmap-type") {
+		for_each_mmap_offset_type(t) {
+			igt_dynamic_f("%s", t->name)
+				gem_mmap_args(t);
+		}
+	}
+
 	igt_subtest("gem-pread")
 		gem_pread_subtest();
 	igt_subtest("gem-execbuf")
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests

[Ramalingam C]

On 2020-02-17 at 15:10:45 +0530, Ramalingam C wrote:
> Tests for gem_mmap_gtt/cpu are replaced with dynamic subtests with
> the array of mmap_types passed to gem_mmap_offset.
> 
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/i915/i915_pm_rpm.c | 34 ++++++++++++++--------------------
>  1 file changed, 14 insertions(+), 20 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 3d7343240802..0c2821122956 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -1007,7 +1007,7 @@ static void debugfs_forcewake_user_subtest(void)
>  	igt_assert(wait_for_suspended());
>  }
>  
> -static void gem_mmap_subtest(bool gtt_mmap)
> +static void gem_mmap_args(const struct mmap_offset *t)
>  {
>  	int i;
>  	uint32_t handle;
> @@ -1019,14 +1019,9 @@ static void gem_mmap_subtest(bool gtt_mmap)
>  
>  	handle = gem_create(drm_fd, buf_size);
>  
> -	if (gtt_mmap) {
> -		gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> -					PROT_READ | PROT_WRITE);
> -	}
> -	else {
> -		gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> -	}
> -
> +	gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> +				    PROT_READ | PROT_WRITE, t->type);
> +	igt_require(gem_buf);
>  
>  	for (i = 0; i < buf_size; i++)
>  		gem_buf[i] = i & 0xFF;
> @@ -1056,13 +1051,9 @@ static void gem_mmap_subtest(bool gtt_mmap)
>  	 * suspended. */
>  	disable_all_screens_and_wait(&ms_data);
>  
> -	if (gtt_mmap) {
> -		gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> -					PROT_READ | PROT_WRITE);
> -	}
> -	else {
> -		gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> -	}
> +	gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> +				    PROT_READ | PROT_WRITE, t->type);
> +	igt_require(gem_buf);
>  
>  	igt_assert(wait_for_suspended());
>  
> @@ -2014,10 +2005,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>  		modeset_subtest(SCREEN_TYPE_NON_LPSP, 1, WAIT_STATUS | USE_DPMS);
>  
>  	/* GEM */
> -	igt_subtest("gem-mmap-cpu")
> -		gem_mmap_subtest(false);
> -	igt_subtest("gem-mmap-gtt")
> -		gem_mmap_subtest(true);
> +	igt_subtest_with_dynamic("gem-mmap-type") {
> +		for_each_mmap_offset_type(t) {
> +			igt_dynamic_f("%s", t->name)
> +				gem_mmap_args(t);
> +		}
> +	}
Chris,

This is what you suggested I guess. But what is the mmap_offset is not
supported? shouldn't we have the legacy tests in such scenario?

Lmem specific tests are not added yet. We will add it in separate
patches.

-Ram
> +
>  	igt_subtest("gem-pread")
>  		gem_pread_subtest();
>  	igt_subtest("gem-execbuf")
> -- 
> 2.20.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests

[Chris Wilson]

Quoting Ramalingam C (2020-02-17 09:44:42)
> On 2020-02-17 at 15:10:45 +0530, Ramalingam C wrote:
> > Tests for gem_mmap_gtt/cpu are replaced with dynamic subtests with
> > the array of mmap_types passed to gem_mmap_offset.
> > 
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > cc: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/i915/i915_pm_rpm.c | 34 ++++++++++++++--------------------
> >  1 file changed, 14 insertions(+), 20 deletions(-)
> > 
> > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> > index 3d7343240802..0c2821122956 100644
> > --- a/tests/i915/i915_pm_rpm.c
> > +++ b/tests/i915/i915_pm_rpm.c
> > @@ -1007,7 +1007,7 @@ static void debugfs_forcewake_user_subtest(void)
> >       igt_assert(wait_for_suspended());
> >  }
> >  
> > -static void gem_mmap_subtest(bool gtt_mmap)
> > +static void gem_mmap_args(const struct mmap_offset *t)
> >  {
> >       int i;
> >       uint32_t handle;
> > @@ -1019,14 +1019,9 @@ static void gem_mmap_subtest(bool gtt_mmap)
> >  
> >       handle = gem_create(drm_fd, buf_size);
> >  
> > -     if (gtt_mmap) {
> > -             gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> > -                                     PROT_READ | PROT_WRITE);
> > -     }
> > -     else {
> > -             gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> > -     }
> > -
> > +     gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> > +                                 PROT_READ | PROT_WRITE, t->type);
> > +     igt_require(gem_buf);
> >  
> >       for (i = 0; i < buf_size; i++)
> >               gem_buf[i] = i & 0xFF;
> > @@ -1056,13 +1051,9 @@ static void gem_mmap_subtest(bool gtt_mmap)
> >        * suspended. */
> >       disable_all_screens_and_wait(&ms_data);
> >  
> > -     if (gtt_mmap) {
> > -             gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> > -                                     PROT_READ | PROT_WRITE);
> > -     }
> > -     else {
> > -             gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> > -     }
> > +     gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> > +                                 PROT_READ | PROT_WRITE, t->type);
> > +     igt_require(gem_buf);
> >  
> >       igt_assert(wait_for_suspended());
> >  
> > @@ -2014,10 +2005,13 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
> >               modeset_subtest(SCREEN_TYPE_NON_LPSP, 1, WAIT_STATUS | USE_DPMS);
> >  
> >       /* GEM */
> > -     igt_subtest("gem-mmap-cpu")
> > -             gem_mmap_subtest(false);
> > -     igt_subtest("gem-mmap-gtt")
> > -             gem_mmap_subtest(true);
> > +     igt_subtest_with_dynamic("gem-mmap-type") {
> > +             for_each_mmap_offset_type(t) {
> > +                     igt_dynamic_f("%s", t->name)
> > +                             gem_mmap_args(t);
> > +             }
> > +     }
> Chris,
> 
> This is what you suggested I guess. But what is the mmap_offset is not
> supported? shouldn't we have the legacy tests in such scenario?

mmap-offset is a pure extension of mmap-gtt.

There's no point testing the plain mmap_ioctl in this test as that does
not use i915 for fault handling; it is independent of our rpm.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests

[C, Ramalingam]

> -----Original Message-----
> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Tuesday, February 18, 2020 1:16 PM
> To: C, Ramalingam <ramalingam.c@intel.com>; igt-dev <igt-
> dev@lists.freedesktop.org>
> Subject: Re: [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic
> subtests
> 
> Quoting Ramalingam C (2020-02-17 09:44:42)
> > On 2020-02-17 at 15:10:45 +0530, Ramalingam C wrote:
> > > Tests for gem_mmap_gtt/cpu are replaced with dynamic subtests with
> > > the array of mmap_types passed to gem_mmap_offset.
> > >
> > > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > > cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > >  tests/i915/i915_pm_rpm.c | 34 ++++++++++++++--------------------
> > >  1 file changed, 14 insertions(+), 20 deletions(-)
> > >
> > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> > > index 3d7343240802..0c2821122956 100644
> > > --- a/tests/i915/i915_pm_rpm.c
> > > +++ b/tests/i915/i915_pm_rpm.c
> > > @@ -1007,7 +1007,7 @@ static void
> debugfs_forcewake_user_subtest(void)
> > >       igt_assert(wait_for_suspended());  }
> > >
> > > -static void gem_mmap_subtest(bool gtt_mmap)
> > > +static void gem_mmap_args(const struct mmap_offset *t)
> > >  {
> > >       int i;
> > >       uint32_t handle;
> > > @@ -1019,14 +1019,9 @@ static void gem_mmap_subtest(bool
> gtt_mmap)
> > >
> > >       handle = gem_create(drm_fd, buf_size);
> > >
> > > -     if (gtt_mmap) {
> > > -             gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> > > -                                     PROT_READ | PROT_WRITE);
> > > -     }
> > > -     else {
> > > -             gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> > > -     }
> > > -
> > > +     gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> > > +                                 PROT_READ | PROT_WRITE, t->type);
> > > +     igt_require(gem_buf);
> > >
> > >       for (i = 0; i < buf_size; i++)
> > >               gem_buf[i] = i & 0xFF; @@ -1056,13 +1051,9 @@ static
> > > void gem_mmap_subtest(bool gtt_mmap)
> > >        * suspended. */
> > >       disable_all_screens_and_wait(&ms_data);
> > >
> > > -     if (gtt_mmap) {
> > > -             gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> > > -                                     PROT_READ | PROT_WRITE);
> > > -     }
> > > -     else {
> > > -             gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> > > -     }
> > > +     gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> > > +                                 PROT_READ | PROT_WRITE, t->type);
> > > +     igt_require(gem_buf);
> > >
> > >       igt_assert(wait_for_suspended());
> > >
> > > @@ -2014,10 +2005,13 @@ igt_main_args("", long_options, help_str,
> opt_handler, NULL)
> > >               modeset_subtest(SCREEN_TYPE_NON_LPSP, 1, WAIT_STATUS |
> > > USE_DPMS);
> > >
> > >       /* GEM */
> > > -     igt_subtest("gem-mmap-cpu")
> > > -             gem_mmap_subtest(false);
> > > -     igt_subtest("gem-mmap-gtt")
> > > -             gem_mmap_subtest(true);
> > > +     igt_subtest_with_dynamic("gem-mmap-type") {
> > > +             for_each_mmap_offset_type(t) {
> > > +                     igt_dynamic_f("%s", t->name)
> > > +                             gem_mmap_args(t);
> > > +             }
> > > +     }
> > Chris,
> >
> > This is what you suggested I guess. But what is the mmap_offset is not
> > supported? shouldn't we have the legacy tests in such scenario?
> 
> mmap-offset is a pure extension of mmap-gtt.
> 
> There's no point testing the plain mmap_ioctl in this test as that does not
> use i915 for fault handling; it is independent of our rpm.

Chris,

So I interpret this as no need for mmap_gtt in case of mmap_offset missing.
In that case do you think this patch is good to merge.?

As we discussed I will include the lmem coverage as a separate patch.

-Ram.

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests

[Chris Wilson]

Quoting C, Ramalingam (2020-02-18 09:07:39)
> > -----Original Message-----
> > From: Chris Wilson <chris@chris-wilson.co.uk>
> > Sent: Tuesday, February 18, 2020 1:16 PM
> > To: C, Ramalingam <ramalingam.c@intel.com>; igt-dev <igt-
> > dev@lists.freedesktop.org>
> > Subject: Re: [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic
> > subtests
> > 
> > Quoting Ramalingam C (2020-02-17 09:44:42)
> > > On 2020-02-17 at 15:10:45 +0530, Ramalingam C wrote:
> > > > Tests for gem_mmap_gtt/cpu are replaced with dynamic subtests with
> > > > the array of mmap_types passed to gem_mmap_offset.
> > > >
> > > > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > > > cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > ---
> > > >  tests/i915/i915_pm_rpm.c | 34 ++++++++++++++--------------------
> > > >  1 file changed, 14 insertions(+), 20 deletions(-)
> > > >
> > > > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> > > > index 3d7343240802..0c2821122956 100644
> > > > --- a/tests/i915/i915_pm_rpm.c
> > > > +++ b/tests/i915/i915_pm_rpm.c
> > > > @@ -1007,7 +1007,7 @@ static void
> > debugfs_forcewake_user_subtest(void)
> > > >       igt_assert(wait_for_suspended());  }
> > > >
> > > > -static void gem_mmap_subtest(bool gtt_mmap)
> > > > +static void gem_mmap_args(const struct mmap_offset *t)
> > > >  {
> > > >       int i;
> > > >       uint32_t handle;
> > > > @@ -1019,14 +1019,9 @@ static void gem_mmap_subtest(bool
> > gtt_mmap)
> > > >
> > > >       handle = gem_create(drm_fd, buf_size);
> > > >
> > > > -     if (gtt_mmap) {
> > > > -             gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> > > > -                                     PROT_READ | PROT_WRITE);
> > > > -     }
> > > > -     else {
> > > > -             gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> > > > -     }
> > > > -
> > > > +     gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> > > > +                                 PROT_READ | PROT_WRITE, t->type);
> > > > +     igt_require(gem_buf);
> > > >
> > > >       for (i = 0; i < buf_size; i++)
> > > >               gem_buf[i] = i & 0xFF; @@ -1056,13 +1051,9 @@ static
> > > > void gem_mmap_subtest(bool gtt_mmap)
> > > >        * suspended. */
> > > >       disable_all_screens_and_wait(&ms_data);
> > > >
> > > > -     if (gtt_mmap) {
> > > > -             gem_buf = gem_mmap__gtt(drm_fd, handle, buf_size,
> > > > -                                     PROT_READ | PROT_WRITE);
> > > > -     }
> > > > -     else {
> > > > -             gem_buf = gem_mmap__cpu(drm_fd, handle, 0, buf_size, 0);
> > > > -     }
> > > > +     gem_buf = __gem_mmap_offset(drm_fd, handle, 0, buf_size,
> > > > +                                 PROT_READ | PROT_WRITE, t->type);
> > > > +     igt_require(gem_buf);
> > > >
> > > >       igt_assert(wait_for_suspended());
> > > >
> > > > @@ -2014,10 +2005,13 @@ igt_main_args("", long_options, help_str,
> > opt_handler, NULL)
> > > >               modeset_subtest(SCREEN_TYPE_NON_LPSP, 1, WAIT_STATUS |
> > > > USE_DPMS);
> > > >
> > > >       /* GEM */
> > > > -     igt_subtest("gem-mmap-cpu")
> > > > -             gem_mmap_subtest(false);
> > > > -     igt_subtest("gem-mmap-gtt")
> > > > -             gem_mmap_subtest(true);
> > > > +     igt_subtest_with_dynamic("gem-mmap-type") {
> > > > +             for_each_mmap_offset_type(t) {
> > > > +                     igt_dynamic_f("%s", t->name)
> > > > +                             gem_mmap_args(t);
> > > > +             }
> > > > +     }
> > > Chris,
> > >
> > > This is what you suggested I guess. But what is the mmap_offset is not
> > > supported? shouldn't we have the legacy tests in such scenario?
> > 
> > mmap-offset is a pure extension of mmap-gtt.
> > 
> > There's no point testing the plain mmap_ioctl in this test as that does not
> > use i915 for fault handling; it is independent of our rpm.
> 
> Chris,
> 
> So I interpret this as no need for mmap_gtt in case of mmap_offset missing.
> In that case do you think this patch is good to merge.?

mmap-offset *is* mmap-gtt, just with a few extra modes. TYPE_GTT is
identical to the original call to mmap_gtt_ioctl.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: mmap type based dynamic subtests

[Chris Wilson]

Quoting Ramalingam C (2020-02-17 09:40:45)
> Tests for gem_mmap_gtt/cpu are replaced with dynamic subtests with
> the array of mmap_types passed to gem_mmap_offset.
> 
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/i915_pm_rpm: use device coherent mapping instead of mmap_gtt

[Dixit, Ashutosh]

On Fri, 07 Feb 2020 05:45:27 -0800, Ramalingam C wrote:
>
> Since on new discrete GPUs we dont have the mappable aperture, if that
> is acceptable for the test purpose, we should use GEM_MMAP_OFFSET.
> Hence using gem_mmap_device_coherent() which wraps the mmap options in
> the order of gem_mmap_offset / gem_mmap / mmap_gtt
>
> Incase of fencing/gtt related tests, we mandate the existance of the
> mmap_gtt.
>
> v2:
>   3 tests are skipped based on mappable aperture and tiling support
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
>  tests/i915/i915_pm_rpm.c | 26 +++++++++++++++++++-------
>  1 file changed, 19 insertions(+), 7 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 3d7343240802..5ad2d833d53b 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -1535,7 +1535,7 @@ static void fill_igt_fb(struct igt_fb *fb, uint32_t color)
>	int i;
>	uint32_t *ptr;
>
> -	ptr = gem_mmap__gtt(drm_fd, fb->gem_handle, fb->size, PROT_WRITE);
> +	ptr = gem_mmap__device_coherent(drm_fd, fb->gem_handle, 0, fb->size, PROT_WRITE);

My earlier comment on this is still valid: even though fill_igt_fb() is
called with tiling set, I think it is still ok > to do this since all we
are doing is filling a solid color for which tiling is immaterial.

cursor_subtest: fix set_tiling() call.

>	for (i = 0; i < fb->size/sizeof(uint32_t); i++)
>		ptr[i] = color;
>	igt_assert(munmap(ptr, fb->size) == 0);
> @@ -2016,16 +2016,20 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>	/* GEM */
>	igt_subtest("gem-mmap-cpu")
>		gem_mmap_subtest(false);
> -	igt_subtest("gem-mmap-gtt")
> +	igt_subtest("gem-mmap-gtt") {
> +		gem_require_mappable_ggtt(drm_fd);

OK.

>		gem_mmap_subtest(true);
> +	}
>	igt_subtest("gem-pread")
>		gem_pread_subtest();
>	igt_subtest("gem-execbuf")
>		gem_execbuf_subtest();
>	igt_subtest("gem-idle")
>		gem_idle_subtest();
> -	igt_subtest("gem-evict-pwrite")
> +	igt_subtest("gem-evict-pwrite") {
> +		gem_require_mappable_ggtt(drm_fd);

Sorry I think I changed my mind on this: for this one it is possible to set
num_trash_bos to some constant value when we don't have aperture and use
device_coherent. I am not completely sure if there's value in that but
maybe let's just go ahead and do it.

>		gem_evict_pwrite_subtest();
> +	}
>
>	/* Planes and cursors */
>	igt_subtest("cursor")
> @@ -2058,10 +2062,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>		dpms_mode_unset_subtest(SCREEN_TYPE_LPSP);
>	igt_subtest("dpms-mode-unset-non-lpsp")
>		dpms_mode_unset_subtest(SCREEN_TYPE_NON_LPSP);
> -	igt_subtest("fences")
> +	igt_subtest("fences") {
> +		gem_require_mappable_ggtt(drm_fd);
>		fences_subtest(false);

Now I am thinking if fences_subtest() should be skipped or we just fix
tiling and mmap and retain it?

> -	igt_subtest("fences-dpms")
> +	}
> +	igt_subtest("fences-dpms") {
> +		gem_require_mappable_ggtt(drm_fd);
>		fences_subtest(true);

Ditto.

> +	}
>
>	/* Modeset stress */
>	igt_subtest("modeset-lpsp-stress")
> @@ -2102,10 +2110,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>		gem_execbuf_stress_subtest(rounds, WAIT_STATUS | WAIT_EXTRA);
>
>	/* power-wake reference tests */
> -	igt_subtest("pm-tiling")
> +	igt_subtest("pm-tiling") {
> +		gem_require_mappable_ggtt(drm_fd);
>		pm_test_tiling();

Maybe fix and retain?

> -	igt_subtest("pm-caching")
> +	}
> +	igt_subtest("pm-caching") {
> +		gem_require_mappable_ggtt(drm_fd);

Again maybe fix and retain?
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt
URL   : https://patchwork.freedesktop.org/series/73148/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7886 -> IGTPW_4113
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/index.html

Known issues
------------

  Here are the changes found in IGTPW_4113 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_close_race@basic-threads:
    - fi-byt-j1900:       [PASS][1] -> [INCOMPLETE][2] ([i915#45])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-byt-j1900/igt@gem_close_race@basic-threads.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-byt-j1900/igt@gem_close_race@basic-threads.html

  * igt@i915_selftest@live_blt:
    - fi-ivb-3770:        [PASS][3] -> [DMESG-FAIL][4] ([i915#770])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-ivb-3770/igt@i915_selftest@live_blt.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-ivb-3770/igt@i915_selftest@live_blt.html
    - fi-bsw-nick:        [PASS][5] -> [INCOMPLETE][6] ([i915#392])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-bsw-nick/igt@i915_selftest@live_blt.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-bsw-nick/igt@i915_selftest@live_blt.html

  * igt@kms_chamelium@hdmi-crc-fast:
    - fi-icl-u2:          [PASS][7] -> [FAIL][8] ([fdo#109635] / [i915#217])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-icl-u2/igt@kms_chamelium@hdmi-crc-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_parallel@contexts:
    - fi-byt-n2820:       [FAIL][9] ([i915#694]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-byt-n2820/igt@gem_exec_parallel@contexts.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-byt-n2820/igt@gem_exec_parallel@contexts.html

  * igt@i915_selftest@live_execlists:
    - fi-icl-y:           [DMESG-FAIL][11] ([fdo#108569]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-icl-y/igt@i915_selftest@live_execlists.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-icl-y/igt@i915_selftest@live_execlists.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-kbl-x1275:       [DMESG-FAIL][13] ([i915#943]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-kbl-x1275/igt@i915_selftest@live_gem_contexts.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-kbl-x1275/igt@i915_selftest@live_gem_contexts.html
    - fi-byt-n2820:       [DMESG-FAIL][15] ([i915#1052]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html

  * igt@i915_selftest@live_gt_pm:
    - {fi-tgl-dsi}:       [DMESG-FAIL][17] -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-tgl-dsi/igt@i915_selftest@live_gt_pm.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-tgl-dsi/igt@i915_selftest@live_gt_pm.html

  * igt@i915_selftest@live_gtt:
    - fi-bxt-dsi:         [TIMEOUT][19] ([fdo#112271]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-bxt-dsi/igt@i915_selftest@live_gtt.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-bxt-dsi/igt@i915_selftest@live_gtt.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-icl-u2:          [DMESG-WARN][21] ([IGT#4] / [i915#263]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html

  
#### Warnings ####

  * igt@gem_exec_parallel@fds:
    - fi-byt-n2820:       [FAIL][23] ([i915#694]) -> [TIMEOUT][24] ([fdo#112271])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-byt-n2820/igt@gem_exec_parallel@fds.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-byt-n2820/igt@gem_exec_parallel@fds.html

  * igt@i915_selftest@live_blt:
    - fi-hsw-4770:        [DMESG-FAIL][25] ([i915#553] / [i915#725]) -> [DMESG-FAIL][26] ([i915#725])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-hsw-4770/igt@i915_selftest@live_blt.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][27] ([fdo#111096] / [i915#323]) -> [FAIL][28] ([fdo#111407])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#4]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/4
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109635]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1052]: https://gitlab.freedesktop.org/drm/intel/issues/1052
  [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
  [i915#263]: https://gitlab.freedesktop.org/drm/intel/issues/263
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#392]: https://gitlab.freedesktop.org/drm/intel/issues/392
  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
  [i915#943]: https://gitlab.freedesktop.org/drm/intel/issues/943


Participating hosts (54 -> 48)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5425 -> IGTPW_4113

  CI-20190529: 20190529
  CI_DRM_7886: c76da740823aa950e340a8e53758511680da79ca @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4113: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/index.html
  IGT_5425: ad4542ef1adbaa1227bc9ba9e24bb0e0f6dd408d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2 1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt

[Dixit, Ashutosh]

On Fri, 07 Feb 2020 05:45:26 -0800, Ramalingam C wrote:
>
> As tiling is not used we use the device coherent mapping instead of
> mmap_gtt.
>
> v2:
>   instead of skipping device coherent mapping is used. [Ashutosh]
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> ---
>  tools/intel_dp_compliance.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/intel_dp_compliance.c b/tools/intel_dp_compliance.c
> index 5cc3d37a71d6..2d42cb1a7b6f 100644
> --- a/tools/intel_dp_compliance.c
> +++ b/tools/intel_dp_compliance.c
> @@ -451,9 +451,9 @@ static int setup_framebuffers(struct connector *dp_conn)
>	igt_assert(dp_conn->fb);
>
>	/* Map the mapping of GEM object into the virtual address space */
> -	dp_conn->pixmap = gem_mmap__gtt(drm_fd,
> +	dp_conn->pixmap = gem_mmap__device_coherent(drm_fd,
>					dp_conn->fb_video_pattern.gem_handle,
> -					dp_conn->fb_video_pattern.size,
> +					0, dp_conn->fb_video_pattern.size,
>					PROT_READ | PROT_WRITE);
>	if (dp_conn->pixmap == NULL)
>		return -1;
> @@ -481,9 +481,9 @@ static int setup_failsafe_framebuffer(struct connector *dp_conn)
>	igt_assert(dp_conn->failsafe_fb);
>
>	/* Map the mapping of GEM object into the virtual address space */
> -	dp_conn->failsafe_pixmap = gem_mmap__gtt(drm_fd,
> +	dp_conn->failsafe_pixmap = gem_mmap__device_coherent(drm_fd,
>						 dp_conn->fb_failsafe_pattern.gem_handle,
> -						 dp_conn->fb_failsafe_pattern.size,
> +						 0, dp_conn->fb_failsafe_pattern.size,
>						 PROT_READ | PROT_WRITE);
>	if (dp_conn->failsafe_pixmap == NULL)
>		return -1;
> @@ -518,9 +518,9 @@ static int setup_video_pattern_framebuffer(struct connector *dp_conn)
>	igt_assert(dp_conn->test_pattern.fb);
>
>	/* Map the mapping of GEM object into the virtual address space */
> -	dp_conn->test_pattern.pixmap = gem_mmap__gtt(drm_fd,
> +	dp_conn->test_pattern.pixmap = gem_mmap__device_coherent(drm_fd,
>						     dp_conn->test_pattern.fb_pattern.gem_handle,
> -						     dp_conn->test_pattern.fb_pattern.size,
> +						     0, dp_conn->test_pattern.fb_pattern.size,
>						     PROT_READ | PROT_WRITE);
>	if (dp_conn->test_pattern.pixmap == NULL)
>		return -1;
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt
URL   : https://patchwork.freedesktop.org/series/73148/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7886_full -> IGTPW_4113_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4113_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4113_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4113_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_mmap_gtt@basic-small-copy-odd:
    - shard-kbl:          [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl4/igt@gem_mmap_gtt@basic-small-copy-odd.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-kbl6/igt@gem_mmap_gtt@basic-small-copy-odd.html

  
Known issues
------------

  Here are the changes found in IGTPW_4113_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb2/igt@gem_busy@busy-vcs1.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb6/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-kbl:          [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +5 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#110854])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb1/igt@gem_exec_balancer@smoke.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb3/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_schedule@promotion-bsd:
    - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#112146]) +4 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb8/igt@gem_exec_schedule@promotion-bsd.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb2/igt@gem_exec_schedule@promotion-bsd.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-snb:          [PASS][11] -> [DMESG-WARN][12] ([fdo#111870] / [i915#478])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-snb4/igt@gem_userptr_blits@dmabuf-unsync.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-snb6/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +2 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-apl6/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_selftest@live_blt:
    - shard-hsw:          [PASS][15] -> [DMESG-FAIL][16] ([i915#725])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-hsw5/igt@i915_selftest@live_blt.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-hsw8/igt@i915_selftest@live_blt.html

  * igt@kms_color@pipe-a-ctm-negative:
    - shard-tglb:         [PASS][17] -> [FAIL][18] ([i915#1149])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb7/igt@kms_color@pipe-a-ctm-negative.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb1/igt@kms_color@pipe-a-ctm-negative.html

  * igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
    - shard-tglb:         [PASS][19] -> [FAIL][20] ([i915#1173])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html

  * igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
    - shard-tglb:         [PASS][21] -> [FAIL][22] ([i915#559]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb2/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb7/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html

  * igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
    - shard-tglb:         [PASS][23] -> [DMESG-FAIL][24] ([i915#402])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb7/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb3/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move:
    - shard-tglb:         [PASS][25] -> [SKIP][26] ([i915#668])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-move.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-glk:          [PASS][27] -> [FAIL][28] ([i915#899])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-glk5/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-glk7/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_sprite_plane_onoff:
    - shard-iclb:         [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb3/igt@kms_psr@psr2_sprite_plane_onoff.html

  * igt@kms_setmode@basic:
    - shard-apl:          [PASS][31] -> [FAIL][32] ([i915#31])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-apl8/igt@kms_setmode@basic.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-apl6/igt@kms_setmode@basic.html

  * igt@prime_vgem@fence-wait-bsd2:
    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109276]) +21 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@rcs0-s3:
    - shard-apl:          [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +2 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-apl1/igt@gem_ctx_isolation@rcs0-s3.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html

  * igt@gem_exec_balancer@hang:
    - shard-tglb:         [TIMEOUT][37] ([fdo#112271]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb8/igt@gem_exec_balancer@hang.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb5/igt@gem_exec_balancer@hang.html

  * igt@gem_exec_schedule@pi-shared-iova-bsd:
    - shard-iclb:         [SKIP][39] ([i915#677]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb2/igt@gem_exec_schedule@pi-shared-iova-bsd.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb7/igt@gem_exec_schedule@pi-shared-iova-bsd.html

  * igt@gem_exec_schedule@preempt-other-chain-bsd:
    - shard-iclb:         [SKIP][41] ([fdo#112146]) -> [PASS][42] +5 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html

  * igt@gem_exec_schedule@promotion-bsd1:
    - shard-iclb:         [SKIP][43] ([fdo#109276]) -> [PASS][44] +18 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html

  * igt@gem_partial_pwrite_pread@write-uncached:
    - shard-hsw:          [FAIL][45] ([i915#694]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-hsw7/igt@gem_partial_pwrite_pread@write-uncached.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-hsw5/igt@gem_partial_pwrite_pread@write-uncached.html

  * igt@gem_ppgtt@flink-and-close-vma-leak:
    - shard-apl:          [FAIL][47] ([i915#644]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-apl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-apl1/igt@gem_ppgtt@flink-and-close-vma-leak.html

  * igt@i915_pm_dc@dc5-psr:
    - shard-tglb:         [DMESG-WARN][49] ([i915#402]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb8/igt@i915_pm_dc@dc5-psr.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb7/igt@i915_pm_dc@dc5-psr.html

  * igt@i915_pm_rps@reset:
    - shard-iclb:         [FAIL][51] ([i915#413]) -> [PASS][52] +1 similar issue
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb6/igt@i915_pm_rps@reset.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb5/igt@i915_pm_rps@reset.html

  * igt@kms_ccs@pipe-a-crc-primary-rotation-180:
    - shard-tglb:         [DMESG-FAIL][53] ([i915#402]) -> [PASS][54] +2 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb7/igt@kms_ccs@pipe-a-crc-primary-rotation-180.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb7/igt@kms_ccs@pipe-a-crc-primary-rotation-180.html

  * igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
    - shard-tglb:         [FAIL][55] ([fdo#111703]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +3 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
    - shard-tglb:         [FAIL][59] ([i915#559]) -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb6/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb7/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html

  * igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled:
    - shard-snb:          [DMESG-WARN][61] ([i915#478]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-snb4/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-snb2/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
    - shard-tglb:         [SKIP][63] ([i915#668]) -> [PASS][64] +1 similar issue
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - shard-tglb:         [FAIL][65] ([i915#1183]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb1/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb6/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html

  * igt@kms_plane@plane-panning-top-left-pipe-a-planes:
    - shard-tglb:         [FAIL][67] ([i915#1171]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb8/igt@kms_plane@plane-panning-top-left-pipe-a-planes.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb8/igt@kms_plane@plane-panning-top-left-pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
    - shard-tglb:         [FAIL][69] ([i915#1184]) -> [PASS][70]
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb5/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html

  * igt@kms_plane_cursor@pipe-a-overlay-size-256:
    - shard-tglb:         [FAIL][71] ([i915#1139]) -> [PASS][72]
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb5/igt@kms_plane_cursor@pipe-a-overlay-size-256.html

  * igt@kms_plane_lowres@pipe-a-tiling-none:
    - shard-tglb:         [FAIL][73] ([i915#899]) -> [PASS][74]
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb5/igt@kms_plane_lowres@pipe-a-tiling-none.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb7/igt@kms_plane_lowres@pipe-a-tiling-none.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [SKIP][75] ([fdo#109441]) -> [PASS][76] +1 similar issue
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb7/igt@kms_psr@psr2_basic.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb2/igt@kms_psr@psr2_basic.html

  * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
    - shard-kbl:          [INCOMPLETE][77] ([fdo#103665]) -> [PASS][78]
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
    - shard-iclb:         [INCOMPLETE][79] ([i915#140]) -> [PASS][80]
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb3/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html

  * igt@perf@gen12-mi-rpc:
    - shard-tglb:         [TIMEOUT][81] ([fdo#112271] / [i915#1085] / [i915#472]) -> [PASS][82]
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-tglb8/igt@perf@gen12-mi-rpc.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-tglb3/igt@perf@gen12-mi-rpc.html

  * igt@perf_pmu@busy-no-semaphores-vcs1:
    - shard-iclb:         [SKIP][83] ([fdo#112080]) -> [PASS][84] +15 similar issues
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb8/igt@perf_pmu@busy-no-semaphores-vcs1.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html

  
#### Warnings ####

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][85] ([fdo#109349]) -> [DMESG-WARN][86] ([fdo#107724])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [DMESG-WARN][87] ([i915#180]) -> [DMESG-WARN][88] ([i915#180] / [i915#56])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl7/igt@kms_flip@flip-vs-suspend.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-kbl4/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-kbl:          [FAIL][89] ([fdo#103375]) -> [DMESG-WARN][90] ([i915#180])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
  [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
  [i915#1139]: https://gitlab.freedesktop.org/drm/intel/issues/1139
  [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
  [i915#1171]: https://gitlab.freedesktop.org/drm/intel/issues/1171
  [i915#1173]: https://gitlab.freedesktop.org/drm/intel/issues/1173
  [i915#1183]: https://gitlab.freedesktop.org/drm/intel/issues/1183
  [i915#1184]: https://gitlab.freedesktop.org/drm/intel/issues/1184
  [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
  [i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
  [i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
  [i915#559]: https://gitlab.freedesktop.org/drm/intel/issues/559
  [i915#56]: https://gitlab.freedesktop.org/drm/intel/issues/56
  [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
  [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
  [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
  [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
  [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
  [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899


Participating hosts (10 -> 8)
------------------------------

  Missing    (2): pig-skl-6260u pig-glk-j5005 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5425 -> IGTPW_4113
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_7886: c76da740823aa950e340a8e53758511680da79ca @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4113: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/index.html
  IGT_5425: ad4542ef1adbaa1227bc9ba9e24bb0e0f6dd408d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4113/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ GitLab.Pipeline: failure for series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt (rev2)
URL   : https://patchwork.freedesktop.org/series/73148/
State : failure

== Summary ==

ERROR! This series introduces new undocumented tests:

i915_pm_rpm@gem-mmap-type

Can you document them as per the requirement in the [CONTRIBUTING.md]?

[Documentation] has more details on how to do this.

Here are few examples:
https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/0316695d03aa46108296b27f3982ec93200c7a6e
https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/443cc658e1e6b492ee17bf4f4d891029eb7a205d

Thanks in advance!

[CONTRIBUTING.md]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/CONTRIBUTING.md#L19
[Documentation]: https://drm.pages.freedesktop.org/igt-gpu-tools/igt-gpu-tools-Core.html#igt-describe

Other than that, pipeline status: SUCCESS.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/109436 for the overview.

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/109436
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] tests/intel_dp_compliance: use device coherent mapping instead of mmap_gtt (rev2)
URL   : https://patchwork.freedesktop.org/series/73148/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7954 -> IGTPW_4163
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4163/index.html

Known issues
------------

  Here are the changes found in IGTPW_4163 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@gem_close_race@basic-threads:
    - fi-hsw-peppy:       [TIMEOUT][1] ([fdo#112271] / [i915#1084]) -> [PASS][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7954/fi-hsw-peppy/igt@gem_close_race@basic-threads.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4163/fi-hsw-peppy/igt@gem_close_race@basic-threads.html

  
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#1084]: https://gitlab.freedesktop.org/drm/intel/issues/1084


Participating hosts (50 -> 44)
------------------------------

  Additional (1): fi-ehl-1 
  Missing    (7): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-kbl-7560u fi-byt-clapper 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5444 -> IGTPW_4163

  CI-20190529: 20190529
  CI_DRM_7954: d7c1791394faaa869d3442705413dac8c0ecd677 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4163: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4163/index.html
  IGT_5444: c46bae259d427f53fcfcd5f05de0181a9e82d6fe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@i915_pm_rpm@gem-mmap-type
-igt@i915_pm_rpm@gem-mmap-cpu
-igt@i915_pm_rpm@gem-mmap-gtt

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4163/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev