* [PATCH] can: rcar_can: Do not print virtual addresses
@ 2017-04-03 10:11 Geert Uytterhoeven
2017-04-03 12:47 ` Sergei Shtylyov
2017-04-04 16:00 ` Marc Kleine-Budde
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-04-03 10:11 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde, Sergei Shtylyov
Cc: linux-renesas-soc, linux-can, netdev, Geert Uytterhoeven
During probe, the rcar_can driver prints:
rcar_can e6e80000.can: device registered (regs @ e08bc000, IRQ76)
The "regs" value is a virtual address, exposing internal information,
hence stop printing it. The (useful) physical address is already
printed as part of the device name.
Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/can/rcar/rcar_can.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c
index caed4e6960f8c77f..11662f479e760ba7 100644
--- a/drivers/net/can/rcar/rcar_can.c
+++ b/drivers/net/can/rcar/rcar_can.c
@@ -826,8 +826,7 @@ static int rcar_can_probe(struct platform_device *pdev)
devm_can_led_init(ndev);
- dev_info(&pdev->dev, "device registered (regs @ %p, IRQ%d)\n",
- priv->regs, ndev->irq);
+ dev_info(&pdev->dev, "device registered (IRQ%d)\n", ndev->irq);
return 0;
fail_candev:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: rcar_can: Do not print virtual addresses
2017-04-03 10:11 [PATCH] can: rcar_can: Do not print virtual addresses Geert Uytterhoeven
@ 2017-04-03 12:47 ` Sergei Shtylyov
2017-04-04 16:00 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2017-04-03 12:47 UTC (permalink / raw)
To: Geert Uytterhoeven, Wolfgang Grandegger, Marc Kleine-Budde
Cc: linux-renesas-soc, linux-can, netdev
On 04/03/2017 01:11 PM, Geert Uytterhoeven wrote:
> During probe, the rcar_can driver prints:
>
> rcar_can e6e80000.can: device registered (regs @ e08bc000, IRQ76)
>
> The "regs" value is a virtual address, exposing internal information,
> hence stop printing it. The (useful) physical address is already
> printed as part of the device name.
>
> Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
[...]
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: rcar_can: Do not print virtual addresses
2017-04-03 10:11 [PATCH] can: rcar_can: Do not print virtual addresses Geert Uytterhoeven
2017-04-03 12:47 ` Sergei Shtylyov
@ 2017-04-04 16:00 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2017-04-04 16:00 UTC (permalink / raw)
To: Geert Uytterhoeven, Wolfgang Grandegger, Sergei Shtylyov
Cc: linux-renesas-soc, linux-can, netdev
[-- Attachment #1.1: Type: text/plain, Size: 823 bytes --]
On 04/03/2017 12:11 PM, Geert Uytterhoeven wrote:
> During probe, the rcar_can driver prints:
>
> rcar_can e6e80000.can: device registered (regs @ e08bc000, IRQ76)
>
> The "regs" value is a virtual address, exposing internal information,
> hence stop printing it. The (useful) physical address is already
> printed as part of the device name.
>
> Fixes: fd1159318e55e901 ("can: add Renesas R-Car CAN driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied and included in pull request.
Mar
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-04 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03 10:11 [PATCH] can: rcar_can: Do not print virtual addresses Geert Uytterhoeven
2017-04-03 12:47 ` Sergei Shtylyov
2017-04-04 16:00 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.