All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] lib/igt_vec: assertion fortification
@ 2020-02-07  3:27 Zbigniew Kempczyński
  2020-02-07  3:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Zbigniew Kempczyński @ 2020-02-07  3:27 UTC (permalink / raw)
  To: igt-dev

Ensure no one will pass negative index on igt_vec because it could
lead to memory corruptions and weird program behavior.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 lib/igt_vec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_vec.c b/lib/igt_vec.c
index 591e56fa..c6ba164b 100644
--- a/lib/igt_vec.c
+++ b/lib/igt_vec.c
@@ -41,7 +41,7 @@ void igt_vec_fini(struct igt_vec *vec)
 
 void *igt_vec_elem(const struct igt_vec *vec, int idx)
 {
-	igt_assert(idx < vec->len);
+	igt_assert(idx >= 0 && idx < vec->len);
 
 	return vec->elems + idx * vec->elem_size;
 }
@@ -79,7 +79,7 @@ int igt_vec_index(const struct igt_vec *vec, void *elem)
 
 void igt_vec_remove(struct igt_vec *vec, int idx)
 {
-	igt_assert(idx < vec->len);
+	igt_assert(idx >= 0 && idx < vec->len);
 
 	memmove(igt_vec_elem(vec, idx),
 		igt_vec_elem(vec, idx + 1),
-- 
2.23.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-02-10  7:33 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07  3:27 [igt-dev] [PATCH i-g-t] lib/igt_vec: assertion fortification Zbigniew Kempczyński
2020-02-07  3:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-07  3:57 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2020-02-07 13:07 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2020-02-10  6:09 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2020-02-10  6:50   ` Zbigniew Kempczyński
2020-02-10  7:33     ` Vudum, Lakshminarayana
2020-02-10  7:08 ` Patchwork
2020-02-10  7:23 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.