From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi.shyti@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions
Date: Mon, 10 Feb 2020 13:45:06 +0000 [thread overview]
Message-ID: <158134230636.5235.8443960836517180676@skylake-alporthouse-com> (raw)
In-Reply-To: <20200210134039.2607-1-andi.shyti@intel.com>
Quoting Andi Shyti (2020-02-10 13:40:39)
> "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*])
>
> I agree, change the functions name from "debugfs_*" to
> "intel_gt_*" prefix.
>
> [*] https://patchwork.freedesktop.org/patch/352553/#comment_651183
>
> Signed-off-by: Andi Shyti <andi.shyti@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/debugfs_engines.c | 4 ++--
> drivers/gpu/drm/i915/gt/debugfs_engines.h | 2 +-
> drivers/gpu/drm/i915/gt/debugfs_gt.c | 14 +++++++-------
> drivers/gpu/drm/i915/gt/debugfs_gt.h | 10 +++++-----
> drivers/gpu/drm/i915/gt/debugfs_gt_pm.c | 4 ++--
> drivers/gpu/drm/i915/gt/debugfs_gt_pm.h | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
> 7 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/debugfs_engines.c b/drivers/gpu/drm/i915/gt/debugfs_engines.c
> index 6a5e9ab20b94..2d4ab974ab67 100644
> --- a/drivers/gpu/drm/i915/gt/debugfs_engines.c
> +++ b/drivers/gpu/drm/i915/gt/debugfs_engines.c
> @@ -26,11 +26,11 @@ static int engines_show(struct seq_file *m, void *data)
> }
> DEFINE_GT_DEBUGFS_ATTRIBUTE(engines);
>
> -void debugfs_engines_register(struct intel_gt *gt, struct dentry *root)
> +void engines_register_debugfs(struct intel_gt *gt, struct dentry *root)
Bad. If you are going to do this, intel_gt something. (At a push,
intel_engines, but maybe we shouldn't spread that too much as that
currently takes i915 to work on the uapi lists.)
But I don't really care, we can cross this bridge if debugfs feature
creeps beyond its current cave.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-10 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:40 [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions Andi Shyti
2020-02-10 13:45 ` Chris Wilson [this message]
2020-02-10 13:46 ` Chris Wilson
2020-02-10 13:58 ` Andi Shyti
2020-02-10 14:00 ` Chris Wilson
2020-02-10 16:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158134230636.5235.8443960836517180676@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=andi.shyti@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.