From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi.shyti@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions
Date: Mon, 10 Feb 2020 14:00:09 +0000 [thread overview]
Message-ID: <158134320986.5235.15215019925630321460@skylake-alporthouse-com> (raw)
In-Reply-To: <20200210135808.GA2677@intel.intel>
Quoting Andi Shyti (2020-02-10 13:58:08)
> Hi Chris,
>
> > > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*])
> > >
> > > I agree, change the functions name from "debugfs_*" to
> > > "intel_gt_*" prefix.
> >
> > An alternate way of looking at it is that these are all dependent on
> > CONFIG_DEBUGFS. So are they not the debugfs interface?
>
> this is a complete matter of taste, I might have a strong opinion
> if the concept of name prefix was something respected all over
> i915, but that's not always the case.
It's an object prefix; here I'd like to argue that it is the global
debugfs/ that is the 'owner' (or root?) for this interface.
> If Jani feels like enforcing the idea of the function name
> prefix, I basically agree with the style.
>
> With "debugfs_*" I understand all those functions that handle the
> debugfs as framework.
Exactly.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-10 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:40 [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions Andi Shyti
2020-02-10 13:45 ` Chris Wilson
2020-02-10 13:46 ` Chris Wilson
2020-02-10 13:58 ` Andi Shyti
2020-02-10 14:00 ` Chris Wilson [this message]
2020-02-10 16:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158134320986.5235.15215019925630321460@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=andi.shyti@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.