* [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment
@ 2020-02-04 0:35 Scott Wood
2020-02-04 14:27 ` Phil Auld
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Scott Wood @ 2020-02-04 0:35 UTC (permalink / raw)
To: Peter Zijlstra, Frederic Weisbecker, Thomas Gleixner, Ingo Molnar
Cc: linux-kernel, Scott Wood
A redundant "curr = rq->curr" was added; remove it.
Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
Signed-off-by: Scott Wood <swood@redhat.com>
---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45f79bcc3146..377ec26e9159 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
if (cpu_is_offline(cpu))
goto out_unlock;
- curr = rq->curr;
update_rq_clock(rq);
if (!is_idle_task(curr)) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment
2020-02-04 0:35 [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment Scott Wood
@ 2020-02-04 14:27 ` Phil Auld
2020-02-04 17:00 ` Scott Wood
2020-02-11 12:47 ` [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote() tip-bot2 for Scott Wood
2020-02-20 20:09 ` tip-bot2 for Scott Wood
2 siblings, 1 reply; 5+ messages in thread
From: Phil Auld @ 2020-02-04 14:27 UTC (permalink / raw)
To: Scott Wood
Cc: Peter Zijlstra, Frederic Weisbecker, Thomas Gleixner,
Ingo Molnar, linux-kernel
Hi Scott,
On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> A redundant "curr = rq->curr" was added; remove it.
>
> Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> Signed-off-by: Scott Wood <swood@redhat.com>
> ---
> kernel/sched/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 45f79bcc3146..377ec26e9159 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
> if (cpu_is_offline(cpu))
> goto out_unlock;
>
> - curr = rq->curr;
> update_rq_clock(rq);
>
> if (!is_idle_task(curr)) {
> --
> 1.8.3.1
>
Reviewed-by: Phil Auld <pauld@redhat.com>
Out of curiosity, why remove this one and not the one right before the
cpu_is_offline check?
Cheers,
Phil
--
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment
2020-02-04 14:27 ` Phil Auld
@ 2020-02-04 17:00 ` Scott Wood
0 siblings, 0 replies; 5+ messages in thread
From: Scott Wood @ 2020-02-04 17:00 UTC (permalink / raw)
To: Phil Auld
Cc: Peter Zijlstra, Frederic Weisbecker, Thomas Gleixner,
Ingo Molnar, linux-kernel
On Tue, 2020-02-04 at 09:27 -0500, Phil Auld wrote:
> Hi Scott,
>
> On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> > A redundant "curr = rq->curr" was added; remove it.
> >
> > Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> > Signed-off-by: Scott Wood <swood@redhat.com>
> > ---
> > kernel/sched/core.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 45f79bcc3146..377ec26e9159 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct
> > *work)
> > if (cpu_is_offline(cpu))
> > goto out_unlock;
> >
> > - curr = rq->curr;
> > update_rq_clock(rq);
> >
> > if (!is_idle_task(curr)) {
> > --
> > 1.8.3.1
> >
>
> Reviewed-by: Phil Auld <pauld@redhat.com>
>
> Out of curiosity, why remove this one and not the one right before the
> cpu_is_offline check?
This was the one that was recently added by mistake.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote()
2020-02-04 0:35 [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment Scott Wood
2020-02-04 14:27 ` Phil Auld
@ 2020-02-11 12:47 ` tip-bot2 for Scott Wood
2020-02-20 20:09 ` tip-bot2 for Scott Wood
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Scott Wood @ 2020-02-11 12:47 UTC (permalink / raw)
To: linux-tip-commits
Cc: Scott Wood, Peter Zijlstra (Intel), Ingo Molnar, x86, LKML
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 4ccfaab0853bfea772558db6a5e289e87cba57ed
Gitweb: https://git.kernel.org/tip/4ccfaab0853bfea772558db6a5e289e87cba57ed
Author: Scott Wood <swood@redhat.com>
AuthorDate: Mon, 03 Feb 2020 19:35:58 -05:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 11 Feb 2020 12:59:22 +01:00
sched/core: Remove duplicate assignment in sched_tick_remote()
A redundant "curr = rq->curr" was added; remove it.
Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
Signed-off-by: Scott Wood <swood@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/1580776558-12882-1-git-send-email-swood@redhat.com
---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45f79bc..377ec26 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
if (cpu_is_offline(cpu))
goto out_unlock;
- curr = rq->curr;
update_rq_clock(rq);
if (!is_idle_task(curr)) {
^ permalink raw reply related [flat|nested] 5+ messages in thread* [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote()
2020-02-04 0:35 [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment Scott Wood
2020-02-04 14:27 ` Phil Auld
2020-02-11 12:47 ` [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote() tip-bot2 for Scott Wood
@ 2020-02-20 20:09 ` tip-bot2 for Scott Wood
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Scott Wood @ 2020-02-20 20:09 UTC (permalink / raw)
To: linux-tip-commits
Cc: Scott Wood, Peter Zijlstra (Intel),
Ingo Molnar, Thomas Gleixner, x86, LKML
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 82e0516ce3a147365a5dd2a9bedd5ba43a18663d
Gitweb: https://git.kernel.org/tip/82e0516ce3a147365a5dd2a9bedd5ba43a18663d
Author: Scott Wood <swood@redhat.com>
AuthorDate: Mon, 03 Feb 2020 19:35:58 -05:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 20 Feb 2020 21:03:13 +01:00
sched/core: Remove duplicate assignment in sched_tick_remote()
A redundant "curr = rq->curr" was added; remove it.
Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
Signed-off-by: Scott Wood <swood@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/1580776558-12882-1-git-send-email-swood@redhat.com
---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45f79bc..377ec26 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
if (cpu_is_offline(cpu))
goto out_unlock;
- curr = rq->curr;
update_rq_clock(rq);
if (!is_idle_task(curr)) {
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-20 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 0:35 [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment Scott Wood
2020-02-04 14:27 ` Phil Auld
2020-02-04 17:00 ` Scott Wood
2020-02-11 12:47 ` [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote() tip-bot2 for Scott Wood
2020-02-20 20:09 ` tip-bot2 for Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.