* [Intel-gfx] [PATCH] drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
@ 2020-02-18 14:13 Chris Wilson
2020-02-18 20:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-18 20:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2020-02-18 14:13 UTC (permalink / raw)
To: intel-gfx; +Cc: Matthew Auld
We only want to wait until the request has been submitted at least once;
that is it is either in flight, or has been.
References: fcf7df7aae24 ("drm/i915/selftests: Check for the error interrupt before we wait!")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index 40c53cc1c7c0..7b303d5fd5b8 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -83,7 +83,7 @@ static int wait_for_submit(struct intel_engine_cs *engine,
return 0;
}
- if (i915_request_completed(rq)) /* that was quick! */
+ if (i915_request_started(rq)) /* that was quick! */
return 0;
} while (time_before(jiffies, timeout));
--
2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
2020-02-18 14:13 [Intel-gfx] [PATCH] drm/i915/selftests: Check for any sign of request starting in wait_for_submit() Chris Wilson
@ 2020-02-18 20:17 ` Patchwork
2020-02-18 20:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-02-18 20:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
URL : https://patchwork.freedesktop.org/series/73572/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
261fc108dea2 drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
References: fcf7df7aae24 ("drm/i915/selftests: Check for the error interrupt before we wait!")
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit fcf7df7aae24 ("drm/i915/selftests: Check for the error interrupt before we wait!")'
#10:
References: fcf7df7aae24 ("drm/i915/selftests: Check for the error interrupt before we wait!")
total: 1 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
2020-02-18 14:13 [Intel-gfx] [PATCH] drm/i915/selftests: Check for any sign of request starting in wait_for_submit() Chris Wilson
2020-02-18 20:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-02-18 20:48 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2020-02-18 20:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
URL : https://patchwork.freedesktop.org/series/73572/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7961 -> Patchwork_16599
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16599 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_16599, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16599:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_execlists:
- fi-cfl-8700k: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-cfl-8700k/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-cfl-8700k/igt@i915_selftest@live_execlists.html
- fi-skl-guc: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-skl-guc/igt@i915_selftest@live_execlists.html
- fi-skl-lmem: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-skl-lmem/igt@i915_selftest@live_execlists.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-skl-lmem/igt@i915_selftest@live_execlists.html
- fi-cfl-8109u: NOTRUN -> [INCOMPLETE][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-cfl-8109u/igt@i915_selftest@live_execlists.html
Known issues
------------
Here are the changes found in Patchwork_16599 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-apl-guc: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927] / [fdo#112175])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-apl-guc/igt@i915_selftest@live_execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-apl-guc/igt@i915_selftest@live_execlists.html
- fi-kbl-x1275: [PASS][9] -> [INCOMPLETE][10] ([fdo#112259])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-kbl-x1275/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-kbl-x1275/igt@i915_selftest@live_execlists.html
- fi-icl-u2: [PASS][11] -> [INCOMPLETE][12] ([fdo#112175] / [i915#140])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-icl-u2/igt@i915_selftest@live_execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-icl-u2/igt@i915_selftest@live_execlists.html
- fi-icl-dsi: [PASS][13] -> [INCOMPLETE][14] ([i915#140])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-icl-dsi/igt@i915_selftest@live_execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-icl-dsi/igt@i915_selftest@live_execlists.html
- fi-cml-s: [PASS][15] -> [INCOMPLETE][16] ([i915#283])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-cml-s/igt@i915_selftest@live_execlists.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-cml-s/igt@i915_selftest@live_execlists.html
- fi-skl-6700k2: [PASS][17] -> [INCOMPLETE][18] ([fdo#112175])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-skl-6700k2/igt@i915_selftest@live_execlists.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-skl-6700k2/igt@i915_selftest@live_execlists.html
- fi-icl-y: [PASS][19] -> [INCOMPLETE][20] ([i915#140])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-icl-y/igt@i915_selftest@live_execlists.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-icl-y/igt@i915_selftest@live_execlists.html
- fi-cml-u2: [PASS][21] -> [INCOMPLETE][22] ([fdo#112175] / [i915#283])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-cml-u2/igt@i915_selftest@live_execlists.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-cml-u2/igt@i915_selftest@live_execlists.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [INCOMPLETE][23] ([i915#151]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live_gem_contexts:
- fi-cml-s: [DMESG-FAIL][25] ([i915#877]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7961/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/fi-cml-s/igt@i915_selftest@live_gem_contexts.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#112175]: https://bugs.freedesktop.org/show_bug.cgi?id=112175
[fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877
Participating hosts (43 -> 43)
------------------------------
Additional (6): fi-kbl-7500u fi-cfl-8109u fi-bsw-kefka fi-blb-e6850 fi-skl-6600u fi-snb-2600
Missing (6): fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7961 -> Patchwork_16599
CI-20190529: 20190529
CI_DRM_7961: e922b318df45b82e75087ecfaceb998db2dd6213 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5448: 116020b1f83c1b3994c76882df7f77b6731d78ba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16599: 261fc108dea2b180b22c615512301b05cd1906e2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
261fc108dea2 drm/i915/selftests: Check for any sign of request starting in wait_for_submit()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16599/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-18 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-18 14:13 [Intel-gfx] [PATCH] drm/i915/selftests: Check for any sign of request starting in wait_for_submit() Chris Wilson
2020-02-18 20:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-18 20:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.