* [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros. @ 2020-02-18 17:39 Wambui Karuga 2020-02-19 0:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork ` (5 more replies) 0 siblings, 6 replies; 7+ messages in thread From: Wambui Karuga @ 2020-02-18 17:39 UTC (permalink / raw) To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel; +Cc: intel-gfx Manual conversion of instances of printk based drm logging macros to the struct drm_device based logging macros in i915/i915_perf.c. Also involves extraction of the struct drm_i915_private device from various intel types for use in the macros. Instances of the DRM_DEBUG printk macro were not converted due to the lack of an analogous struct drm_device based logging macro. v2: remove instances of DRM_DEBUG that were converted. References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> --- drivers/gpu/drm/i915/i915_perf.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index b5249ee5bda6..e34c79df6ebc 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -555,8 +555,9 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream) aging_tail = hw_tail; stream->oa_buffer.aging_timestamp = now; } else { - DRM_ERROR("Ignoring spurious out of range OA buffer tail pointer = %x\n", - hw_tail); + drm_err(&stream->perf->i915->drm, + "Ignoring spurious out of range OA buffer tail pointer = %x\n", + hw_tail); } } @@ -745,7 +746,8 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream, */ if (drm_WARN_ON(&uncore->i915->drm, (OA_BUFFER_SIZE - head) < report_size)) { - DRM_ERROR("Spurious OA head ptr: non-integral report offset\n"); + drm_err(&uncore->i915->drm, + "Spurious OA head ptr: non-integral report offset\n"); break; } @@ -1041,7 +1043,8 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream, */ if (drm_WARN_ON(&uncore->i915->drm, (OA_BUFFER_SIZE - head) < report_size)) { - DRM_ERROR("Spurious OA head ptr: non-integral report offset\n"); + drm_err(&uncore->i915->drm, + "Spurious OA head ptr: non-integral report offset\n"); break; } @@ -1339,9 +1342,10 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream) ce->tag = stream->specific_ctx_id; - DRM_DEBUG_DRIVER("filtering on ctx_id=0x%x ctx_id_mask=0x%x\n", - stream->specific_ctx_id, - stream->specific_ctx_id_mask); + drm_dbg(&stream->perf->i915->drm, + "filtering on ctx_id=0x%x ctx_id_mask=0x%x\n", + stream->specific_ctx_id, + stream->specific_ctx_id_mask); return 0; } @@ -2657,7 +2661,8 @@ static void gen7_oa_disable(struct i915_perf_stream *stream) if (intel_wait_for_register(uncore, GEN7_OACONTROL, GEN7_OACONTROL_ENABLE, 0, 50)) - DRM_ERROR("wait for OA to be disabled timed out\n"); + drm_err(&stream->perf->i915->drm, + "wait for OA to be disabled timed out\n"); } static void gen8_oa_disable(struct i915_perf_stream *stream) @@ -2668,7 +2673,8 @@ static void gen8_oa_disable(struct i915_perf_stream *stream) if (intel_wait_for_register(uncore, GEN8_OACONTROL, GEN8_OA_COUNTER_ENABLE, 0, 50)) - DRM_ERROR("wait for OA to be disabled timed out\n"); + drm_err(&stream->perf->i915->drm, + "wait for OA to be disabled timed out\n"); } static void gen12_oa_disable(struct i915_perf_stream *stream) @@ -2680,7 +2686,8 @@ static void gen12_oa_disable(struct i915_perf_stream *stream) GEN12_OAG_OACONTROL, GEN12_OAG_OACONTROL_OA_COUNTER_ENABLE, 0, 50)) - DRM_ERROR("wait for OA to be disabled timed out\n"); + drm_err(&stream->perf->i915->drm, + "wait for OA to be disabled timed out\n"); } /** -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: conversion to struct drm_device based logging macros. 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga @ 2020-02-19 0:59 ` Patchwork 2020-02-19 1:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-02-19 0:59 UTC (permalink / raw) To: Wambui Karuga; +Cc: intel-gfx == Series Details == Series: drm/i915/perf: conversion to struct drm_device based logging macros. URL : https://patchwork.freedesktop.org/series/73589/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2da597adb589 drm/i915/perf: conversion to struct drm_device based logging macros. -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #17: References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html total: 0 errors, 1 warnings, 0 checks, 69 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/perf: conversion to struct drm_device based logging macros. 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga 2020-02-19 0:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2020-02-19 1:22 ` Patchwork 2020-02-19 10:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) Patchwork ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-02-19 1:22 UTC (permalink / raw) To: Wambui Karuga; +Cc: intel-gfx == Series Details == Series: drm/i915/perf: conversion to struct drm_device based logging macros. URL : https://patchwork.freedesktop.org/series/73589/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7963 -> Patchwork_16605 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_16605 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_16605, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_16605: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live_requests: - fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-bwr-2160/igt@i915_selftest@live_requests.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-bwr-2160/igt@i915_selftest@live_requests.html Known issues ------------ Here are the changes found in Patchwork_16605 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_sanitycheck: - fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([i915#585]) +39 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html * igt@kms_chamelium@dp-edid-read: - fi-cml-u2: [PASS][5] -> [FAIL][6] ([i915#217] / [i915#976]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-cml-u2/igt@kms_chamelium@dp-edid-read.html #### Possible fixes #### * igt@gem_close_race@basic-threads: - fi-byt-j1900: [INCOMPLETE][7] ([i915#45]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-byt-j1900/igt@gem_close_race@basic-threads.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-byt-j1900/igt@gem_close_race@basic-threads.html * igt@i915_selftest@live_active: - fi-icl-dsi: [DMESG-FAIL][9] ([i915#765]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-dsi/igt@i915_selftest@live_active.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-icl-dsi/igt@i915_selftest@live_active.html * igt@i915_selftest@live_gem_contexts: - fi-cfl-8700k: [INCOMPLETE][11] ([i915#424]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html - fi-cml-s: [DMESG-FAIL][13] ([i915#877]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-cml-s/igt@i915_selftest@live_gem_contexts.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-cml-s/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_gt_heartbeat: - fi-kbl-7500u: [DMESG-FAIL][15] ([fdo#112406]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-kbl-7500u/igt@i915_selftest@live_gt_heartbeat.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-kbl-7500u/igt@i915_selftest@live_gt_heartbeat.html #### Warnings #### * igt@i915_pm_rpm@basic-rte: - fi-kbl-guc: [FAIL][17] ([i915#579]) -> [SKIP][18] ([fdo#109271]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html * igt@kms_chamelium@dp-hpd-fast: - fi-icl-u3: [SKIP][19] ([fdo#109284] / [fdo#111827]) -> [SKIP][20] ([fdo#109284] / [fdo#111827] / [i915#585]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-u3/igt@kms_chamelium@dp-hpd-fast.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-icl-u3/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_force_connector_basic@force-load-detect: - fi-icl-u3: [SKIP][21] ([fdo#109285]) -> [SKIP][22] ([fdo#109285] / [i915#585]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-u3/igt@kms_force_connector_basic@force-load-detect.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/fi-icl-u3/igt@kms_force_connector_basic@force-load-detect.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112406]: https://bugs.freedesktop.org/show_bug.cgi?id=112406 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424 [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 [i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585 [i915#765]: https://gitlab.freedesktop.org/drm/intel/issues/765 [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877 [i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976 Participating hosts (50 -> 37) ------------------------------ Missing (13): fi-ilk-m540 fi-bsw-n3050 fi-hsw-4200u fi-hsw-peppy fi-glk-dsi fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-bsw-kefka fi-bdw-samus fi-bsw-nick fi-skl-6700k2 fi-snb-2600 Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7963 -> Patchwork_16605 CI-20190529: 20190529 CI_DRM_7963: e0d737598eb749378a5dc4ed3dfafc6f79d512cb @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5448: 116020b1f83c1b3994c76882df7f77b6731d78ba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16605: 2da597adb589e84f76bbc995dcfbd8d2e7566f1d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 2da597adb589 drm/i915/perf: conversion to struct drm_device based logging macros. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16605/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga 2020-02-19 0:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-02-19 1:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork @ 2020-02-19 10:30 ` Patchwork 2020-02-19 11:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-02-19 10:30 UTC (permalink / raw) To: Wambui Karuga; +Cc: intel-gfx == Series Details == Series: drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) URL : https://patchwork.freedesktop.org/series/73589/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9139cc1d6f24 drm/i915/perf: conversion to struct drm_device based logging macros. -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #17: References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html total: 0 errors, 1 warnings, 0 checks, 69 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga ` (2 preceding siblings ...) 2020-02-19 10:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) Patchwork @ 2020-02-19 11:04 ` Patchwork 2020-02-20 23:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-02-21 9:36 ` [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Jani Nikula 5 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-02-19 11:04 UTC (permalink / raw) To: Wambui Karuga; +Cc: intel-gfx == Series Details == Series: drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) URL : https://patchwork.freedesktop.org/series/73589/ State : success == Summary == CI Bug Log - changes from CI_DRM_7963 -> Patchwork_16617 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/index.html Known issues ------------ Here are the changes found in Patchwork_16617 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-ilk-650: [PASS][1] -> [DMESG-WARN][2] ([i915#116]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-ilk-650/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-ilk-650/igt@gem_exec_suspend@basic-s3.html * igt@i915_selftest@live_execlists: - fi-icl-y: [PASS][3] -> [DMESG-FAIL][4] ([fdo#108569]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-y/igt@i915_selftest@live_execlists.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-icl-y/igt@i915_selftest@live_execlists.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([i915#585]) +39 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@gem_exec_parallel@contexts: - {fi-ehl-1}: [INCOMPLETE][7] ([i915#937]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-ehl-1/igt@gem_exec_parallel@contexts.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-ehl-1/igt@gem_exec_parallel@contexts.html * igt@i915_selftest@live_active: - fi-icl-dsi: [DMESG-FAIL][9] ([i915#765]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-dsi/igt@i915_selftest@live_active.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-icl-dsi/igt@i915_selftest@live_active.html * igt@i915_selftest@live_gem_contexts: - fi-cfl-8700k: [INCOMPLETE][11] ([i915#424]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html - fi-cml-s: [DMESG-FAIL][13] ([i915#877]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-cml-s/igt@i915_selftest@live_gem_contexts.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-cml-s/igt@i915_selftest@live_gem_contexts.html * igt@i915_selftest@live_gt_heartbeat: - fi-kbl-7500u: [DMESG-FAIL][15] ([fdo#112406]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-kbl-7500u/igt@i915_selftest@live_gt_heartbeat.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-kbl-7500u/igt@i915_selftest@live_gt_heartbeat.html * igt@kms_flip@basic-flip-vs-wf_vblank: - fi-bsw-n3050: [FAIL][17] ([i915#34]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank.html #### Warnings #### * igt@i915_pm_rpm@basic-rte: - fi-kbl-guc: [FAIL][19] ([i915#579]) -> [SKIP][20] ([fdo#109271]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html * igt@kms_chamelium@dp-hpd-fast: - fi-icl-u3: [SKIP][21] ([fdo#109284] / [fdo#111827]) -> [SKIP][22] ([fdo#109284] / [fdo#111827] / [i915#585]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-u3/igt@kms_chamelium@dp-hpd-fast.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-icl-u3/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_force_connector_basic@force-load-detect: - fi-icl-u3: [SKIP][23] ([fdo#109285]) -> [SKIP][24] ([fdo#109285] / [i915#585]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/fi-icl-u3/igt@kms_force_connector_basic@force-load-detect.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/fi-icl-u3/igt@kms_force_connector_basic@force-load-detect.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112406]: https://bugs.freedesktop.org/show_bug.cgi?id=112406 [i915#116]: https://gitlab.freedesktop.org/drm/intel/issues/116 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 [i915#585]: https://gitlab.freedesktop.org/drm/intel/issues/585 [i915#765]: https://gitlab.freedesktop.org/drm/intel/issues/765 [i915#877]: https://gitlab.freedesktop.org/drm/intel/issues/877 [i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937 Participating hosts (50 -> 46) ------------------------------ Additional (1): fi-skl-6770hq Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7963 -> Patchwork_16617 CI-20190529: 20190529 CI_DRM_7963: e0d737598eb749378a5dc4ed3dfafc6f79d512cb @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5448: 116020b1f83c1b3994c76882df7f77b6731d78ba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16617: 9139cc1d6f24405b4652499b50e05a76181398f8 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 9139cc1d6f24 drm/i915/perf: conversion to struct drm_device based logging macros. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga ` (3 preceding siblings ...) 2020-02-19 11:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-02-20 23:41 ` Patchwork 2020-02-21 9:36 ` [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Jani Nikula 5 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-02-20 23:41 UTC (permalink / raw) To: Wambui Karuga; +Cc: intel-gfx == Series Details == Series: drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) URL : https://patchwork.freedesktop.org/series/73589/ State : success == Summary == CI Bug Log - changes from CI_DRM_7963_full -> Patchwork_16617_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16617_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@busy-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +11 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb1/igt@gem_busy@busy-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb6/igt@gem_busy@busy-vcs1.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#110841]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb7/igt@gem_exec_schedule@pi-common-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +6 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_partial_pwrite_pread@reads: - shard-hsw: [PASS][9] -> [FAIL][10] ([i915#694]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-hsw2/igt@gem_partial_pwrite_pread@reads.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-hsw8/igt@gem_partial_pwrite_pread@reads.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][11] -> [FAIL][12] ([i915#454]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb4/igt@i915_pm_dc@dc6-psr.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb6/igt@i915_pm_dc@dc6-psr.html * igt@i915_suspend@debugfs-reader: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-apl4/igt@i915_suspend@debugfs-reader.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-apl6/igt@i915_suspend@debugfs-reader.html * igt@kms_flip@flip-vs-absolute-wf_vblank: - shard-tglb: [PASS][15] -> [FAIL][16] ([i915#488]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-tglb5/igt@kms_flip@flip-vs-absolute-wf_vblank.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-tglb8/igt@kms_flip@flip-vs-absolute-wf_vblank.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +4 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-skl: [PASS][23] -> [INCOMPLETE][24] ([i915#69]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl5/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109276]) +22 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb4/igt@prime_busy@hang-bsd2.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb3/igt@prime_busy@hang-bsd2.html #### Possible fixes #### * {igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox}: - shard-skl: [FAIL][27] ([i915#679]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl8/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl8/igt@gem_ctx_persistence@legacy-engines-mixed-process@vebox.html * igt@gem_eio@in-flight-suspend: - shard-kbl: [INCOMPLETE][29] ([fdo#103665]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-kbl6/igt@gem_eio@in-flight-suspend.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-kbl7/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][31] ([fdo#110854]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb5/igt@gem_exec_balancer@smoke.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb2/igt@gem_exec_balancer@smoke.html * {igt@gem_exec_schedule@implicit-both-bsd1}: - shard-iclb: [SKIP][33] ([fdo#109276] / [i915#677]) -> [PASS][34] +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb7/igt@gem_exec_schedule@implicit-both-bsd1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb1/igt@gem_exec_schedule@implicit-both-bsd1.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [SKIP][35] ([i915#677]) -> [PASS][36] +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][37] ([fdo#112146]) -> [PASS][38] +6 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@kms_cursor_crc@pipe-a-cursor-size-change: - shard-snb: [SKIP][39] ([fdo#109271]) -> [PASS][40] +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-snb4/igt@kms_cursor_crc@pipe-a-cursor-size-change.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-snb5/igt@kms_cursor_crc@pipe-a-cursor-size-change.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-hsw: [FAIL][41] ([i915#96]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [FAIL][43] ([i915#79]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible.html - shard-hsw: [INCOMPLETE][47] ([i915#61]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@psr-1p-rte: - shard-tglb: [SKIP][49] ([i915#668]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-tglb5/igt@kms_frontbuffer_tracking@psr-1p-rte.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-tglb8/igt@kms_frontbuffer_tracking@psr-1p-rte.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [FAIL][51] ([fdo#108145]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][53] ([fdo#108145] / [i915#265]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [FAIL][55] ([i915#899]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-glk9/igt@kms_plane_lowres@pipe-a-tiling-x.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@no_drrs: - shard-iclb: [FAIL][57] ([i915#173]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb1/igt@kms_psr@no_drrs.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb5/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-skl: [INCOMPLETE][61] ([i915#69]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-skl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-skl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@perf@short-reads: - shard-kbl: [TIMEOUT][63] ([fdo#112271] / [i915#51]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-kbl6/igt@perf@short-reads.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-kbl2/igt@perf@short-reads.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [SKIP][65] ([fdo#112080]) -> [PASS][66] +12 similar issues [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb7/igt@perf_pmu@busy-no-semaphores-vcs1.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +16 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-iclb8/igt@prime_vgem@fence-wait-bsd2.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html #### Warnings #### * igt@gem_tiled_blits@normal: - shard-hsw: [FAIL][69] ([i915#818]) -> [FAIL][70] ([i915#694]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-hsw2/igt@gem_tiled_blits@normal.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-hsw1/igt@gem_tiled_blits@normal.html * igt@i915_pm_dc@dc6-psr: - shard-tglb: [FAIL][71] ([i915#454]) -> [SKIP][72] ([i915#468]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7963/shard-tglb6/igt@i915_pm_dc@dc6-psr.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/shard-tglb2/igt@i915_pm_dc@dc6-psr.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#488]: https://gitlab.freedesktop.org/drm/intel/issues/488 [i915#51]: https://gitlab.freedesktop.org/drm/intel/issues/51 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 [i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7963 -> Patchwork_16617 CI-20190529: 20190529 CI_DRM_7963: e0d737598eb749378a5dc4ed3dfafc6f79d512cb @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5448: 116020b1f83c1b3994c76882df7f77b6731d78ba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16617: 9139cc1d6f24405b4652499b50e05a76181398f8 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16617/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros. 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga ` (4 preceding siblings ...) 2020-02-20 23:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-02-21 9:36 ` Jani Nikula 5 siblings, 0 replies; 7+ messages in thread From: Jani Nikula @ 2020-02-21 9:36 UTC (permalink / raw) To: Wambui Karuga, joonas.lahtinen, rodrigo.vivi, airlied, daniel; +Cc: intel-gfx On Tue, 18 Feb 2020, Wambui Karuga <wambui.karugax@gmail.com> wrote: > Manual conversion of instances of printk based drm logging macros to the > struct drm_device based logging macros in i915/i915_perf.c. > Also involves extraction of the struct drm_i915_private device from > various intel types for use in the macros. > > Instances of the DRM_DEBUG printk macro were not converted due to the > lack of an analogous struct drm_device based logging macro. > > v2: remove instances of DRM_DEBUG that were converted. > > References: https://lists.freedesktop.org/archives/dri-devel/2020-January/253381.html > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> Thanks, pushed to drm-intel-next-queued. BR, Jani. > --- > drivers/gpu/drm/i915/i915_perf.c | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index b5249ee5bda6..e34c79df6ebc 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -555,8 +555,9 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream) > aging_tail = hw_tail; > stream->oa_buffer.aging_timestamp = now; > } else { > - DRM_ERROR("Ignoring spurious out of range OA buffer tail pointer = %x\n", > - hw_tail); > + drm_err(&stream->perf->i915->drm, > + "Ignoring spurious out of range OA buffer tail pointer = %x\n", > + hw_tail); > } > } > > @@ -745,7 +746,8 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream, > */ > if (drm_WARN_ON(&uncore->i915->drm, > (OA_BUFFER_SIZE - head) < report_size)) { > - DRM_ERROR("Spurious OA head ptr: non-integral report offset\n"); > + drm_err(&uncore->i915->drm, > + "Spurious OA head ptr: non-integral report offset\n"); > break; > } > > @@ -1041,7 +1043,8 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream, > */ > if (drm_WARN_ON(&uncore->i915->drm, > (OA_BUFFER_SIZE - head) < report_size)) { > - DRM_ERROR("Spurious OA head ptr: non-integral report offset\n"); > + drm_err(&uncore->i915->drm, > + "Spurious OA head ptr: non-integral report offset\n"); > break; > } > > @@ -1339,9 +1342,10 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream) > > ce->tag = stream->specific_ctx_id; > > - DRM_DEBUG_DRIVER("filtering on ctx_id=0x%x ctx_id_mask=0x%x\n", > - stream->specific_ctx_id, > - stream->specific_ctx_id_mask); > + drm_dbg(&stream->perf->i915->drm, > + "filtering on ctx_id=0x%x ctx_id_mask=0x%x\n", > + stream->specific_ctx_id, > + stream->specific_ctx_id_mask); > > return 0; > } > @@ -2657,7 +2661,8 @@ static void gen7_oa_disable(struct i915_perf_stream *stream) > if (intel_wait_for_register(uncore, > GEN7_OACONTROL, GEN7_OACONTROL_ENABLE, 0, > 50)) > - DRM_ERROR("wait for OA to be disabled timed out\n"); > + drm_err(&stream->perf->i915->drm, > + "wait for OA to be disabled timed out\n"); > } > > static void gen8_oa_disable(struct i915_perf_stream *stream) > @@ -2668,7 +2673,8 @@ static void gen8_oa_disable(struct i915_perf_stream *stream) > if (intel_wait_for_register(uncore, > GEN8_OACONTROL, GEN8_OA_COUNTER_ENABLE, 0, > 50)) > - DRM_ERROR("wait for OA to be disabled timed out\n"); > + drm_err(&stream->perf->i915->drm, > + "wait for OA to be disabled timed out\n"); > } > > static void gen12_oa_disable(struct i915_perf_stream *stream) > @@ -2680,7 +2686,8 @@ static void gen12_oa_disable(struct i915_perf_stream *stream) > GEN12_OAG_OACONTROL, > GEN12_OAG_OACONTROL_OA_COUNTER_ENABLE, 0, > 50)) > - DRM_ERROR("wait for OA to be disabled timed out\n"); > + drm_err(&stream->perf->i915->drm, > + "wait for OA to be disabled timed out\n"); > } > > /** -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-21 9:36 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-18 17:39 [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Wambui Karuga 2020-02-19 0:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-02-19 1:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2020-02-19 10:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: conversion to struct drm_device based logging macros. (rev2) Patchwork 2020-02-19 11:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-02-20 23:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-02-21 9:36 ` [Intel-gfx] [PATCH v2] drm/i915/perf: conversion to struct drm_device based logging macros Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.