Re: [PATCH v5 00/50] Initial support for multi-process qemu

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/cover.1582576372.git.jag.raman@oracle.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v5 00/50] Initial support for multi-process qemu
Message-id: cover.1582576372.git.jag.raman@oracle.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200224205533.23798-1-philmd@redhat.com -> patchew/20200224205533.23798-1-philmd@redhat.com
Switched to a new branch 'test'
046649c multi-process: add configure and usage information
7c79419 multi-process: add the concept description to docs/devel/qemu-multiprocess
b06e676 multi-process: Validate incoming commands from Proxy
cc1f6b4 multi-process: Enable support for multiple devices in remote
0060f81 multi-process/mig: Restore the VMSD in remote process
f163e9b multi-process/mig: Synchronize runstate of remote process
8bc3796 multi-process/mig: refactor runstate_check into common file
4ebbd74 multi-process/mig: Load VMSD in the proxy object
4b124b2 multi-process/mig: Send VMSD of remote to the Proxy object
b8dbad8 multi-process/mig: Enable VMSD save in the Proxy object
3253157 multi-process/mig: build migration module in the remote process
96557d0 multi-process: prevent duplicate memory initialization in remote
9a85af0 multi-process/mon: Initialize QMP module for remote processes
ca70d4a multi-process/mon: Refactor monitor/chardev functions out of vl.c
dbe3a63 multi-process/mon: enable QMP module support in the remote process
a12a802 multi-process/mon: stub functions to enable QMP module for remote process
1e6d3af multi-process/mon: choose HMP commands based on target
888e741 multi-process: perform device reset in the remote process
8f15bd8 multi-process: Use separate MMIO communication channel
64593f5 multi-process: handle heartbeat messages in remote process
93b0f96 multi-process: send heartbeat messages to remote
ad214e9 multi-process: add parse_cmdline in remote process
83bc352 multi-process: add remote options parser
7fcc704 multi-process: add remote option
24ca162 multi-process: refractor vl.c code
20c05d9 multi-process: Introduce build flags to separate remote process code
335f331 multi-process: add processing of remote device command line
413bf28 multi-process: remote: add create_done condition
d0e4f00 multi-process: remote: use fd for socket from parent process
045f8f8 multi-process: remote: add setup_devices msg processing
a8ea8aa multi-process: add qdev_proxy_add to create proxy devices
59d0bff multi-process: Retrieve PCI info from remote process
898af59 multi-process: configure remote side devices
b49c9f3 multi-process: create IOHUB object to handle irq
06dc766 multi-process: Synchronize remote memory
a88dcbd multi-process: PCI BAR read/write handling for proxy & remote endpoints
5a3fbbb mutli-process: build remote command line args
c319ce7 multi-process: introduce proxy object
7cb950d multi-process: remote process initialization
e91592e multi-process: setup memory manager for remote device
4f14ba4 multi-process: setup a machine object for remote device process
b1e58b1 multi-process: setup PCI host bridge for remote device
2785043 multi-process: add functions to synchronize proxy and remote endpoints
f83d3f3 multi-process: define mpqemu-link object
252d736 multi-process: build system for remote device process
1482849 multi-process: Add config option for multi-process QEMU
b78f0cc multi-process: Add stub functions to facilate build of multi-process
837f4a6 multi-process: add a command line option for debug file
e58fa6d multi-process: Refactor machine_init and exit notifiers
bf5b343 multi-process: memory: alloc RAM from file at offset

=== OUTPUT BEGIN ===
1/50 Checking commit bf5b3438f584 (multi-process: memory: alloc RAM from file at offset)
2/50 Checking commit e58fa6db276f (multi-process: Refactor machine_init and exit notifiers)
3/50 Checking commit 837f4a602862 (multi-process: add a command line option for debug file)
4/50 Checking commit b78f0cc3f072 (multi-process: Add stub functions to facilate build of multi-process)
ERROR: suspect code indent for conditional statements (4, 4)
#141: FILE: accel/stubs/tcg-stub.c:109:
+    while (1) {
+    }

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#155: 
new file mode 100644

total: 1 errors, 1 warnings, 378 lines checked

Patch 4/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/50 Checking commit 1482849e9584 (multi-process: Add config option for multi-process QEMU)
6/50 Checking commit 252d7366e5c1 (multi-process: build system for remote device process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#311: 
new file mode 100644

total: 0 errors, 1 warnings, 250 lines checked

Patch 6/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/50 Checking commit f83d3f37432f (multi-process: define mpqemu-link object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 437 lines checked

Patch 7/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/50 Checking commit 278504388c18 (multi-process: add functions to synchronize proxy and remote endpoints)
9/50 Checking commit b1e58b14c4d2 (multi-process: setup PCI host bridge for remote device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 118 lines checked

Patch 9/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/50 Checking commit 4f14ba434d5b (multi-process: setup a machine object for remote device process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#63: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 10/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/50 Checking commit e91592e1d3e5 (multi-process: setup memory manager for remote device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#122: 
new file mode 100644

total: 0 errors, 1 warnings, 163 lines checked

Patch 11/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/50 Checking commit 7cb950d0b414 (multi-process: remote process initialization)
13/50 Checking commit c319ce7e8e42 (multi-process: introduce proxy object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

WARNING: line over 80 characters
#78: FILE: hw/proxy/qemu-proxy.c:33:
+        error_setg(errp, "Remote processed is managed and launched by external program");

total: 0 errors, 2 warnings, 338 lines checked

Patch 13/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/50 Checking commit 5a3fbbb83e89 (mutli-process: build remote command line args)
15/50 Checking commit a88dcbd3b371 (multi-process: PCI BAR read/write handling for proxy & remote endpoints)
16/50 Checking commit 06dc7666cb21 (multi-process: Synchronize remote memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 323 lines checked

Patch 16/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/50 Checking commit b49c9f3a3655 (multi-process: create IOHUB object to handle irq)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
deleted file mode 100644

total: 0 errors, 1 warnings, 411 lines checked

Patch 17/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/50 Checking commit 898af59b01ef (multi-process: configure remote side devices)
19/50 Checking commit 59d0bff02614 (multi-process: Retrieve PCI info from remote process)
20/50 Checking commit a8ea8aa3417d (multi-process: add qdev_proxy_add to create proxy devices)
21/50 Checking commit 045f8f82de1c (multi-process: remote: add setup_devices msg processing)
22/50 Checking commit d0e4f00c3065 (multi-process: remote: use fd for socket from parent process)
23/50 Checking commit 413bf287c459 (multi-process: remote: add create_done condition)
24/50 Checking commit 335f331eed39 (multi-process: add processing of remote device command line)
25/50 Checking commit 20c05d9deccc (multi-process: Introduce build flags to separate remote process code)
26/50 Checking commit 24ca162587f0 (multi-process: refractor vl.c code)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#189: 
new file mode 100644

total: 0 errors, 1 warnings, 326 lines checked

Patch 26/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/50 Checking commit 7fcc7047eaa0 (multi-process: add remote option)
28/50 Checking commit 83bc352512c7 (multi-process: add remote options parser)
29/50 Checking commit ad214e916e4d (multi-process: add parse_cmdline in remote process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

ERROR: line over 90 characters
#135: FILE: remote/remote-opts.c:72:
+                error_report("Option not supported for this target, %x arch_mask, %x arch_type",

total: 1 errors, 1 warnings, 148 lines checked

Patch 29/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

30/50 Checking commit 93b0f96ec29b (multi-process: send heartbeat messages to remote)
31/50 Checking commit 64593f51a86c (multi-process: handle heartbeat messages in remote process)
32/50 Checking commit 8f15bd8412a3 (multi-process: Use separate MMIO communication channel)
33/50 Checking commit 888e741a19af (multi-process: perform device reset in the remote process)
34/50 Checking commit 1e6d3af047e6 (multi-process/mon: choose HMP commands based on target)
35/50 Checking commit a12a80202f4e (multi-process/mon: stub functions to enable QMP module for remote process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#110: 
new file mode 100644

ERROR: line over 90 characters
#550: FILE: stubs/qapi-target.c:48:
+#if defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_I386) || defined(TARGET_S390X) || defined(TARGET_MIPS)

total: 1 errors, 1 warnings, 730 lines checked

Patch 35/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

36/50 Checking commit dbe3a637fac7 (multi-process/mon: enable QMP module support in the remote process)
37/50 Checking commit ca70d4a7859d (multi-process/mon: Refactor monitor/chardev functions out of vl.c)
38/50 Checking commit 9a85af09cf01 (multi-process/mon: Initialize QMP module for remote processes)
39/50 Checking commit 96557d09787c (multi-process: prevent duplicate memory initialization in remote)
40/50 Checking commit 32531572e8c7 (multi-process/mig: build migration module in the remote process)
41/50 Checking commit b8dbad8073b6 (multi-process/mig: Enable VMSD save in the Proxy object)
ERROR: suspect code indent for conditional statements (4, 4)
#131: FILE: hw/proxy/qemu-proxy.c:557:
+    while (*((volatile uint64_t *)&pdev->migsize) < size) {
+    }

total: 1 errors, 0 warnings, 174 lines checked

Patch 41/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

42/50 Checking commit 4b124b25aded (multi-process/mig: Send VMSD of remote to the Proxy object)
43/50 Checking commit 4ebbd744f34b (multi-process/mig: Load VMSD in the proxy object)
44/50 Checking commit 8bc37967dcd8 (multi-process/mig: refactor runstate_check into common file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 89 lines checked

Patch 44/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
45/50 Checking commit f163e9b02e25 (multi-process/mig: Synchronize runstate of remote process)
46/50 Checking commit 0060f814e9c8 (multi-process/mig: Restore the VMSD in remote process)
47/50 Checking commit cc1f6b4970d4 (multi-process: Enable support for multiple devices in remote)
48/50 Checking commit b06e676c2119 (multi-process: Validate incoming commands from Proxy)
49/50 Checking commit 7c794195319d (multi-process: add the concept description to docs/devel/qemu-multiprocess)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 1106 lines checked

Patch 49/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
50/50 Checking commit 046649c71c87 (multi-process: add configure and usage information)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 86 lines checked

Patch 50/50 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1582576372.git.jag.raman@oracle.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com