* [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check @ 2020-02-29 10:39 Oliver Barta 2020-03-02 18:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork ` (4 more replies) 0 siblings, 5 replies; 7+ messages in thread From: Oliver Barta @ 2020-02-29 10:39 UTC (permalink / raw) To: intel-gfx, Jani Nikula, Joonas Lahtinen Cc: Daniel Vetter, Ravisankar Madasamy, Sean Paul, Oliver Barta From: Oliver Barta <oliver.barta@aptiv.com> The check was always succeeding even in case of a mismatch due to the HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. Signed-off-by: Oliver Barta <oliver.barta@aptiv.com> Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") --- Submitted before as part of patch series https://patchwork.freedesktop.org/series/73961/ For some reason the versioning got messed up. I marked the patch series as superseded and I'm starting all over. Sorry for spamming you. drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 0ac9bdfbc094..ac4276157182 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -1536,7 +1536,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port) intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg); /* Wait for Ri prime match */ - if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) & + if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, + port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) == (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) { DRM_ERROR("Ri' mismatch detected, link check failed (%x)\n", intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port))); -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HDCP: fix Ri prime check done during link check 2020-02-29 10:39 [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta @ 2020-03-02 18:56 ` Patchwork 2020-03-02 19:11 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork ` (3 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-03-02 18:56 UTC (permalink / raw) To: Oliver Barta; +Cc: intel-gfx == Series Details == Series: drm/i915: HDCP: fix Ri prime check done during link check URL : https://patchwork.freedesktop.org/series/74152/ State : warning == Summary == $ dim checkpatch origin/drm-tip 56c69a1c0711 drm/i915: HDCP: fix Ri prime check done during link check -:22: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #22: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1540: + if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, + port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) == total: 0 errors, 0 warnings, 1 checks, 9 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: HDCP: fix Ri prime check done during link check 2020-02-29 10:39 [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta 2020-03-02 18:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2020-03-02 19:11 ` Patchwork 2020-03-02 19:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-03-02 19:11 UTC (permalink / raw) To: Oliver Barta; +Cc: intel-gfx == Series Details == Series: drm/i915: HDCP: fix Ri prime check done during link check URL : https://patchwork.freedesktop.org/series/74152/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c Error: Cannot open file ./drivers/gpu/drm/i915/intel_csr.c ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq' not described in 'intel_shared_dpll_funcs' ./drivers/gpu/drm/i915/i915_vma.h:1: warning: 'Virtual Memory Address' not found ./drivers/gpu/drm/i915/i915_gem_gtt.c:1: warning: 'Global GTT views' not found WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -function csr support for dmc ./drivers/gpu/drm/i915/intel_csr.c' failed with return code 1 WARNING: kernel-doc './scripts/kernel-doc -rst -enable-lineno -internal ./drivers/gpu/drm/i915/intel_csr.c' failed with return code 2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HDCP: fix Ri prime check done during link check 2020-02-29 10:39 [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta 2020-03-02 18:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-03-02 19:11 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork @ 2020-03-02 19:22 ` Patchwork 2020-03-03 8:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-03-03 9:33 ` [Intel-gfx] [PATCH] " Ramalingam C 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-03-02 19:22 UTC (permalink / raw) To: Oliver Barta; +Cc: intel-gfx == Series Details == Series: drm/i915: HDCP: fix Ri prime check done during link check URL : https://patchwork.freedesktop.org/series/74152/ State : success == Summary == CI Bug Log - changes from CI_DRM_8046 -> Patchwork_16784 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/index.html Known issues ------------ Here are the changes found in Patchwork_16784 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_wait@basic-await-all: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([CI#94] / [i915#402]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/fi-tgl-y/igt@gem_wait@basic-await-all.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/fi-tgl-y/igt@gem_wait@basic-await-all.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [FAIL][3] ([CI#94]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@kms_addfb_basic@addfb25-modifier-no-flag: - fi-tgl-y: [DMESG-WARN][5] ([CI#94] / [i915#402]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/fi-tgl-y/igt@kms_addfb_basic@addfb25-modifier-no-flag.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/fi-tgl-y/igt@kms_addfb_basic@addfb25-modifier-no-flag.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][7] ([fdo#111096] / [i915#323]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Warnings #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-guc: [FAIL][9] ([i915#704]) -> [SKIP][10] ([fdo#109271]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704 Participating hosts (43 -> 44) ------------------------------ Additional (7): fi-bdw-5557u fi-bwr-2160 fi-ilk-650 fi-snb-2520m fi-gdg-551 fi-bsw-kefka fi-snb-2600 Missing (6): fi-ilk-m540 fi-byt-squawks fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8046 -> Patchwork_16784 CI-20190529: 20190529 CI_DRM_8046: be13ba469987146d8e75f7c07103c0a087a3b520 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5483: 1707153df224ffb6333c6c660a792b7f334eb3d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16784: 56c69a1c0711155721a1bbd48dbce158ea85a436 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 56c69a1c0711 drm/i915: HDCP: fix Ri prime check done during link check == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: HDCP: fix Ri prime check done during link check 2020-02-29 10:39 [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta ` (2 preceding siblings ...) 2020-03-02 19:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-03-03 8:12 ` Patchwork 2020-03-03 9:33 ` [Intel-gfx] [PATCH] " Ramalingam C 4 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-03-03 8:12 UTC (permalink / raw) To: Oliver Barta; +Cc: intel-gfx == Series Details == Series: drm/i915: HDCP: fix Ri prime check done during link check URL : https://patchwork.freedesktop.org/series/74152/ State : success == Summary == CI Bug Log - changes from CI_DRM_8046_full -> Patchwork_16784_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16784_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb4/igt@gem_exec_balancer@smoke.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb5/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([i915#677]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb6/igt@gem_exec_schedule@pi-common-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb2/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +7 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb6/igt@gem_exec_schedule@wide-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-apl: [PASS][7] -> [FAIL][8] ([i915#644]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-apl3/igt@gem_ppgtt@flink-and-close-vma-leak.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-apl1/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-apl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-dpms: - shard-skl: [PASS][13] -> [FAIL][14] ([i915#54]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-dpms.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-dpms.html * igt@kms_flip@plain-flip-ts-check-interruptible: - shard-skl: [PASS][15] -> [FAIL][16] ([i915#34]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible.html * igt@kms_hdr@bpc-switch: - shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl8/igt@kms_hdr@bpc-switch.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl6/igt@kms_hdr@bpc-switch.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [i915#265]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [PASS][23] -> [FAIL][24] ([i915#899]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-glk3/igt@kms_plane_lowres@pipe-a-tiling-x.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-glk8/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +5 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#112080]) +11 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb8/igt@perf_pmu@busy-no-semaphores-vcs1.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109276]) +21 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb2/igt@prime_busy@hang-bsd2.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb8/igt@prime_busy@hang-bsd2.html #### Possible fixes #### * igt@gem_ctx_isolation@vcs1-dirty-create: - shard-iclb: [SKIP][31] ([fdo#112080]) -> [PASS][32] +10 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-create.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html * igt@gem_exec_schedule@implicit-read-write-bsd1: - shard-iclb: [SKIP][33] ([fdo#109276] / [i915#677]) -> [PASS][34] +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb6/igt@gem_exec_schedule@implicit-read-write-bsd1.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html * igt@gem_exec_schedule@implicit-write-read-bsd: - shard-iclb: [SKIP][35] ([i915#677]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb4/igt@gem_exec_schedule@implicit-write-read-bsd.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb8/igt@gem_exec_schedule@implicit-write-read-bsd.html * igt@gem_exec_schedule@independent-bsd2: - shard-iclb: [SKIP][37] ([fdo#109276]) -> [PASS][38] +11 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb3/igt@gem_exec_schedule@independent-bsd2.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb4/igt@gem_exec_schedule@independent-bsd2.html * igt@gem_exec_schedule@reorder-wide-bsd: - shard-iclb: [SKIP][39] ([fdo#112146]) -> [PASS][40] +6 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb2/igt@gem_exec_schedule@reorder-wide-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html * igt@gem_exec_whisper@basic-queues-forked: - shard-apl: [INCOMPLETE][41] ([fdo#103927]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-apl4/igt@gem_exec_whisper@basic-queues-forked.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-apl8/igt@gem_exec_whisper@basic-queues-forked.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-tglb: [FAIL][43] ([i915#644]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-tglb6/igt@gem_ppgtt@flink-and-close-vma-leak.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-tglb8/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][45] ([i915#716]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-glk9/igt@gen9_exec_parse@allowed-all.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-glk7/igt@gen9_exec_parse@allowed-all.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-kbl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-iclb: [FAIL][49] ([IGT#5]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb2/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb1/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][53] ([i915#79]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc: - shard-snb: [SKIP][55] ([fdo#109271]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render: - shard-tglb: [SKIP][57] ([i915#668]) -> [PASS][58] +6 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-tglb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-tglb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [FAIL][59] ([i915#1188]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl3/igt@kms_hdr@bpc-switch-suspend.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [FAIL][61] ([fdo#108145]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_basic: - shard-iclb: [SKIP][63] ([fdo#109441]) -> [PASS][64] +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-iclb6/igt@kms_psr@psr2_basic.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-iclb2/igt@kms_psr@psr2_basic.html * igt@kms_setmode@basic: - shard-apl: [FAIL][65] ([i915#31]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-apl3/igt@kms_setmode@basic.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-apl8/igt@kms_setmode@basic.html - shard-kbl: [FAIL][67] ([i915#31]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-kbl7/igt@kms_setmode@basic.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-kbl2/igt@kms_setmode@basic.html * igt@perf@oa-exponents: - shard-glk: [FAIL][69] ([i915#84]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-glk5/igt@perf@oa-exponents.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-glk1/igt@perf@oa-exponents.html #### Warnings #### * igt@i915_suspend@fence-restore-untiled: - shard-kbl: [INCOMPLETE][71] ([fdo#103665]) -> [DMESG-WARN][72] ([i915#180]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8046/shard-kbl1/igt@i915_suspend@fence-restore-untiled.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/shard-kbl7/igt@i915_suspend@fence-restore-untiled.html [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#84]: https://gitlab.freedesktop.org/drm/intel/issues/84 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8046 -> Patchwork_16784 CI-20190529: 20190529 CI_DRM_8046: be13ba469987146d8e75f7c07103c0a087a3b520 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5483: 1707153df224ffb6333c6c660a792b7f334eb3d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16784: 56c69a1c0711155721a1bbd48dbce158ea85a436 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16784/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check 2020-02-29 10:39 [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta ` (3 preceding siblings ...) 2020-03-03 8:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-03-03 9:33 ` Ramalingam C 2020-03-05 8:14 ` Oliver Barta 4 siblings, 1 reply; 7+ messages in thread From: Ramalingam C @ 2020-03-03 9:33 UTC (permalink / raw) To: Oliver Barta Cc: Daniel Vetter, intel-gfx, Sean Paul, Oliver Barta, Ravisankar Madasamy On 2020-02-29 at 11:39:22 +0100, Oliver Barta wrote: > From: Oliver Barta <oliver.barta@aptiv.com> > > The check was always succeeding even in case of a mismatch due to the > HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. > > Signed-off-by: Oliver Barta <oliver.barta@aptiv.com> Looks good to me. But we need to do same on intel_hdcp_auth(), where we check the R0 on authentication. -Ram > Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") > --- > Submitted before as part of patch series > https://patchwork.freedesktop.org/series/73961/ > For some reason the versioning got messed up. > I marked the patch series as superseded and I'm > starting all over. Sorry for spamming you. > > drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > index 0ac9bdfbc094..ac4276157182 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -1536,7 +1536,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port) > intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg); > > /* Wait for Ri prime match */ > - if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) & > + if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, > + port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) == > (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) { > DRM_ERROR("Ri' mismatch detected, link check failed (%x)\n", > intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port))); > -- > 2.20.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check 2020-03-03 9:33 ` [Intel-gfx] [PATCH] " Ramalingam C @ 2020-03-05 8:14 ` Oliver Barta 0 siblings, 0 replies; 7+ messages in thread From: Oliver Barta @ 2020-03-05 8:14 UTC (permalink / raw) To: Ramalingam C Cc: Daniel Vetter, intel-gfx, Sean Paul, Oliver Barta, Ravisankar Madasamy On Tue, Mar 3, 2020 at 10:33 AM Ramalingam C <ramalingam.c@intel.com> wrote: > > On 2020-02-29 at 11:39:22 +0100, Oliver Barta wrote: > > From: Oliver Barta <oliver.barta@aptiv.com> > > > > The check was always succeeding even in case of a mismatch due to the > > HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. > > > > Signed-off-by: Oliver Barta <oliver.barta@aptiv.com> > Looks good to me. But we need to do same on intel_hdcp_auth(), where we > check the R0 on authentication. > > -Ram Thanks for review and your suggestion. I have created a separate patch as the problem is a little bit different in intel_hdcp_auth(). See https://patchwork.freedesktop.org/series/74271/ Oliver > > Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") > > --- > > Submitted before as part of patch series > > https://patchwork.freedesktop.org/series/73961/ > > For some reason the versioning got messed up. > > I marked the patch series as superseded and I'm > > starting all over. Sorry for spamming you. > > > > drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c > > index 0ac9bdfbc094..ac4276157182 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > > @@ -1536,7 +1536,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port) > > intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg); > > > > /* Wait for Ri prime match */ > > - if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) & > > + if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, > > + port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) == > > (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) { > > DRM_ERROR("Ri' mismatch detected, link check failed (%x)\n", > > intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port))); > > -- > > 2.20.1 > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-05 13:55 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-29 10:39 [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta 2020-03-02 18:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2020-03-02 19:11 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2020-03-02 19:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-03-03 8:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-03-03 9:33 ` [Intel-gfx] [PATCH] " Ramalingam C 2020-03-05 8:14 ` Oliver Barta
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.