From: Paul Cercueil <paul@crapouillou.net> To: "H. Nikolaus Schaller" <hns@goldelico.com> Cc: Paul Boddie <paul@boddie.org.uk>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ralf Baechle <ralf@linux-mips.org>, Paul Burton <paulburton@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Andi Kleen <ak@linux.intel.com>, Krzysztof Kozlowski <krzk@kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, "Eric W. Biederman" <ebiederm@xmission.com>, Miquel Raynal <miquel.raynal@bootlin.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller Date: Mon, 02 Mar 2020 16:27:33 -0300 [thread overview] Message-ID: <1583177253.3.5@crapouillou.net> (raw) In-Reply-To: <04b485165f38744816a0446e95150cafdeb716ee.1582913973.git.hns@goldelico.com> Hi Nikolaus, Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > From: Paul Boddie <paul@boddie.org.uk> > > A specialisation of the generic Synopsys HDMI driver is employed for > JZ4780 > HDMI support. This requires a new driver, plus device tree and > configuration > modifications. > > Signed-off-by: Paul Boddie <paul@boddie.org.uk> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 32 > ++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi > b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index f928329b034b..391d4e1efd35 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -433,4 +433,36 @@ > > status = "disabled"; > }; > + > + hdmi: hdmi@10180000 { > + compatible = "ingenic,jz4780-dw-hdmi"; > + reg = <0x10180000 0x8000>; > + reg-io-width = <4>; > + > + clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>; > + clock-names = "isfr" , "iahb"; > + > + assigned-clocks = <&cgu JZ4780_CLK_HDMI>; > + assigned-clock-rates = <27000000>; I *think* this should go to the board file. > + > + interrupt-parent = <&intc>; > + interrupts = <3>; > + > + /* ddc-i2c-bus = <&i2c4>; */ > + > + status = "disabled"; > + }; > + > + lcd: lcd@13050000 { The node name should be 'lcd-controller'. > + compatible = "ingenic,jz4740-lcd"; The JZ4780's LCD controller is much newer than the JZ4740 one, so even if it works with the "ingenic,jz4740-lcd" compatible string, you want it as a fallback. So this should be: compatible = "ingenic,jz4780-lcd", "ingenic,jz4740-lcd". That means the YAML should be updated too. -Paul > + reg = <0x13050000 0x1800>; > + > + clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>; > + clock-names = "lcd", "lcd_pclk"; > + > + interrupt-parent = <&intc>; > + interrupts = <31>; > + > + status = "disabled"; > + }; > }; > -- > 2.23.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net> To: "H. Nikolaus Schaller" <hns@goldelico.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Paul Boddie <paul@boddie.org.uk>, Geert Uytterhoeven <geert+renesas@glider.be>, Paul Burton <paulburton@kernel.org>, linux-gpio@vger.kernel.org, David Airlie <airlied@linux.ie>, kernel@pyra-handheld.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips@vger.kernel.org, Andi Kleen <ak@linux.intel.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Miquel Raynal <miquel.raynal@bootlin.com>, letux-kernel@openphoenux.org, "Eric W. Biederman" <ebiederm@xmission.com> Subject: Re: [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller Date: Mon, 02 Mar 2020 16:27:33 -0300 [thread overview] Message-ID: <1583177253.3.5@crapouillou.net> (raw) In-Reply-To: <04b485165f38744816a0446e95150cafdeb716ee.1582913973.git.hns@goldelico.com> Hi Nikolaus, Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller <hns@goldelico.com> a écrit : > From: Paul Boddie <paul@boddie.org.uk> > > A specialisation of the generic Synopsys HDMI driver is employed for > JZ4780 > HDMI support. This requires a new driver, plus device tree and > configuration > modifications. > > Signed-off-by: Paul Boddie <paul@boddie.org.uk> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 32 > ++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi > b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index f928329b034b..391d4e1efd35 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -433,4 +433,36 @@ > > status = "disabled"; > }; > + > + hdmi: hdmi@10180000 { > + compatible = "ingenic,jz4780-dw-hdmi"; > + reg = <0x10180000 0x8000>; > + reg-io-width = <4>; > + > + clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>; > + clock-names = "isfr" , "iahb"; > + > + assigned-clocks = <&cgu JZ4780_CLK_HDMI>; > + assigned-clock-rates = <27000000>; I *think* this should go to the board file. > + > + interrupt-parent = <&intc>; > + interrupts = <3>; > + > + /* ddc-i2c-bus = <&i2c4>; */ > + > + status = "disabled"; > + }; > + > + lcd: lcd@13050000 { The node name should be 'lcd-controller'. > + compatible = "ingenic,jz4740-lcd"; The JZ4780's LCD controller is much newer than the JZ4740 one, so even if it works with the "ingenic,jz4740-lcd" compatible string, you want it as a fallback. So this should be: compatible = "ingenic,jz4780-lcd", "ingenic,jz4740-lcd". That means the YAML should be updated too. -Paul > + reg = <0x13050000 0x1800>; > + > + clocks = <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>; > + clock-names = "lcd", "lcd_pclk"; > + > + interrupt-parent = <&intc>; > + interrupts = <31>; > + > + status = "disabled"; > + }; > }; > -- > 2.23.0 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-02 19:28 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-28 18:19 [RFC v2 0/8] MIPS: CI20: add HDMI out support H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 1/8] dt-bindings: display: add ingenic-jz4780-lcd DT Schema H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-02-28 18:42 ` Sam Ravnborg 2020-02-28 18:42 ` Sam Ravnborg 2020-02-28 18:51 ` H. Nikolaus Schaller 2020-03-02 18:55 ` Rob Herring 2020-03-02 18:55 ` Rob Herring 2020-03-02 19:10 ` Paul Cercueil 2020-03-02 19:10 ` Paul Cercueil 2020-03-03 7:21 ` H. Nikolaus Schaller 2020-03-03 7:21 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 2/8] dt-bindings: display: add ingenic-jz4780-hdmi " H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-03-02 19:19 ` Paul Cercueil 2020-03-02 19:19 ` Paul Cercueil 2020-03-03 7:22 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 3/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-03-02 19:21 ` Paul Cercueil 2020-03-02 19:21 ` Paul Cercueil 2020-03-03 7:22 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 4/8] drm: ingenic: add jz4780 Synopsys HDMI driver H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 5/8] pinctrl: ingenic: add hdmi-ddc pin control group H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-02-28 22:05 ` Linus Walleij 2020-02-28 22:05 ` Linus Walleij 2020-02-29 6:41 ` H. Nikolaus Schaller 2020-02-29 6:41 ` H. Nikolaus Schaller 2020-03-02 8:42 ` Linus Walleij 2020-03-02 8:42 ` Linus Walleij 2020-02-28 18:19 ` [RFC v2 6/8] MIPS: DTS: jz4780: account for Synopsys HDMI driver and LCD controller H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-03-02 19:27 ` Paul Cercueil [this message] 2020-03-02 19:27 ` Paul Cercueil 2020-03-03 7:24 ` H. Nikolaus Schaller 2020-03-11 12:43 ` H. Nikolaus Schaller 2020-03-11 12:43 ` H. Nikolaus Schaller 2020-03-11 12:43 ` H. Nikolaus Schaller 2020-03-11 13:20 ` Paul Cercueil 2020-03-11 13:20 ` Paul Cercueil 2020-03-11 13:20 ` Paul Cercueil 2020-03-11 13:30 ` H. Nikolaus Schaller 2020-03-11 13:30 ` H. Nikolaus Schaller 2020-03-11 13:30 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 7/8] MIPS: DTS: CI20: add HDMI setup H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller 2020-02-28 18:19 ` [RFC v2 8/8] MIPS: CI20: defconfig: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller 2020-02-28 18:19 ` H. Nikolaus Schaller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1583177253.3.5@crapouillou.net \ --to=paul@crapouillou.net \ --cc=airlied@linux.ie \ --cc=ak@linux.intel.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=ebiederm@xmission.com \ --cc=geert+renesas@glider.be \ --cc=hns@goldelico.com \ --cc=kernel@pyra-handheld.com \ --cc=krzk@kernel.org \ --cc=letux-kernel@openphoenux.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=miquel.raynal@bootlin.com \ --cc=paul@boddie.org.uk \ --cc=paulburton@kernel.org \ --cc=ralf@linux-mips.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.