* [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off @ 2020-03-04 12:51 Anshuman Gupta 2020-03-04 13:33 ` Jani Nikula ` (8 more replies) 0 siblings, 9 replies; 18+ messages in thread From: Anshuman Gupta @ 2020-03-04 12:51 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Few edp panels like Sharp is triggering short and long hpd pulse after panel is getting powered off. Currently driver is already ignoring long pulse for eDP panel but in order to process the short pulse, it turns on the VDD which requires panel power_cycle_delay + panel_power_on_delay these delay on Sharp panel introduced the responsiveness overhead of 800ms in the modeset sequence and as well is in suspend sequence. Ignoring any short pulse once panel is powered off. FIXME: It requires to wait for panel_power_off_delay in order to check the panel status, as panel triggers short pulse immediately after writing PP_OFF to PP_CTRL register. Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 0a417cd2af2b..93de015f5322 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -6763,10 +6763,24 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { .destroy = intel_dp_encoder_destroy, }; +static bool is_edp_powered_off(struct intel_dp *intel_dp) +{ + intel_wakeref_t wakeref; + bool powerd_off = false; + + if (intel_dp_is_edp(intel_dp)) { + with_pps_lock(intel_dp, wakeref) + powerd_off = !edp_have_panel_power(intel_dp); + } + + return powerd_off; +} + enum irqreturn intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) { struct intel_dp *intel_dp = &intel_dig_port->dp; + struct drm_i915_private *i915 = dp_to_i915(intel_dp); if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { /* @@ -6810,6 +6824,11 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) if (!intel_dp->is_mst) { bool handled; + if (is_edp_powered_off(intel_dp)) { + drm_info(&i915->drm, "edp panel is off, ignoring the short pulse\n"); + return IRQ_HANDLED; + } + handled = intel_dp_short_pulse(intel_dp); if (!handled) -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta @ 2020-03-04 13:33 ` Jani Nikula 2020-03-04 18:45 ` Ville Syrjälä 2020-03-04 17:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork ` (7 subsequent siblings) 8 siblings, 1 reply; 18+ messages in thread From: Jani Nikula @ 2020-03-04 13:33 UTC (permalink / raw) To: Anshuman Gupta, intel-gfx On Wed, 04 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > Few edp panels like Sharp is triggering short and long > hpd pulse after panel is getting powered off. > Currently driver is already ignoring long pulse for eDP > panel but in order to process the short pulse, it turns on > the VDD which requires panel power_cycle_delay + panel_power_on_delay > these delay on Sharp panel introduced the responsiveness overhead > of 800ms in the modeset sequence and as well is in suspend > sequence. > Ignoring any short pulse once panel is powered off. > > FIXME: It requires to wait for panel_power_off_delay in order > to check the panel status, as panel triggers short pulse immediately > after writing PP_OFF to PP_CTRL register. > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 0a417cd2af2b..93de015f5322 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6763,10 +6763,24 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > .destroy = intel_dp_encoder_destroy, > }; > > +static bool is_edp_powered_off(struct intel_dp *intel_dp) We have a number of existing edp_ prefixed functions, with intel_ prefixed wrappers. Please make this intel_edp_have_panel_power(). Early return false for non-eDP. Also handle intel_dp_is_edp() in the caller so it's clear what's being done. > +{ > + intel_wakeref_t wakeref; > + bool powerd_off = false; > + > + if (intel_dp_is_edp(intel_dp)) { > + with_pps_lock(intel_dp, wakeref) > + powerd_off = !edp_have_panel_power(intel_dp); > + } > + > + return powerd_off; > +} > + > enum irqreturn > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > { > struct intel_dp *intel_dp = &intel_dig_port->dp; > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > /* > @@ -6810,6 +6824,11 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > if (!intel_dp->is_mst) { > bool handled; > > + if (is_edp_powered_off(intel_dp)) { I would move this to the beginning of the function in the same if statement as the long_hpd handling: if (intel_dp_is_edp(intel_dp) && (long_hpd || !intel_edp_have_panel_power(intel_dp))) But makes me wonder if that should be changed to ignore all hpd from eDP if there's no panel power nor vdd. Ville? > + drm_info(&i915->drm, "edp panel is off, ignoring the short pulse\n"); drm_dbg_kms() will be enough. > + return IRQ_HANDLED; > + } > + > handled = intel_dp_short_pulse(intel_dp); > > if (!handled) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 13:33 ` Jani Nikula @ 2020-03-04 18:45 ` Ville Syrjälä 2020-03-05 3:17 ` Anshuman Gupta 2020-03-13 18:47 ` Anshuman Gupta 0 siblings, 2 replies; 18+ messages in thread From: Ville Syrjälä @ 2020-03-04 18:45 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Wed, Mar 04, 2020 at 03:33:03PM +0200, Jani Nikula wrote: > On Wed, 04 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > Few edp panels like Sharp is triggering short and long > > hpd pulse after panel is getting powered off. > > Currently driver is already ignoring long pulse for eDP > > panel but in order to process the short pulse, it turns on > > the VDD which requires panel power_cycle_delay + panel_power_on_delay > > these delay on Sharp panel introduced the responsiveness overhead > > of 800ms in the modeset sequence and as well is in suspend > > sequence. > > Ignoring any short pulse once panel is powered off. > > > > FIXME: It requires to wait for panel_power_off_delay in order > > to check the panel status, as panel triggers short pulse immediately > > after writing PP_OFF to PP_CTRL register. > > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > > index 0a417cd2af2b..93de015f5322 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -6763,10 +6763,24 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > > .destroy = intel_dp_encoder_destroy, > > }; > > > > +static bool is_edp_powered_off(struct intel_dp *intel_dp) > > We have a number of existing edp_ prefixed functions, with intel_ > prefixed wrappers. Please make this intel_edp_have_panel_power(). Early > return false for non-eDP. > > Also handle intel_dp_is_edp() in the caller so it's clear what's being > done. > > > +{ > > + intel_wakeref_t wakeref; > > + bool powerd_off = false; > > + > > + if (intel_dp_is_edp(intel_dp)) { > > + with_pps_lock(intel_dp, wakeref) > > + powerd_off = !edp_have_panel_power(intel_dp); > > + } > > + > > + return powerd_off; > > +} > > + > > enum irqreturn > > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > { > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > > > if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > > /* > > @@ -6810,6 +6824,11 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > if (!intel_dp->is_mst) { > > bool handled; > > > > + if (is_edp_powered_off(intel_dp)) { > > I would move this to the beginning of the function in the same if > statement as the long_hpd handling: > > if (intel_dp_is_edp(intel_dp) && > (long_hpd || !intel_edp_have_panel_power(intel_dp))) > > But makes me wonder if that should be changed to ignore all hpd from eDP > if there's no panel power nor vdd. Ville? From what I've seen for eDP no vdd implies HPD being deasserted, hence there is no way to signal short HPDs after vdd has been removed (apart from some glitchy HPD lines I guess). This case sounds like there could be a glitch of some sort on the HPD line while it is being deasserted and that triggers a short HPD. Either that or the panel is just stupid. Anyways, vdd and panel power are the same thing from the panel POV, so checking both would make sense. I can't actually imagine this even working correctly otherwise, unless there is an actual bug in our code and the spurious HPD only happens when we disable vdd via the state machine rather than the override bit. So which is it? > > > + drm_info(&i915->drm, "edp panel is off, ignoring the short pulse\n"); > > drm_dbg_kms() will be enough. > > > + return IRQ_HANDLED; > > + } > > + > > handled = intel_dp_short_pulse(intel_dp); > > > > if (!handled) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 18:45 ` Ville Syrjälä @ 2020-03-05 3:17 ` Anshuman Gupta 2020-03-09 8:50 ` Anshuman Gupta 2020-03-13 18:47 ` Anshuman Gupta 1 sibling, 1 reply; 18+ messages in thread From: Anshuman Gupta @ 2020-03-05 3:17 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx On 2020-03-04 at 20:45:20 +0200, Ville Syrjälä wrote: > On Wed, Mar 04, 2020 at 03:33:03PM +0200, Jani Nikula wrote: > > On Wed, 04 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > > Few edp panels like Sharp is triggering short and long > > > hpd pulse after panel is getting powered off. > > > Currently driver is already ignoring long pulse for eDP > > > panel but in order to process the short pulse, it turns on > > > the VDD which requires panel power_cycle_delay + panel_power_on_delay > > > these delay on Sharp panel introduced the responsiveness overhead > > > of 800ms in the modeset sequence and as well is in suspend > > > sequence. > > > Ignoring any short pulse once panel is powered off. > > > > > > FIXME: It requires to wait for panel_power_off_delay in order > > > to check the panel status, as panel triggers short pulse immediately > > > after writing PP_OFF to PP_CTRL register. > > > > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp.c | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > > > index 0a417cd2af2b..93de015f5322 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > @@ -6763,10 +6763,24 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > > > .destroy = intel_dp_encoder_destroy, > > > }; > > > > > > +static bool is_edp_powered_off(struct intel_dp *intel_dp) > > > > We have a number of existing edp_ prefixed functions, with intel_ > > prefixed wrappers. Please make this intel_edp_have_panel_power(). Early > > return false for non-eDP. > > > > Also handle intel_dp_is_edp() in the caller so it's clear what's being > > done. > > > > > +{ > > > + intel_wakeref_t wakeref; > > > + bool powerd_off = false; > > > + > > > + if (intel_dp_is_edp(intel_dp)) { > > > + with_pps_lock(intel_dp, wakeref) > > > + powerd_off = !edp_have_panel_power(intel_dp); > > > + } > > > + > > > + return powerd_off; > > > +} > > > + > > > enum irqreturn > > > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > > { > > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > > > > > if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > > > /* > > > @@ -6810,6 +6824,11 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > > if (!intel_dp->is_mst) { > > > bool handled; > > > > > > + if (is_edp_powered_off(intel_dp)) { > > > > I would move this to the beginning of the function in the same if > > statement as the long_hpd handling: > > > > if (intel_dp_is_edp(intel_dp) && > > (long_hpd || !intel_edp_have_panel_power(intel_dp))) > > > > But makes me wonder if that should be changed to ignore all hpd from eDP > > if there's no panel power nor vdd. Ville? > > From what I've seen for eDP no vdd implies HPD being deasserted, hence > there is no way to signal short HPDs after vdd has been removed (apart > from some glitchy HPD lines I guess). This case sounds like there could > be a glitch of some sort on the HPD line while it is being deasserted > and that triggers a short HPD. Either that or the panel is just stupid. Hi Ville , I have observed that, similar panel doesn't trigger any short/long pulse on ICL but on TGL it triggers both short and long pulse. Thanks, Anshuman. > > Anyways, vdd and panel power are the same thing from the panel POV, so > checking both would make sense. I can't actually imagine this even > working correctly otherwise, unless there is an actual bug in our code > and the spurious HPD only happens when we disable vdd via the state > machine rather than the override bit. So which is it? > > > > > > + drm_info(&i915->drm, "edp panel is off, ignoring the short pulse\n"); > > > > drm_dbg_kms() will be enough. > > > > > + return IRQ_HANDLED; > > > + } > > > + > > > handled = intel_dp_short_pulse(intel_dp); > > > > > > if (!handled) > > > > -- > > Jani Nikula, Intel Open Source Graphics Center > > -- > Ville Syrjälä > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-05 3:17 ` Anshuman Gupta @ 2020-03-09 8:50 ` Anshuman Gupta 0 siblings, 0 replies; 18+ messages in thread From: Anshuman Gupta @ 2020-03-09 8:50 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Nikula, Jani, intel-gfx On 2020-03-05 at 08:47:42 +0530, Anshuman Gupta wrote: > On 2020-03-04 at 20:45:20 +0200, Ville Syrjälä wrote: > > On Wed, Mar 04, 2020 at 03:33:03PM +0200, Jani Nikula wrote: > > > On Wed, 04 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > > > Few edp panels like Sharp is triggering short and long > > > > hpd pulse after panel is getting powered off. > > > > Currently driver is already ignoring long pulse for eDP > > > > panel but in order to process the short pulse, it turns on > > > > the VDD which requires panel power_cycle_delay + panel_power_on_delay > > > > these delay on Sharp panel introduced the responsiveness overhead > > > > of 800ms in the modeset sequence and as well is in suspend > > > > sequence. > > > > Ignoring any short pulse once panel is powered off. > > > > > > > > FIXME: It requires to wait for panel_power_off_delay in order > > > > to check the panel status, as panel triggers short pulse immediately > > > > after writing PP_OFF to PP_CTRL register. > > > > > > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_dp.c | 19 +++++++++++++++++++ > > > > 1 file changed, 19 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > > > > index 0a417cd2af2b..93de015f5322 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > > @@ -6763,10 +6763,24 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > > > > .destroy = intel_dp_encoder_destroy, > > > > }; > > > > > > > > +static bool is_edp_powered_off(struct intel_dp *intel_dp) > > > > > > We have a number of existing edp_ prefixed functions, with intel_ > > > prefixed wrappers. Please make this intel_edp_have_panel_power(). Early > > > return false for non-eDP. > > > > > > Also handle intel_dp_is_edp() in the caller so it's clear what's being > > > done. > > > > > > > +{ > > > > + intel_wakeref_t wakeref; > > > > + bool powerd_off = false; > > > > + > > > > + if (intel_dp_is_edp(intel_dp)) { > > > > + with_pps_lock(intel_dp, wakeref) > > > > + powerd_off = !edp_have_panel_power(intel_dp); > > > > + } > > > > + > > > > + return powerd_off; > > > > +} > > > > + > > > > enum irqreturn > > > > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > > > { > > > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > > > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > > > > > > > if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > > > > /* > > > > @@ -6810,6 +6824,11 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > > > if (!intel_dp->is_mst) { > > > > bool handled; > > > > > > > > + if (is_edp_powered_off(intel_dp)) { > > > > > > I would move this to the beginning of the function in the same if > > > statement as the long_hpd handling: > > > > > > if (intel_dp_is_edp(intel_dp) && > > > (long_hpd || !intel_edp_have_panel_power(intel_dp))) > > > > > > But makes me wonder if that should be changed to ignore all hpd from eDP > > > if there's no panel power nor vdd. Ville? > > > > From what I've seen for eDP no vdd implies HPD being deasserted, hence > > there is no way to signal short HPDs after vdd has been removed (apart > > from some glitchy HPD lines I guess). This case sounds like there could > > be a glitch of some sort on the HPD line while it is being deasserted > > and that triggers a short HPD. Either that or the panel is just stupid. > Hi Ville , > I have observed that, similar panel doesn't trigger any short/long pulse on ICL but on TGL > it triggers both short and long pulse. > Thanks, > Anshuman. > > > > Anyways, vdd and panel power are the same thing from the panel POV, so > > checking both would make sense. I can't actually imagine this even > > working correctly otherwise, unless there is an actual bug in our code > > and the spurious HPD only happens when we disable vdd via the state > > machine rather than the override bit. So which is it? Hi Ville/Jani, AFAIU for v2 preparation i should ignore the entire HPD if there is no eDP power nor vdd at in intel_hpd_irq_handler(), or it is something additional would be required. Thanks, Anshuman. > > > > > > > > > + drm_info(&i915->drm, "edp panel is off, ignoring the short pulse\n"); > > > > > > drm_dbg_kms() will be enough. > > > > > > > + return IRQ_HANDLED; > > > > + } > > > > + > > > > handled = intel_dp_short_pulse(intel_dp); > > > > > > > > if (!handled) > > > > > > -- > > > Jani Nikula, Intel Open Source Graphics Center > > > > -- > > Ville Syrjälä > > Intel > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 18:45 ` Ville Syrjälä 2020-03-05 3:17 ` Anshuman Gupta @ 2020-03-13 18:47 ` Anshuman Gupta 1 sibling, 0 replies; 18+ messages in thread From: Anshuman Gupta @ 2020-03-13 18:47 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx On 2020-03-04 at 20:45:20 +0200, Ville Syrjälä wrote: > On Wed, Mar 04, 2020 at 03:33:03PM +0200, Jani Nikula wrote: > > On Wed, 04 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > > Few edp panels like Sharp is triggering short and long > > > hpd pulse after panel is getting powered off. > > > Currently driver is already ignoring long pulse for eDP > > > panel but in order to process the short pulse, it turns on > > > the VDD which requires panel power_cycle_delay + panel_power_on_delay > > > these delay on Sharp panel introduced the responsiveness overhead > > > of 800ms in the modeset sequence and as well is in suspend > > > sequence. > > > Ignoring any short pulse once panel is powered off. > > > > > > FIXME: It requires to wait for panel_power_off_delay in order > > > to check the panel status, as panel triggers short pulse immediately > > > after writing PP_OFF to PP_CTRL register. > > > > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp.c | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > > > index 0a417cd2af2b..93de015f5322 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > @@ -6763,10 +6763,24 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > > > .destroy = intel_dp_encoder_destroy, > > > }; > > > > > > +static bool is_edp_powered_off(struct intel_dp *intel_dp) > > > > We have a number of existing edp_ prefixed functions, with intel_ > > prefixed wrappers. Please make this intel_edp_have_panel_power(). Early > > return false for non-eDP. > > > > Also handle intel_dp_is_edp() in the caller so it's clear what's being > > done. > > > > > +{ > > > + intel_wakeref_t wakeref; > > > + bool powerd_off = false; > > > + > > > + if (intel_dp_is_edp(intel_dp)) { > > > + with_pps_lock(intel_dp, wakeref) > > > + powerd_off = !edp_have_panel_power(intel_dp); > > > + } > > > + > > > + return powerd_off; > > > +} > > > + > > > enum irqreturn > > > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > > { > > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > > > > > if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > > > /* > > > @@ -6810,6 +6824,11 @@ intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > > > if (!intel_dp->is_mst) { > > > bool handled; > > > > > > + if (is_edp_powered_off(intel_dp)) { > > > > I would move this to the beginning of the function in the same if > > statement as the long_hpd handling: > > > > if (intel_dp_is_edp(intel_dp) && > > (long_hpd || !intel_edp_have_panel_power(intel_dp))) > > > > But makes me wonder if that should be changed to ignore all hpd from eDP > > if there's no panel power nor vdd. Ville? > > From what I've seen for eDP no vdd implies HPD being deasserted, hence > there is no way to signal short HPDs after vdd has been removed (apart > from some glitchy HPD lines I guess). This case sounds like there could > be a glitch of some sort on the HPD line while it is being deasserted > and that triggers a short HPD. Either that or the panel is just stupid. > > Anyways, vdd and panel power are the same thing from the panel POV, so > checking both would make sense. I can't actually imagine this even > working correctly otherwise, unless there is an actual bug in our code > and the spurious HPD only happens when we disable vdd via the state > machine rather than the override bit. So which is it? It disable vdd via override bit, as furthter investigation i tried to remove the vdd off sequence from edp_panel_off, to check if there is any spurious hpd, but there was spurious HPD even with VDD on, so this looks the issue from panel side or some HPD line glich. Thanks, Anshuman Gupta. > > > > > > + drm_info(&i915->drm, "edp panel is off, ignoring the short pulse\n"); > > > > drm_dbg_kms() will be enough. > > > > > + return IRQ_HANDLED; > > > + } > > > + > > > handled = intel_dp_short_pulse(intel_dp); > > > > > > if (!handled) > > > > -- > > Jani Nikula, Intel Open Source Graphics Center > > -- > Ville Syrjälä > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta 2020-03-04 13:33 ` Jani Nikula @ 2020-03-04 17:25 ` Patchwork 2020-03-04 17:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (6 subsequent siblings) 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-04 17:25 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off URL : https://patchwork.freedesktop.org/series/74265/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq' not described in 'intel_shared_dpll_funcs' _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta 2020-03-04 13:33 ` Jani Nikula 2020-03-04 17:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork @ 2020-03-04 17:48 ` Patchwork 2020-03-05 16:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork ` (5 subsequent siblings) 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-04 17:48 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8066 -> Patchwork_16817 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/index.html Known issues ------------ Here are the changes found in Patchwork_16817 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_getparams_basic@basic-subslice-total: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([CI#94] / [i915#402]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html * igt@kms_frontbuffer_tracking@basic: - fi-hsw-peppy: [PASS][3] -> [DMESG-WARN][4] ([i915#44]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@i915_selftest@live@workarounds: - fi-icl-guc: [DMESG-FAIL][5] ([i915#922]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-icl-guc/igt@i915_selftest@live@workarounds.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/fi-icl-guc/igt@i915_selftest@live@workarounds.html * igt@prime_self_import@basic-llseek-bad: - fi-tgl-y: [DMESG-WARN][7] ([CI#94] / [i915#402]) -> [PASS][8] +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#44]: https://gitlab.freedesktop.org/drm/intel/issues/44 [i915#922]: https://gitlab.freedesktop.org/drm/intel/issues/922 Participating hosts (45 -> 42) ------------------------------ Additional (6): fi-bwr-2160 fi-kbl-7500u fi-cfl-8109u fi-skl-lmem fi-blb-e6850 fi-kbl-r Missing (9): fi-icl-1065g7 fi-bdw-5557u fi-tgl-dsi fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus fi-byt-clapper fi-skl-6600u Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8066 -> Patchwork_16817 CI-20190529: 20190529 CI_DRM_8066: 9e1454777a07902c85ce3febcc9648837a2224fd @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5491: d52794b426ae16630cc1e0354ae435ec98f6174b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16817: e394b1179ebcf458edc0cc1c9ddd081972b29021 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == e394b1179ebc drm/i915/edp: Ignore short pulse when panel powered off == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta ` (2 preceding siblings ...) 2020-03-04 17:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-03-05 16:05 ` Patchwork 2020-03-13 18:52 ` [Intel-gfx] [PATCH v2] " Anshuman Gupta ` (4 subsequent siblings) 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-05 16:05 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8066_full -> Patchwork_16817_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16817_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@busy-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +4 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@gem_busy@busy-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb6/igt@gem_busy@busy-vcs1.html * igt@gem_exec_async@concurrent-writes-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112146]) +2 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb3/igt@gem_exec_async@concurrent-writes-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@gem_exec_balancer@smoke.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb3/igt@gem_exec_balancer@smoke.html * igt@gem_exec_schedule@implicit-read-write-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb8/igt@gem_exec_schedule@implicit-read-write-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd.html * igt@gem_exec_schedule@implicit-write-read-bsd1: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276] / [i915#677]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@gem_exec_schedule@implicit-write-read-bsd1.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb6/igt@gem_exec_schedule@implicit-write-read-bsd1.html * igt@gem_exec_schedule@promotion-bsd1: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +6 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb3/igt@gem_exec_schedule@promotion-bsd1.html * igt@gem_workarounds@suspend-resume: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-apl4/igt@gem_workarounds@suspend-resume.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-apl4/igt@gem_workarounds@suspend-resume.html * igt@i915_pm_rpm@system-suspend-modeset: - shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#151] / [i915#69]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl5/igt@i915_pm_rpm@system-suspend-modeset.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl5/igt@i915_pm_rpm@system-suspend-modeset.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen: - shard-skl: [PASS][19] -> [FAIL][20] ([i915#54]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen.html * igt@kms_flip@dpms-off-confusion: - shard-kbl: [PASS][21] -> [INCOMPLETE][22] ([fdo#103665]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-kbl4/igt@kms_flip@dpms-off-confusion.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-kbl1/igt@kms_flip@dpms-off-confusion.html - shard-apl: [PASS][23] -> [INCOMPLETE][24] ([fdo#103927]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-apl2/igt@kms_flip@dpms-off-confusion.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-apl2/igt@kms_flip@dpms-off-confusion.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][25] -> [FAIL][26] ([i915#79]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend: - shard-skl: [PASS][27] -> [INCOMPLETE][28] ([i915#221]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl10/igt@kms_flip@flip-vs-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl10/igt@kms_flip@flip-vs-suspend.html * igt@kms_flip@plain-flip-ts-check-interruptible: - shard-skl: [PASS][29] -> [FAIL][30] ([i915#34]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [PASS][33] -> [FAIL][34] ([fdo#108145] / [i915#265]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-glk: [PASS][35] -> [FAIL][36] ([i915#899]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-glk1/igt@kms_plane_lowres@pipe-a-tiling-y.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-glk4/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html * igt@kms_setmode@basic: - shard-skl: [PASS][39] -> [FAIL][40] ([i915#31]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl9/igt@kms_setmode@basic.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl10/igt@kms_setmode@basic.html #### Possible fixes #### * igt@gem_busy@extended-parallel-vcs1: - shard-iclb: [SKIP][41] ([fdo#112080]) -> [PASS][42] +6 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb5/igt@gem_busy@extended-parallel-vcs1.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb2/igt@gem_busy@extended-parallel-vcs1.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [SKIP][43] ([i915#677]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb2/igt@gem_exec_schedule@pi-common-bsd.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb3/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-apl1/igt@gem_workarounds@suspend-resume-context.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-apl1/igt@gem_workarounds@suspend-resume-context.html * igt@i915_pm_sseu@full-enable: - shard-skl: [FAIL][47] -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl1/igt@i915_pm_sseu@full-enable.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl8/igt@i915_pm_sseu@full-enable.html * igt@i915_selftest@mock@buddy: - shard-skl: [INCOMPLETE][49] ([i915#1310] / [i915#1360]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl2/igt@i915_selftest@mock@buddy.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl8/igt@i915_selftest@mock@buddy.html * igt@i915_suspend@debugfs-reader: - shard-skl: [INCOMPLETE][51] ([i915#69]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl5/igt@i915_suspend@debugfs-reader.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl6/igt@i915_suspend@debugfs-reader.html * igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen: - shard-skl: [FAIL][53] ([i915#54]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][57] ([i915#1188]) -> [PASS][58] +1 similar issue [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl1/igt@kms_hdr@bpc-switch-dpms.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][59] ([fdo#108145] / [i915#265]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][61] ([fdo#109276]) -> [PASS][62] +13 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb7/igt@prime_busy@hang-bsd2.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb1/igt@prime_busy@hang-bsd2.html #### Warnings #### * igt@gem_exec_schedule@pi-userfault-bsd: - shard-iclb: [SKIP][63] ([i915#677]) -> [INCOMPLETE][64] ([i915#1381]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/shard-iclb1/igt@gem_exec_schedule@pi-userfault-bsd.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/shard-iclb6/igt@gem_exec_schedule@pi-userfault-bsd.html [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1310]: https://gitlab.freedesktop.org/drm/intel/issues/1310 [i915#1360]: https://gitlab.freedesktop.org/drm/intel/issues/1360 [i915#1381]: https://gitlab.freedesktop.org/drm/intel/issues/1381 [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8066 -> Patchwork_16817 CI-20190529: 20190529 CI_DRM_8066: 9e1454777a07902c85ce3febcc9648837a2224fd @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5491: d52794b426ae16630cc1e0354ae435ec98f6174b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16817: e394b1179ebcf458edc0cc1c9ddd081972b29021 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16817/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta ` (3 preceding siblings ...) 2020-03-05 16:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-03-13 18:52 ` Anshuman Gupta 2020-03-17 17:54 ` Jani Nikula 2020-03-18 8:18 ` [Intel-gfx] [PATCH v3] " Anshuman Gupta 2020-03-16 15:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev2) Patchwork ` (3 subsequent siblings) 8 siblings, 2 replies; 18+ messages in thread From: Anshuman Gupta @ 2020-03-13 18:52 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Few edp panels like Sharp is triggering short and long hpd pulse after panel is getting powered off. Currently driver is already ignoring long pulse for eDP panel but in order to process the short pulse, it turns on the VDD which requires panel power_cycle_delay + panel_power_on_delay these delay on Sharp panel introduced the responsiveness overhead of 800ms in the modeset sequence and as well is in suspend sequence. Ignoring any short pulse once panel is powered off. FIXME: It requires to wait for panel_power_off_delay in order to check the panel status, as panel triggers short pulse immediately after writing PP_OFF to PP_CTRL register. v2: - checking vdd along with panel power to ignore the hpd. [Jani,Ville] Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 27 +++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 0a417cd2af2b..3475791d3bea 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -6763,21 +6763,36 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { .destroy = intel_dp_encoder_destroy, }; +static bool intel_edp_have_power(struct intel_dp *intel_dp) +{ + intel_wakeref_t wakeref; + bool powerd_on = false; + + with_pps_lock(intel_dp, wakeref) { + powerd_on = edp_have_panel_power(intel_dp) && + edp_have_panel_vdd(intel_dp); + } + + return powerd_on; +} + enum irqreturn intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) { struct intel_dp *intel_dp = &intel_dig_port->dp; + struct drm_i915_private *i915 = dp_to_i915(intel_dp); - if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { + if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && + !intel_edp_have_power(intel_dp)) { /* - * vdd off can generate a long pulse on eDP which + * vdd off can generate a hpd pulse on eDP which * would require vdd on to handle it, and thus we * would end up in an endless cycle of - * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." + * "vdd off -> hpd -> vdd on -> detect -> vdd off -> ..." */ - DRM_DEBUG_KMS("ignoring long hpd on eDP [ENCODER:%d:%s]\n", - intel_dig_port->base.base.base.id, - intel_dig_port->base.base.name); + drm_dbg_kms(&i915->drm, "ignoring hpd on eDP [ENCODER:%d:%s]\n", + intel_dig_port->base.base.base.id, + intel_dig_port->base.base.name); return IRQ_HANDLED; } -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-13 18:52 ` [Intel-gfx] [PATCH v2] " Anshuman Gupta @ 2020-03-17 17:54 ` Jani Nikula 2020-03-18 8:18 ` [Intel-gfx] [PATCH v3] " Anshuman Gupta 1 sibling, 0 replies; 18+ messages in thread From: Jani Nikula @ 2020-03-17 17:54 UTC (permalink / raw) To: Anshuman Gupta, intel-gfx On Sat, 14 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > Few edp panels like Sharp is triggering short and long > hpd pulse after panel is getting powered off. > Currently driver is already ignoring long pulse for eDP > panel but in order to process the short pulse, it turns on > the VDD which requires panel power_cycle_delay + panel_power_on_delay > these delay on Sharp panel introduced the responsiveness overhead > of 800ms in the modeset sequence and as well is in suspend > sequence. > Ignoring any short pulse once panel is powered off. > > FIXME: It requires to wait for panel_power_off_delay in order > to check the panel status, as panel triggers short pulse immediately > after writing PP_OFF to PP_CTRL register. > > v2: > - checking vdd along with panel power to ignore the hpd. [Jani,Ville] > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 27 +++++++++++++++++++------ > 1 file changed, 21 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 0a417cd2af2b..3475791d3bea 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6763,21 +6763,36 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > .destroy = intel_dp_encoder_destroy, > }; > > +static bool intel_edp_have_power(struct intel_dp *intel_dp) > +{ > + intel_wakeref_t wakeref; > + bool powerd_on = false; Nitpick, "powerd" seems like a typo. "have_power" to reflect the name of the function? > + > + with_pps_lock(intel_dp, wakeref) { > + powerd_on = edp_have_panel_power(intel_dp) && > + edp_have_panel_vdd(intel_dp); > + } > + > + return powerd_on; > +} > + > enum irqreturn > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > { > struct intel_dp *intel_dp = &intel_dig_port->dp; > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > > - if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > + if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && > + !intel_edp_have_power(intel_dp)) { This *enables* long hpd handling when eDP *does* have power. Not sure if we want that. Erring on the safe side, this might be a better option: if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && (long_hpd || !intel_edp_have_power(intel_dp))) > /* > - * vdd off can generate a long pulse on eDP which > + * vdd off can generate a hpd pulse on eDP which > * would require vdd on to handle it, and thus we > * would end up in an endless cycle of > - * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." > + * "vdd off -> hpd -> vdd on -> detect -> vdd off -> ..." > */ > - DRM_DEBUG_KMS("ignoring long hpd on eDP [ENCODER:%d:%s]\n", > - intel_dig_port->base.base.base.id, > - intel_dig_port->base.base.name); > + drm_dbg_kms(&i915->drm, "ignoring hpd on eDP [ENCODER:%d:%s]\n", > + intel_dig_port->base.base.base.id, > + intel_dig_port->base.base.name); I think we may want to know whether it was a short or long hpd that was ignored if we ever need to debug this again. (We will. ;) Something along the lines of "ignoring %s hpd ...", long_hpd ? "long" : "short". Please keep the old logging macro here, in case this needs backporting to older kernels. (In general not a huge fan of doing two independent things at once.) BR, Jani. > return IRQ_HANDLED; > } -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-13 18:52 ` [Intel-gfx] [PATCH v2] " Anshuman Gupta 2020-03-17 17:54 ` Jani Nikula @ 2020-03-18 8:18 ` Anshuman Gupta 2020-03-18 9:38 ` Jani Nikula 1 sibling, 1 reply; 18+ messages in thread From: Anshuman Gupta @ 2020-03-18 8:18 UTC (permalink / raw) To: intel-gfx; +Cc: jani.nikula Few edp panels like Sharp is triggering short and long hpd pulse after panel is getting powered off. Currently driver is already ignoring long pulse for eDP panel but in order to process the short pulse, it turns on the VDD which requires panel power_cycle_delay + panel_power_on_delay these delay on Sharp panel introduced the responsiveness overhead of 800ms in the modeset sequence and as well is in suspend sequence. Ignoring any short pulse if panel is powered off. FIXME: It requires to wait for panel_power_off delay in order to check the panel power status due to pps_lock because panel triggers short pulse immediately after writing PP_OFF to PP_CTRL register and wait_panel_off waits for panel_power_off delay with pps_lock held. This still creates responsiveness overhead of panel_power_off delay. v2: - checking vdd along with panel power to ignore the hpd. [Jani,Ville] v3: - safer side check to ignore the long hpd when eDP have power, adding type of hpd to debug log. [Jani] Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 0a417cd2af2b..38e74195101a 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -6763,19 +6763,34 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { .destroy = intel_dp_encoder_destroy, }; +static bool intel_edp_have_power(struct intel_dp *intel_dp) +{ + intel_wakeref_t wakeref; + bool have_power = false; + + with_pps_lock(intel_dp, wakeref) { + have_power = edp_have_panel_power(intel_dp) && + edp_have_panel_vdd(intel_dp); + } + + return have_power; +} + enum irqreturn intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) { struct intel_dp *intel_dp = &intel_dig_port->dp; - if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { + if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && + (long_hpd || !intel_edp_have_power(intel_dp))) { /* - * vdd off can generate a long pulse on eDP which + * vdd off can generate a long/short pulse on eDP which * would require vdd on to handle it, and thus we * would end up in an endless cycle of - * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." + * "vdd off -> long/short hpd -> vdd on -> detect -> vdd off -> ..." */ - DRM_DEBUG_KMS("ignoring long hpd on eDP [ENCODER:%d:%s]\n", + DRM_DEBUG_KMS("ignoring %s hpd on eDP [ENCODER:%d:%s]\n", + long_hpd ? "long" : "short", intel_dig_port->base.base.base.id, intel_dig_port->base.base.name); return IRQ_HANDLED; -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-18 8:18 ` [Intel-gfx] [PATCH v3] " Anshuman Gupta @ 2020-03-18 9:38 ` Jani Nikula 2020-03-23 8:35 ` Shankar, Uma 0 siblings, 1 reply; 18+ messages in thread From: Jani Nikula @ 2020-03-18 9:38 UTC (permalink / raw) To: Anshuman Gupta, intel-gfx On Wed, 18 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > Few edp panels like Sharp is triggering short and long > hpd pulse after panel is getting powered off. > Currently driver is already ignoring long pulse for eDP > panel but in order to process the short pulse, it turns on > the VDD which requires panel power_cycle_delay + panel_power_on_delay > these delay on Sharp panel introduced the responsiveness overhead > of 800ms in the modeset sequence and as well is in suspend > sequence. > Ignoring any short pulse if panel is powered off. > > FIXME: It requires to wait for panel_power_off delay in order > to check the panel power status due to pps_lock because panel triggers > short pulse immediately after writing PP_OFF to PP_CTRL register and > wait_panel_off waits for panel_power_off delay with pps_lock held. > This still creates responsiveness overhead of panel_power_off delay. > > v2: > - checking vdd along with panel power to ignore the hpd. [Jani,Ville] > v3: > - safer side check to ignore the long hpd when eDP have power, > adding type of hpd to debug log. [Jani] > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> Thanks, Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 0a417cd2af2b..38e74195101a 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -6763,19 +6763,34 @@ static const struct drm_encoder_funcs intel_dp_enc_funcs = { > .destroy = intel_dp_encoder_destroy, > }; > > +static bool intel_edp_have_power(struct intel_dp *intel_dp) > +{ > + intel_wakeref_t wakeref; > + bool have_power = false; > + > + with_pps_lock(intel_dp, wakeref) { > + have_power = edp_have_panel_power(intel_dp) && > + edp_have_panel_vdd(intel_dp); > + } > + > + return have_power; > +} > + > enum irqreturn > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool long_hpd) > { > struct intel_dp *intel_dp = &intel_dig_port->dp; > > - if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > + if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && > + (long_hpd || !intel_edp_have_power(intel_dp))) { > /* > - * vdd off can generate a long pulse on eDP which > + * vdd off can generate a long/short pulse on eDP which > * would require vdd on to handle it, and thus we > * would end up in an endless cycle of > - * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." > + * "vdd off -> long/short hpd -> vdd on -> detect -> vdd off -> ..." > */ > - DRM_DEBUG_KMS("ignoring long hpd on eDP [ENCODER:%d:%s]\n", > + DRM_DEBUG_KMS("ignoring %s hpd on eDP [ENCODER:%d:%s]\n", > + long_hpd ? "long" : "short", > intel_dig_port->base.base.base.id, > intel_dig_port->base.base.name); > return IRQ_HANDLED; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel powered off 2020-03-18 9:38 ` Jani Nikula @ 2020-03-23 8:35 ` Shankar, Uma 0 siblings, 0 replies; 18+ messages in thread From: Shankar, Uma @ 2020-03-23 8:35 UTC (permalink / raw) To: Nikula, Jani, Gupta, Anshuman, intel-gfx > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula > Sent: Wednesday, March 18, 2020 3:09 PM > To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel- > gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/edp: Ignore short pulse when panel > powered off > > On Wed, 18 Mar 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote: > > Few edp panels like Sharp is triggering short and long hpd pulse after > > panel is getting powered off. > > Currently driver is already ignoring long pulse for eDP panel but in > > order to process the short pulse, it turns on the VDD which requires > > panel power_cycle_delay + panel_power_on_delay these delay on Sharp > > panel introduced the responsiveness overhead of 800ms in the modeset > > sequence and as well is in suspend sequence. > > Ignoring any short pulse if panel is powered off. > > > > FIXME: It requires to wait for panel_power_off delay in order to check > > the panel power status due to pps_lock because panel triggers short > > pulse immediately after writing PP_OFF to PP_CTRL register and > > wait_panel_off waits for panel_power_off delay with pps_lock held. > > This still creates responsiveness overhead of panel_power_off delay. > > > > v2: > > - checking vdd along with panel power to ignore the hpd. [Jani,Ville] > > v3: > > - safer side check to ignore the long hpd when eDP have power, > > adding type of hpd to debug log. [Jani] > > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > Thanks, > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Pushed to dinq, thanks for the patch and review. Regards, Uma Shankar > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 23 +++++++++++++++++++---- > > 1 file changed, 19 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > b/drivers/gpu/drm/i915/display/intel_dp.c > > index 0a417cd2af2b..38e74195101a 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -6763,19 +6763,34 @@ static const struct drm_encoder_funcs > intel_dp_enc_funcs = { > > .destroy = intel_dp_encoder_destroy, }; > > > > +static bool intel_edp_have_power(struct intel_dp *intel_dp) { > > + intel_wakeref_t wakeref; > > + bool have_power = false; > > + > > + with_pps_lock(intel_dp, wakeref) { > > + have_power = edp_have_panel_power(intel_dp) && > > + edp_have_panel_vdd(intel_dp); > > + } > > + > > + return have_power; > > +} > > + > > enum irqreturn > > intel_dp_hpd_pulse(struct intel_digital_port *intel_dig_port, bool > > long_hpd) { > > struct intel_dp *intel_dp = &intel_dig_port->dp; > > > > - if (long_hpd && intel_dig_port->base.type == INTEL_OUTPUT_EDP) { > > + if (intel_dig_port->base.type == INTEL_OUTPUT_EDP && > > + (long_hpd || !intel_edp_have_power(intel_dp))) { > > /* > > - * vdd off can generate a long pulse on eDP which > > + * vdd off can generate a long/short pulse on eDP which > > * would require vdd on to handle it, and thus we > > * would end up in an endless cycle of > > - * "vdd off -> long hpd -> vdd on -> detect -> vdd off -> ..." > > + * "vdd off -> long/short hpd -> vdd on -> detect -> vdd off -> ..." > > */ > > - DRM_DEBUG_KMS("ignoring long hpd on eDP > [ENCODER:%d:%s]\n", > > + DRM_DEBUG_KMS("ignoring %s hpd on eDP [ENCODER:%d:%s]\n", > > + long_hpd ? "long" : "short", > > intel_dig_port->base.base.base.id, > > intel_dig_port->base.base.name); > > return IRQ_HANDLED; > > -- > Jani Nikula, Intel Open Source Graphics Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev2) 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta ` (4 preceding siblings ...) 2020-03-13 18:52 ` [Intel-gfx] [PATCH v2] " Anshuman Gupta @ 2020-03-16 15:14 ` Patchwork 2020-03-16 22:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork ` (2 subsequent siblings) 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-16 15:14 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev2) URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8137 -> Patchwork_16970 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/index.html Known issues ------------ Here are the changes found in Patchwork_16970 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-r: [PASS][1] -> [FAIL][2] ([i915#665]) +2 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html - fi-icl-guc: [PASS][3] -> [SKIP][4] ([i915#1316]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-icl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html - fi-tgl-y: [PASS][5] -> [SKIP][6] ([CI#94] / [i915#1316]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@basic-rte: - fi-icl-guc: [PASS][7] -> [FAIL][8] ([i915#704]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-guc/igt@i915_pm_rpm@basic-rte.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-icl-guc/igt@i915_pm_rpm@basic-rte.html - fi-icl-u2: [PASS][9] -> [FAIL][10] ([i915#579]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-u2/igt@i915_pm_rpm@basic-rte.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-icl-u2/igt@i915_pm_rpm@basic-rte.html - fi-tgl-y: [PASS][11] -> [FAIL][12] ([CI#94] / [i915#579]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-tgl-y/igt@i915_pm_rpm@basic-rte.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-tgl-y/igt@i915_pm_rpm@basic-rte.html * igt@i915_pm_rpm@module-reload: - fi-cml-u2: [PASS][13] -> [FAIL][14] ([i915#665]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-cml-u2/igt@i915_pm_rpm@module-reload.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-cml-u2/igt@i915_pm_rpm@module-reload.html - fi-icl-guc: [PASS][15] -> [FAIL][16] ([i915#579]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-guc/igt@i915_pm_rpm@module-reload.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-icl-guc/igt@i915_pm_rpm@module-reload.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [FAIL][17] ([CI#94]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@i915_selftest@live@execlists: - fi-cfl-8700k: [INCOMPLETE][19] ([i915#656]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-cfl-8700k/igt@i915_selftest@live@execlists.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-cfl-8700k/igt@i915_selftest@live@execlists.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-icl-u2: [FAIL][21] ([i915#217]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html - fi-kbl-7500u: [FAIL][23] ([i915#323]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html #### Warnings #### * igt@i915_pm_rpm@module-reload: - fi-icl-u2: [DMESG-WARN][25] ([i915#289]) -> [DMESG-FAIL][26] ([i915#289]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-u2/igt@i915_pm_rpm@module-reload.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/fi-icl-u2/igt@i915_pm_rpm@module-reload.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316 [i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217 [i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 [i915#665]: https://gitlab.freedesktop.org/drm/intel/issues/665 [i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704 Participating hosts (48 -> 42) ------------------------------ Additional (1): fi-tgl-dsi Missing (7): fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-bsw-kefka fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8137 -> Patchwork_16970 CI-20190529: 20190529 CI_DRM_8137: 5786b5e77cc17a1b494b9bdf3c3f29eedc2e2e7d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5510: e100092d50105463f58db531fa953c70cc58bb10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16970: ce1dfcf387f0782a1628ff012123058904ecb9ae @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == ce1dfcf387f0 drm/i915/edp: Ignore short pulse when panel powered off == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/edp: Ignore short pulse when panel powered off (rev2) 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta ` (5 preceding siblings ...) 2020-03-16 15:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev2) Patchwork @ 2020-03-16 22:26 ` Patchwork 2020-03-18 9:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3) Patchwork 2020-03-18 11:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-16 22:26 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev2) URL : https://patchwork.freedesktop.org/series/74265/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8137_full -> Patchwork_16970_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_16970_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_16970_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_16970_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_parallel@bcs0-fds: - shard-kbl: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl7/igt@gem_exec_parallel@bcs0-fds.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-kbl2/igt@gem_exec_parallel@bcs0-fds.html * igt@i915_pm_rpm@gem-mmap-type@gtt: - shard-tglb: [PASS][3] -> [FAIL][4] +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb1/igt@i915_pm_rpm@gem-mmap-type@gtt.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb1/igt@i915_pm_rpm@gem-mmap-type@gtt.html * igt@i915_pm_rpm@gem-mmap-type@uc: - shard-skl: NOTRUN -> [FAIL][5] +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl9/igt@i915_pm_rpm@gem-mmap-type@uc.html * igt@i915_pm_rpm@gem-mmap-type@wb: - shard-iclb: [PASS][6] -> [FAIL][7] +9 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb3/igt@i915_pm_rpm@gem-mmap-type@wb.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb2/igt@i915_pm_rpm@gem-mmap-type@wb.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@sysfs_preempt_timeout@timeout@rcs0}: - shard-skl: NOTRUN -> [FAIL][8] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl5/igt@sysfs_preempt_timeout@timeout@rcs0.html New tests --------- New tests have been introduced between CI_DRM_8137_full and Patchwork_16970_full: ### New IGT tests (10) ### * igt@sysfs_heartbeat_interval@idempotent: - Statuses : - Exec time: [None] s * igt@sysfs_heartbeat_interval@invalid: - Statuses : - Exec time: [None] s * igt@sysfs_heartbeat_interval@nopreempt: - Statuses : - Exec time: [None] s * igt@sysfs_heartbeat_interval@off: - Statuses : - Exec time: [None] s * igt@sysfs_heartbeat_interval@precise: - Statuses : - Exec time: [None] s * igt@sysfs_preempt_timeout@idempotent: - Statuses : - Exec time: [None] s * igt@sysfs_preempt_timeout@invalid: - Statuses : - Exec time: [None] s * igt@sysfs_timeslice_duration@duration: - Statuses : - Exec time: [None] s * igt@sysfs_timeslice_duration@idempotent: - Statuses : - Exec time: [None] s * igt@sysfs_timeslice_duration@timeout: - Statuses : - Exec time: [None] s Known issues ------------ Here are the changes found in Patchwork_16970_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@close-replace-race: - shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([i915#1402]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@gem_ctx_persistence@close-replace-race.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb4/igt@gem_ctx_persistence@close-replace-race.html - shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#1402]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl6/igt@gem_ctx_persistence@close-replace-race.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl8/igt@gem_ctx_persistence@close-replace-race.html - shard-glk: [PASS][13] -> [INCOMPLETE][14] ([i915#1402] / [i915#58] / [k.org#198133]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk3/igt@gem_ctx_persistence@close-replace-race.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-glk5/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_schedule@implicit-write-read-bsd1: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109276] / [i915#677]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@gem_exec_schedule@implicit-write-read-bsd1.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb3/igt@gem_exec_schedule@implicit-write-read-bsd1.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#112146]) +8 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-glk: [PASS][19] -> [FAIL][20] ([i915#644]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_softpin@noreloc-s3: - shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl3/igt@gem_softpin@noreloc-s3.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-kbl7/igt@gem_softpin@noreloc-s3.html * igt@i915_pm_rpm@basic-pci-d3-state: - shard-skl: [PASS][23] -> [FAIL][24] ([i915#138]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl5/igt@i915_pm_rpm@basic-pci-d3-state.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl2/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@cursor: - shard-tglb: [PASS][25] -> [SKIP][26] ([i915#1316]) +12 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb1/igt@i915_pm_rpm@cursor.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb1/igt@i915_pm_rpm@cursor.html * igt@i915_pm_rpm@cursor-dpms: - shard-skl: [PASS][27] -> [FAIL][28] ([i915#665]) +8 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl3/igt@i915_pm_rpm@cursor-dpms.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl9/igt@i915_pm_rpm@cursor-dpms.html * igt@i915_pm_rpm@dpms-lpsp: - shard-iclb: [PASS][29] -> [SKIP][30] ([i915#1316]) +13 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@i915_pm_rpm@dpms-lpsp.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb7/igt@i915_pm_rpm@dpms-lpsp.html * igt@i915_pm_rpm@gem-execbuf-stress: - shard-skl: [PASS][31] -> [SKIP][32] ([fdo#109271]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl3/igt@i915_pm_rpm@gem-execbuf-stress.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl7/igt@i915_pm_rpm@gem-execbuf-stress.html * igt@i915_pm_rpm@pm-caching: - shard-tglb: [PASS][33] -> [FAIL][34] ([i915#665]) +5 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb8/igt@i915_pm_rpm@pm-caching.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb6/igt@i915_pm_rpm@pm-caching.html * igt@i915_pm_rps@waitboost: - shard-iclb: [PASS][35] -> [FAIL][36] ([i915#413]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@i915_pm_rps@waitboost.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb6/igt@i915_pm_rps@waitboost.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [PASS][37] -> [FAIL][38] ([i915#79]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-apl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +3 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-glk: [PASS][41] -> [FAIL][42] ([i915#899]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@kms_plane_lowres@pipe-a-tiling-x.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-glk3/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +3 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic: - shard-kbl: [PASS][45] -> [FAIL][46] ([i915#31]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl7/igt@kms_setmode@basic.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-kbl4/igt@kms_setmode@basic.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#112080]) +15 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@perf_pmu@busy-no-semaphores-vcs1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109276]) +20 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb7/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_exec_parallel@bcs0-fds: - shard-glk: [FAIL][51] -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@gem_exec_parallel@bcs0-fds.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-glk7/igt@gem_exec_parallel@bcs0-fds.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][53] ([fdo#112080]) -> [PASS][54] +9 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@gem_exec_parallel@vcs1-fds.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb4/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@implicit-read-write-bsd1: - shard-iclb: [SKIP][55] ([fdo#109276] / [i915#677]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@gem_exec_schedule@implicit-read-write-bsd1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [SKIP][57] ([i915#677]) -> [PASS][58] +4 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preemptive-hang-bsd: - shard-iclb: [SKIP][59] ([fdo#112146]) -> [PASS][60] +7 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [DMESG-WARN][61] ([i915#180]) -> [PASS][62] +2 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][63] ([i915#716]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl3/igt@gen9_exec_parse@allowed-single.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl9/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_dc@dc5-dpms: - shard-iclb: [FAIL][65] ([i915#447]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb1/igt@i915_pm_dc@dc5-dpms.html * igt@i915_selftest@live@execlists: - shard-skl: [INCOMPLETE][67] ([i915#656]) -> [PASS][68] [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl3/igt@i915_selftest@live@execlists.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl7/igt@i915_selftest@live@execlists.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [FAIL][69] ([i915#72]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled: - shard-skl: [FAIL][71] ([fdo#108145] / [i915#177] / [i915#52] / [i915#54]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl5/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl2/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [SKIP][73] ([fdo#109441]) -> [PASS][74] +2 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][75] ([fdo#109276]) -> [PASS][76] +22 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@prime_busy@hang-bsd2.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb4/igt@prime_busy@hang-bsd2.html * {igt@sysfs_timeslice_duration@timeout@rcs0}: - shard-skl: [FAIL][77] -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl10/igt@sysfs_timeslice_duration@timeout@rcs0.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl1/igt@sysfs_timeslice_duration@timeout@rcs0.html #### Warnings #### * igt@i915_pm_dc@dc6-dpms: - shard-tglb: [SKIP][79] ([i915#468]) -> [FAIL][80] ([i915#454]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb7/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp: - shard-tglb: [SKIP][81] ([fdo#111644] / [i915#1397]) -> [SKIP][82] ([i915#1316]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-iclb: [SKIP][83] ([fdo#109293] / [fdo#109506]) -> [SKIP][84] ([i915#1316]) +2 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb3/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-iclb: [SKIP][85] ([fdo#110892]) -> [SKIP][86] ([i915#1316]) +2 similar issues [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@i915_pm_rpm@modeset-non-lpsp.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-iclb2/igt@i915_pm_rpm@modeset-non-lpsp.html - shard-tglb: [SKIP][87] ([fdo#111644] / [i915#1397]) -> [SKIP][88] ([IGT#35] / [i915#1316]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb5/igt@i915_pm_rpm@modeset-non-lpsp.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb8/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@i915_pm_rpm@modeset-non-lpsp-stress: - shard-skl: [SKIP][89] ([fdo#109271]) -> [FAIL][90] ([i915#665]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl4/igt@i915_pm_rpm@modeset-non-lpsp-stress.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html * igt@i915_pm_rpm@modeset-pc8-residency-stress: - shard-tglb: [SKIP][91] ([fdo#109506]) -> [SKIP][92] ([i915#1316]) +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@i915_pm_rpm@modeset-pc8-residency-stress.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-tglb8/igt@i915_pm_rpm@modeset-pc8-residency-stress.html * igt@runner@aborted: - shard-skl: ([FAIL][93], [FAIL][94]) ([i915#69]) -> [FAIL][95] ([i915#1402] / [i915#69]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl3/igt@runner@aborted.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-skl3/igt@runner@aborted.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/shard-skl8/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#35]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/35 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109293]: https://bugs.freedesktop.org/show_bug.cgi?id=109293 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316 [i915#138]: https://gitlab.freedesktop.org/drm/intel/issues/138 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1402]: https://gitlab.freedesktop.org/drm/intel/issues/1402 [i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 [i915#665]: https://gitlab.freedesktop.org/drm/intel/issues/665 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8137 -> Patchwork_16970 CI-20190529: 20190529 CI_DRM_8137: 5786b5e77cc17a1b494b9bdf3c3f29eedc2e2e7d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5510: e100092d50105463f58db531fa953c70cc58bb10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16970: ce1dfcf387f0782a1628ff012123058904ecb9ae @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16970/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3) 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta ` (6 preceding siblings ...) 2020-03-16 22:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2020-03-18 9:13 ` Patchwork 2020-03-18 11:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-18 9:13 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev3) URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145 -> Patchwork_17004 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/index.html Known issues ------------ Here are the changes found in Patchwork_17004 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@execlists: - fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2] ([fdo#112259] / [i915#1430] / [i915#656]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/fi-kbl-soraka/igt@i915_selftest@live@execlists.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/fi-kbl-soraka/igt@i915_selftest@live@execlists.html #### Possible fixes #### * igt@gem_exec_parallel@fds: - fi-glk-dsi: [INCOMPLETE][3] ([i915#529] / [i915#58] / [k.org#198133]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/fi-glk-dsi/igt@gem_exec_parallel@fds.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/fi-glk-dsi/igt@gem_exec_parallel@fds.html * igt@i915_selftest@live@hangcheck: - fi-bwr-2160: [INCOMPLETE][5] ([i915#489]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/fi-bwr-2160/igt@i915_selftest@live@hangcheck.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/fi-bwr-2160/igt@i915_selftest@live@hangcheck.html [fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259 [i915#1430]: https://gitlab.freedesktop.org/drm/intel/issues/1430 [i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489 [i915#529]: https://gitlab.freedesktop.org/drm/intel/issues/529 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (46 -> 37) ------------------------------ Missing (9): fi-kbl-7560u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-gdg-551 fi-skl-lmem fi-blb-e6850 fi-byt-clapper Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8145 -> Patchwork_17004 CI-20190529: 20190529 CI_DRM_8145: 5e893da0b8c2bfec015c5eaa7981e1ffab1d7c9c @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5518: ee05a571255783837b18d626c4dff6cd9613cee2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17004: 868d9767077c45136ca958c1011e25d4b19e48cb @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 868d9767077c drm/i915/edp: Ignore short pulse when panel powered off == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3) 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta ` (7 preceding siblings ...) 2020-03-18 9:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3) Patchwork @ 2020-03-18 11:33 ` Patchwork 8 siblings, 0 replies; 18+ messages in thread From: Patchwork @ 2020-03-18 11:33 UTC (permalink / raw) To: Anshuman Gupta; +Cc: intel-gfx == Series Details == Series: drm/i915/edp: Ignore short pulse when panel powered off (rev3) URL : https://patchwork.freedesktop.org/series/74265/ State : success == Summary == CI Bug Log - changes from CI_DRM_8145_full -> Patchwork_17004_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_17004_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@close-race: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([i915#977]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-tglb2/igt@gem_busy@close-race.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-tglb2/igt@gem_busy@close-race.html * igt@gem_exec_schedule@implicit-both-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([i915#677]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb5/igt@gem_exec_schedule@implicit-both-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb2/igt@gem_exec_schedule@implicit-both-bsd.html * igt@gem_exec_schedule@implicit-both-bsd1: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [i915#677]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb2/igt@gem_exec_schedule@implicit-both-bsd1.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb3/igt@gem_exec_schedule@implicit-both-bsd1.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +5 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@out-order-bsd2: - shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109276]) +19 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb4/igt@gem_exec_schedule@out-order-bsd2.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb5/igt@gem_exec_schedule@out-order-bsd2.html * igt@gem_exec_whisper@basic-fds-priority: - shard-tglb: [PASS][11] -> [TIMEOUT][12] ([i915#1408]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-tglb7/igt@gem_exec_whisper@basic-fds-priority.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-tglb1/igt@gem_exec_whisper@basic-fds-priority.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-apl6/igt@gem_workarounds@suspend-resume-context.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-apl2/igt@gem_workarounds@suspend-resume-context.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-256x85-random: - shard-skl: [PASS][17] -> [FAIL][18] ([i915#54]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-256x85-random.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy: - shard-glk: [PASS][19] -> [FAIL][20] ([i915#72]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [PASS][21] -> [FAIL][22] ([IGT#5]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled: - shard-skl: [PASS][23] -> [FAIL][24] ([i915#52] / [i915#54]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl8/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][25] -> [FAIL][26] ([i915#79]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([i915#61]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc: - shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb4/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][33] -> [FAIL][34] ([i915#173]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb3/igt@kms_psr@no_drrs.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_basic: - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb2/igt@kms_psr@psr2_basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb5/igt@kms_psr@psr2_basic.html * igt@kms_setmode@basic: - shard-apl: [PASS][37] -> [FAIL][38] ([i915#31]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-apl8/igt@kms_setmode@basic.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-apl8/igt@kms_setmode@basic.html * igt@perf_pmu@busy-no-semaphores-vcs1: - shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#112080]) +17 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb1/igt@perf_pmu@busy-no-semaphores-vcs1.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html #### Possible fixes #### * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][41] ([fdo#110841]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb3/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][43] ([fdo#110854]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb7/igt@gem_exec_balancer@smoke.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb2/igt@gem_exec_balancer@smoke.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][45] ([fdo#112080]) -> [PASS][46] +16 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@implicit-write-read-bsd1: - shard-iclb: [SKIP][47] ([fdo#109276] / [i915#677]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb3/igt@gem_exec_schedule@implicit-write-read-bsd1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb4/igt@gem_exec_schedule@implicit-write-read-bsd1.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [SKIP][49] ([i915#677]) -> [PASS][50] +2 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb8/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@wide-bsd: - shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +6 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb3/igt@gem_exec_schedule@wide-bsd.html * igt@gem_exec_whisper@basic-queues-priority: - shard-skl: [FAIL][53] -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl10/igt@gem_exec_whisper@basic-queues-priority.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl8/igt@gem_exec_whisper@basic-queues-priority.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-kbl1/igt@gem_workarounds@suspend-resume-fd.html * igt@kms_color@pipe-a-legacy-gamma: - shard-skl: [FAIL][57] ([fdo#108145] / [i915#71]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl2/igt@kms_color@pipe-a-legacy-gamma.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl4/igt@kms_color@pipe-a-legacy-gamma.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [DMESG-WARN][59] ([i915#180]) -> [PASS][60] +1 similar issue [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-apl6/igt@kms_frontbuffer_tracking@fbc-suspend.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-iclb: [INCOMPLETE][61] ([i915#1185] / [i915#250]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@prime_busy@hang-bsd2: - shard-iclb: [SKIP][67] ([fdo#109276]) -> [PASS][68] +25 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-iclb3/igt@prime_busy@hang-bsd2.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-iclb4/igt@prime_busy@hang-bsd2.html * {igt@sysfs_timeslice_duration@timeout@rcs0}: - shard-skl: [FAIL][69] ([i915#1459]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-skl3/igt@sysfs_timeslice_duration@timeout@rcs0.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-skl6/igt@sysfs_timeslice_duration@timeout@rcs0.html #### Warnings #### * igt@gen9_exec_parse@allowed-all: - shard-glk: [DMESG-WARN][71] ([i915#716]) -> [INCOMPLETE][72] ([i915#58] / [k.org#198133]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-glk5/igt@gen9_exec_parse@allowed-all.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-glk3/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_dc@dc5-psr: - shard-snb: [INCOMPLETE][73] ([i915#82]) -> [SKIP][74] ([fdo#109271]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8145/shard-snb4/igt@i915_pm_dc@dc5-psr.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/shard-snb6/igt@i915_pm_dc@dc5-psr.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185 [i915#1408]: https://gitlab.freedesktop.org/drm/intel/issues/1408 [i915#1459]: https://gitlab.freedesktop.org/drm/intel/issues/1459 [i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#71]: https://gitlab.freedesktop.org/drm/intel/issues/71 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#977]: https://gitlab.freedesktop.org/drm/intel/issues/977 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8145 -> Patchwork_17004 CI-20190529: 20190529 CI_DRM_8145: 5e893da0b8c2bfec015c5eaa7981e1ffab1d7c9c @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5518: ee05a571255783837b18d626c4dff6cd9613cee2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17004: 868d9767077c45136ca958c1011e25d4b19e48cb @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17004/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2020-03-23 8:35 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-04 12:51 [Intel-gfx] [PATCH] drm/i915/edp: Ignore short pulse when panel powered off Anshuman Gupta 2020-03-04 13:33 ` Jani Nikula 2020-03-04 18:45 ` Ville Syrjälä 2020-03-05 3:17 ` Anshuman Gupta 2020-03-09 8:50 ` Anshuman Gupta 2020-03-13 18:47 ` Anshuman Gupta 2020-03-04 17:25 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2020-03-04 17:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-03-05 16:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-03-13 18:52 ` [Intel-gfx] [PATCH v2] " Anshuman Gupta 2020-03-17 17:54 ` Jani Nikula 2020-03-18 8:18 ` [Intel-gfx] [PATCH v3] " Anshuman Gupta 2020-03-18 9:38 ` Jani Nikula 2020-03-23 8:35 ` Shankar, Uma 2020-03-16 15:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev2) Patchwork 2020-03-16 22:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-03-18 9:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Ignore short pulse when panel powered off (rev3) Patchwork 2020-03-18 11:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.