* [Intel-gfx] [PATCH] drm/i915: Tweak scheduler's kick_submission() @ 2020-03-04 17:48 Chris Wilson 2020-03-04 20:49 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2020-03-04 20:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Chris Wilson @ 2020-03-04 17:48 UTC (permalink / raw) To: intel-gfx Skip useless priority bumping on adding a new dependency, but otherwise prevent tasklet scheduling until we have completed all the potential rescheduling. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/i915_scheduler.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c index be770f2419b1..44070fe753b5 100644 --- a/drivers/gpu/drm/i915/i915_scheduler.c +++ b/drivers/gpu/drm/i915/i915_scheduler.c @@ -209,6 +209,8 @@ static void kick_submission(struct intel_engine_cs *engine, if (!inflight) goto unlock; + engine->execlists.queue_priority_hint = prio; + /* * If we are already the currently executing context, don't * bother evaluating if we should preempt ourselves. @@ -216,7 +218,6 @@ static void kick_submission(struct intel_engine_cs *engine, if (inflight->context == rq->context) goto unlock; - engine->execlists.queue_priority_hint = prio; if (need_preempt(prio, rq_prio(inflight))) tasklet_hi_schedule(&engine->execlists.tasklet); @@ -466,11 +467,15 @@ int i915_sched_node_add_dependency(struct i915_sched_node *node, if (!dep) return -ENOMEM; + local_bh_disable(); + if (!__i915_sched_node_add_dependency(node, signal, dep, I915_DEPENDENCY_EXTERNAL | I915_DEPENDENCY_ALLOC)) i915_dependency_free(dep); + local_bh_enable(); /* kick submission tasklet */ + return 0; } -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Tweak scheduler's kick_submission() 2020-03-04 17:48 [Intel-gfx] [PATCH] drm/i915: Tweak scheduler's kick_submission() Chris Wilson @ 2020-03-04 20:49 ` Patchwork 2020-03-04 20:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2020-03-04 20:49 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Tweak scheduler's kick_submission() URL : https://patchwork.freedesktop.org/series/74279/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_dpll_mgr.h:285: warning: Function parameter or member 'get_freq' not described in 'intel_shared_dpll_funcs' _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tweak scheduler's kick_submission() 2020-03-04 17:48 [Intel-gfx] [PATCH] drm/i915: Tweak scheduler's kick_submission() Chris Wilson 2020-03-04 20:49 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork @ 2020-03-04 20:59 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2020-03-04 20:59 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Tweak scheduler's kick_submission() URL : https://patchwork.freedesktop.org/series/74279/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8066 -> Patchwork_16824 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_16824 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_16824, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_16824: ### IGT changes ### #### Possible regressions #### * igt@runner@aborted: - fi-kbl-r: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/fi-kbl-r/igt@runner@aborted.html Known issues ------------ Here are the changes found in Patchwork_16824 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s4-devices: - fi-tgl-y: [PASS][2] -> [FAIL][3] ([CI#94]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html * igt@i915_module_load@reload: - fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([CI#94] / [i915#402]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@i915_module_load@reload.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/fi-tgl-y/igt@i915_module_load@reload.html #### Possible fixes #### * igt@i915_selftest@live@workarounds: - fi-icl-guc: [DMESG-FAIL][6] ([i915#922]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-icl-guc/igt@i915_selftest@live@workarounds.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/fi-icl-guc/igt@i915_selftest@live@workarounds.html * igt@prime_self_import@basic-llseek-bad: - fi-tgl-y: [DMESG-WARN][8] ([CI#94] / [i915#402]) -> [PASS][9] +1 similar issue [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8066/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/fi-tgl-y/igt@prime_self_import@basic-llseek-bad.html [CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#922]: https://gitlab.freedesktop.org/drm/intel/issues/922 Participating hosts (45 -> 40) ------------------------------ Additional (4): fi-skl-lmem fi-blb-e6850 fi-kbl-r fi-kbl-7500u Missing (9): fi-icl-1065g7 fi-skl-guc fi-glk-dsi fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bsw-kefka fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_8066 -> Patchwork_16824 CI-20190529: 20190529 CI_DRM_8066: 9e1454777a07902c85ce3febcc9648837a2224fd @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5491: d52794b426ae16630cc1e0354ae435ec98f6174b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16824: 780aa744d9be937a68475138a7a7ad0627d3b665 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 780aa744d9be drm/i915: Tweak scheduler's kick_submission() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16824/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-04 20:59 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-04 17:48 [Intel-gfx] [PATCH] drm/i915: Tweak scheduler's kick_submission() Chris Wilson 2020-03-04 20:49 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2020-03-04 20:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.