All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/tiny: fix sparse warning: incorrect type in assignment (different base types)
@ 2020-03-08 16:14 Kamlesh Gurudasani
  2020-03-14  7:34 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Kamlesh Gurudasani @ 2020-03-08 16:14 UTC (permalink / raw)
  To: Sam Ravnborg, Noralf Tronnes, David Airlie, Daniel Vetter
  Cc: Kamlesh Gurudasani, dri-devel

This fixes the following sparse warning:

drivers/gpu/drm/tiny/ili9486.c:61:16: sparse: sparse: incorrect type in assignment (different base types)
drivers/gpu/drm/tiny/ili9486.c:61:16: sparse:    expected unsigned short [usertype]
drivers/gpu/drm/tiny/ili9486.c:61:16: sparse:    got restricted __be16 [usertype]
drivers/gpu/drm/tiny/ili9486.c:71:32: sparse: sparse: incorrect type in assignment (different base types)
drivers/gpu/drm/tiny/ili9486.c:71:32: sparse:    expected unsigned short [usertype]
drivers/gpu/drm/tiny/ili9486.c:71:32: sparse:    got restricted __be16 [usertype]

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>
---
 drivers/gpu/drm/tiny/ili9486.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index 5084b38..532560ae 100644
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -45,7 +45,7 @@ static int waveshare_command(struct mipi_dbi *mipi, u8 *cmd, u8 *par,
 	void *data = par;
 	u32 speed_hz;
 	int i, ret;
-	u16 *buf;
+	__be16 *buf;
 
 	buf = kmalloc(32 * sizeof(u16), GFP_KERNEL);
 	if (!buf)
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tiny: fix sparse warning: incorrect type in assignment (different base types)
  2020-03-08 16:14 [PATCH] drm/tiny: fix sparse warning: incorrect type in assignment (different base types) Kamlesh Gurudasani
@ 2020-03-14  7:34 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-03-14  7:34 UTC (permalink / raw)
  To: Kamlesh Gurudasani; +Cc: David Airlie, dri-devel

Hi Kamlesh

On Sun, Mar 08, 2020 at 09:44:44PM +0530, Kamlesh Gurudasani wrote:
> This fixes the following sparse warning:
> 
> drivers/gpu/drm/tiny/ili9486.c:61:16: sparse: sparse: incorrect type in assignment (different base types)
> drivers/gpu/drm/tiny/ili9486.c:61:16: sparse:    expected unsigned short [usertype]
> drivers/gpu/drm/tiny/ili9486.c:61:16: sparse:    got restricted __be16 [usertype]
> drivers/gpu/drm/tiny/ili9486.c:71:32: sparse: sparse: incorrect type in assignment (different base types)
> drivers/gpu/drm/tiny/ili9486.c:71:32: sparse:    expected unsigned short [usertype]
> drivers/gpu/drm/tiny/ili9486.c:71:32: sparse:    got restricted __be16 [usertype]
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>

Thanks. Applied and pushed to drm-misc-next.

	Sam

> ---
>  drivers/gpu/drm/tiny/ili9486.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 5084b38..532560ae 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -45,7 +45,7 @@ static int waveshare_command(struct mipi_dbi *mipi, u8 *cmd, u8 *par,
>  	void *data = par;
>  	u32 speed_hz;
>  	int i, ret;
> -	u16 *buf;
> +	__be16 *buf;
>  
>  	buf = kmalloc(32 * sizeof(u16), GFP_KERNEL);
>  	if (!buf)
> -- 
> 2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-14  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-08 16:14 [PATCH] drm/tiny: fix sparse warning: incorrect type in assignment (different base types) Kamlesh Gurudasani
2020-03-14  7:34 ` Sam Ravnborg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.