Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.alon@oracle.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Message-id: 20200309235411.76587-1-liran.alon@oracle.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
a905012 hw/i386/vmport: Assert vmport initialized before registering commands
aad4359 hw/i386/vmport: Add support for CMD_GETHZ
3edb9da i386/cpu: Store LAPIC bus frequency in CPU structure
b72a3e0 hw/i386/vmport: Allow x2apic without IR
7504676 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO
79d0a3f hw/i386/vmport: Add support for CMD_GETTIMEFULL
0d6e6b1 hw/i386/vmport: Add support for CMD_GETTIME
805b514 hw/i386/vmport: Add support for CMD_GETBIOSUUID
8271871 hw/i386/vmport: Define enum for all commands
9266505 hw/i386/vmport: Report VMX type in CMD_GETVERSION
7e250cd hw/i386/vmport: Introduce vmx-version property
b57af82 hw/i386/vmport: Add device properties
db12fa9 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands
8eab8de hw/i386/vmport: Propagate IOPort read to vCPU EAX register

=== OUTPUT BEGIN ===
1/14 Checking commit 8eab8ded095b (hw/i386/vmport: Propagate IOPort read to vCPU EAX register)
2/14 Checking commit db12fa95ba3b (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands)
3/14 Checking commit b57af82026fc (hw/i386/vmport: Add device properties)
4/14 Checking commit 7e250cdab468 (hw/i386/vmport: Introduce vmx-version property)
5/14 Checking commit 9266505822e8 (hw/i386/vmport: Report VMX type in CMD_GETVERSION)
6/14 Checking commit 82718710613d (hw/i386/vmport: Define enum for all commands)
7/14 Checking commit 805b5146d2ea (hw/i386/vmport: Add support for CMD_GETBIOSUUID)
ERROR: "(foo*)" should be "(foo *)"
#33: FILE: hw/i386/vmport.c:128:
+    uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data);

total: 1 errors, 0 warnings, 39 lines checked

Patch 7/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/14 Checking commit 0d6e6b1b6230 (hw/i386/vmport: Add support for CMD_GETTIME)
9/14 Checking commit 79d0a3f89d9c (hw/i386/vmport: Add support for CMD_GETTIMEFULL)
10/14 Checking commit 75046767a647 (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO)
ERROR: return is not a function, parentheses are not required
#41: FILE: hw/i386/vmport.c:185:
+    return (1 << VCPU_INFO_RESERVED_BIT);

total: 1 errors, 0 warnings, 38 lines checked

Patch 10/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/14 Checking commit b72a3e03d26d (hw/i386/vmport: Allow x2apic without IR)
12/14 Checking commit 3edb9da71251 (i386/cpu: Store LAPIC bus frequency in CPU structure)
13/14 Checking commit aad435930bec (hw/i386/vmport: Add support for CMD_GETHZ)
14/14 Checking commit a9050129b333 (hw/i386/vmport: Assert vmport initialized before registering commands)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200309235411.76587-1-liran.alon@oracle.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com