From: Robin Gong <yibin.gong@nxp.com> To: s.hauer@pengutronix.de, vkoul@kernel.org, shawnguo@kernel.org, u.kleine-koenig@pengutronix.de, broonie@kernel.org, robh+dt@kernel.org, festevam@gmail.com, dan.j.williams@intel.com, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, l.stach@pengutronix.de, martin.fuzzey@flowbird.group Cc: kernel@pengutronix.de, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Subject: [RESEND v6 04/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context Date: Tue, 10 Mar 2020 19:31:53 +0800 [thread overview] Message-ID: <1583839922-22699-5-git-send-email-yibin.gong@nxp.com> (raw) In-Reply-To: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong <yibin.gong@nxp.com> Acked-by: Vinod Koul <vkoul@kernel.org> --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 4c11c38..a7656a4 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan) sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Robin Gong <yibin.gong@nxp.com> To: s.hauer@pengutronix.de, vkoul@kernel.org, shawnguo@kernel.org, u.kleine-koenig@pengutronix.de, broonie@kernel.org, robh+dt@kernel.org, festevam@gmail.com, dan.j.williams@intel.com, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, l.stach@pengutronix.de, martin.fuzzey@flowbird.group Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND v6 04/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context Date: Tue, 10 Mar 2020 19:31:53 +0800 [thread overview] Message-ID: <1583839922-22699-5-git-send-email-yibin.gong@nxp.com> (raw) In-Reply-To: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong <yibin.gong@nxp.com> Acked-by: Vinod Koul <vkoul@kernel.org> --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 4c11c38..a7656a4 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan) sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac, -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-10 3:31 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-10 11:31 [RESEND v6 00/13] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 01/13] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 02/13] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 03/13] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong [this message] 2020-03-10 11:31 ` [RESEND v6 04/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong 2020-03-10 11:31 ` [RESEND v6 05/13] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 06/13] spi: imx: fix ERR009165 Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 7:39 ` Sascha Hauer 2020-03-10 7:39 ` Sascha Hauer 2020-03-10 7:39 ` Sascha Hauer 2020-03-10 8:27 ` Robin Gong 2020-03-10 8:27 ` Robin Gong 2020-03-10 8:27 ` Robin Gong 2020-03-10 8:37 ` Uwe Kleine-König 2020-03-10 8:37 ` Uwe Kleine-König 2020-03-10 8:37 ` Uwe Kleine-König 2020-03-10 9:02 ` Robin Gong 2020-03-10 9:02 ` Robin Gong 2020-03-10 9:02 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 07/13] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 8:02 ` Sascha Hauer 2020-03-10 8:02 ` Sascha Hauer 2020-03-10 8:02 ` Sascha Hauer 2020-03-10 8:43 ` Robin Gong 2020-03-10 8:43 ` Robin Gong 2020-03-10 8:43 ` Robin Gong 2020-03-10 9:25 ` Sascha Hauer 2020-03-10 9:25 ` Sascha Hauer 2020-03-10 9:25 ` Sascha Hauer 2020-03-10 9:31 ` Robin Gong 2020-03-10 9:31 ` Robin Gong 2020-03-10 9:31 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 08/13] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 18:41 ` Rob Herring 2020-03-10 18:41 ` Rob Herring 2020-03-10 18:41 ` Rob Herring 2020-03-11 3:22 ` Robin Gong 2020-03-11 3:22 ` Robin Gong 2020-03-11 3:22 ` Robin Gong 2020-03-11 3:22 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 09/13] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 8:19 ` Sascha Hauer 2020-03-10 8:19 ` Sascha Hauer 2020-03-10 8:19 ` Sascha Hauer 2020-03-10 8:59 ` Robin Gong 2020-03-10 8:59 ` Robin Gong 2020-03-10 8:59 ` Robin Gong 2020-03-10 9:28 ` Sascha Hauer 2020-03-10 9:28 ` Sascha Hauer 2020-03-10 9:28 ` Sascha Hauer 2020-03-10 9:35 ` Robin Gong 2020-03-10 9:35 ` Robin Gong 2020-03-10 9:35 ` Robin Gong 2020-03-10 11:31 ` [RESEND v6 10/13] dma: imx-sdma: add i.mx6ul/6sx compatible name Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:31 ` Robin Gong 2020-03-10 11:32 ` [RESEND v6 11/13] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong 2020-03-10 11:32 ` Robin Gong 2020-03-10 11:32 ` Robin Gong 2020-03-10 11:32 ` [RESEND v6 12/13] dmaengine: imx-sdma: add uart rom script Robin Gong 2020-03-10 11:32 ` Robin Gong 2020-03-10 11:32 ` Robin Gong 2020-03-10 11:32 ` [RESEND v6 13/13] Revert "dmaengine: imx-sdma: fix context cache" Robin Gong 2020-03-10 11:32 ` Robin Gong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1583839922-22699-5-git-send-email-yibin.gong@nxp.com \ --to=yibin.gong@nxp.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=martin.fuzzey@flowbird.group \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=vkoul@kernel.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.