* [PATCH] nvme: Use nvme_state_terminal helper
@ 2020-03-10 14:39 Israel Rukshin
2020-03-10 17:50 ` Christoph Hellwig
2020-03-10 20:55 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Israel Rukshin @ 2020-03-10 14:39 UTC (permalink / raw)
To: Linux-nvme, Sagi Grimberg, Christoph Hellwig; +Cc: Israel Rukshin, Max Gurtovoy
Improve code readability.
Signed-off-by: Israel Rukshin <israelr@mellanox.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
---
drivers/nvme/host/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c7933a8..17cd39b 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2628,8 +2628,7 @@ static bool nvme_validate_cntlid(struct nvme_subsystem *subsys,
lockdep_assert_held(&nvme_subsystems_lock);
list_for_each_entry(tmp, &subsys->ctrls, subsys_entry) {
- if (tmp->state == NVME_CTRL_DELETING ||
- tmp->state == NVME_CTRL_DEAD)
+ if (nvme_state_terminal(tmp))
continue;
if (tmp->cntlid == ctrl->cntlid) {
--
1.8.3.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: Use nvme_state_terminal helper
2020-03-10 14:39 [PATCH] nvme: Use nvme_state_terminal helper Israel Rukshin
@ 2020-03-10 17:50 ` Christoph Hellwig
2020-03-10 20:55 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-03-10 17:50 UTC (permalink / raw)
To: Israel Rukshin; +Cc: Max Gurtovoy, Sagi Grimberg, Linux-nvme, Christoph Hellwig
On Tue, Mar 10, 2020 at 04:39:10PM +0200, Israel Rukshin wrote:
> Improve code readability.
>
> Signed-off-by: Israel Rukshin <israelr@mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: Use nvme_state_terminal helper
2020-03-10 14:39 [PATCH] nvme: Use nvme_state_terminal helper Israel Rukshin
2020-03-10 17:50 ` Christoph Hellwig
@ 2020-03-10 20:55 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2020-03-10 20:55 UTC (permalink / raw)
To: Israel Rukshin; +Cc: Max Gurtovoy, Sagi Grimberg, Linux-nvme, Christoph Hellwig
On Tue, Mar 10, 2020 at 04:39:10PM +0200, Israel Rukshin wrote:
> Improve code readability.
>
> Signed-off-by: Israel Rukshin <israelr@mellanox.com>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Thanks, applied for 5.7
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-10 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 14:39 [PATCH] nvme: Use nvme_state_terminal helper Israel Rukshin
2020-03-10 17:50 ` Christoph Hellwig
2020-03-10 20:55 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.