From: Stephen Boyd <swboyd@chromium.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Girish Mahadevan <girishm@codeaurora.org>,
Dilip Kota <dkota@codeaurora.org>,
Alok Chauhan <alokc@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags
Date: Tue, 10 Mar 2020 08:35:11 -0700 [thread overview]
Message-ID: <158385451115.149997.17354220554214087646@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200310094159.GG1987@ninjato>
Quoting Wolfram Sang (2020-03-10 02:42:00)
> On Tue, Feb 04, 2020 at 11:31:50AM -0800, Stephen Boyd wrote:
> > We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
> > should take care of this for us. Just use 0 instead so that we use the
> > flags from the firmware. Also, remove specify dev_name() for the irq
> > name so that we can get better information in /proc/interrupts about
> > which device is generating interrupts.
> >
> > Cc: Girish Mahadevan <girishm@codeaurora.org>
> > Cc: Dilip Kota <dkota@codeaurora.org>
> > Cc: Alok Chauhan <alokc@codeaurora.org>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
>
> All patches look good, but this one doesn't build because dev is defined
> in the next patch only. I also can't apply patch 2 before 1, so please
> rebase and resend.
Ok.
next prev parent reply other threads:[~2020-03-10 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 19:31 [PATCH 0/3] Misc qcom geni i2c driver fixes Stephen Boyd
2020-02-04 19:31 ` [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags Stephen Boyd
2020-02-04 21:05 ` Brendan Higgins
2020-02-04 21:17 ` Doug Anderson
2020-03-10 9:42 ` Wolfram Sang
2020-03-10 15:35 ` Stephen Boyd [this message]
2020-02-04 19:31 ` [PATCH 2/3] i2c: qcom-geni: Grow a dev pointer to simplify code Stephen Boyd
2020-02-04 21:14 ` Brendan Higgins
2020-02-04 21:18 ` Doug Anderson
2020-02-04 19:31 ` [PATCH 3/3] i2c: qcom-geni: Drop of_platform.h include Stephen Boyd
2020-02-04 21:18 ` Doug Anderson
2020-02-04 21:20 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158385451115.149997.17354220554214087646@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=alokc@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=dkota@codeaurora.org \
--cc=girishm@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.