* [PATCH] scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw()
@ 2020-03-11 15:22 John Garry
2020-03-12 3:11 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: John Garry @ 2020-03-11 15:22 UTC (permalink / raw)
To: jejb, martin.petersen
Cc: linux-scsi, linux-kernel, linuxarm, Luo Jiaxing, John Garry
From: Luo Jiaxing <luojiaxing@huawei.com>
The print of pr_err() does not come with device information, so replace
it with dev_err(). Also improve the grammar in the message.
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
index a2debe0c8185..374885aa8d77 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -2938,6 +2938,7 @@ static void read_iost_itct_cache_v3_hw(struct hisi_hba *hisi_hba,
{
u32 cache_dw_size = HISI_SAS_IOST_ITCT_CACHE_DW_SZ *
HISI_SAS_IOST_ITCT_CACHE_NUM;
+ struct device *dev = hisi_hba->dev;
u32 *buf = cache;
u32 i, val;
@@ -2950,7 +2951,7 @@ static void read_iost_itct_cache_v3_hw(struct hisi_hba *hisi_hba,
}
if (val != 0xffffffff) {
- pr_err("Issue occur when reading IOST/ITCT cache!\n");
+ dev_err(dev, "Issue occurred in reading IOST/ITCT cache!\n");
return;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw()
2020-03-11 15:22 [PATCH] scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw() John Garry
@ 2020-03-12 3:11 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-03-12 3:11 UTC (permalink / raw)
To: John Garry
Cc: jejb, martin.petersen, linux-scsi, linux-kernel, linuxarm, Luo Jiaxing
John,
> The print of pr_err() does not come with device information, so
> replace it with dev_err(). Also improve the grammar in the message.
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-12 3:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 15:22 [PATCH] scsi: hisi_sas: Use dev_err() in read_iost_itct_cache_v3_hw() John Garry
2020-03-12 3:11 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.