* [PATCH V2 0/2] Convert QSPI binding to YAML and add interconnect doc
@ 2020-03-13 11:15 Akash Asthana
2020-03-13 11:15 ` [PATCH V2 1/2] dt-bindings: spi: Convert QSPI bindings to YAML Akash Asthana
2020-03-13 11:15 ` [PATCH V2 2/2] dt-bindings: spi: Add interconnect binding for QSPI Akash Asthana
0 siblings, 2 replies; 5+ messages in thread
From: Akash Asthana @ 2020-03-13 11:15 UTC (permalink / raw)
To: robh+dt, agross, mark.rutland
Cc: linux-arm-msm, devicetree, linux-kernel, mgautam, rojay, skakit,
Akash Asthana
Akash Asthana (2):
dt-bindings: spi: Convert QSPI bindings to YAML
dt-bindings: spi: Add interconnect binding for QSPI
.../devicetree/bindings/spi/qcom,spi-qcom-qspi.txt | 36 ---------
.../bindings/spi/qcom,spi-qcom-qspi.yaml | 88 ++++++++++++++++++++++
2 files changed, 88 insertions(+), 36 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2 1/2] dt-bindings: spi: Convert QSPI bindings to YAML
2020-03-13 11:15 [PATCH V2 0/2] Convert QSPI binding to YAML and add interconnect doc Akash Asthana
@ 2020-03-13 11:15 ` Akash Asthana
2020-03-30 18:07 ` Rob Herring
2020-03-13 11:15 ` [PATCH V2 2/2] dt-bindings: spi: Add interconnect binding for QSPI Akash Asthana
1 sibling, 1 reply; 5+ messages in thread
From: Akash Asthana @ 2020-03-13 11:15 UTC (permalink / raw)
To: robh+dt, agross, mark.rutland
Cc: linux-arm-msm, devicetree, linux-kernel, mgautam, rojay, skakit,
Akash Asthana
Convert QSPI bindings to DT schema format using json-schema.
Signed-off-by: Akash Asthana <akashast@codeaurora.org>
---
Changes in V2:
- As per Stephen's comment, dropped properties "#address-cells" &
"#size-cells" from QSPI node as it's already defined in
$ref: /spi/spi-controller.yaml#.
- As per Stephen's comment, dropped description for reg property and
answered few Nitpicks.
.../devicetree/bindings/spi/qcom,spi-qcom-qspi.txt | 36 ----------
.../bindings/spi/qcom,spi-qcom-qspi.yaml | 79 ++++++++++++++++++++++
2 files changed, 79 insertions(+), 36 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
deleted file mode 100644
index 1d64b61..0000000
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
+++ /dev/null
@@ -1,36 +0,0 @@
-Qualcomm Quad Serial Peripheral Interface (QSPI)
-
-The QSPI controller allows SPI protocol communication in single, dual, or quad
-wire transmission modes for read/write access to slaves such as NOR flash.
-
-Required properties:
-- compatible: An SoC specific identifier followed by "qcom,qspi-v1", such as
- "qcom,sdm845-qspi", "qcom,qspi-v1"
-- reg: Should contain the base register location and length.
-- interrupts: Interrupt number used by the controller.
-- clocks: Should contain the core and AHB clock.
-- clock-names: Should be "core" for core clock and "iface" for AHB clock.
-
-SPI slave nodes must be children of the SPI master node and can contain
-properties described in Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Example:
-
- qspi: spi@88df000 {
- compatible = "qcom,sdm845-qspi", "qcom,qspi-v1";
- reg = <0x88df000 0x600>;
- #address-cells = <1>;
- #size-cells = <0>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
- clock-names = "iface", "core";
- clocks = <&gcc GCC_QSPI_CNOC_PERIPH_AHB_CLK>,
- <&gcc GCC_QSPI_CORE_CLK>;
-
- flash@0 {
- compatible = "jedec,spi-nor";
- reg = <0>;
- spi-max-frequency = <25000000>;
- spi-tx-bus-width = <2>;
- spi-rx-bus-width = <2>;
- };
- };
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
new file mode 100644
index 0000000..9582d37
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/spi/qcom,spi-qcom-qspi.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Quad Serial Peripheral Interface (QSPI)
+
+maintainers:
+ - Mukesh Savaliya <msavaliy@codeaurora.org>
+ - Akash Asthana <akashast@codeaurora.org>
+
+description:
+ The QSPI controller allows SPI protocol communication in single, dual, or quad
+ wire transmission modes for read/write access to slaves such as NOR flash.
+
+allOf:
+ - $ref: /spi/spi-controller.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: qcom,sdm845-qspi
+ - const: qcom,qspi-v1
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: iface
+ - const: core
+
+ clocks:
+ items:
+ - description: AHB clock
+ - description: QSPI core clock
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clock-names
+ - clocks
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,gcc-sdm845.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ soc: soc@0 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ qspi: spi@88df000 {
+ compatible = "qcom,sdm845-qspi", "qcom,qspi-v1";
+ reg = <0 0x88df000 0 0x600>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "iface", "core";
+ clocks = <&gcc GCC_QSPI_CNOC_PERIPH_AHB_CLK>,
+ <&gcc GCC_QSPI_CORE_CLK>;
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <25000000>;
+ spi-tx-bus-width = <2>;
+ spi-rx-bus-width = <2>;
+ };
+
+ };
+ };
+...
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V2 2/2] dt-bindings: spi: Add interconnect binding for QSPI
2020-03-13 11:15 [PATCH V2 0/2] Convert QSPI binding to YAML and add interconnect doc Akash Asthana
2020-03-13 11:15 ` [PATCH V2 1/2] dt-bindings: spi: Convert QSPI bindings to YAML Akash Asthana
@ 2020-03-13 11:15 ` Akash Asthana
2020-03-30 18:07 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Akash Asthana @ 2020-03-13 11:15 UTC (permalink / raw)
To: robh+dt, agross, mark.rutland
Cc: linux-arm-msm, devicetree, linux-kernel, mgautam, rojay, skakit,
Akash Asthana
Add documentation for the interconnect and interconnect-names
properties for QSPI.
Signed-off-by: Akash Asthana <akashast@codeaurora.org>
---
Changes in V2:
- Added minItems = 1 for interconnect property
Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
index 9582d37..0cf470e 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
@@ -40,6 +40,15 @@ properties:
- description: AHB clock
- description: QSPI core clock
+ interconnects:
+ minItems: 1
+ maxItems: 2
+
+ interconnect-names:
+ items:
+ - const: qspi-config
+ - const: qspi-memory
+
required:
- compatible
- reg
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: spi: Convert QSPI bindings to YAML
2020-03-13 11:15 ` [PATCH V2 1/2] dt-bindings: spi: Convert QSPI bindings to YAML Akash Asthana
@ 2020-03-30 18:07 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-03-30 18:07 UTC (permalink / raw)
To: Akash Asthana
Cc: robh+dt, agross, mark.rutland, linux-arm-msm, devicetree,
linux-kernel, mgautam, rojay, skakit, Akash Asthana
On Fri, 13 Mar 2020 16:45:20 +0530, Akash Asthana wrote:
> Convert QSPI bindings to DT schema format using json-schema.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> Changes in V2:
> - As per Stephen's comment, dropped properties "#address-cells" &
> "#size-cells" from QSPI node as it's already defined in
> $ref: /spi/spi-controller.yaml#.
> - As per Stephen's comment, dropped description for reg property and
> answered few Nitpicks.
>
> .../devicetree/bindings/spi/qcom,spi-qcom-qspi.txt | 36 ----------
> .../bindings/spi/qcom,spi-qcom-qspi.yaml | 79 ++++++++++++++++++++++
> 2 files changed, 79 insertions(+), 36 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
> create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 2/2] dt-bindings: spi: Add interconnect binding for QSPI
2020-03-13 11:15 ` [PATCH V2 2/2] dt-bindings: spi: Add interconnect binding for QSPI Akash Asthana
@ 2020-03-30 18:07 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-03-30 18:07 UTC (permalink / raw)
To: Akash Asthana
Cc: robh+dt, agross, mark.rutland, linux-arm-msm, devicetree,
linux-kernel, mgautam, rojay, skakit, Akash Asthana
On Fri, 13 Mar 2020 16:45:21 +0530, Akash Asthana wrote:
> Add documentation for the interconnect and interconnect-names
> properties for QSPI.
>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
> Changes in V2:
> - Added minItems = 1 for interconnect property
>
> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-30 18:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 11:15 [PATCH V2 0/2] Convert QSPI binding to YAML and add interconnect doc Akash Asthana
2020-03-13 11:15 ` [PATCH V2 1/2] dt-bindings: spi: Convert QSPI bindings to YAML Akash Asthana
2020-03-30 18:07 ` Rob Herring
2020-03-13 11:15 ` [PATCH V2 2/2] dt-bindings: spi: Add interconnect binding for QSPI Akash Asthana
2020-03-30 18:07 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.