From: no-reply@patchew.org To: alistair.francis@wdc.com Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, laurent@vivier.eu, alistair.francis@wdc.com, alistair23@gmail.com, palmer@dabbelt.com Subject: Re: [PATCH v8 0/4] linux-user: generate syscall_nr.sh for RISC-V Date: Fri, 13 Mar 2020 17:18:58 -0700 (PDT) [thread overview] Message-ID: <158414513652.29765.9214965526138586973@39012742ff91> (raw) In-Reply-To: <cover.1584143748.git.alistair.francis@wdc.com> Patchew URL: https://patchew.org/QEMU/cover.1584143748.git.alistair.francis@wdc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v8 0/4] linux-user: generate syscall_nr.sh for RISC-V Message-id: cover.1584143748.git.alistair.francis@wdc.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3617079 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel 526acda linux-user: Support futex_time64 b8a61fe linux-user/syscall: Add support for clock_gettime64/clock_settime64 685420e linux-user: Protect more syscalls === OUTPUT BEGIN === 1/4 Checking commit 685420e07f1b (linux-user: Protect more syscalls) 2/4 Checking commit b8a61fef0fdc (linux-user/syscall: Add support for clock_gettime64/clock_settime64) 3/4 Checking commit 526acdaf0686 (linux-user: Support futex_time64) WARNING: architecture specific defines should be avoided #23: FILE: linux-user/syscall.c:248: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #26: FILE: linux-user/syscall.c:251: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #37: FILE: linux-user/syscall.c:303: +#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \ WARNING: architecture specific defines should be avoided #43: FILE: linux-user/syscall.c:309: +#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64)) ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #55: FILE: linux-user/syscall.c:776: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #59: FILE: linux-user/syscall.c:780: +#if defined(__NR_futex_time64) ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #84: FILE: linux-user/syscall.c:6913: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #90: FILE: linux-user/syscall.c:6919: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #96: FILE: linux-user/syscall.c:6925: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #109: FILE: linux-user/syscall.c:6938: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #114: FILE: linux-user/syscall.c:6943: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #121: FILE: linux-user/syscall.c:6950: +#if defined(__NR_futex) WARNING: line over 80 characters #168: FILE: linux-user/syscall.c:7013: +static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout, WARNING: Block comments use a leading /* on a separate line #174: FILE: linux-user/syscall.c:7019: + /* ??? We assume FUTEX_* constants are the same on both host WARNING: Block comments use * on subsequent lines #175: FILE: linux-user/syscall.c:7020: + /* ??? We assume FUTEX_* constants are the same on both host + and target. */ WARNING: Block comments use a trailing */ on a separate line #175: FILE: linux-user/syscall.c:7020: + and target. */ WARNING: Block comments use a leading /* on a separate line #199: FILE: linux-user/syscall.c:7044: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the WARNING: Block comments use * on subsequent lines #200: FILE: linux-user/syscall.c:7045: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the + TIMEOUT parameter is interpreted as a uint32_t by the kernel. WARNING: Block comments use a trailing */ on a separate line #203: FILE: linux-user/syscall.c:7048: + since it's not compared to guest memory. */ total: 24 errors, 19 warnings, 212 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 36170794264c (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 total: 0 errors, 1 warnings, 898 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1584143748.git.alistair.francis@wdc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: no-reply@patchew.org To: alistair.francis@wdc.com Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, laurent@vivier.eu, alistair.francis@wdc.com, palmer@dabbelt.com, alistair23@gmail.com Subject: Re: [PATCH v8 0/4] linux-user: generate syscall_nr.sh for RISC-V Date: Fri, 13 Mar 2020 17:18:58 -0700 (PDT) [thread overview] Message-ID: <158414513652.29765.9214965526138586973@39012742ff91> (raw) In-Reply-To: <cover.1584143748.git.alistair.francis@wdc.com> Patchew URL: https://patchew.org/QEMU/cover.1584143748.git.alistair.francis@wdc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v8 0/4] linux-user: generate syscall_nr.sh for RISC-V Message-id: cover.1584143748.git.alistair.francis@wdc.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3617079 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel 526acda linux-user: Support futex_time64 b8a61fe linux-user/syscall: Add support for clock_gettime64/clock_settime64 685420e linux-user: Protect more syscalls === OUTPUT BEGIN === 1/4 Checking commit 685420e07f1b (linux-user: Protect more syscalls) 2/4 Checking commit b8a61fef0fdc (linux-user/syscall: Add support for clock_gettime64/clock_settime64) 3/4 Checking commit 526acdaf0686 (linux-user: Support futex_time64) WARNING: architecture specific defines should be avoided #23: FILE: linux-user/syscall.c:248: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #26: FILE: linux-user/syscall.c:251: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #37: FILE: linux-user/syscall.c:303: +#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \ WARNING: architecture specific defines should be avoided #43: FILE: linux-user/syscall.c:309: +#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64)) ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #44: FILE: linux-user/syscall.c:310: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #45: FILE: linux-user/syscall.c:311: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #55: FILE: linux-user/syscall.c:776: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #59: FILE: linux-user/syscall.c:780: +#if defined(__NR_futex_time64) ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #60: FILE: linux-user/syscall.c:781: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #61: FILE: linux-user/syscall.c:782: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #84: FILE: linux-user/syscall.c:6913: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #90: FILE: linux-user/syscall.c:6919: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #96: FILE: linux-user/syscall.c:6925: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #109: FILE: linux-user/syscall.c:6938: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #114: FILE: linux-user/syscall.c:6943: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #121: FILE: linux-user/syscall.c:6950: +#if defined(__NR_futex) WARNING: line over 80 characters #168: FILE: linux-user/syscall.c:7013: +static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout, WARNING: Block comments use a leading /* on a separate line #174: FILE: linux-user/syscall.c:7019: + /* ??? We assume FUTEX_* constants are the same on both host WARNING: Block comments use * on subsequent lines #175: FILE: linux-user/syscall.c:7020: + /* ??? We assume FUTEX_* constants are the same on both host + and target. */ WARNING: Block comments use a trailing */ on a separate line #175: FILE: linux-user/syscall.c:7020: + and target. */ WARNING: Block comments use a leading /* on a separate line #199: FILE: linux-user/syscall.c:7044: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the WARNING: Block comments use * on subsequent lines #200: FILE: linux-user/syscall.c:7045: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the + TIMEOUT parameter is interpreted as a uint32_t by the kernel. WARNING: Block comments use a trailing */ on a separate line #203: FILE: linux-user/syscall.c:7048: + since it's not compared to guest memory. */ total: 24 errors, 19 warnings, 212 lines checked Patch 3/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/4 Checking commit 36170794264c (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 total: 0 errors, 1 warnings, 898 lines checked Patch 4/4 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1584143748.git.alistair.francis@wdc.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2020-03-14 0:19 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-13 23:56 [PATCH v8 0/4] linux-user: generate syscall_nr.sh for RISC-V Alistair Francis 2020-03-13 23:56 ` Alistair Francis 2020-03-13 23:56 ` [PATCH v8 1/4] linux-user: Protect more syscalls Alistair Francis 2020-03-13 23:56 ` Alistair Francis 2020-03-13 23:56 ` [PATCH v8 2/4] linux-user/syscall: Add support for clock_gettime64/clock_settime64 Alistair Francis 2020-03-13 23:56 ` Alistair Francis 2020-03-13 23:56 ` [PATCH v8 3/4] linux-user: Support futex_time64 Alistair Francis 2020-03-13 23:56 ` Alistair Francis 2020-03-14 11:05 ` Laurent Vivier 2020-03-14 11:05 ` Laurent Vivier 2020-03-14 11:19 ` Laurent Vivier 2020-03-14 11:19 ` Laurent Vivier 2020-03-13 23:56 ` [PATCH v8 4/4] linux-user/riscv: Update the syscall_nr's to the 5.5 kernel Alistair Francis 2020-03-13 23:56 ` Alistair Francis 2020-03-14 0:18 ` no-reply [this message] 2020-03-14 0:18 ` [PATCH v8 0/4] linux-user: generate syscall_nr.sh for RISC-V no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=158414513652.29765.9214965526138586973@39012742ff91 \ --to=no-reply@patchew.org \ --cc=alistair.francis@wdc.com \ --cc=alistair23@gmail.com \ --cc=laurent@vivier.eu \ --cc=palmer@dabbelt.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.