* [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
@ 2020-03-16 16:11 ` Lyude
2020-03-16 23:11 ` Chris Wilson
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static Lyude
` (5 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Lyude @ 2020-03-16 16:11 UTC (permalink / raw)
To: igt-dev
From: Lyude Paul <lyude@redhat.com>
Since gcc 10, -fno-common has become the default (vs. -fcommon). As a
result, gcc is much stricter about missing extern and static keywords
and causes our build to fail in anything including igt_core.h:
/usr/bin/ld:
lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:149:
multiple definition of `igt_dynamic_jmpbuf';
lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:149: first defined
here
/usr/bin/ld:
lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:148:
multiple definition of `igt_subtest_jmpbuf';
lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:148: first defined
here
So, fix this by marking these as extern and declaring them in
lib/igt_core.c.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
lib/igt_core.c | 3 +++
lib/igt_core.h | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 51041793..2b928f1a 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -261,6 +261,9 @@
* such as those related to Chamelium support.
*/
+jmp_buf igt_subtest_jmpbuf;
+jmp_buf igt_dynamic_jmpbuf;
+
static unsigned int exit_handler_count;
const char *igt_interactive_debug;
bool igt_skip_crc_compare;
diff --git a/lib/igt_core.h b/lib/igt_core.h
index c17a7ba8..fae5f59e 100644
--- a/lib/igt_core.h
+++ b/lib/igt_core.h
@@ -145,8 +145,8 @@ void __igt_fixture_end(void) __attribute__((noreturn));
__igt_fixture_complete())
/* subtest infrastructure */
-jmp_buf igt_subtest_jmpbuf;
-jmp_buf igt_dynamic_jmpbuf;
+extern jmp_buf igt_subtest_jmpbuf;
+extern jmp_buf igt_dynamic_jmpbuf;
typedef int (*igt_opt_handler_t)(int opt, int opt_index, void *data);
#define IGT_OPT_HANDLER_SUCCESS 0
#define IGT_OPT_HANDLER_ERROR -2
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern Lyude
@ 2020-03-16 23:11 ` Chris Wilson
0 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2020-03-16 23:11 UTC (permalink / raw)
To: Lyude, igt-dev
Quoting Lyude (2020-03-16 16:11:29)
> From: Lyude Paul <lyude@redhat.com>
>
> Since gcc 10, -fno-common has become the default (vs. -fcommon). As a
> result, gcc is much stricter about missing extern and static keywords
> and causes our build to fail in anything including igt_core.h:
>
> /usr/bin/ld:
> lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:149:
> multiple definition of `igt_dynamic_jmpbuf';
> lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:149: first defined
> here
> /usr/bin/ld:
> lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:148:
> multiple definition of `igt_subtest_jmpbuf';
> lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:148: first defined
> here
>
> So, fix this by marking these as extern and declaring them in
> lib/igt_core.c.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
One might be tempted to start marking up library private symbols.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern Lyude
@ 2020-03-16 16:11 ` Lyude
2020-03-16 23:11 ` Chris Wilson
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern Lyude
` (4 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Lyude @ 2020-03-16 16:11 UTC (permalink / raw)
To: igt-dev
From: Lyude Paul <lyude@redhat.com>
Since both rendercopy_gen8.c and rendercopy_gen9.c declare cc/viewport
variables without marking them as static, -fcommon also causes these to
make our builds fail:
/usr/bin/ld:
lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:46:
multiple definition of `cc';
lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:45:
first defined here
/usr/bin/ld:
lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:51:
multiple definition of `viewport';
lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:50:
first defined here
So, fix this by marking them as static.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
lib/rendercopy_gen8.c | 4 ++--
lib/rendercopy_gen9.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/rendercopy_gen8.c b/lib/rendercopy_gen8.c
index 8e02d846..bace64a7 100644
--- a/lib/rendercopy_gen8.c
+++ b/lib/rendercopy_gen8.c
@@ -39,12 +39,12 @@ static void dump_batch(struct intel_batchbuffer *batch) {
#define dump_batch(x) do { } while(0)
#endif
-struct {
+static struct {
uint32_t cc_state;
uint32_t blend_state;
} cc;
-struct {
+static struct {
uint32_t cc_state;
uint32_t sf_clip_state;
} viewport;
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 835c8d80..f364c2b9 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -40,12 +40,12 @@ static void dump_batch(struct intel_batchbuffer *batch) {
#define dump_batch(x) do { } while(0)
#endif
-struct {
+static struct {
uint32_t cc_state;
uint32_t blend_state;
} cc;
-struct {
+static struct {
uint32_t cc_state;
uint32_t sf_clip_state;
} viewport;
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static Lyude
@ 2020-03-16 23:11 ` Chris Wilson
0 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2020-03-16 23:11 UTC (permalink / raw)
To: Lyude, igt-dev
Quoting Lyude (2020-03-16 16:11:30)
> From: Lyude Paul <lyude@redhat.com>
>
> Since both rendercopy_gen8.c and rendercopy_gen9.c declare cc/viewport
> variables without marking them as static, -fcommon also causes these to
> make our builds fail:
>
> /usr/bin/ld:
> lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:46:
> multiple definition of `cc';
> lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:45:
> first defined here
> /usr/bin/ld:
> lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:51:
> multiple definition of `viewport';
> lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:50:
> first defined here
>
> So, fix this by marking them as static.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern Lyude
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static Lyude
@ 2020-03-16 16:11 ` Lyude
2020-03-16 23:08 ` Chris Wilson
` (2 more replies)
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags Lyude
` (3 subsequent siblings)
6 siblings, 3 replies; 17+ messages in thread
From: Lyude @ 2020-03-16 16:11 UTC (permalink / raw)
To: igt-dev
From: Lyude Paul <lyude@redhat.com>
Another spot where we fail compilation with -fcommon, due to src_operand
getting included in multiple translation units without being marked as
extern:
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand';
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand';
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
So, fix this by marking struct src_operand as extern.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
assembler/gen4asm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
index 6b957e28..7845060c 100644
--- a/assembler/gen4asm.h
+++ b/assembler/gen4asm.h
@@ -111,7 +111,7 @@ struct regtype {
* This structure is the internal representation of source operands in the
* parser.
*/
-struct src_operand {
+extern struct src_operand {
struct brw_reg reg;
int default_region;
uint32_t imm32; /* set if src_operand is expressing a branch offset */
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern Lyude
@ 2020-03-16 23:08 ` Chris Wilson
2020-03-17 16:56 ` Lyude Paul
2020-03-16 23:10 ` Chris Wilson
2020-03-19 17:40 ` [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable Lyude
2 siblings, 1 reply; 17+ messages in thread
From: Chris Wilson @ 2020-03-16 23:08 UTC (permalink / raw)
To: Lyude, igt-dev
Quoting Lyude (2020-03-16 16:11:31)
> From: Lyude Paul <lyude@redhat.com>
>
> Another spot where we fail compilation with -fcommon, due to src_operand
> getting included in multiple translation units without being marked as
> extern:
>
> /usr/bin/ld:
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
> multiple definition of `src_operand';
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
> first defined here
> /usr/bin/ld:
> assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
> multiple definition of `src_operand';
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
> first defined here
>
> So, fix this by marking struct src_operand as extern.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> assembler/gen4asm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
> index 6b957e28..7845060c 100644
> --- a/assembler/gen4asm.h
> +++ b/assembler/gen4asm.h
> @@ -111,7 +111,7 @@ struct regtype {
> * This structure is the internal representation of source operands in the
> * parser.
> */
> -struct src_operand {
> +extern struct src_operand {
> struct brw_reg reg;
> int default_region;
> uint32_t imm32; /* set if src_operand is expressing a branch offset */
I suspect this was a typedef. I can't see any definition for the struct
src_operand src_operand, and I think it can be deleted.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern
2020-03-16 23:08 ` Chris Wilson
@ 2020-03-17 16:56 ` Lyude Paul
2020-03-19 17:29 ` Lyude Paul
0 siblings, 1 reply; 17+ messages in thread
From: Lyude Paul @ 2020-03-17 16:56 UTC (permalink / raw)
To: Chris Wilson, igt-dev
On Mon, 2020-03-16 at 23:08 +0000, Chris Wilson wrote:
> Quoting Lyude (2020-03-16 16:11:31)
> > From: Lyude Paul <lyude@redhat.com>
> >
> > Another spot where we fail compilation with -fcommon, due to src_operand
> > getting included in multiple translation units without being marked as
> > extern:
> >
> > /usr/bin/ld:
> > assembler/1ca89e8@@intel-gen4asm@exe/meson-
> > generated_gram.c.o:assembler/gen4asm.h:119:
> > multiple definition of `src_operand';
> > assembler/1ca89e8@@intel-gen4asm@exe/meson-
> > generated_lex.c.o:assembler/gen4asm.h:119:
> > first defined here
> > /usr/bin/ld:
> > assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
> > multiple definition of `src_operand';
> > assembler/1ca89e8@@intel-gen4asm@exe/meson-
> > generated_lex.c.o:assembler/gen4asm.h:119:
> > first defined here
> >
> > So, fix this by marking struct src_operand as extern.
> >
> > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > ---
> > assembler/gen4asm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
> > index 6b957e28..7845060c 100644
> > --- a/assembler/gen4asm.h
> > +++ b/assembler/gen4asm.h
> > @@ -111,7 +111,7 @@ struct regtype {
> > * This structure is the internal representation of source operands in
> > the
> > * parser.
> > */
> > -struct src_operand {
> > +extern struct src_operand {
> > struct brw_reg reg;
> > int default_region;
> > uint32_t imm32; /* set if src_operand is expressing a branch
> > offset */
>
> I suspect this was a typedef. I can't see any definition for the struct
> src_operand src_operand, and I think it can be deleted.
You sure about this? It appears to be referenced in assembler/gram.y:
assembler/gram.y:57:static struct src_operand src_null_reg =
assembler/gram.y:77:static struct src_operand ip_src =
assembler/gram.y:92: struct src_operand *src,
assembler/gram.y:95: struct src_operand *src,
(etc.)
Or are you suggesting we just move it into gram.y?
> -Chris
>
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern
2020-03-17 16:56 ` Lyude Paul
@ 2020-03-19 17:29 ` Lyude Paul
0 siblings, 0 replies; 17+ messages in thread
From: Lyude Paul @ 2020-03-19 17:29 UTC (permalink / raw)
To: Chris Wilson, igt-dev
On Tue, 2020-03-17 at 12:56 -0400, Lyude Paul wrote:
> On Mon, 2020-03-16 at 23:08 +0000, Chris Wilson wrote:
> > Quoting Lyude (2020-03-16 16:11:31)
> > > From: Lyude Paul <lyude@redhat.com>
> > >
> > > Another spot where we fail compilation with -fcommon, due to src_operand
> > > getting included in multiple translation units without being marked as
> > > extern:
> > >
> > > /usr/bin/ld:
> > > assembler/1ca89e8@@intel-gen4asm@exe/meson-
> > > generated_gram.c.o:assembler/gen4asm.h:119:
> > > multiple definition of `src_operand';
> > > assembler/1ca89e8@@intel-gen4asm@exe/meson-
> > > generated_lex.c.o:assembler/gen4asm.h:119:
> > > first defined here
> > > /usr/bin/ld:
> > > assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
> > > multiple definition of `src_operand';
> > > assembler/1ca89e8@@intel-gen4asm@exe/meson-
> > > generated_lex.c.o:assembler/gen4asm.h:119:
> > > first defined here
> > >
> > > So, fix this by marking struct src_operand as extern.
> > >
> > > Signed-off-by: Lyude Paul <lyude@redhat.com>
> > > ---
> > > assembler/gen4asm.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
> > > index 6b957e28..7845060c 100644
> > > --- a/assembler/gen4asm.h
> > > +++ b/assembler/gen4asm.h
> > > @@ -111,7 +111,7 @@ struct regtype {
> > > * This structure is the internal representation of source operands in
> > > the
> > > * parser.
> > > */
> > > -struct src_operand {
> > > +extern struct src_operand {
> > > struct brw_reg reg;
> > > int default_region;
> > > uint32_t imm32; /* set if src_operand is expressing a branch
> > > offset */
> >
> > I suspect this was a typedef. I can't see any definition for the struct
> > src_operand src_operand, and I think it can be deleted.
>
> You sure about this? It appears to be referenced in assembler/gram.y:
>
> assembler/gram.y:57:static struct src_operand src_null_reg =
> assembler/gram.y:77:static struct src_operand ip_src =
> assembler/gram.y:92: struct src_operand *src,
> assembler/gram.y:95: struct src_operand *src,
> (etc.)
>
> Or are you suggesting we just move it into gram.y?
ah-whoops, I just realized you were talking about the fact we defined it as a
variable at all, oops. will send a respin with this changed
> > -Chris
> >
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern Lyude
2020-03-16 23:08 ` Chris Wilson
@ 2020-03-16 23:10 ` Chris Wilson
2020-03-19 17:40 ` [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable Lyude
2 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2020-03-16 23:10 UTC (permalink / raw)
To: Lyude, igt-dev
Quoting Lyude (2020-03-16 16:11:31)
> From: Lyude Paul <lyude@redhat.com>
>
> Another spot where we fail compilation with -fcommon, due to src_operand
> getting included in multiple translation units without being marked as
> extern:
>
> /usr/bin/ld:
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
> multiple definition of `src_operand';
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
> first defined here
> /usr/bin/ld:
> assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
> multiple definition of `src_operand';
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
> first defined here
>
> So, fix this by marking struct src_operand as extern.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> ---
> assembler/gen4asm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
> index 6b957e28..7845060c 100644
> --- a/assembler/gen4asm.h
> +++ b/assembler/gen4asm.h
> @@ -111,7 +111,7 @@ struct regtype {
> * This structure is the internal representation of source operands in the
> * parser.
> */
> -struct src_operand {
> +extern struct src_operand {
> struct brw_reg reg;
> int default_region;
> uint32_t imm32; /* set if src_operand is expressing a branch offset */
I think this was a typedef, and I can't see any definition for the
src_operand so I think this declaration can be safely deleted.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern Lyude
2020-03-16 23:08 ` Chris Wilson
2020-03-16 23:10 ` Chris Wilson
@ 2020-03-19 17:40 ` Lyude
2020-03-20 12:24 ` Petri Latvala
2 siblings, 1 reply; 17+ messages in thread
From: Lyude @ 2020-03-19 17:40 UTC (permalink / raw)
To: igt-dev, Chris Wilson
From: Lyude Paul <lyude@redhat.com>
Another spot where we fail compilation with -fcommon, due to src_operand
getting included in multiple translation units without being marked as
extern:
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand';
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand';
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
However, we never actually refer to this variable - only its type
definition. So, just remove the declaration entirely.
Changes since v1:
* Don't make src_operand extern - just remove the variable declaration
entirely, we only ever use the typedef - Chris Wilson
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
assembler/gen4asm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
index 6b957e28..9537d457 100644
--- a/assembler/gen4asm.h
+++ b/assembler/gen4asm.h
@@ -116,7 +116,7 @@ struct src_operand {
int default_region;
uint32_t imm32; /* set if src_operand is expressing a branch offset */
char *reloc_target; /* bspec: branching instructions JIP and UIP are source operands */
-} src_operand;
+};
typedef struct {
enum {
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable
2020-03-19 17:40 ` [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable Lyude
@ 2020-03-20 12:24 ` Petri Latvala
0 siblings, 0 replies; 17+ messages in thread
From: Petri Latvala @ 2020-03-20 12:24 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev
On Thu, Mar 19, 2020 at 01:40:39PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> Another spot where we fail compilation with -fcommon, due to src_operand
> getting included in multiple translation units without being marked as
> extern:
>
> /usr/bin/ld:
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
> multiple definition of `src_operand';
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
> first defined here
> /usr/bin/ld:
> assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
> multiple definition of `src_operand';
> assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
> first defined here
>
> However, we never actually refer to this variable - only its type
> definition. So, just remove the declaration entirely.
>
> Changes since v1:
> * Don't make src_operand extern - just remove the variable declaration
> entirely, we only ever use the typedef - Chris Wilson
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> assembler/gen4asm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/assembler/gen4asm.h b/assembler/gen4asm.h
> index 6b957e28..9537d457 100644
> --- a/assembler/gen4asm.h
> +++ b/assembler/gen4asm.h
> @@ -116,7 +116,7 @@ struct src_operand {
> int default_region;
> uint32_t imm32; /* set if src_operand is expressing a branch offset */
> char *reloc_target; /* bspec: branching instructions JIP and UIP are source operands */
> -} src_operand;
> +};
>
> typedef struct {
> enum {
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
` (2 preceding siblings ...)
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern Lyude
@ 2020-03-16 16:11 ` Lyude
2020-03-17 6:34 ` Petri Latvala
2020-03-16 17:16 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes for GCC 10's -fcommon default Patchwork
` (2 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Lyude @ 2020-03-16 16:11 UTC (permalink / raw)
To: igt-dev
From: Lyude Paul <lyude@redhat.com>
Now that we've fixed a bunch of build breakages on systems where
-fcommon is the default (gcc 10+), let's start building with -fcommon by
default so we can make sure things don't break with this in the future.
Supposedly it's supposed to be able to generate better code anyway!
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/meson.build b/meson.build
index bcb69e1c..0d7092bd 100644
--- a/meson.build
+++ b/meson.build
@@ -70,6 +70,7 @@ cc_args = [
# well with longjmp which is heavily used by IGT framework.
'-fno-builtin-malloc',
'-fno-builtin-calloc',
+ '-fcommon',
]
foreach cc_arg : cc_args
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags Lyude
@ 2020-03-17 6:34 ` Petri Latvala
0 siblings, 0 replies; 17+ messages in thread
From: Petri Latvala @ 2020-03-17 6:34 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev
On Mon, Mar 16, 2020 at 12:11:32PM -0400, Lyude wrote:
> From: Lyude Paul <lyude@redhat.com>
>
> Now that we've fixed a bunch of build breakages on systems where
> -fcommon is the default (gcc 10+), let's start building with -fcommon by
> default so we can make sure things don't break with this in the future.
> Supposedly it's supposed to be able to generate better code anyway!
The documentation claims otherwise, "on many targets implies a speed
and code size penalty on global variable references". In fact the
documentation even claims you get the multiple definition errors for
variables with -fno-common and -fcommon helps avoiding them in legacy
code! It's completely backwards to what happens. Oh well.
With that said, the code was clearly wrong, thanks for the series.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Acked-by: Petri Latvala <petri.latvala@intel.com>
What this series proves is that no one is able to understand how
tentative definitions and tentative declarations work in C.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Fixes for GCC 10's -fcommon default
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
` (3 preceding siblings ...)
2020-03-16 16:11 ` [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags Lyude
@ 2020-03-16 17:16 ` Patchwork
2020-03-17 0:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-19 18:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fixes for GCC 10's -fcommon default (rev2) Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2020-03-16 17:16 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev
== Series Details ==
Series: Fixes for GCC 10's -fcommon default
URL : https://patchwork.freedesktop.org/series/74749/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8137 -> IGTPW_4310
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
Known issues
------------
Here are the changes found in IGTPW_4310 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927] / [i915#656])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-bxt-dsi/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-bxt-dsi/igt@i915_selftest@live@execlists.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][3] ([CI#94]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][5] ([i915#217]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][7] ([fdo#109271]) -> [FAIL][8] ([i915#665] / [i915#704])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([i915#323]) -> [FAIL][10] ([fdo#111407])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259
[i915#1430]: https://gitlab.freedesktop.org/drm/intel/issues/1430
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
[i915#665]: https://gitlab.freedesktop.org/drm/intel/issues/665
[i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704
Participating hosts (48 -> 42)
------------------------------
Additional (1): fi-tgl-dsi
Missing (7): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5510 -> IGTPW_4310
CI-20190529: 20190529
CI_DRM_8137: 5786b5e77cc17a1b494b9bdf3c3f29eedc2e2e7d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4310: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
IGT_5510: e100092d50105463f58db531fa953c70cc58bb10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for Fixes for GCC 10's -fcommon default
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
` (4 preceding siblings ...)
2020-03-16 17:16 ` [igt-dev] ✓ Fi.CI.BAT: success for Fixes for GCC 10's -fcommon default Patchwork
@ 2020-03-17 0:39 ` Patchwork
2020-03-19 18:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fixes for GCC 10's -fcommon default (rev2) Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2020-03-17 0:39 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev
== Series Details ==
Series: Fixes for GCC 10's -fcommon default
URL : https://patchwork.freedesktop.org/series/74749/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8137_full -> IGTPW_4310_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4310_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4310_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4310_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_shared@single-timeline:
- shard-snb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb4/igt@gem_ctx_shared@single-timeline.html
* igt@gem_eio@banned:
- shard-iclb: [PASS][2] -> [SKIP][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@gem_eio@banned.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb7/igt@gem_eio@banned.html
- shard-tglb: [PASS][4] -> [SKIP][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@gem_eio@banned.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@gem_eio@banned.html
* igt@gem_eio@kms:
- shard-glk: [PASS][6] -> [FAIL][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk5/igt@gem_eio@kms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@gem_eio@kms.html
* igt@gem_wait@busy-vecs0:
- shard-hsw: NOTRUN -> [FAIL][8] +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@gem_wait@busy-vecs0.html
* igt@gem_wait@write-wait-bcs0:
- shard-hsw: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@gem_wait@write-wait-bcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@gem_wait@write-wait-bcs0.html
* igt@i915_hangman@error-state-capture-vcs0:
- shard-snb: [PASS][11] -> [TIMEOUT][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@i915_hangman@error-state-capture-vcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb4/igt@i915_hangman@error-state-capture-vcs0.html
* igt@i915_pm_sseu@full-enable:
- shard-apl: [PASS][13] -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl7/igt@i915_pm_sseu@full-enable.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl6/igt@i915_pm_sseu@full-enable.html
- shard-kbl: [PASS][15] -> [FAIL][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl1/igt@i915_pm_sseu@full-enable.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@i915_pm_sseu@full-enable.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-snb: [PASS][17] -> [FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
New tests
---------
New tests have been introduced between CI_DRM_8137_full and IGTPW_4310_full:
### New IGT tests (10) ###
* igt@sysfs_heartbeat_interval@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@nopreempt:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@off:
- Statuses :
- Exec time: [None] s
* igt@sysfs_heartbeat_interval@precise:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_preempt_timeout@invalid:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@duration:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@idempotent:
- Statuses :
- Exec time: [None] s
* igt@sysfs_timeslice_duration@timeout:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in IGTPW_4310_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@close-replace-race:
- shard-kbl: [PASS][23] -> [INCOMPLETE][24] ([i915#1402])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl6/igt@gem_ctx_persistence@close-replace-race.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@gem_ctx_persistence@close-replace-race.html
- shard-glk: [PASS][25] -> [INCOMPLETE][26] ([i915#1402] / [i915#58] / [k.org#198133])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk3/igt@gem_ctx_persistence@close-replace-race.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk2/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#110841])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_ctx_shared@q-out-order-blt:
- shard-glk: [PASS][29] -> [FAIL][30] ([fdo#112118]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@gem_ctx_shared@q-out-order-blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk3/igt@gem_ctx_shared@q-out-order-blt.html
- shard-apl: [PASS][31] -> [FAIL][32] ([fdo#112118])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl8/igt@gem_ctx_shared@q-out-order-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl3/igt@gem_ctx_shared@q-out-order-blt.html
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#112118])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@gem_ctx_shared@q-out-order-blt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@gem_ctx_shared@q-out-order-blt.html
* igt@gem_ctx_shared@q-out-order-vebox:
- shard-kbl: [PASS][35] -> [FAIL][36] ([fdo#112118])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl6/igt@gem_ctx_shared@q-out-order-vebox.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@gem_ctx_shared@q-out-order-vebox.html
* igt@gem_eio@banned:
- shard-apl: [PASS][37] -> [SKIP][38] ([fdo#109271]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl8/igt@gem_eio@banned.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl3/igt@gem_eio@banned.html
- shard-glk: [PASS][39] -> [SKIP][40] ([fdo#109271]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@gem_eio@banned.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk3/igt@gem_eio@banned.html
- shard-kbl: [PASS][41] -> [SKIP][42] ([fdo#109271]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl3/igt@gem_eio@banned.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@gem_eio@banned.html
* igt@gem_exec_schedule@implicit-both-bsd1:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109276] / [i915#677]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@gem_exec_schedule@implicit-both-bsd1.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112146]) +8 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][47] -> [FAIL][48] ([i915#644])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk9/igt@gem_ppgtt@flink-and-close-vma-leak.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk4/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [PASS][49] -> [FAIL][50] ([i915#413])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@i915_pm_rps@waitboost.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@i915_pm_rps@waitboost.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-glk: [PASS][51] -> [FAIL][52] ([i915#407])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@kms_flip@2x-modeset-vs-vblank-race.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk8/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][53] -> [FAIL][54] ([i915#79])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][55] -> [DMESG-WARN][56] ([i915#180])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-snb: [PASS][57] -> [DMESG-WARN][58] ([i915#478])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_plane_lowres@pipe-c-tiling-x:
- shard-hsw: [PASS][59] -> [DMESG-WARN][60] ([i915#478])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw7/igt@kms_plane_lowres@pipe-c-tiling-x.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw5/igt@kms_plane_lowres@pipe-c-tiling-x.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][61] -> [SKIP][62] ([fdo#109441]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][63] -> [FAIL][64] ([i915#31])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk2/igt@kms_setmode@basic.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk8/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-query-idle-hang:
- shard-iclb: [PASS][65] -> [SKIP][66] ([fdo#109278])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@kms_vblank@pipe-c-query-idle-hang.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb7/igt@kms_vblank@pipe-c-query-idle-hang.html
- shard-tglb: [PASS][67] -> [SKIP][68] ([fdo#112015])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@kms_vblank@pipe-c-query-idle-hang.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@kms_vblank@pipe-c-query-idle-hang.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][69] -> [SKIP][70] ([fdo#112080]) +11 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@perf_pmu@busy-no-semaphores-vcs1.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][71] -> [SKIP][72] ([fdo#109276]) +17 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][73] ([fdo#112080]) -> [PASS][74] +12 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@gem_busy@busy-vcs1.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@rcs0-s3:
- shard-snb: [FAIL][75] -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@gem_ctx_isolation@rcs0-s3.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb5/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_persistence@close-replace-race:
- shard-tglb: [INCOMPLETE][77] ([i915#1402]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@gem_ctx_persistence@close-replace-race.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb1/igt@gem_ctx_persistence@close-replace-race.html
- shard-apl: [INCOMPLETE][79] ([fdo#103927] / [i915#1402]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl1/igt@gem_ctx_persistence@close-replace-race.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl8/igt@gem_ctx_persistence@close-replace-race.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-hsw: [TIMEOUT][81] -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw1/igt@gem_eio@in-flight-contexts-1us.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_parallel@bcs0-fds:
- shard-apl: [FAIL][83] -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@gem_exec_parallel@bcs0-fds.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl3/igt@gem_exec_parallel@bcs0-fds.html
- shard-iclb: [FAIL][85] -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@gem_exec_parallel@bcs0-fds.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb6/igt@gem_exec_parallel@bcs0-fds.html
- shard-tglb: [FAIL][87] -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@gem_exec_parallel@bcs0-fds.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb3/igt@gem_exec_parallel@bcs0-fds.html
- shard-glk: [FAIL][89] -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@gem_exec_parallel@bcs0-fds.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@gem_exec_parallel@bcs0-fds.html
* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [SKIP][91] ([fdo#109276] / [i915#677]) -> [PASS][92] +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@gem_exec_schedule@implicit-read-write-bsd1.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][93] ([fdo#112146]) -> [PASS][94] +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@gem_exec_schedule@in-order-bsd.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][95] ([i915#677]) -> [PASS][96] +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@gem_exec_schedule@pi-common-bsd.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb8/igt@gem_exec_schedule@pi-common-bsd.html
* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][97] ([fdo#109276]) -> [PASS][98] +15 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@gem_exec_schedule@preempt-contexts-bsd2.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@gem_exec_schedule@preempt-contexts-bsd2.html
* igt@gem_exec_schedule@preempt-hang-render:
- shard-apl: [SKIP][99] ([fdo#109271]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@gem_exec_schedule@preempt-hang-render.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl4/igt@gem_exec_schedule@preempt-hang-render.html
- shard-glk: [SKIP][101] ([fdo#109271]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@gem_exec_schedule@preempt-hang-render.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk6/igt@gem_exec_schedule@preempt-hang-render.html
- shard-iclb: [SKIP][103] -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@gem_exec_schedule@preempt-hang-render.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb1/igt@gem_exec_schedule@preempt-hang-render.html
- shard-tglb: [SKIP][105] -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@gem_exec_schedule@preempt-hang-render.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb6/igt@gem_exec_schedule@preempt-hang-render.html
- shard-kbl: [SKIP][107] ([fdo#109271]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl7/igt@gem_exec_schedule@preempt-hang-render.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl7/igt@gem_exec_schedule@preempt-hang-render.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][109] ([fdo#111870]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw7/igt@gem_userptr_blits@dmabuf-unsync.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw5/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][111] ([i915#180]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][113] ([i915#447]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb2/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_rpm@system-suspend-devices:
- shard-iclb: [SKIP][115] ([i915#1316]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@i915_pm_rpm@system-suspend-devices.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@i915_pm_rpm@system-suspend-devices.html
- shard-hsw: [SKIP][117] ([fdo#109271]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@i915_pm_rpm@system-suspend-devices.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw4/igt@i915_pm_rpm@system-suspend-devices.html
- shard-tglb: [SKIP][119] ([i915#1316]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb6/igt@i915_pm_rpm@system-suspend-devices.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@i915_pm_rpm@system-suspend-devices.html
* igt@i915_pm_rps@waitboost:
- shard-tglb: [FAIL][121] ([i915#413]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@i915_pm_rps@waitboost.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb5/igt@i915_pm_rps@waitboost.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][123] ([i915#72]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [INCOMPLETE][125] ([i915#61]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@kms_flip@flip-vs-suspend.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-kbl: [FAIL][127] ([i915#49]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
- shard-glk: [FAIL][129] ([i915#49]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
- shard-apl: [FAIL][131] ([i915#49]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-snb: [DMESG-WARN][133] ([i915#478]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [DMESG-WARN][135] ([i915#180]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][137] ([fdo#109441]) -> [PASS][138] +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_vblank@pipe-d-ts-continuation-modeset-hang:
- shard-tglb: [SKIP][139] ([fdo#112015]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@kms_vblank@pipe-d-ts-continuation-modeset-hang.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@kms_vblank@pipe-d-ts-continuation-modeset-hang.html
* igt@perf@gen12-mi-rpc:
- shard-tglb: [FAIL][141] ([i915#1085]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb6/igt@perf@gen12-mi-rpc.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb7/igt@perf@gen12-mi-rpc.html
* igt@perf_pmu@most-busy-idle-check-all-bcs0:
- shard-hsw: [FAIL][143] -> [PASS][144] +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@perf_pmu@most-busy-idle-check-all-bcs0.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw5/igt@perf_pmu@most-busy-idle-check-all-bcs0.html
#### Warnings ####
* igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt:
- shard-hsw: [DMESG-WARN][145] ([fdo#110789] / [i915#478]) -> [DMESG-WARN][146] ([i915#478])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw4/igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [SKIP][147] ([i915#468]) -> [FAIL][148] ([i915#454])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb6/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_content_protection@legacy:
- shard-apl: [TIMEOUT][149] ([i915#1319]) -> [FAIL][150] ([fdo#110321] / [fdo#110336])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl8/igt@kms_content_protection@legacy.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl4/igt@kms_content_protection@legacy.html
* igt@runner@aborted:
- shard-kbl: [FAIL][151] ([i915#92]) -> ([FAIL][152], [FAIL][153]) ([i915#1389] / [i915#1402] / [i915#92])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl3/igt@runner@aborted.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@runner@aborted.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@runner@aborted.html
- shard-apl: ([FAIL][154], [FAIL][155]) ([fdo#103927] / [i915#1402]) -> [FAIL][156] ([fdo#103927])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl3/igt@runner@aborted.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl1/igt@runner@aborted.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl1/igt@runner@aborted.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112015]: https://bugs.freedesktop.org/show_bug.cgi?id=112015
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112118]: https://bugs.freedesktop.org/show_bug.cgi?id=112118
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1389]: https://gitlab.freedesktop.org/drm/intel/issues/1389
[i915#1402]: https://gitlab.freedesktop.org/drm/intel/issues/1402
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#58]: https://gitlab.freedesktop.org/d
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for Fixes for GCC 10's -fcommon default (rev2)
2020-03-16 16:11 [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default Lyude
` (5 preceding siblings ...)
2020-03-17 0:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-03-19 18:59 ` Patchwork
6 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2020-03-19 18:59 UTC (permalink / raw)
To: Lyude; +Cc: igt-dev
== Series Details ==
Series: Fixes for GCC 10's -fcommon default (rev2)
URL : https://patchwork.freedesktop.org/series/74749/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8160 -> IGTPW_4329
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_4329 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_4329, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_4329:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-hsw-peppy: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8160/fi-hsw-peppy/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/fi-hsw-peppy/igt@i915_selftest@live@gt_heartbeat.html
Known issues
------------
Here are the changes found in IGTPW_4329 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927] / [i915#656])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8160/fi-bxt-dsi/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/fi-bxt-dsi/igt@i915_selftest@live@execlists.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([i915#323])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8160/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (37 -> 39)
------------------------------
Additional (6): fi-bsw-n3050 fi-byt-j1900 fi-cfl-8109u fi-skl-6600u fi-bsw-nick fi-skl-6700k2
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-kbl-8809g
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5523 -> IGTPW_4329
CI-20190529: 20190529
CI_DRM_8160: 6ba1729e5025761ab74914f6b8aa3288f493e9c7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4329: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/index.html
IGT_5523: cf6d524007ac51a7d5a48503ea3dd5f01fd4ebab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread