[meta-virtualization][PATCH] libvirt: Workaround mips assembler crash on target

[meta-virtualization][PATCH] libvirt: Workaround mips assembler crash on target

[hongxu]

While enabling multilib on qemumips64, lib32 assembler ends up
crashing on target sometimes due to branch out of range,
therefore using -O2 for now

[snip]
|../../libvirt-6.1.0/tests/qemuxml2argvtest.c: In function 'mymain':
|../../libvirt-6.1.0/tests/qemuxml2argvtest.c:608:1: note: variable
tracking size limit exceeded with '-fvar-tracking-assignments', retrying without
|  608 | mymain(void)
|      | ^~~~~~
|/tmp/ccXJSwZR.s: Assembler messages:
|/tmp/ccXJSwZR.s:43943: Error: branch out of range
[snip]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 recipes-extended/libvirt/libvirt_6.1.0.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/recipes-extended/libvirt/libvirt_6.1.0.bb b/recipes-extended/libvirt/libvirt_6.1.0.bb
index 0ad3d8b..44354a4 100644
--- a/recipes-extended/libvirt/libvirt_6.1.0.bb
+++ b/recipes-extended/libvirt/libvirt_6.1.0.bb
@@ -375,6 +375,11 @@ EXTRA_OECONF += " \
     --with-test-suite \
     "
 
+# gcc9 end up mis-compiling qemuxml2argvtest.o with Og which then
+# crashes on target, so remove -Og and use -O2 as workaround
+SELECTED_OPTIMIZATION_remove_virtclass-multilib-lib32_mipsarch = "-Og"
+SELECTED_OPTIMIZATION_append_virtclass-multilib-lib32_mipsarch = " -O2"
+
 EXTRA_OEMAKE = "BUILD_DIR=${B} DEST_DIR=${D}${PTEST_PATH} PTEST_DIR=${PTEST_PATH} SYSTEMD_UNIT_DIR=${systemd_system_unitdir}"
 
 PRIVATE_LIBS_${PN}-ptest_append = "libvirt-admin.so.0"
-- 
2.7.4

Re: [meta-virtualization][PATCH] libvirt: Workaround mips assembler crash on target

[Bruce Ashfield]

merged

Bruce

In message: [meta-virtualization][PATCH] libvirt: Workaround mips assembler crash on target
on 31/03/2020 hongxu wrote:

> While enabling multilib on qemumips64, lib32 assembler ends up
> crashing on target sometimes due to branch out of range,
> therefore using -O2 for now
> 
> [snip]
> |../../libvirt-6.1.0/tests/qemuxml2argvtest.c: In function 'mymain':
> |../../libvirt-6.1.0/tests/qemuxml2argvtest.c:608:1: note: variable
> tracking size limit exceeded with '-fvar-tracking-assignments', retrying without
> |  608 | mymain(void)
> |      | ^~~~~~
> |/tmp/ccXJSwZR.s: Assembler messages:
> |/tmp/ccXJSwZR.s:43943: Error: branch out of range
> [snip]
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  recipes-extended/libvirt/libvirt_6.1.0.bb | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/recipes-extended/libvirt/libvirt_6.1.0.bb b/recipes-extended/libvirt/libvirt_6.1.0.bb
> index 0ad3d8b..44354a4 100644
> --- a/recipes-extended/libvirt/libvirt_6.1.0.bb
> +++ b/recipes-extended/libvirt/libvirt_6.1.0.bb
> @@ -375,6 +375,11 @@ EXTRA_OECONF += " \
>      --with-test-suite \
>      "
>  
> +# gcc9 end up mis-compiling qemuxml2argvtest.o with Og which then
> +# crashes on target, so remove -Og and use -O2 as workaround
> +SELECTED_OPTIMIZATION_remove_virtclass-multilib-lib32_mipsarch = "-Og"
> +SELECTED_OPTIMIZATION_append_virtclass-multilib-lib32_mipsarch = " -O2"
> +
>  EXTRA_OEMAKE = "BUILD_DIR=${B} DEST_DIR=${D}${PTEST_PATH} PTEST_DIR=${PTEST_PATH} SYSTEMD_UNIT_DIR=${systemd_system_unitdir}"
>  
>  PRIVATE_LIBS_${PN}-ptest_append = "libvirt-admin.so.0"
> -- 
> 2.7.4
> 

>