* [PATCH] sched: Remove unused last_load_update_tick rq member
@ 2020-03-20 13:21 vincent.donnefort
2020-03-20 13:44 ` Dietmar Eggemann
2020-04-08 12:20 ` [tip: sched/urgent] sched/core: Remove unused rq::last_load_update_tick tip-bot2 for Vincent Donnefort
0 siblings, 2 replies; 4+ messages in thread
From: vincent.donnefort @ 2020-03-20 13:21 UTC (permalink / raw)
To: mingo, peterz
Cc: linux-kernel, dietmar.eggemann, valentin.schneider, Vincent Donnefort
From: Vincent Donnefort <vincent.donnefort@arm.com>
The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
code") eliminated the use case for rq->last_load_update_tick. Removing
it.
Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1a9983d..c41ee26 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6685,7 +6685,6 @@ void __init sched_init(void)
rq_attach_root(rq, &def_root_domain);
#ifdef CONFIG_NO_HZ_COMMON
- rq->last_load_update_tick = jiffies;
rq->last_blocked_load_update_tick = jiffies;
atomic_set(&rq->nohz_flags, 0);
#endif
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 9ea6478..6e14fad 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -860,7 +860,6 @@ struct rq {
#endif
#ifdef CONFIG_NO_HZ_COMMON
#ifdef CONFIG_SMP
- unsigned long last_load_update_tick;
unsigned long last_blocked_load_update_tick;
unsigned int has_blocked_load;
#endif /* CONFIG_SMP */
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sched: Remove unused last_load_update_tick rq member
2020-03-20 13:21 [PATCH] sched: Remove unused last_load_update_tick rq member vincent.donnefort
@ 2020-03-20 13:44 ` Dietmar Eggemann
2020-03-20 13:57 ` Vincent Guittot
2020-04-08 12:20 ` [tip: sched/urgent] sched/core: Remove unused rq::last_load_update_tick tip-bot2 for Vincent Donnefort
1 sibling, 1 reply; 4+ messages in thread
From: Dietmar Eggemann @ 2020-03-20 13:44 UTC (permalink / raw)
To: vincent.donnefort, mingo, peterz
Cc: linux-kernel, valentin.schneider, Vincent Guittot
+ Vincent Guittot
On 20.03.20 14:21, vincent.donnefort@arm.com wrote:
> From: Vincent Donnefort <vincent.donnefort@arm.com>
>
> The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
> code") eliminated the use case for rq->last_load_update_tick. Removing
> it.
>
> Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 1a9983d..c41ee26 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6685,7 +6685,6 @@ void __init sched_init(void)
>
> rq_attach_root(rq, &def_root_domain);
> #ifdef CONFIG_NO_HZ_COMMON
> - rq->last_load_update_tick = jiffies;
> rq->last_blocked_load_update_tick = jiffies;
> atomic_set(&rq->nohz_flags, 0);
> #endif
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 9ea6478..6e14fad 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -860,7 +860,6 @@ struct rq {
> #endif
> #ifdef CONFIG_NO_HZ_COMMON
> #ifdef CONFIG_SMP
> - unsigned long last_load_update_tick;
> unsigned long last_blocked_load_update_tick;
> unsigned int has_blocked_load;
> #endif /* CONFIG_SMP */
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sched: Remove unused last_load_update_tick rq member
2020-03-20 13:44 ` Dietmar Eggemann
@ 2020-03-20 13:57 ` Vincent Guittot
0 siblings, 0 replies; 4+ messages in thread
From: Vincent Guittot @ 2020-03-20 13:57 UTC (permalink / raw)
To: Dietmar Eggemann
Cc: Vincent Donnefort, Ingo Molnar, Peter Zijlstra, linux-kernel,
Valentin Schneider
On Fri, 20 Mar 2020 at 14:44, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
> + Vincent Guittot
Thanks Dietmar
>
> On 20.03.20 14:21, vincent.donnefort@arm.com wrote:
> > From: Vincent Donnefort <vincent.donnefort@arm.com>
> >
> > The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
> > code") eliminated the use case for rq->last_load_update_tick. Removing
> > it.
> >
> > Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 1a9983d..c41ee26 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6685,7 +6685,6 @@ void __init sched_init(void)
> >
> > rq_attach_root(rq, &def_root_domain);
> > #ifdef CONFIG_NO_HZ_COMMON
> > - rq->last_load_update_tick = jiffies;
> > rq->last_blocked_load_update_tick = jiffies;
> > atomic_set(&rq->nohz_flags, 0);
> > #endif
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index 9ea6478..6e14fad 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -860,7 +860,6 @@ struct rq {
> > #endif
> > #ifdef CONFIG_NO_HZ_COMMON
> > #ifdef CONFIG_SMP
> > - unsigned long last_load_update_tick;
> > unsigned long last_blocked_load_update_tick;
> > unsigned int has_blocked_load;
> > #endif /* CONFIG_SMP */
>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: sched/urgent] sched/core: Remove unused rq::last_load_update_tick
2020-03-20 13:21 [PATCH] sched: Remove unused last_load_update_tick rq member vincent.donnefort
2020-03-20 13:44 ` Dietmar Eggemann
@ 2020-04-08 12:20 ` tip-bot2 for Vincent Donnefort
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Vincent Donnefort @ 2020-04-08 12:20 UTC (permalink / raw)
To: linux-tip-commits
Cc: Dietmar Eggemann, Vincent Guittot, Vincent Donnefort,
Peter Zijlstra (Intel),
Ingo Molnar, x86, LKML
The following commit has been merged into the sched/urgent branch of tip:
Commit-ID: 275b2f6723ab9173484e1055ae138d4c2dd9d7c5
Gitweb: https://git.kernel.org/tip/275b2f6723ab9173484e1055ae138d4c2dd9d7c5
Author: Vincent Donnefort <vincent.donnefort@arm.com>
AuthorDate: Fri, 20 Mar 2020 13:21:35
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 08 Apr 2020 11:35:23 +02:00
sched/core: Remove unused rq::last_load_update_tick
The following commit:
5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update code")
eliminated the last use case for rq->last_load_update_tick, so remove
the field as well.
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/1584710495-308969-1-git-send-email-vincent.donnefort@arm.com
---
kernel/sched/core.c | 1 -
kernel/sched/sched.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c3d12e3..3a61a3b 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6694,7 +6694,6 @@ void __init sched_init(void)
rq_attach_root(rq, &def_root_domain);
#ifdef CONFIG_NO_HZ_COMMON
- rq->last_load_update_tick = jiffies;
rq->last_blocked_load_update_tick = jiffies;
atomic_set(&rq->nohz_flags, 0);
#endif
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index cd00814..db3a576 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -888,7 +888,6 @@ struct rq {
#endif
#ifdef CONFIG_NO_HZ_COMMON
#ifdef CONFIG_SMP
- unsigned long last_load_update_tick;
unsigned long last_blocked_load_update_tick;
unsigned int has_blocked_load;
#endif /* CONFIG_SMP */
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-08 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 13:21 [PATCH] sched: Remove unused last_load_update_tick rq member vincent.donnefort
2020-03-20 13:44 ` Dietmar Eggemann
2020-03-20 13:57 ` Vincent Guittot
2020-04-08 12:20 ` [tip: sched/urgent] sched/core: Remove unused rq::last_load_update_tick tip-bot2 for Vincent Donnefort
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.