* [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile
@ 2020-04-08 16:52 Chandana kalluri
2020-04-08 16:52 ` [meta-virtualization][master][PATCH 2/2] go-build_git.bb: go-build: set GO_PARALLEL_BUILD to default value Chandana kalluri
2020-04-09 3:08 ` [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Bruce Ashfield
0 siblings, 2 replies; 3+ messages in thread
From: Chandana kalluri @ 2020-04-08 16:52 UTC (permalink / raw)
To: meta-virtualization; +Cc: Sai Hari Chandana Kalluri
go-build recipe depends on runc source and during compilation tries to run the
command: go get github.com/opencontainers/runc.
This is incorrect as a source fetch shouldn't occur during compilation. Also,
even after a fetch occurs during compilation, the go build path GOPATH points
to the incorrect path hence the runc source is never found.
Fetch the opencontainers/runc source and create links in the correct GOPATH
before compilation for a successful build.
Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
---
recipes-devtools/go/go-build_git.bb | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/recipes-devtools/go/go-build_git.bb b/recipes-devtools/go/go-build_git.bb
index c11ad99..f94a722 100644
--- a/recipes-devtools/go/go-build_git.bb
+++ b/recipes-devtools/go/go-build_git.bb
@@ -3,8 +3,11 @@ SUMMARY = "console for runx"
DESCRIPTION = "Xen Runtime for OCI"
SRCREV_runx = "da0c75c58ae5232d19b1791c33545db3225e1ea9"
+SRCREV_runc = "e4363b038787addfa12e8b0acf5417d4fba01693"
+
SRC_URI = "\
git://github.com/lf-edge/runx;nobranch=1;name=runx \
+ git://github.com/opencontainers/runc.git;nobranch=1;destsuffix=runc;name=runc \
"
SRC_URI[md5sum] = "0d701ac1e2a67d47ce7127432df2c32b"
SRC_URI[sha256sum] = "5a26478906d5005f4f809402e981518d2b8844949199f60c4b6e1f986ca2a769"
@@ -29,6 +32,9 @@ do_compile() {
export GOARCH="${TARGET_GOARCH}"
cd ${S}/src/import/gobuild
+ mkdir -p go/src/github.com/opencontainers
+ ln -s ${WORKDIR}/runc ${S}/src/import/gobuild/go/src/github.com/opencontainers/runc
+ export GOPATH="${S}/src/import/gobuild/go/src/github.com/opencontainers/runc"
oe_runmake
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [meta-virtualization][master][PATCH 2/2] go-build_git.bb: go-build: set GO_PARALLEL_BUILD to default value
2020-04-08 16:52 [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Chandana kalluri
@ 2020-04-08 16:52 ` Chandana kalluri
2020-04-09 3:08 ` [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Bruce Ashfield
1 sibling, 0 replies; 3+ messages in thread
From: Chandana kalluri @ 2020-04-08 16:52 UTC (permalink / raw)
To: meta-virtualization; +Cc: Sai Hari Chandana Kalluri, Bruce Ashfield
Set GO_PARALLEL_BUILD to default to prevent the following error:
failed to create new OS thread (have 13 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc
Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
Signed-off-by: Bruce Ashfield <bruce.ashfield@xilinx.com>
---
recipes-devtools/go/go-build_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-devtools/go/go-build_git.bb b/recipes-devtools/go/go-build_git.bb
index f94a722..e057b6d 100644
--- a/recipes-devtools/go/go-build_git.bb
+++ b/recipes-devtools/go/go-build_git.bb
@@ -20,6 +20,7 @@ PV = "0.1-git${SRCREV_runx}"
inherit features_check
REQUIRED_DISTRO_FEATURES = "vmsep"
+GO_PARALLEL_BUILD ?= "${@oe.utils.parallel_make_argument(d, '-p %d')}"
inherit pkgconfig
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile
2020-04-08 16:52 [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Chandana kalluri
2020-04-08 16:52 ` [meta-virtualization][master][PATCH 2/2] go-build_git.bb: go-build: set GO_PARALLEL_BUILD to default value Chandana kalluri
@ 2020-04-09 3:08 ` Bruce Ashfield
1 sibling, 0 replies; 3+ messages in thread
From: Bruce Ashfield @ 2020-04-09 3:08 UTC (permalink / raw)
To: Chandana kalluri
Cc: meta-virtualization, Sai Hari Chandana Kalluri, Bruce Ashfield
merged
Bruce
In message: [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile
on 08/04/2020 Chandana kalluri wrote:
> go-build recipe depends on runc source and during compilation tries to run the
> command: go get github.com/opencontainers/runc.
>
> This is incorrect as a source fetch shouldn't occur during compilation. Also,
> even after a fetch occurs during compilation, the go build path GOPATH points
> to the incorrect path hence the runc source is never found.
>
> Fetch the opencontainers/runc source and create links in the correct GOPATH
> before compilation for a successful build.
>
> Signed-off-by: Sai Hari Chandana Kalluri <chandana.kalluri@xilinx.com>
> ---
> recipes-devtools/go/go-build_git.bb | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/recipes-devtools/go/go-build_git.bb b/recipes-devtools/go/go-build_git.bb
> index c11ad99..f94a722 100644
> --- a/recipes-devtools/go/go-build_git.bb
> +++ b/recipes-devtools/go/go-build_git.bb
> @@ -3,8 +3,11 @@ SUMMARY = "console for runx"
> DESCRIPTION = "Xen Runtime for OCI"
>
> SRCREV_runx = "da0c75c58ae5232d19b1791c33545db3225e1ea9"
> +SRCREV_runc = "e4363b038787addfa12e8b0acf5417d4fba01693"
> +
> SRC_URI = "\
> git://github.com/lf-edge/runx;nobranch=1;name=runx \
> + git://github.com/opencontainers/runc.git;nobranch=1;destsuffix=runc;name=runc \
> "
> SRC_URI[md5sum] = "0d701ac1e2a67d47ce7127432df2c32b"
> SRC_URI[sha256sum] = "5a26478906d5005f4f809402e981518d2b8844949199f60c4b6e1f986ca2a769"
> @@ -29,6 +32,9 @@ do_compile() {
>
> export GOARCH="${TARGET_GOARCH}"
> cd ${S}/src/import/gobuild
> + mkdir -p go/src/github.com/opencontainers
> + ln -s ${WORKDIR}/runc ${S}/src/import/gobuild/go/src/github.com/opencontainers/runc
> + export GOPATH="${S}/src/import/gobuild/go/src/github.com/opencontainers/runc"
> oe_runmake
> }
>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-09 3:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-08 16:52 [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Chandana kalluri
2020-04-08 16:52 ` [meta-virtualization][master][PATCH 2/2] go-build_git.bb: go-build: set GO_PARALLEL_BUILD to default value Chandana kalluri
2020-04-09 3:08 ` [meta-virtualization][master][PATCH 1/2] go-build: Set up dependencies and GOPATH before do_compile Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.