* [PATCH] ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts
@ 2020-04-09 8:30 ` Manikanta Pubbisetty
0 siblings, 0 replies; 4+ messages in thread
From: Manikanta Pubbisetty @ 2020-04-09 8:30 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless, Manikanta Pubbisetty
Unlike CE interrupts, DP interrupts are not enabled/disabled at
source; they are enabled/disabled only at GIC level, therefore
it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious
interrupts.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/ahb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index 59342d2..3b2b76d 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -788,7 +788,7 @@ static int ath11k_ahb_ext_irq_config(struct ath11k_base *ab)
irq = platform_get_irq_byname(ab->pdev,
irq_name[irq_idx]);
ab->irq_num[irq_idx] = irq;
- irq_set_status_flags(irq, IRQ_NOAUTOEN);
+ irq_set_status_flags(irq, IRQ_NOAUTOEN | IRQ_DISABLE_UNLAZY);
ret = request_irq(irq, ath11k_ahb_ext_interrupt_handler,
IRQF_TRIGGER_RISING,
irq_name[irq_idx], irq_grp);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts
@ 2020-04-09 8:30 ` Manikanta Pubbisetty
0 siblings, 0 replies; 4+ messages in thread
From: Manikanta Pubbisetty @ 2020-04-09 8:30 UTC (permalink / raw)
To: ath11k; +Cc: Manikanta Pubbisetty, linux-wireless
Unlike CE interrupts, DP interrupts are not enabled/disabled at
source; they are enabled/disabled only at GIC level, therefore
it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious
interrupts.
Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/ahb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index 59342d2..3b2b76d 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -788,7 +788,7 @@ static int ath11k_ahb_ext_irq_config(struct ath11k_base *ab)
irq = platform_get_irq_byname(ab->pdev,
irq_name[irq_idx]);
ab->irq_num[irq_idx] = irq;
- irq_set_status_flags(irq, IRQ_NOAUTOEN);
+ irq_set_status_flags(irq, IRQ_NOAUTOEN | IRQ_DISABLE_UNLAZY);
ret = request_irq(irq, ath11k_ahb_ext_interrupt_handler,
IRQF_TRIGGER_RISING,
irq_name[irq_idx], irq_grp);
--
2.7.4
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts
2020-04-09 8:30 ` Manikanta Pubbisetty
(?)
(?)
@ 2020-04-14 8:33 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-04-14 8:33 UTC (permalink / raw)
To: Manikanta Pubbisetty; +Cc: ath11k, linux-wireless, Manikanta Pubbisetty
Manikanta Pubbisetty <mpubbise@codeaurora.org> wrote:
> Unlike CE interrupts, DP interrupts are not enabled/disabled at
> source; they are enabled/disabled only at GIC level, therefore
> it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious
> interrupts.
>
> Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
05090864fc7e ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts
--
https://patchwork.kernel.org/patch/11481417/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts
2020-04-09 8:30 ` Manikanta Pubbisetty
(?)
@ 2020-04-14 8:33 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2020-04-14 8:33 UTC (permalink / raw)
To: Manikanta Pubbisetty; +Cc: linux-wireless, ath11k
Manikanta Pubbisetty <mpubbise@codeaurora.org> wrote:
> Unlike CE interrupts, DP interrupts are not enabled/disabled at
> source; they are enabled/disabled only at GIC level, therefore
> it is required to set IRQ_DISABLE_UNLAZY flag to avoid spurious
> interrupts.
>
> Signed-off-by: Manikanta Pubbisetty <mpubbise@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
05090864fc7e ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts
--
https://patchwork.kernel.org/patch/11481417/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-14 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 8:30 [PATCH] ath11k: set IRQ_DISABLE_UNLAZY flag for DP interrupts Manikanta Pubbisetty
2020-04-09 8:30 ` Manikanta Pubbisetty
2020-04-14 8:33 ` Kalle Valo
2020-04-14 8:33 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.