All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: mtk.manpages@gmail.com, Andrea Arcangeli <aarcange@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-man@vger.kernel.org
Subject: Re: [PATCH man-pages 1/5] ioctl_userfaultfd.2: update description of shared memory areas
Date: Tue, 2 May 2017 22:23:28 +0200	[thread overview]
Message-ID: <1586d8ea-342c-c652-86f4-a7fafc8c7be6@gmail.com> (raw)
In-Reply-To: <20170502093110.GA5910@rapoport-lnx>

On 05/02/2017 11:31 AM, Mike Rapoport wrote:
> On Mon, May 01, 2017 at 08:33:31PM +0200, Michael Kerrisk (man-pages) wrote:
>> Hello Mike,
>>
>> I've applied this patch, but  have a question.
>>
>> On 05/01/2017 07:43 AM, Mike Rapoport wrote:
>>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
>>> ---
>>>  man2/ioctl_userfaultfd.2 | 13 +++++++++++--
>>>  1 file changed, 11 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
>>> index 889feb9..6edd396 100644
>>> --- a/man2/ioctl_userfaultfd.2
>>> +++ b/man2/ioctl_userfaultfd.2
>>> @@ -181,8 +181,17 @@ virtual memory areas
>>>  .TP
>>>  .B UFFD_FEATURE_MISSING_SHMEM
>>>  If this feature bit is set,
>>> -the kernel supports registering userfaultfd ranges on tmpfs
>>> -virtual memory areas
>>> +the kernel supports registering userfaultfd ranges on shared memory areas.
>>> +This includes all kernel shared memory APIs:
>>> +System V shared memory,
>>> +tmpfs,
>>> +/dev/zero,
>>> +.BR mmap(2)
>>> +with
>>> +.I MAP_SHARED
>>> +flag set,
>>> +.BR memfd_create (2),
>>> +etc.
>>>  
>>>  The returned
>>>  .I ioctls
>>
>> Does the change in this patch represent a change that occurred in
>> Linux 4.11? If so, I think this needs to be said explicitly in the text.
> 
> The patch only extends the description of UFFD_FEATURE_MISSING_SHMEM. The
> feature is indeed available from 4.11, but that is said a few lives above
> (line 136 in ioctl_userfaultfd.2)

Okay -- thanks for the clarification.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: mtk.manpages@gmail.com, Andrea Arcangeli <aarcange@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-man@vger.kernel.org
Subject: Re: [PATCH man-pages 1/5] ioctl_userfaultfd.2: update description of shared memory areas
Date: Tue, 2 May 2017 22:23:28 +0200	[thread overview]
Message-ID: <1586d8ea-342c-c652-86f4-a7fafc8c7be6@gmail.com> (raw)
In-Reply-To: <20170502093110.GA5910@rapoport-lnx>

On 05/02/2017 11:31 AM, Mike Rapoport wrote:
> On Mon, May 01, 2017 at 08:33:31PM +0200, Michael Kerrisk (man-pages) wrote:
>> Hello Mike,
>>
>> I've applied this patch, but  have a question.
>>
>> On 05/01/2017 07:43 AM, Mike Rapoport wrote:
>>> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
>>> ---
>>>  man2/ioctl_userfaultfd.2 | 13 +++++++++++--
>>>  1 file changed, 11 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2
>>> index 889feb9..6edd396 100644
>>> --- a/man2/ioctl_userfaultfd.2
>>> +++ b/man2/ioctl_userfaultfd.2
>>> @@ -181,8 +181,17 @@ virtual memory areas
>>>  .TP
>>>  .B UFFD_FEATURE_MISSING_SHMEM
>>>  If this feature bit is set,
>>> -the kernel supports registering userfaultfd ranges on tmpfs
>>> -virtual memory areas
>>> +the kernel supports registering userfaultfd ranges on shared memory areas.
>>> +This includes all kernel shared memory APIs:
>>> +System V shared memory,
>>> +tmpfs,
>>> +/dev/zero,
>>> +.BR mmap(2)
>>> +with
>>> +.I MAP_SHARED
>>> +flag set,
>>> +.BR memfd_create (2),
>>> +etc.
>>>  
>>>  The returned
>>>  .I ioctls
>>
>> Does the change in this patch represent a change that occurred in
>> Linux 4.11? If so, I think this needs to be said explicitly in the text.
> 
> The patch only extends the description of UFFD_FEATURE_MISSING_SHMEM. The
> feature is indeed available from 4.11, but that is said a few lives above
> (line 136 in ioctl_userfaultfd.2)

Okay -- thanks for the clarification.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-05-02 20:23 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01  5:43 [PATCH man-pages 0/5] {ioctl_}userfaultfd.2: yet another update Mike Rapoport
2017-05-01  5:43 ` Mike Rapoport
2017-05-01  5:43 ` [PATCH man-pages 1/5] ioctl_userfaultfd.2: update description of shared memory areas Mike Rapoport
2017-05-01  5:43   ` Mike Rapoport
2017-05-01 18:33   ` Michael Kerrisk (man-pages)
2017-05-01 18:33     ` Michael Kerrisk (man-pages)
2017-05-02  9:31     ` Mike Rapoport
2017-05-02  9:31       ` Mike Rapoport
2017-05-02  9:31       ` Mike Rapoport
2017-05-02 20:23       ` Michael Kerrisk (man-pages) [this message]
2017-05-02 20:23         ` Michael Kerrisk (man-pages)
2017-05-01  5:43 ` [PATCH man-pages 2/5] ioctl_userfaultfd.2: UFFDIO_COPY: add ENOENT and ENOSPC description Mike Rapoport
2017-05-01  5:43   ` Mike Rapoport
2017-05-01 18:33   ` Michael Kerrisk (man-pages)
2017-05-01 18:33     ` Michael Kerrisk (man-pages)
2017-05-01  5:43 ` [PATCH man-pages 3/5] ioctl_userfaultfd.2: add BUGS section Mike Rapoport
2017-05-01  5:43   ` Mike Rapoport
2017-05-01 18:33   ` Michael Kerrisk (man-pages)
2017-05-01 18:33     ` Michael Kerrisk (man-pages)
2017-05-02  9:32     ` Mike Rapoport
2017-05-02  9:32       ` Mike Rapoport
2017-05-02  9:32       ` Mike Rapoport
2017-05-01  5:43 ` [PATCH man-pages 4/5] userfaultfd.2: add note about asynchronios events delivery Mike Rapoport
2017-05-01  5:43   ` Mike Rapoport
2017-05-01 18:33   ` Michael Kerrisk (man-pages)
2017-05-01 18:33     ` Michael Kerrisk (man-pages)
2017-05-02  9:46     ` Mike Rapoport
2017-05-02  9:46       ` Mike Rapoport
2017-05-02 20:27       ` Michael Kerrisk (man-pages)
2017-05-02 20:27         ` Michael Kerrisk (man-pages)
2017-05-01  5:43 ` [PATCH man-pages 5/5] userfaultfd.2: update VERSIONS section with 4.11 chanegs Mike Rapoport
2017-05-01  5:43   ` Mike Rapoport
2017-05-01 18:33   ` Michael Kerrisk (man-pages)
2017-05-01 18:33     ` Michael Kerrisk (man-pages)
2017-05-01 18:34 ` [PATCH man-pages 0/5] {ioctl_}userfaultfd.2: yet another update Michael Kerrisk (man-pages)
2017-05-01 18:34   ` Michael Kerrisk (man-pages)
2017-05-02  9:48   ` Mike Rapoport
2017-05-02  9:48     ` Mike Rapoport
2017-05-02 20:28     ` Michael Kerrisk (man-pages)
2017-05-02 20:28       ` Michael Kerrisk (man-pages)
2017-05-02 20:28       ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1586d8ea-342c-c652-86f4-a7fafc8c7be6@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.