[Intel-gfx] [PATCH] drm/i915/selftests: Show the pstate limits on any failure to reset min

[Intel-gfx] [PATCH] drm/i915/selftests: Show the pstate limits on any failure to reset min

[Chris Wilson]

We want to see the pstate limits whenever we fail to set the minimum
frequency as that may help for debugging.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_rps.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
index d7cd673550ef..e0a791eac752 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rps.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
@@ -238,6 +238,7 @@ int live_rps_control(void *arg)
 			pr_err("%s: could not set minimum frequency [%x], only %x!\n",
 			       engine->name, rps->min_freq, read_cagf(rps));
 			igt_spinner_end(&spin);
+			show_pstate_limits(rps);
 			err = -EINVAL;
 			break;
 		}
@@ -278,6 +279,7 @@ int live_rps_control(void *arg)
 		if (limit == rps->min_freq) {
 			pr_err("%s: GPU throttled to minimum!\n",
 			       engine->name);
+			show_pstate_limits(rps);
 			err = -ENODEV;
 			break;
 		}
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Show the pstate limits on any failure to reset min

[Patchwork]

== Series Details ==

Series: drm/i915/selftests: Show the pstate limits on any failure to reset min
URL   : https://patchwork.freedesktop.org/series/76214/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8335 -> Patchwork_17392
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_17392 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_17392, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17392/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_17392:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_exec_fence@basic-await@vecs0:
    - fi-apl-guc:         [PASS][1] -> [DMESG-WARN][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8335/fi-apl-guc/igt@gem_exec_fence@basic-await@vecs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17392/fi-apl-guc/igt@gem_exec_fence@basic-await@vecs0.html

  
Known issues
------------

  Here are the changes found in Patchwork_17392 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live@hangcheck:
    - fi-icl-y:           [INCOMPLETE][3] ([i915#1580]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8335/fi-icl-y/igt@i915_selftest@live@hangcheck.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17392/fi-icl-y/igt@i915_selftest@live@hangcheck.html

  
  [i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580


Participating hosts (51 -> 43)
------------------------------

  Missing    (8): fi-cml-u2 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_8335 -> Patchwork_17392

  CI-20190529: 20190529
  CI_DRM_8335: ad015a5ae83e52e4eac4975e27c0db4d633345ce @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17392: a768fba3d8d9177eb720b9ceb55aa8c42ae8d39c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

a768fba3d8d9 drm/i915/selftests: Show the pstate limits on any failure to reset min

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17392/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Show the pstate limits on any failure to reset min

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> We want to see the pstate limits whenever we fail to set the minimum
> frequency as that may help for debugging.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/selftest_rps.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index d7cd673550ef..e0a791eac752 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -238,6 +238,7 @@ int live_rps_control(void *arg)
>  			pr_err("%s: could not set minimum frequency [%x], only %x!\n",
>  			       engine->name, rps->min_freq, read_cagf(rps));
>  			igt_spinner_end(&spin);
> +			show_pstate_limits(rps);
>  			err = -EINVAL;
>  			break;
>  		}
> @@ -278,6 +279,7 @@ int live_rps_control(void *arg)
>  		if (limit == rps->min_freq) {
>  			pr_err("%s: GPU throttled to minimum!\n",
>  			       engine->name);
> +			show_pstate_limits(rps);
>  			err = -ENODEV;
>  			break;
>  		}
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Show the pstate limits on any failure to reset min

[Chris Wilson]

Quoting Mika Kuoppala (2020-04-21 09:28:41)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > We want to see the pstate limits whenever we fail to set the minimum
> > frequency as that may help for debugging.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

It was a nice idea but for soraka, it reports 0x000000ff, which means
unlimited [min = 0, max = ff]. Grr.

Thanks for the review, it may help for some systems!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx