[igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[Umesh Nerlige Ramappa]

The gen12-mi-rpc test checks for B0 counter to be zero, however,
occassionally the counter reads a non-zero value. To ensure the test
works as expected, we check B0 with the preset value.

Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
---
 tests/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/perf.c b/tests/perf.c
index b7d5e50e..9d0ed45c 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
 	 */
 	igt_assert_eq(report32[0], REPORT_ID);
 	igt_assert_neq(report32[1], 0);
-	igt_assert_eq(report32[format.b_off >> 2], 0);
+	igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
 	igt_assert_eq(report32[format_size_32], 0x80808080);
 
 	drm_intel_bo_unmap(bo);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for tests/perf: Fix B0 counter check in gen12-mi-rpc

[Patchwork]

== Series Details ==

Series: tests/perf: Fix B0 counter check in gen12-mi-rpc
URL   : https://patchwork.freedesktop.org/series/76278/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5604 -> IGTPW_4497
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_4497 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_4497, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_4497:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@workarounds:
    - fi-byt-j1900:       [PASS][1] -> [FAIL][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5604/fi-byt-j1900/igt@i915_selftest@live@workarounds.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/fi-byt-j1900/igt@i915_selftest@live@workarounds.html

  
Known issues
------------

  Here are the changes found in IGTPW_4497 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-soraka:      [DMESG-FAIL][3] ([i915#541]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5604/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_mocs:
    - fi-snb-2600:        [FAIL][5] ([i915#1763]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5604/fi-snb-2600/igt@i915_selftest@live@gt_mocs.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/fi-snb-2600/igt@i915_selftest@live@gt_mocs.html

  
#### Warnings ####

  * igt@amdgpu/amd_basic@query-info:
    - fi-bwr-2160:        [FAIL][7] -> [SKIP][8] ([fdo#109271])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5604/fi-bwr-2160/igt@amdgpu/amd_basic@query-info.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/fi-bwr-2160/igt@amdgpu/amd_basic@query-info.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1763]: https://gitlab.freedesktop.org/drm/intel/issues/1763
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541


Participating hosts (49 -> 43)
------------------------------

  Additional (1): fi-kbl-7560u 
  Missing    (7): fi-cml-u2 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5604 -> IGTPW_4497

  CI-20190529: 20190529
  CI_DRM_8345: e1fa8774e58e663bec8257f678c2f8fd17088292 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_4497: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/index.html
  IGT_5604: 18cc19ece602ba552a8386222b49e7e82820f9aa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4497/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[Lionel Landwerlin]

On 21/04/2020 21:22, Umesh Nerlige Ramappa wrote:
> The gen12-mi-rpc test checks for B0 counter to be zero, however,
> occassionally the counter reads a non-zero value. To ensure the test
> works as expected, we check B0 with the preset value.


What the value being reported?


Sounds like we should ask around see if there isn't a deeper problem 
with the HW configuration.


-Lionel


>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
> ---
>   tests/perf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index b7d5e50e..9d0ed45c 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
>   	 */
>   	igt_assert_eq(report32[0], REPORT_ID);
>   	igt_assert_neq(report32[1], 0);
> -	igt_assert_eq(report32[format.b_off >> 2], 0);
> +	igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
>   	igt_assert_eq(report32[format_size_32], 0x80808080);
>   
>   	drm_intel_bo_unmap(bo);


_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[Umesh Nerlige Ramappa]

On Tue, Apr 21, 2020 at 11:06:27PM +0300, Lionel Landwerlin wrote:
>On 21/04/2020 21:22, Umesh Nerlige Ramappa wrote:
>>The gen12-mi-rpc test checks for B0 counter to be zero, however,
>>occassionally the counter reads a non-zero value. To ensure the test
>>works as expected, we check B0 with the preset value.
>
>
>What the value being reported?
>
>
>Sounds like we should ask around see if there isn't a deeper problem 
>with the HW configuration.
>

I have seen values 0x121 and 0x1ec. The issue occurs sometimes on 
reboots. Subsequent runs I see that the counter is 0.

Thanks,
Umesh

>
>-Lionel
>
>
>>
>>Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>>Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
>>---
>>  tests/perf.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/tests/perf.c b/tests/perf.c
>>index b7d5e50e..9d0ed45c 100644
>>--- a/tests/perf.c
>>+++ b/tests/perf.c
>>@@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
>>  	 */
>>  	igt_assert_eq(report32[0], REPORT_ID);
>>  	igt_assert_neq(report32[1], 0);
>>-	igt_assert_eq(report32[format.b_off >> 2], 0);
>>+	igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
>>  	igt_assert_eq(report32[format_size_32], 0x80808080);
>>  	drm_intel_bo_unmap(bo);
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[Lionel Landwerlin]

On 22/04/2020 18:47, Umesh Nerlige Ramappa wrote:
> On Tue, Apr 21, 2020 at 11:06:27PM +0300, Lionel Landwerlin wrote:
>> On 21/04/2020 21:22, Umesh Nerlige Ramappa wrote:
>>> The gen12-mi-rpc test checks for B0 counter to be zero, however,
>>> occassionally the counter reads a non-zero value. To ensure the test
>>> works as expected, we check B0 with the preset value.
>>
>>
>> What the value being reported?
>>
>>
>> Sounds like we should ask around see if there isn't a deeper problem 
>> with the HW configuration.
>>
>
> I have seen values 0x121 and 0x1ec. The issue occurs sometimes on 
> reboots. Subsequent runs I see that the counter is 0.
>
> Thanks,
> Umesh


Oh... I thought this test was using sanity_check_reports() on deltas 
between 2 reports.

Yeah I guess your change is fine then.

The test could be improved with sanity_check_reports.


-Lionel


>
>>
>> -Lionel
>>
>>
>>>
>>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>>> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
>>> ---
>>>  tests/perf.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/perf.c b/tests/perf.c
>>> index b7d5e50e..9d0ed45c 100644
>>> --- a/tests/perf.c
>>> +++ b/tests/perf.c
>>> @@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
>>>       */
>>>      igt_assert_eq(report32[0], REPORT_ID);
>>>      igt_assert_neq(report32[1], 0);
>>> -    igt_assert_eq(report32[format.b_off >> 2], 0);
>>> +    igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
>>>      igt_assert_eq(report32[format_size_32], 0x80808080);
>>>      drm_intel_bo_unmap(bo);
>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[Umesh Nerlige Ramappa]

On Wed, Apr 22, 2020 at 07:01:22PM +0300, Lionel Landwerlin wrote:
>On 22/04/2020 18:47, Umesh Nerlige Ramappa wrote:
>>On Tue, Apr 21, 2020 at 11:06:27PM +0300, Lionel Landwerlin wrote:
>>>On 21/04/2020 21:22, Umesh Nerlige Ramappa wrote:
>>>>The gen12-mi-rpc test checks for B0 counter to be zero, however,
>>>>occassionally the counter reads a non-zero value. To ensure the test
>>>>works as expected, we check B0 with the preset value.
>>>
>>>
>>>What the value being reported?
>>>
>>>
>>>Sounds like we should ask around see if there isn't a deeper 
>>>problem with the HW configuration.
>>>
>>
>>I have seen values 0x121 and 0x1ec. The issue occurs sometimes on 
>>reboots. Subsequent runs I see that the counter is 0.
>>
>>Thanks,
>>Umesh
>
>
>Oh... I thought this test was using sanity_check_reports() on deltas 
>between 2 reports.
>
>Yeah I guess your change is fine then.
>
>The test could be improved with sanity_check_reports.
>

Agreed. For now, the test is only checking if the report landed 
entirely. Please let me know if this is good enough for an R-b.

Thanks,
Umesh

>
>-Lionel
>
>
>>
>>>
>>>-Lionel
>>>
>>>
>>>>
>>>>Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>>>>Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
>>>>---
>>>> tests/perf.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>>diff --git a/tests/perf.c b/tests/perf.c
>>>>index b7d5e50e..9d0ed45c 100644
>>>>--- a/tests/perf.c
>>>>+++ b/tests/perf.c
>>>>@@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
>>>>      */
>>>>     igt_assert_eq(report32[0], REPORT_ID);
>>>>     igt_assert_neq(report32[1], 0);
>>>>-    igt_assert_eq(report32[format.b_off >> 2], 0);
>>>>+    igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
>>>>     igt_assert_eq(report32[format_size_32], 0x80808080);
>>>>     drm_intel_bo_unmap(bo);
>>>
>>>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/perf: Fix B0 counter check in gen12-mi-rpc

[Lionel Landwerlin]

On 24/04/2020 21:07, Umesh Nerlige Ramappa wrote:
> On Wed, Apr 22, 2020 at 07:01:22PM +0300, Lionel Landwerlin wrote:
>> On 22/04/2020 18:47, Umesh Nerlige Ramappa wrote:
>>> On Tue, Apr 21, 2020 at 11:06:27PM +0300, Lionel Landwerlin wrote:
>>>> On 21/04/2020 21:22, Umesh Nerlige Ramappa wrote:
>>>>> The gen12-mi-rpc test checks for B0 counter to be zero, however,
>>>>> occassionally the counter reads a non-zero value. To ensure the test
>>>>> works as expected, we check B0 with the preset value.
>>>>
>>>>
>>>> What the value being reported?
>>>>
>>>>
>>>> Sounds like we should ask around see if there isn't a deeper 
>>>> problem with the HW configuration.
>>>>
>>>
>>> I have seen values 0x121 and 0x1ec. The issue occurs sometimes on 
>>> reboots. Subsequent runs I see that the counter is 0.
>>>
>>> Thanks,
>>> Umesh
>>
>>
>> Oh... I thought this test was using sanity_check_reports() on deltas 
>> between 2 reports.
>>
>> Yeah I guess your change is fine then.
>>
>> The test could be improved with sanity_check_reports.
>>
>
> Agreed. For now, the test is only checking if the report landed 
> entirely. Please let me know if this is good enough for an R-b.
>
> Thanks,
> Umesh


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


>
>>
>> -Lionel
>>
>>
>>>
>>>>
>>>> -Lionel
>>>>
>>>>
>>>>>
>>>>> Signed-off-by: Umesh Nerlige Ramappa 
>>>>> <umesh.nerlige.ramappa@intel.com>
>>>>> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/1085
>>>>> ---
>>>>>  tests/perf.c | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/tests/perf.c b/tests/perf.c
>>>>> index b7d5e50e..9d0ed45c 100644
>>>>> --- a/tests/perf.c
>>>>> +++ b/tests/perf.c
>>>>> @@ -3002,7 +3002,7 @@ gen12_test_mi_rpc(void)
>>>>>       */
>>>>>      igt_assert_eq(report32[0], REPORT_ID);
>>>>>      igt_assert_neq(report32[1], 0);
>>>>> -    igt_assert_eq(report32[format.b_off >> 2], 0);
>>>>> +    igt_assert_neq(report32[format.b_off >> 2], 0x80808080);
>>>>>      igt_assert_eq(report32[format_size_32], 0x80808080);
>>>>>      drm_intel_bo_unmap(bo);
>>>>
>>>>
>>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev