* [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static
@ 2020-04-23 2:22 Zou Wei
2020-04-23 2:31 ` Zhou Wang
2020-04-30 5:31 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-23 2:22 UTC (permalink / raw)
To: wangzhou1, herbert, davem; +Cc: linux-crypto, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/crypto/hisilicon/qm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 80c5525..69d02cb 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -3076,7 +3076,7 @@ static int qm_controller_reset_done(struct hisi_qm *qm)
return 0;
}
-int qm_controller_reset(struct hisi_qm *qm)
+static int qm_controller_reset(struct hisi_qm *qm)
{
struct pci_dev *pdev = qm->pdev;
int ret;
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static
2020-04-23 2:22 [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static Zou Wei
@ 2020-04-23 2:31 ` Zhou Wang
2020-04-30 5:31 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Zhou Wang @ 2020-04-23 2:31 UTC (permalink / raw)
To: Zou Wei, herbert, davem; +Cc: linux-crypto, linux-kernel
On 2020/4/23 10:22, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset'
> was not declared. Should it be static?
It should be static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks,
Zhou
> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index 80c5525..69d02cb 100644
> --- a/drivers/crypto/hisilicon/qm.c
> +++ b/drivers/crypto/hisilicon/qm.c
> @@ -3076,7 +3076,7 @@ static int qm_controller_reset_done(struct hisi_qm *qm)
> return 0;
> }
>
> -int qm_controller_reset(struct hisi_qm *qm)
> +static int qm_controller_reset(struct hisi_qm *qm)
> {
> struct pci_dev *pdev = qm->pdev;
> int ret;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static
2020-04-23 2:22 [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static Zou Wei
2020-04-23 2:31 ` Zhou Wang
@ 2020-04-30 5:31 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-04-30 5:31 UTC (permalink / raw)
To: Zou Wei; +Cc: wangzhou1, davem, linux-crypto, linux-kernel
On Thu, Apr 23, 2020 at 10:22:36AM +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-30 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 2:22 [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static Zou Wei
2020-04-23 2:31 ` Zhou Wang
2020-04-30 5:31 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.