* [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison
@ 2020-04-24 8:14 Yang Yingliang
2020-04-24 10:12 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2020-04-24 8:14 UTC (permalink / raw)
To: richardcochran, vincent.cheng.xh, davem, yangyingliang
Cc: netdev, linux-kernel
The type of loaddr is u8 which is always '<=' 0xff, so the
loaddr <= 0xff is always true, we can remove this comparison.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/ptp/ptp_clockmatrix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
index 032e112..56aee4f 100644
--- a/drivers/ptp/ptp_clockmatrix.c
+++ b/drivers/ptp/ptp_clockmatrix.c
@@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
/* Page size 128, last 4 bytes of page skipped */
if (((loaddr > 0x7b) && (loaddr <= 0x7f))
- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
+ || loaddr <= 0xff)
continue;
err = idtcm_write(idtcm, regaddr, 0, &val, sizeof(val));
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison
2020-04-24 8:14 [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison Yang Yingliang
@ 2020-04-24 10:12 ` Sergei Shtylyov
2020-04-24 12:24 ` Yang Yingliang
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2020-04-24 10:12 UTC (permalink / raw)
To: Yang Yingliang, richardcochran, vincent.cheng.xh, davem
Cc: netdev, linux-kernel
Hello!
On 24.04.2020 11:14, Yang Yingliang wrote:
> The type of loaddr is u8 which is always '<=' 0xff, so the
> loaddr <= 0xff is always true, we can remove this comparison.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/ptp/ptp_clockmatrix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
> index 032e112..56aee4f 100644
> --- a/drivers/ptp/ptp_clockmatrix.c
> +++ b/drivers/ptp/ptp_clockmatrix.c
> @@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
>
> /* Page size 128, last 4 bytes of page skipped */
> if (((loaddr > 0x7b) && (loaddr <= 0x7f))
> - || ((loaddr > 0xfb) && (loaddr <= 0xff)))
> + || loaddr <= 0xff)
Haven't you just said that this is always true? :-)
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison
2020-04-24 10:12 ` Sergei Shtylyov
@ 2020-04-24 12:24 ` Yang Yingliang
0 siblings, 0 replies; 3+ messages in thread
From: Yang Yingliang @ 2020-04-24 12:24 UTC (permalink / raw)
To: Sergei Shtylyov, richardcochran, vincent.cheng.xh, davem
Cc: netdev, linux-kernel
On 2020/4/24 18:12, Sergei Shtylyov wrote:
> Hello!
>
> On 24.04.2020 11:14, Yang Yingliang wrote:
>
>> The type of loaddr is u8 which is always '<=' 0xff, so the
>> loaddr <= 0xff is always true, we can remove this comparison.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> drivers/ptp/ptp_clockmatrix.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ptp/ptp_clockmatrix.c
>> b/drivers/ptp/ptp_clockmatrix.c
>> index 032e112..56aee4f 100644
>> --- a/drivers/ptp/ptp_clockmatrix.c
>> +++ b/drivers/ptp/ptp_clockmatrix.c
>> @@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
>> /* Page size 128, last 4 bytes of page skipped */
>> if (((loaddr > 0x7b) && (loaddr <= 0x7f))
>> - || ((loaddr > 0xfb) && (loaddr <= 0xff)))
>> + || loaddr <= 0xff)
>
> Haven't you just said that this is always true? :-)
My bad, I sent the patch.
>
> [...]
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-24 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 8:14 [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison Yang Yingliang
2020-04-24 10:12 ` Sergei Shtylyov
2020-04-24 12:24 ` Yang Yingliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.