* [PATCH] most: core: use function subsys_initcall()
@ 2020-04-24 14:12 Christian Gromm
2020-04-24 15:01 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Christian Gromm @ 2020-04-24 14:12 UTC (permalink / raw)
To: gregkh; +Cc: Christian Gromm, driverdev-devel
This patch replaces function module_init() with subsys_initcall().
It is needed to ensure that the core module of the driver is
initialized before a component tries to register with the core. This
leads to a NULL pointer dereference if the driver is configured as
in-tree.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
---
drivers/most/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/most/core.c b/drivers/most/core.c
index 06426fc..f781c46 100644
--- a/drivers/most/core.c
+++ b/drivers/most/core.c
@@ -1483,7 +1483,7 @@ static void __exit most_exit(void)
ida_destroy(&mdev_id);
}
-module_init(most_init);
+subsys_initcall(most_init);
module_exit(most_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Gromm <christian.gromm@microchip.com>");
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] most: core: use function subsys_initcall()
2020-04-24 14:12 [PATCH] most: core: use function subsys_initcall() Christian Gromm
@ 2020-04-24 15:01 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-04-24 15:01 UTC (permalink / raw)
To: Christian Gromm; +Cc: driverdev-devel
On Fri, Apr 24, 2020 at 04:12:15PM +0200, Christian Gromm wrote:
> This patch replaces function module_init() with subsys_initcall().
> It is needed to ensure that the core module of the driver is
> initialized before a component tries to register with the core. This
> leads to a NULL pointer dereference if the driver is configured as
> in-tree.
>
> Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
No "fixes:" or "Reported-by:" tags?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-24 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 14:12 [PATCH] most: core: use function subsys_initcall() Christian Gromm
2020-04-24 15:01 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.