All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
@ 2020-04-28  8:52 ` Bhupesh Sharma
  0 siblings, 0 replies; 8+ messages in thread
From: Bhupesh Sharma @ 2020-04-28  8:52 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: linux-kernel, bhsharma, bhupesh.linux, Mark Rutland, Will Deacon,
	Catalin Marinas

commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
the event callback") removed '__register_perf_hw_breakpoint' function
usage and replaced it with 'register_perf_hw_breakpoint' function.

Remove the left-over unused '__register_perf_hw_breakpoint' declaration
from 'hw_breakpoint.h' as well.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
---
 include/linux/hw_breakpoint.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
index 6058c3844a76..fe1302da8e0f 100644
--- a/include/linux/hw_breakpoint.h
+++ b/include/linux/hw_breakpoint.h
@@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
 			    void *context);
 
 extern int register_perf_hw_breakpoint(struct perf_event *bp);
-extern int __register_perf_hw_breakpoint(struct perf_event *bp);
 extern void unregister_hw_breakpoint(struct perf_event *bp);
 extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
 
@@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
 			    void *context)		{ return NULL; }
 static inline int
 register_perf_hw_breakpoint(struct perf_event *bp)	{ return -ENOSYS; }
-static inline int
-__register_perf_hw_breakpoint(struct perf_event *bp) 	{ return -ENOSYS; }
 static inline void unregister_hw_breakpoint(struct perf_event *bp)	{ }
 static inline void
 unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)	{ }
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
@ 2020-04-28  8:52 ` Bhupesh Sharma
  0 siblings, 0 replies; 8+ messages in thread
From: Bhupesh Sharma @ 2020-04-28  8:52 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Mark Rutland, Catalin Marinas, bhsharma, linux-kernel,
	bhupesh.linux, Will Deacon

commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
the event callback") removed '__register_perf_hw_breakpoint' function
usage and replaced it with 'register_perf_hw_breakpoint' function.

Remove the left-over unused '__register_perf_hw_breakpoint' declaration
from 'hw_breakpoint.h' as well.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
---
 include/linux/hw_breakpoint.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
index 6058c3844a76..fe1302da8e0f 100644
--- a/include/linux/hw_breakpoint.h
+++ b/include/linux/hw_breakpoint.h
@@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
 			    void *context);
 
 extern int register_perf_hw_breakpoint(struct perf_event *bp);
-extern int __register_perf_hw_breakpoint(struct perf_event *bp);
 extern void unregister_hw_breakpoint(struct perf_event *bp);
 extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
 
@@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
 			    void *context)		{ return NULL; }
 static inline int
 register_perf_hw_breakpoint(struct perf_event *bp)	{ return -ENOSYS; }
-static inline int
-__register_perf_hw_breakpoint(struct perf_event *bp) 	{ return -ENOSYS; }
 static inline void unregister_hw_breakpoint(struct perf_event *bp)	{ }
 static inline void
 unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)	{ }
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
  2020-04-28  8:52 ` Bhupesh Sharma
@ 2020-04-28 10:07   ` Mark Rutland
  -1 siblings, 0 replies; 8+ messages in thread
From: Mark Rutland @ 2020-04-28 10:07 UTC (permalink / raw)
  To: Bhupesh Sharma
  Cc: linux-arm-kernel, linux-kernel, bhupesh.linux, Will Deacon,
	Catalin Marinas, Frederic Weisbecker, Peter Zijlstra,
	Ingo Molnar

Hi Bhupesh,

On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote:
> commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
> the event callback") removed '__register_perf_hw_breakpoint' function
> usage and replaced it with 'register_perf_hw_breakpoint' function.
> 
> Remove the left-over unused '__register_perf_hw_breakpoint' declaration
> from 'hw_breakpoint.h' as well.
> 
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>

This is generic code, so I'm a bit confused as to why you've sent it to
us. I'd expect this to go via the perf core maintainers (cc'd).

FWIW, this looks sane to me, so:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  include/linux/hw_breakpoint.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> index 6058c3844a76..fe1302da8e0f 100644
> --- a/include/linux/hw_breakpoint.h
> +++ b/include/linux/hw_breakpoint.h
> @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
>  			    void *context);
>  
>  extern int register_perf_hw_breakpoint(struct perf_event *bp);
> -extern int __register_perf_hw_breakpoint(struct perf_event *bp);
>  extern void unregister_hw_breakpoint(struct perf_event *bp);
>  extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
>  
> @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
>  			    void *context)		{ return NULL; }
>  static inline int
>  register_perf_hw_breakpoint(struct perf_event *bp)	{ return -ENOSYS; }
> -static inline int
> -__register_perf_hw_breakpoint(struct perf_event *bp) 	{ return -ENOSYS; }
>  static inline void unregister_hw_breakpoint(struct perf_event *bp)	{ }
>  static inline void
>  unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)	{ }
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
@ 2020-04-28 10:07   ` Mark Rutland
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Rutland @ 2020-04-28 10:07 UTC (permalink / raw)
  To: Bhupesh Sharma
  Cc: Peter Zijlstra, Catalin Marinas, linux-kernel,
	Frederic Weisbecker, bhupesh.linux, Will Deacon, Ingo Molnar,
	linux-arm-kernel

Hi Bhupesh,

On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote:
> commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
> the event callback") removed '__register_perf_hw_breakpoint' function
> usage and replaced it with 'register_perf_hw_breakpoint' function.
> 
> Remove the left-over unused '__register_perf_hw_breakpoint' declaration
> from 'hw_breakpoint.h' as well.
> 
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>

This is generic code, so I'm a bit confused as to why you've sent it to
us. I'd expect this to go via the perf core maintainers (cc'd).

FWIW, this looks sane to me, so:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  include/linux/hw_breakpoint.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> index 6058c3844a76..fe1302da8e0f 100644
> --- a/include/linux/hw_breakpoint.h
> +++ b/include/linux/hw_breakpoint.h
> @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
>  			    void *context);
>  
>  extern int register_perf_hw_breakpoint(struct perf_event *bp);
> -extern int __register_perf_hw_breakpoint(struct perf_event *bp);
>  extern void unregister_hw_breakpoint(struct perf_event *bp);
>  extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
>  
> @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
>  			    void *context)		{ return NULL; }
>  static inline int
>  register_perf_hw_breakpoint(struct perf_event *bp)	{ return -ENOSYS; }
> -static inline int
> -__register_perf_hw_breakpoint(struct perf_event *bp) 	{ return -ENOSYS; }
>  static inline void unregister_hw_breakpoint(struct perf_event *bp)	{ }
>  static inline void
>  unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)	{ }
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
  2020-04-28 10:07   ` Mark Rutland
@ 2020-04-30  4:19     ` Bhupesh Sharma
  -1 siblings, 0 replies; 8+ messages in thread
From: Bhupesh Sharma @ 2020-04-30  4:19 UTC (permalink / raw)
  To: Mark Rutland
  Cc: linux-arm-kernel, Linux Kernel Mailing List, Bhupesh SHARMA,
	Will Deacon, Catalin Marinas, Frederic Weisbecker,
	Peter Zijlstra, Ingo Molnar

Hi Mark,

Thanks for the review.

On Tue, Apr 28, 2020 at 3:37 PM Mark Rutland <mark.rutland@arm.com> wrote:
>
> Hi Bhupesh,
>
> On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote:
> > commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
> > the event callback") removed '__register_perf_hw_breakpoint' function
> > usage and replaced it with 'register_perf_hw_breakpoint' function.
> >
> > Remove the left-over unused '__register_perf_hw_breakpoint' declaration
> > from 'hw_breakpoint.h' as well.
> >
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
>
> This is generic code, so I'm a bit confused as to why you've sent it to
> us. I'd expect this to go via the perf core maintainers (cc'd).

Oops, my bad. Seems my git patch sending script messed up while
picking up the perf maintainers (who should have been Cc'ed on the
patch) :(

Thanks for adding them in the Cc list.

Hi Peter, Frederic, Ingo - Kindly help review this patch and help
apply the patch (if suitable).

Thanks,
Bhupesh

> FWIW, this looks sane to me, so:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Mark.
>
> > ---
> >  include/linux/hw_breakpoint.h | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> > index 6058c3844a76..fe1302da8e0f 100644
> > --- a/include/linux/hw_breakpoint.h
> > +++ b/include/linux/hw_breakpoint.h
> > @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> >                           void *context);
> >
> >  extern int register_perf_hw_breakpoint(struct perf_event *bp);
> > -extern int __register_perf_hw_breakpoint(struct perf_event *bp);
> >  extern void unregister_hw_breakpoint(struct perf_event *bp);
> >  extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
> >
> > @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> >                           void *context)              { return NULL; }
> >  static inline int
> >  register_perf_hw_breakpoint(struct perf_event *bp)   { return -ENOSYS; }
> > -static inline int
> > -__register_perf_hw_breakpoint(struct perf_event *bp)         { return -ENOSYS; }
> >  static inline void unregister_hw_breakpoint(struct perf_event *bp)   { }
> >  static inline void
> >  unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)      { }
> > --
> > 2.7.4
> >
>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
@ 2020-04-30  4:19     ` Bhupesh Sharma
  0 siblings, 0 replies; 8+ messages in thread
From: Bhupesh Sharma @ 2020-04-30  4:19 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Peter Zijlstra, Catalin Marinas, Linux Kernel Mailing List,
	Frederic Weisbecker, Bhupesh SHARMA, Will Deacon, Ingo Molnar,
	linux-arm-kernel

Hi Mark,

Thanks for the review.

On Tue, Apr 28, 2020 at 3:37 PM Mark Rutland <mark.rutland@arm.com> wrote:
>
> Hi Bhupesh,
>
> On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote:
> > commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
> > the event callback") removed '__register_perf_hw_breakpoint' function
> > usage and replaced it with 'register_perf_hw_breakpoint' function.
> >
> > Remove the left-over unused '__register_perf_hw_breakpoint' declaration
> > from 'hw_breakpoint.h' as well.
> >
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
>
> This is generic code, so I'm a bit confused as to why you've sent it to
> us. I'd expect this to go via the perf core maintainers (cc'd).

Oops, my bad. Seems my git patch sending script messed up while
picking up the perf maintainers (who should have been Cc'ed on the
patch) :(

Thanks for adding them in the Cc list.

Hi Peter, Frederic, Ingo - Kindly help review this patch and help
apply the patch (if suitable).

Thanks,
Bhupesh

> FWIW, this looks sane to me, so:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Mark.
>
> > ---
> >  include/linux/hw_breakpoint.h | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> > index 6058c3844a76..fe1302da8e0f 100644
> > --- a/include/linux/hw_breakpoint.h
> > +++ b/include/linux/hw_breakpoint.h
> > @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> >                           void *context);
> >
> >  extern int register_perf_hw_breakpoint(struct perf_event *bp);
> > -extern int __register_perf_hw_breakpoint(struct perf_event *bp);
> >  extern void unregister_hw_breakpoint(struct perf_event *bp);
> >  extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
> >
> > @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> >                           void *context)              { return NULL; }
> >  static inline int
> >  register_perf_hw_breakpoint(struct perf_event *bp)   { return -ENOSYS; }
> > -static inline int
> > -__register_perf_hw_breakpoint(struct perf_event *bp)         { return -ENOSYS; }
> >  static inline void unregister_hw_breakpoint(struct perf_event *bp)   { }
> >  static inline void
> >  unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)      { }
> > --
> > 2.7.4
> >
>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
  2020-04-30  4:19     ` Bhupesh Sharma
@ 2020-05-15  9:15       ` Bhupesh Sharma
  -1 siblings, 0 replies; 8+ messages in thread
From: Bhupesh Sharma @ 2020-05-15  9:15 UTC (permalink / raw)
  To: Mark Rutland, Frederic Weisbecker, Ingo Molnar, Peter Zijlstra
  Cc: linux-arm-kernel, Linux Kernel Mailing List, Bhupesh SHARMA,
	Will Deacon, Catalin Marinas

Hi Peter, Frederic, Ingo

On Thu, Apr 30, 2020 at 9:49 AM Bhupesh Sharma <bhsharma@redhat.com> wrote:
>
> Hi Mark,
>
> Thanks for the review.
>
> On Tue, Apr 28, 2020 at 3:37 PM Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > Hi Bhupesh,
> >
> > On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote:
> > > commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
> > > the event callback") removed '__register_perf_hw_breakpoint' function
> > > usage and replaced it with 'register_perf_hw_breakpoint' function.
> > >
> > > Remove the left-over unused '__register_perf_hw_breakpoint' declaration
> > > from 'hw_breakpoint.h' as well.
> > >
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Will Deacon <will@kernel.org>
> > > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > > Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> >
> > This is generic code, so I'm a bit confused as to why you've sent it to
> > us. I'd expect this to go via the perf core maintainers (cc'd).
>
> Oops, my bad. Seems my git patch sending script messed up while
> picking up the perf maintainers (who should have been Cc'ed on the
> patch) :(
>
> Thanks for adding them in the Cc list.
>
> Hi Peter, Frederic, Ingo - Kindly help review this patch and help
> apply the patch (if suitable).

Ping. Any comments on this patch?

Thanks,
Bhupesh

> > FWIW, this looks sane to me, so:
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> >
> > Mark.
> >
> > > ---
> > >  include/linux/hw_breakpoint.h | 3 ---
> > >  1 file changed, 3 deletions(-)
> > >
> > > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> > > index 6058c3844a76..fe1302da8e0f 100644
> > > --- a/include/linux/hw_breakpoint.h
> > > +++ b/include/linux/hw_breakpoint.h
> > > @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> > >                           void *context);
> > >
> > >  extern int register_perf_hw_breakpoint(struct perf_event *bp);
> > > -extern int __register_perf_hw_breakpoint(struct perf_event *bp);
> > >  extern void unregister_hw_breakpoint(struct perf_event *bp);
> > >  extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
> > >
> > > @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> > >                           void *context)              { return NULL; }
> > >  static inline int
> > >  register_perf_hw_breakpoint(struct perf_event *bp)   { return -ENOSYS; }
> > > -static inline int
> > > -__register_perf_hw_breakpoint(struct perf_event *bp)         { return -ENOSYS; }
> > >  static inline void unregister_hw_breakpoint(struct perf_event *bp)   { }
> > >  static inline void
> > >  unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)      { }
> > > --
> > > 2.7.4
> > >
> >


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration
@ 2020-05-15  9:15       ` Bhupesh Sharma
  0 siblings, 0 replies; 8+ messages in thread
From: Bhupesh Sharma @ 2020-05-15  9:15 UTC (permalink / raw)
  To: Mark Rutland, Frederic Weisbecker, Ingo Molnar, Peter Zijlstra
  Cc: Catalin Marinas, Bhupesh SHARMA, Will Deacon,
	Linux Kernel Mailing List, linux-arm-kernel

Hi Peter, Frederic, Ingo

On Thu, Apr 30, 2020 at 9:49 AM Bhupesh Sharma <bhsharma@redhat.com> wrote:
>
> Hi Mark,
>
> Thanks for the review.
>
> On Tue, Apr 28, 2020 at 3:37 PM Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > Hi Bhupesh,
> >
> > On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote:
> > > commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of
> > > the event callback") removed '__register_perf_hw_breakpoint' function
> > > usage and replaced it with 'register_perf_hw_breakpoint' function.
> > >
> > > Remove the left-over unused '__register_perf_hw_breakpoint' declaration
> > > from 'hw_breakpoint.h' as well.
> > >
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Will Deacon <will@kernel.org>
> > > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > > Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
> >
> > This is generic code, so I'm a bit confused as to why you've sent it to
> > us. I'd expect this to go via the perf core maintainers (cc'd).
>
> Oops, my bad. Seems my git patch sending script messed up while
> picking up the perf maintainers (who should have been Cc'ed on the
> patch) :(
>
> Thanks for adding them in the Cc list.
>
> Hi Peter, Frederic, Ingo - Kindly help review this patch and help
> apply the patch (if suitable).

Ping. Any comments on this patch?

Thanks,
Bhupesh

> > FWIW, this looks sane to me, so:
> >
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> >
> > Mark.
> >
> > > ---
> > >  include/linux/hw_breakpoint.h | 3 ---
> > >  1 file changed, 3 deletions(-)
> > >
> > > diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
> > > index 6058c3844a76..fe1302da8e0f 100644
> > > --- a/include/linux/hw_breakpoint.h
> > > +++ b/include/linux/hw_breakpoint.h
> > > @@ -72,7 +72,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> > >                           void *context);
> > >
> > >  extern int register_perf_hw_breakpoint(struct perf_event *bp);
> > > -extern int __register_perf_hw_breakpoint(struct perf_event *bp);
> > >  extern void unregister_hw_breakpoint(struct perf_event *bp);
> > >  extern void unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events);
> > >
> > > @@ -115,8 +114,6 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
> > >                           void *context)              { return NULL; }
> > >  static inline int
> > >  register_perf_hw_breakpoint(struct perf_event *bp)   { return -ENOSYS; }
> > > -static inline int
> > > -__register_perf_hw_breakpoint(struct perf_event *bp)         { return -ENOSYS; }
> > >  static inline void unregister_hw_breakpoint(struct perf_event *bp)   { }
> > >  static inline void
> > >  unregister_wide_hw_breakpoint(struct perf_event * __percpu *cpu_events)      { }
> > > --
> > > 2.7.4
> > >
> >


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-15  9:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28  8:52 [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration Bhupesh Sharma
2020-04-28  8:52 ` Bhupesh Sharma
2020-04-28 10:07 ` Mark Rutland
2020-04-28 10:07   ` Mark Rutland
2020-04-30  4:19   ` Bhupesh Sharma
2020-04-30  4:19     ` Bhupesh Sharma
2020-05-15  9:15     ` Bhupesh Sharma
2020-05-15  9:15       ` Bhupesh Sharma

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.