* [Bug 1869426] Re: 5.0rc0->4.2 serial migraiton
2020-03-27 20:06 [Bug 1869426] [NEW] 5.0rc0->4.2 serial migraiton Dr. David Alan Gilbert
@ 2020-03-27 20:43 ` Dr. David Alan Gilbert
2020-03-27 20:47 ` Dr. David Alan Gilbert
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-27 20:43 UTC (permalink / raw)
To: qemu-devel
git bisect says:
c9808d602813bce4fada7bf9ecc463aa779b73f7 is the first bad commit
commit c9808d602813bce4fada7bf9ecc463aa779b73f7
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Tue Oct 22 01:02:50 2019 +0200
serial: realize the serial device
Instead of calling serial_realize_core(), use the QDev realize
callback.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869426
Title:
5.0rc0->4.2 serial migraiton
Status in QEMU:
New
Bug description:
Migrating from 5.0rc0->4.2 with pc-q35-4.2 we get an error:
Unknown savevm section or instance 'serial' 1
dumping the migration streams it looks like 5.0 is duplicating the
serial migration data:
"serial (26)": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
},
"serial (27)": {
"state": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
}
},
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1869426/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 1869426] Re: 5.0rc0->4.2 serial migraiton
2020-03-27 20:06 [Bug 1869426] [NEW] 5.0rc0->4.2 serial migraiton Dr. David Alan Gilbert
2020-03-27 20:43 ` [Bug 1869426] " Dr. David Alan Gilbert
@ 2020-03-27 20:47 ` Dr. David Alan Gilbert
2020-03-30 15:28 ` elmarco
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-27 20:47 UTC (permalink / raw)
To: qemu-devel
Marc-Andre: I think you're ending up with two top level objects with
vmsd's
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869426
Title:
5.0rc0->4.2 serial migraiton
Status in QEMU:
New
Bug description:
Migrating from 5.0rc0->4.2 with pc-q35-4.2 we get an error:
Unknown savevm section or instance 'serial' 1
dumping the migration streams it looks like 5.0 is duplicating the
serial migration data:
"serial (26)": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
},
"serial (27)": {
"state": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
}
},
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1869426/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 1869426] Re: 5.0rc0->4.2 serial migraiton
2020-03-27 20:06 [Bug 1869426] [NEW] 5.0rc0->4.2 serial migraiton Dr. David Alan Gilbert
2020-03-27 20:43 ` [Bug 1869426] " Dr. David Alan Gilbert
2020-03-27 20:47 ` Dr. David Alan Gilbert
@ 2020-03-30 15:28 ` elmarco
2020-04-01 10:04 ` Dr. David Alan Gilbert
2020-04-30 13:44 ` Laurent Vivier
4 siblings, 0 replies; 6+ messages in thread
From: elmarco @ 2020-03-30 15:28 UTC (permalink / raw)
To: qemu-devel
I thought backward migration wasn't supported.
Isn't it this commit?
commit 4cc017e505df7e5344e4dfe7fc17711117c5f11f
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Tue Oct 22 00:32:41 2019 +0200
serial: register vmsd with DeviceClass
Migration from old to new code works, however the other way fails for
devices that use serial_init/serial_mm_init with "base", used as
instance_id previously.
(with qdev_set_legacy_instance_id, the alias_id is only used in
savevm.c:find_se(), and thus can only be used to match against
"legacy" instance id values. On new code, instance_id is generated
incrementally from 0 with calculate_new_instance_id(), based on
"qdev-path/vmsd-name")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: xiaoqiang zhao <zxq_yx_007@163.com>
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869426
Title:
5.0rc0->4.2 serial migraiton
Status in QEMU:
New
Bug description:
Migrating from 5.0rc0->4.2 with pc-q35-4.2 we get an error:
Unknown savevm section or instance 'serial' 1
dumping the migration streams it looks like 5.0 is duplicating the
serial migration data:
"serial (26)": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
},
"serial (27)": {
"state": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
}
},
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1869426/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 1869426] Re: 5.0rc0->4.2 serial migraiton
2020-03-27 20:06 [Bug 1869426] [NEW] 5.0rc0->4.2 serial migraiton Dr. David Alan Gilbert
` (2 preceding siblings ...)
2020-03-30 15:28 ` elmarco
@ 2020-04-01 10:04 ` Dr. David Alan Gilbert
2020-04-30 13:44 ` Laurent Vivier
4 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2020-04-01 10:04 UTC (permalink / raw)
To: qemu-devel
Fix posted:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg08803.html
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869426
Title:
5.0rc0->4.2 serial migraiton
Status in QEMU:
New
Bug description:
Migrating from 5.0rc0->4.2 with pc-q35-4.2 we get an error:
Unknown savevm section or instance 'serial' 1
dumping the migration streams it looks like 5.0 is duplicating the
serial migration data:
"serial (26)": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
},
"serial (27)": {
"state": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
}
},
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1869426/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug 1869426] Re: 5.0rc0->4.2 serial migraiton
2020-03-27 20:06 [Bug 1869426] [NEW] 5.0rc0->4.2 serial migraiton Dr. David Alan Gilbert
` (3 preceding siblings ...)
2020-04-01 10:04 ` Dr. David Alan Gilbert
@ 2020-04-30 13:44 ` Laurent Vivier
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2020-04-30 13:44 UTC (permalink / raw)
To: qemu-devel
Fixed here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=f602d047ac21
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1869426
Title:
5.0rc0->4.2 serial migraiton
Status in QEMU:
Fix Released
Bug description:
Migrating from 5.0rc0->4.2 with pc-q35-4.2 we get an error:
Unknown savevm section or instance 'serial' 1
dumping the migration streams it looks like 5.0 is duplicating the
serial migration data:
"serial (26)": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
},
"serial (27)": {
"state": {
"divider": "0x000c",
"rbr": "0x00",
"ier": "0x00",
"iir": "0x01",
"lcr": "0x00",
"mcr": "0x00",
"lsr": "0x60",
"msr": "0xb0",
"scr": "0x00",
"fcr_vmstate": "0x00"
}
},
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1869426/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread