All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static
@ 2020-05-11 12:29 Ma Feng
  2020-07-10  6:00 ` Barry Song
  0 siblings, 1 reply; 2+ messages in thread
From: Ma Feng @ 2020-05-11 12:29 UTC (permalink / raw)
  To: baohua; +Cc: linux-arm-kernel

Fix sparse warning:

arch/arm/mach-prima2/rtciobrg.c:34:6: warning: symbol
'sirfsoc_rtc_iobrg_wait_sync' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
---
 arch/arm/mach-prima2/rtciobrg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-prima2/rtciobrg.c b/arch/arm/mach-prima2/rtciobrg.c
index 97c0e33..f517721 100644
--- a/arch/arm/mach-prima2/rtciobrg.c
+++ b/arch/arm/mach-prima2/rtciobrg.c
@@ -31,7 +31,7 @@ static DEFINE_SPINLOCK(rtciobrg_lock);
  * symbols without lock are only used by suspend asm codes
  * and these symbols are not exported too
  */
-void sirfsoc_rtc_iobrg_wait_sync(void)
+static void sirfsoc_rtc_iobrg_wait_sync(void)
 {
 	while (readl_relaxed(sirfsoc_rtciobrg_base + SIRFSOC_CPUIOBRG_CTRL))
 		cpu_relax();
--
2.6.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static
  2020-05-11 12:29 [PATCH] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ma Feng
@ 2020-07-10  6:00 ` Barry Song
  0 siblings, 0 replies; 2+ messages in thread
From: Barry Song @ 2020-07-10  6:00 UTC (permalink / raw)
  To: Ma Feng; +Cc: linux-arm-kernel

Ma Feng <mafeng.ma@huawei.com> 于2020年5月12日周二 上午12:23写道:
>
> Fix sparse warning:
>
> arch/arm/mach-prima2/rtciobrg.c:34:6: warning: symbol
> 'sirfsoc_rtc_iobrg_wait_sync' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>

Acked-by: Barry Song <baohua@kernel.org>

> ---
>  arch/arm/mach-prima2/rtciobrg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-prima2/rtciobrg.c b/arch/arm/mach-prima2/rtciobrg.c
> index 97c0e33..f517721 100644
> --- a/arch/arm/mach-prima2/rtciobrg.c
> +++ b/arch/arm/mach-prima2/rtciobrg.c
> @@ -31,7 +31,7 @@ static DEFINE_SPINLOCK(rtciobrg_lock);
>   * symbols without lock are only used by suspend asm codes
>   * and these symbols are not exported too
>   */
> -void sirfsoc_rtc_iobrg_wait_sync(void)
> +static void sirfsoc_rtc_iobrg_wait_sync(void)
>  {
>         while (readl_relaxed(sirfsoc_rtciobrg_base + SIRFSOC_CPUIOBRG_CTRL))
>                 cpu_relax();
> --
> 2.6.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-10  6:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 12:29 [PATCH] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ma Feng
2020-07-10  6:00 ` Barry Song

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.