* [PATCH] scsi: lpfc: remove redundant initialization to variable rc
@ 2020-05-07 20:31 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2020-05-07 20:31 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable rc is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 1354c141d614..87ac8ac0f72a 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -4877,7 +4877,7 @@ lpfc_request_firmware_upgrade_store(struct device *dev,
struct Scsi_Host *shost = class_to_shost(dev);
struct lpfc_vport *vport = (struct lpfc_vport *)shost->hostdata;
struct lpfc_hba *phba = vport->phba;
- int val = 0, rc = -EINVAL;
+ int val = 0, rc;
/* Sanity check on user data */
if (!isdigit(buf[0]))
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] scsi: lpfc: remove redundant initialization to variable rc
@ 2020-05-07 20:31 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2020-05-07 20:31 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable rc is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 1354c141d614..87ac8ac0f72a 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -4877,7 +4877,7 @@ lpfc_request_firmware_upgrade_store(struct device *dev,
struct Scsi_Host *shost = class_to_shost(dev);
struct lpfc_vport *vport = (struct lpfc_vport *)shost->hostdata;
struct lpfc_hba *phba = vport->phba;
- int val = 0, rc = -EINVAL;
+ int val = 0, rc;
/* Sanity check on user data */
if (!isdigit(buf[0]))
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant initialization to variable rc
2020-05-07 20:31 ` Colin King
@ 2020-05-12 3:28 ` Martin K. Petersen
-1 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-05-12 3:28 UTC (permalink / raw)
To: linux-scsi, James Smart, Colin King, James E . J . Bottomley,
Dick Kennedy
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Thu, 7 May 2020 21:31:11 +0100, Colin King wrote:
> The variable rc is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: lpfc: Remove redundant initialization to variable rc
https://git.kernel.org/mkp/scsi/c/6e27a86aed97
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant initialization to variable rc
@ 2020-05-12 3:28 ` Martin K. Petersen
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-05-12 3:28 UTC (permalink / raw)
To: linux-scsi, James Smart, Colin King, James E . J . Bottomley,
Dick Kennedy
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Thu, 7 May 2020 21:31:11 +0100, Colin King wrote:
> The variable rc is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: lpfc: Remove redundant initialization to variable rc
https://git.kernel.org/mkp/scsi/c/6e27a86aed97
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-12 3:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 20:31 [PATCH] scsi: lpfc: remove redundant initialization to variable rc Colin King
2020-05-07 20:31 ` Colin King
2020-05-12 3:28 ` Martin K. Petersen
2020-05-12 3:28 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.