All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: ti: am33xx: fix RTC clock parent
@ 2020-04-24 15:23 Tero Kristo
  2020-04-24 15:37 ` Tony Lindgren
  2020-05-13  3:17 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Tero Kristo @ 2020-04-24 15:23 UTC (permalink / raw)
  To: linux-clk, sboyd, mturquette; +Cc: tony, linux-omap

Right now, trying to use RTC purely with the ti-sysc / clkctrl framework
fails to enable the RTC module properly. Based on experimentation, this
appears to be because RTC is sourced from the clkdiv32k optional clock.
TRM is not very clear on this topic, but fix the RTC to use the proper
source clock nevertheless.

Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/clk/ti/clk-33xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
index e001b9bcb6bf..7dc30dd6c8d5 100644
--- a/drivers/clk/ti/clk-33xx.c
+++ b/drivers/clk/ti/clk-33xx.c
@@ -212,7 +212,7 @@ static const struct omap_clkctrl_reg_data am3_mpu_clkctrl_regs[] __initconst = {
 };
 
 static const struct omap_clkctrl_reg_data am3_l4_rtc_clkctrl_regs[] __initconst = {
-	{ AM3_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clk_32768_ck" },
+	{ AM3_L4_RTC_RTC_CLKCTRL, NULL, CLKF_SW_SUP, "clk-24mhz-clkctrl:0000:0" },
 	{ 0 },
 };
 
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: ti: am33xx: fix RTC clock parent
  2020-04-24 15:23 [PATCH] clk: ti: am33xx: fix RTC clock parent Tero Kristo
@ 2020-04-24 15:37 ` Tony Lindgren
  2020-05-13  3:17 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2020-04-24 15:37 UTC (permalink / raw)
  To: Tero Kristo; +Cc: linux-clk, sboyd, mturquette, linux-omap

* Tero Kristo <t-kristo@ti.com> [200424 15:23]:
> Right now, trying to use RTC purely with the ti-sysc / clkctrl framework
> fails to enable the RTC module properly. Based on experimentation, this
> appears to be because RTC is sourced from the clkdiv32k optional clock.
> TRM is not very clear on this topic, but fix the RTC to use the proper
> source clock nevertheless.
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>

This fixes the issue where RTC won't get enabled unless the
clock is enabled by the bootloader or early init code:

Acked-by: Tony Lindgren <tony@atomide.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: ti: am33xx: fix RTC clock parent
  2020-04-24 15:23 [PATCH] clk: ti: am33xx: fix RTC clock parent Tero Kristo
  2020-04-24 15:37 ` Tony Lindgren
@ 2020-05-13  3:17 ` Stephen Boyd
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-05-13  3:17 UTC (permalink / raw)
  To: Tero Kristo, linux-clk, mturquette; +Cc: tony, linux-omap

Quoting Tero Kristo (2020-04-24 08:23:01)
> Right now, trying to use RTC purely with the ti-sysc / clkctrl framework
> fails to enable the RTC module properly. Based on experimentation, this
> appears to be because RTC is sourced from the clkdiv32k optional clock.
> TRM is not very clear on this topic, but fix the RTC to use the proper
> source clock nevertheless.
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---

Applied to clk-fixes

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-13  3:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 15:23 [PATCH] clk: ti: am33xx: fix RTC clock parent Tero Kristo
2020-04-24 15:37 ` Tony Lindgren
2020-05-13  3:17 ` Stephen Boyd

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.