* [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY @ 2020-05-13 8:07 ` Corentin Labbe 2020-05-13 10:38 ` Matthias Brugger 2020-05-15 9:26 ` Jaehoon Chung 0 siblings, 2 replies; 4+ messages in thread From: Corentin Labbe @ 2020-05-13 8:07 UTC (permalink / raw) To: u-boot As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. Without it, booting with an initrd fail. Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- Changes since v1: - added fix for rpi_4_32b_defconfig configs/rpi_4_32b_defconfig | 2 +- configs/rpi_4_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index 8d262d89b4..f2a975891c 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs/rpi_4_32b_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 2a0cea4222..f1c8f5ef7d 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_ARCH_FIXUP_FDT_MEMORY=y CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set -- 2.26.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY 2020-05-13 8:07 ` [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY Corentin Labbe @ 2020-05-13 10:38 ` Matthias Brugger 2020-05-13 11:45 ` LABBE Corentin 2020-05-15 9:26 ` Jaehoon Chung 1 sibling, 1 reply; 4+ messages in thread From: Matthias Brugger @ 2020-05-13 10:38 UTC (permalink / raw) To: u-boot On 13/05/2020 10:07, Corentin Labbe wrote: > As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ > the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. > Without it, booting with an initrd fail. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > Changes since v1: > - added fix for rpi_4_32b_defconfig > > configs/rpi_4_32b_defconfig | 2 +- > configs/rpi_4_defconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Any reason why you don't added rpi_arm64_defconfig? Regards, Matthias > diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig > index 8d262d89b4..f2a975891c 100644 > --- a/configs/rpi_4_32b_defconfig > +++ b/configs/rpi_4_32b_defconfig > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 > CONFIG_NR_DRAM_BANKS=2 > CONFIG_DISTRO_DEFAULTS=y > CONFIG_OF_BOARD_SETUP=y > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y > CONFIG_MISC_INIT_R=y > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set > diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig > index 2a0cea4222..f1c8f5ef7d 100644 > --- a/configs/rpi_4_defconfig > +++ b/configs/rpi_4_defconfig > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 > CONFIG_NR_DRAM_BANKS=2 > CONFIG_DISTRO_DEFAULTS=y > CONFIG_OF_BOARD_SETUP=y > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y > CONFIG_MISC_INIT_R=y > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY 2020-05-13 10:38 ` Matthias Brugger @ 2020-05-13 11:45 ` LABBE Corentin 0 siblings, 0 replies; 4+ messages in thread From: LABBE Corentin @ 2020-05-13 11:45 UTC (permalink / raw) To: u-boot On Wed, May 13, 2020 at 12:38:58PM +0200, Matthias Brugger wrote: > > > On 13/05/2020 10:07, Corentin Labbe wrote: > > As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ > > the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. > > Without it, booting with an initrd fail. > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > Changes since v1: > > - added fix for rpi_4_32b_defconfig > > > > configs/rpi_4_32b_defconfig | 2 +- > > configs/rpi_4_defconfig | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > Any reason why you don't added rpi_arm64_defconfig? > I didnt see rpi4 in its name so out of context of my changes. I believe it is a common defconfig for all rpis, in that case touching it need more testing. So I propose to apply the change for rpi4 which are tested now. And later I could try to test rpi_arm64_defconfig on rpi4 AND other rpis.. > > > diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig > > index 8d262d89b4..f2a975891c 100644 > > --- a/configs/rpi_4_32b_defconfig > > +++ b/configs/rpi_4_32b_defconfig > > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 > > CONFIG_NR_DRAM_BANKS=2 > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_OF_BOARD_SETUP=y > > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set > > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y > > CONFIG_MISC_INIT_R=y > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig > > index 2a0cea4222..f1c8f5ef7d 100644 > > --- a/configs/rpi_4_defconfig > > +++ b/configs/rpi_4_defconfig > > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 > > CONFIG_NR_DRAM_BANKS=2 > > CONFIG_DISTRO_DEFAULTS=y > > CONFIG_OF_BOARD_SETUP=y > > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set > > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y > > CONFIG_MISC_INIT_R=y > > # CONFIG_DISPLAY_CPUINFO is not set > > # CONFIG_DISPLAY_BOARDINFO is not set > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY 2020-05-13 8:07 ` [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY Corentin Labbe 2020-05-13 10:38 ` Matthias Brugger @ 2020-05-15 9:26 ` Jaehoon Chung 1 sibling, 0 replies; 4+ messages in thread From: Jaehoon Chung @ 2020-05-15 9:26 UTC (permalink / raw) To: u-boot On 5/13/20 5:07 PM, Corentin Labbe wrote: > As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ > the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY. > Without it, booting with an initrd fail. > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > Changes since v1: > - added fix for rpi_4_32b_defconfig > > configs/rpi_4_32b_defconfig | 2 +- > configs/rpi_4_defconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig > index 8d262d89b4..f2a975891c 100644 > --- a/configs/rpi_4_32b_defconfig > +++ b/configs/rpi_4_32b_defconfig > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 > CONFIG_NR_DRAM_BANKS=2 > CONFIG_DISTRO_DEFAULTS=y > CONFIG_OF_BOARD_SETUP=y > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y > CONFIG_MISC_INIT_R=y > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set > diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig > index 2a0cea4222..f1c8f5ef7d 100644 > --- a/configs/rpi_4_defconfig > +++ b/configs/rpi_4_defconfig > @@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000 > CONFIG_NR_DRAM_BANKS=2 > CONFIG_DISTRO_DEFAULTS=y > CONFIG_OF_BOARD_SETUP=y > -# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set > +CONFIG_ARCH_FIXUP_FDT_MEMORY=y > CONFIG_MISC_INIT_R=y > # CONFIG_DISPLAY_CPUINFO is not set > # CONFIG_DISPLAY_BOARDINFO is not set > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-15 9:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200513080753epcas1p1529866fe57ea238049d69fdc40e4b46a@epcas1p1.samsung.com>
2020-05-13 8:07 ` [PATCH v2] rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY Corentin Labbe
2020-05-13 10:38 ` Matthias Brugger
2020-05-13 11:45 ` LABBE Corentin
2020-05-15 9:26 ` Jaehoon Chung
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.