From: Min Guo <min.guo@mediatek.com>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Hans de Goede <hdegoede@redhat.com>, Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
Macpaul Lin <macpaul.lin@gmail.com>
Subject: Re: [PATCH] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
Date: Thu, 14 May 2020 15:33:25 +0800 [thread overview]
Message-ID: <1589441605.28160.27.camel@mhfsdcap03> (raw)
In-Reply-To: <1589428872-29282-1-git-send-email-macpaul.lin@mediatek.com>
On Thu, 2020-05-14 at 12:01 +0800, Macpaul Lin wrote:
> When receiving reset interrupt, FADDR need to be reset to zero in
> periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB
> cable.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> drivers/usb/musb/mediatek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> index 6196b0e..eebeadd 100644
> --- a/drivers/usb/musb/mediatek.c
> +++ b/drivers/usb/musb/mediatek.c
> @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
>
> + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> + musb_ep_select(musb->mregs, 0);
> + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> + }
> +
> if (musb->int_usb || musb->int_tx || musb->int_rx)
> retval = musb_interrupt(musb);
>
Acked-by:Min Guo <min.guo@mediatek.com>
WARNING: multiple messages have this Message-ID (diff)
From: Min Guo <min.guo@mediatek.com>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-mediatek@lists.infradead.org,
Macpaul Lin <macpaul.lin@gmail.com>, Bin Liu <b-liu@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
Date: Thu, 14 May 2020 15:33:25 +0800 [thread overview]
Message-ID: <1589441605.28160.27.camel@mhfsdcap03> (raw)
In-Reply-To: <1589428872-29282-1-git-send-email-macpaul.lin@mediatek.com>
On Thu, 2020-05-14 at 12:01 +0800, Macpaul Lin wrote:
> When receiving reset interrupt, FADDR need to be reset to zero in
> periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB
> cable.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> drivers/usb/musb/mediatek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> index 6196b0e..eebeadd 100644
> --- a/drivers/usb/musb/mediatek.c
> +++ b/drivers/usb/musb/mediatek.c
> @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
>
> + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> + musb_ep_select(musb->mregs, 0);
> + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> + }
> +
> if (musb->int_usb || musb->int_tx || musb->int_rx)
> retval = musb_interrupt(musb);
>
Acked-by:Min Guo <min.guo@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Min Guo <min.guo@mediatek.com>
To: Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-mediatek@lists.infradead.org,
Macpaul Lin <macpaul.lin@gmail.com>, Bin Liu <b-liu@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle
Date: Thu, 14 May 2020 15:33:25 +0800 [thread overview]
Message-ID: <1589441605.28160.27.camel@mhfsdcap03> (raw)
In-Reply-To: <1589428872-29282-1-git-send-email-macpaul.lin@mediatek.com>
On Thu, 2020-05-14 at 12:01 +0800, Macpaul Lin wrote:
> When receiving reset interrupt, FADDR need to be reset to zero in
> periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB
> cable.
>
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> drivers/usb/musb/mediatek.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
> index 6196b0e..eebeadd 100644
> --- a/drivers/usb/musb/mediatek.c
> +++ b/drivers/usb/musb/mediatek.c
> @@ -208,6 +208,12 @@ static irqreturn_t generic_interrupt(int irq, void *__hci)
> musb->int_rx = musb_clearw(musb->mregs, MUSB_INTRRX);
> musb->int_tx = musb_clearw(musb->mregs, MUSB_INTRTX);
>
> + if ((musb->int_usb & MUSB_INTR_RESET) && !is_host_active(musb)) {
> + /* ep0 FADDR must be 0 when (re)entering peripheral mode */
> + musb_ep_select(musb->mregs, 0);
> + musb_writeb(musb->mregs, MUSB_FADDR, 0);
> + }
> +
> if (musb->int_usb || musb->int_tx || musb->int_rx)
> retval = musb_interrupt(musb);
>
Acked-by:Min Guo <min.guo@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-14 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 4:01 [PATCH] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle Macpaul Lin
2020-05-14 4:01 ` Macpaul Lin
2020-05-14 4:01 ` Macpaul Lin
2020-05-14 7:33 ` Min Guo [this message]
2020-05-14 7:33 ` Min Guo
2020-05-14 7:33 ` Min Guo
2020-05-20 2:44 ` Bin Liu
2020-05-20 2:44 ` Bin Liu
2020-05-20 2:44 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589441605.28160.27.camel@mhfsdcap03 \
--to=min.guo@mediatek.com \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@gmail.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.