* [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
@ 2020-05-08 1:49 ` Chen Zhou
0 siblings, 0 replies; 6+ messages in thread
From: Chen Zhou @ 2020-05-08 1:49 UTC (permalink / raw)
To: will, robin.murphy, joro
Cc: linux-arm-kernel, iommu, linux-kernel, chenzhou10
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/iommu/arm-smmu-v3.c:2989:26:
warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable]
struct arm_smmu_device *smmu;
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/iommu/arm-smmu-v3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 42e1ee7e5197..89ee9c5d8b88 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -2986,13 +2986,11 @@ static void arm_smmu_release_device(struct device *dev)
{
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
struct arm_smmu_master *master;
- struct arm_smmu_device *smmu;
if (!fwspec || fwspec->ops != &arm_smmu_ops)
return;
master = dev_iommu_priv_get(dev);
- smmu = master->smmu;
arm_smmu_detach_dev(master);
arm_smmu_disable_pasid(master);
kfree(master);
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
@ 2020-05-08 1:49 ` Chen Zhou
0 siblings, 0 replies; 6+ messages in thread
From: Chen Zhou @ 2020-05-08 1:49 UTC (permalink / raw)
To: will, robin.murphy, joro
Cc: chenzhou10, iommu, linux-kernel, linux-arm-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/iommu/arm-smmu-v3.c:2989:26:
warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable]
struct arm_smmu_device *smmu;
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/iommu/arm-smmu-v3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 42e1ee7e5197..89ee9c5d8b88 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -2986,13 +2986,11 @@ static void arm_smmu_release_device(struct device *dev)
{
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
struct arm_smmu_master *master;
- struct arm_smmu_device *smmu;
if (!fwspec || fwspec->ops != &arm_smmu_ops)
return;
master = dev_iommu_priv_get(dev);
- smmu = master->smmu;
arm_smmu_detach_dev(master);
arm_smmu_disable_pasid(master);
kfree(master);
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
@ 2020-05-08 1:49 ` Chen Zhou
0 siblings, 0 replies; 6+ messages in thread
From: Chen Zhou @ 2020-05-08 1:49 UTC (permalink / raw)
To: will, robin.murphy, joro
Cc: chenzhou10, iommu, linux-kernel, linux-arm-kernel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/iommu/arm-smmu-v3.c:2989:26:
warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable]
struct arm_smmu_device *smmu;
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/iommu/arm-smmu-v3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 42e1ee7e5197..89ee9c5d8b88 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -2986,13 +2986,11 @@ static void arm_smmu_release_device(struct device *dev)
{
struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
struct arm_smmu_master *master;
- struct arm_smmu_device *smmu;
if (!fwspec || fwspec->ops != &arm_smmu_ops)
return;
master = dev_iommu_priv_get(dev);
- smmu = master->smmu;
arm_smmu_detach_dev(master);
arm_smmu_disable_pasid(master);
kfree(master);
--
2.20.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
2020-05-08 1:49 ` Chen Zhou
(?)
@ 2020-05-18 23:04 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-05-18 23:04 UTC (permalink / raw)
To: joro, robin.murphy, Chen Zhou
Cc: catalin.marinas, Will Deacon, linux-arm-kernel, linux-kernel, iommu
On Fri, 8 May 2020 09:49:55 +0800, Chen Zhou wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/iommu/arm-smmu-v3.c:2989:26:
> warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable]
> struct arm_smmu_device *smmu;
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
https://git.kernel.org/will/c/06020196c82e
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
@ 2020-05-18 23:04 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-05-18 23:04 UTC (permalink / raw)
To: joro, robin.murphy, Chen Zhou
Cc: catalin.marinas, iommu, Will Deacon, linux-kernel, linux-arm-kernel
On Fri, 8 May 2020 09:49:55 +0800, Chen Zhou wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/iommu/arm-smmu-v3.c:2989:26:
> warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable]
> struct arm_smmu_device *smmu;
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
https://git.kernel.org/will/c/06020196c82e
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
@ 2020-05-18 23:04 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2020-05-18 23:04 UTC (permalink / raw)
To: joro, robin.murphy, Chen Zhou
Cc: catalin.marinas, iommu, Will Deacon, linux-kernel, linux-arm-kernel
On Fri, 8 May 2020 09:49:55 +0800, Chen Zhou wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/iommu/arm-smmu-v3.c:2989:26:
> warning: variable ‘smmu’ set but not used [-Wunused-but-set-variable]
> struct arm_smmu_device *smmu;
Applied to will (for-joerg/arm-smmu/updates), thanks!
[1/1] iommu/arm-smmu-v3: remove set but not used variable 'smmu'
https://git.kernel.org/will/c/06020196c82e
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-18 23:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 1:49 [PATCH -next] iommu/arm-smmu-v3: remove set but not used variable 'smmu' Chen Zhou
2020-05-08 1:49 ` Chen Zhou
2020-05-08 1:49 ` Chen Zhou
2020-05-18 23:04 ` Will Deacon
2020-05-18 23:04 ` Will Deacon
2020-05-18 23:04 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.