* [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
@ 2019-07-09 1:35 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2019-07-09 1:35 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Matthias Kaehlcke
Cc: Wei Yongjun, linux-bluetooth, kernel-janitors
Use kfree_skb() instead of kfree() to free sk_buff.
Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/bluetooth/hci_qca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 9a5c9c1f9484..cbae86e55aed 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -909,7 +909,7 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
if (hdr->evt == HCI_EV_VENDOR)
complete(&qca->drop_ev_comp);
- kfree(skb);
+ kfree_skb(skb);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
@ 2019-07-09 1:35 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2019-07-09 1:35 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Matthias Kaehlcke
Cc: Wei Yongjun, linux-bluetooth, kernel-janitors
Use kfree_skb() instead of kfree() to free sk_buff.
Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/bluetooth/hci_qca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 9a5c9c1f9484..cbae86e55aed 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -909,7 +909,7 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
if (hdr->evt = HCI_EV_VENDOR)
complete(&qca->drop_ev_comp);
- kfree(skb);
+ kfree_skb(skb);
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
2019-07-09 1:35 ` Wei Yongjun
@ 2019-07-09 14:52 ` Matthias Kaehlcke
-1 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-07-09 14:52 UTC (permalink / raw)
To: Wei Yongjun
Cc: Marcel Holtmann, Johan Hedberg, linux-bluetooth, kernel-janitors
On Tue, Jul 09, 2019 at 01:35:30AM +0000, Wei Yongjun wrote:
> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 9a5c9c1f9484..cbae86e55aed 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -909,7 +909,7 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
> if (hdr->evt == HCI_EV_VENDOR)
> complete(&qca->drop_ev_comp);
>
> - kfree(skb);
> + kfree_skb(skb);
>
> return 0;
> }
Good catch, thanks!
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
@ 2019-07-09 14:52 ` Matthias Kaehlcke
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-07-09 14:52 UTC (permalink / raw)
To: Wei Yongjun
Cc: Marcel Holtmann, Johan Hedberg, linux-bluetooth, kernel-janitors
On Tue, Jul 09, 2019 at 01:35:30AM +0000, Wei Yongjun wrote:
> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 9a5c9c1f9484..cbae86e55aed 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -909,7 +909,7 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
> if (hdr->evt = HCI_EV_VENDOR)
> complete(&qca->drop_ev_comp);
>
> - kfree(skb);
> + kfree_skb(skb);
>
> return 0;
> }
Good catch, thanks!
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
2019-07-09 1:35 ` Wei Yongjun
@ 2019-07-11 7:07 ` Marcel Holtmann
-1 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2019-07-11 7:07 UTC (permalink / raw)
To: Wei Yongjun
Cc: Johan Hedberg, Matthias Kaehlcke, linux-bluetooth, kernel-janitors
Hi Wei,
> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
@ 2019-07-11 7:07 ` Marcel Holtmann
0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2019-07-11 7:07 UTC (permalink / raw)
To: Wei Yongjun
Cc: Johan Hedberg, Matthias Kaehlcke, linux-bluetooth, kernel-janitors
Hi Wei,
> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-11 7:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 1:35 [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree() Wei Yongjun
2019-07-09 1:35 ` Wei Yongjun
2019-07-09 14:52 ` Matthias Kaehlcke
2019-07-09 14:52 ` Matthias Kaehlcke
2019-07-11 7:07 ` Marcel Holtmann
2019-07-11 7:07 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.