* [PATCH 1/1] nvmet-rdma: add unlikely check in the fast path
@ 2018-06-27 11:58 Max Gurtovoy
2018-06-28 14:36 ` Sagi Grimberg
2018-06-29 9:05 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Max Gurtovoy @ 2018-06-27 11:58 UTC (permalink / raw)
ib_post_send operation should succeed unless something unusual
happened to the ib device.
Signed-off-by: Max Gurtovoy <maxg at mellanox.com>
---
drivers/nvme/target/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 88d9f82..ac4fdab 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -501,7 +501,7 @@ static void nvmet_rdma_queue_response(struct nvmet_req *req)
rsp->send_sge.addr, rsp->send_sge.length,
DMA_TO_DEVICE);
- if (ib_post_send(cm_id->qp, first_wr, &bad_wr)) {
+ if (unlikely(ib_post_send(cm_id->qp, first_wr, &bad_wr))) {
pr_err("sending cmd response failed\n");
nvmet_rdma_release_rsp(rsp);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] nvmet-rdma: add unlikely check in the fast path
2018-06-27 11:58 [PATCH 1/1] nvmet-rdma: add unlikely check in the fast path Max Gurtovoy
@ 2018-06-28 14:36 ` Sagi Grimberg
2018-06-29 9:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2018-06-28 14:36 UTC (permalink / raw)
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] nvmet-rdma: add unlikely check in the fast path
2018-06-27 11:58 [PATCH 1/1] nvmet-rdma: add unlikely check in the fast path Max Gurtovoy
2018-06-28 14:36 ` Sagi Grimberg
@ 2018-06-29 9:05 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2018-06-29 9:05 UTC (permalink / raw)
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-29 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 11:58 [PATCH 1/1] nvmet-rdma: add unlikely check in the fast path Max Gurtovoy
2018-06-28 14:36 ` Sagi Grimberg
2018-06-29 9:05 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.