[Intel-gfx] [PATCH] drm/i915/gt: Force the GT reset on shutdown

[Intel-gfx] [PATCH] drm/i915/gt: Force the GT reset on shutdown

[Chris Wilson]

Before we return control to the system, and letting it reuse all the
pages being accessed by HW, we must disable the HW. At the moment, we
dare not reset the GPU if it will clobber the display, but once we know
the display has been disabled, we can proceed with the reset as we
shutdown the module. We know the next user must reinitialise the HW for
their purpose.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/489
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
---
 drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index dac254673c2e..e4ff18ab48e5 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -634,4 +634,6 @@ void intel_gt_driver_late_release(struct intel_gt *gt)
 	intel_gt_fini_reset(gt);
 	intel_gt_fini_timelines(gt);
 	intel_engines_free(gt);
+
+	__intel_gt_reset(gt, ALL_ENGINES);
 }
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Force the GT reset on shutdown

[Patchwork]

== Series Details ==

Series: drm/i915/gt: Force the GT reset on shutdown
URL   : https://patchwork.freedesktop.org/series/77633/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8529 -> Patchwork_17769
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_17769 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_17769, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_17769:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload:
    - fi-snb-2520m:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-snb-2520m/igt@i915_module_load@reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-snb-2520m/igt@i915_module_load@reload.html
    - fi-ilk-650:         [PASS][3] -> [INCOMPLETE][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-ilk-650/igt@i915_module_load@reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-ilk-650/igt@i915_module_load@reload.html
    - fi-ivb-3770:        [PASS][5] -> [INCOMPLETE][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-ivb-3770/igt@i915_module_load@reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-ivb-3770/igt@i915_module_load@reload.html

  
Known issues
------------

  Here are the changes found in Patchwork_17769 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-kbl-8809g:       [PASS][7] -> [INCOMPLETE][8] ([k.org#204565])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-kbl-8809g/igt@i915_module_load@reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-kbl-8809g/igt@i915_module_load@reload.html
    - fi-icl-u2:          [PASS][9] -> [INCOMPLETE][10] ([k.org#204565])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-icl-u2/igt@i915_module_load@reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-icl-u2/igt@i915_module_load@reload.html
    - fi-cml-u2:          [PASS][11] -> [INCOMPLETE][12] ([k.org#204565])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-cml-u2/igt@i915_module_load@reload.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-cml-u2/igt@i915_module_load@reload.html
    - fi-byt-j1900:       [PASS][13] -> [INCOMPLETE][14] ([i915#45])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-byt-j1900/igt@i915_module_load@reload.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-byt-j1900/igt@i915_module_load@reload.html
    - fi-cfl-8700k:       [PASS][15] -> [INCOMPLETE][16] ([k.org#204565])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-cfl-8700k/igt@i915_module_load@reload.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-cfl-8700k/igt@i915_module_load@reload.html
    - fi-kbl-r:           [PASS][17] -> [INCOMPLETE][18] ([k.org#204565])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-kbl-r/igt@i915_module_load@reload.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-kbl-r/igt@i915_module_load@reload.html
    - fi-apl-guc:         [PASS][19] -> [INCOMPLETE][20] ([k.org#204565])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-apl-guc/igt@i915_module_load@reload.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-apl-guc/igt@i915_module_load@reload.html
    - fi-bxt-dsi:         [PASS][21] -> [INCOMPLETE][22] ([k.org#204565])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-bxt-dsi/igt@i915_module_load@reload.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-bxt-dsi/igt@i915_module_load@reload.html
    - fi-whl-u:           [PASS][23] -> [INCOMPLETE][24] ([k.org#204565])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-whl-u/igt@i915_module_load@reload.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-whl-u/igt@i915_module_load@reload.html
    - fi-cml-s:           [PASS][25] -> [INCOMPLETE][26] ([k.org#204565])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-cml-s/igt@i915_module_load@reload.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-cml-s/igt@i915_module_load@reload.html
    - fi-skl-6600u:       [PASS][27] -> [INCOMPLETE][28] ([i915#69] / [k.org#204565])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-skl-6600u/igt@i915_module_load@reload.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-skl-6600u/igt@i915_module_load@reload.html
    - fi-bsw-n3050:       [PASS][29] -> [INCOMPLETE][30] ([k.org#204565])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-bsw-n3050/igt@i915_module_load@reload.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-bsw-n3050/igt@i915_module_load@reload.html
    - fi-skl-lmem:        [PASS][31] -> [INCOMPLETE][32] ([k.org#204565])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-skl-lmem/igt@i915_module_load@reload.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-skl-lmem/igt@i915_module_load@reload.html
    - fi-elk-e7500:       [PASS][33] -> [INCOMPLETE][34] ([i915#66])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-elk-e7500/igt@i915_module_load@reload.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-elk-e7500/igt@i915_module_load@reload.html
    - fi-skl-6700k2:      [PASS][35] -> [INCOMPLETE][36] ([k.org#204565])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-skl-6700k2/igt@i915_module_load@reload.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-skl-6700k2/igt@i915_module_load@reload.html
    - fi-icl-guc:         [PASS][37] -> [INCOMPLETE][38] ([k.org#204565])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-icl-guc/igt@i915_module_load@reload.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-icl-guc/igt@i915_module_load@reload.html
    - fi-byt-n2820:       [PASS][39] -> [INCOMPLETE][40] ([i915#45])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-byt-n2820/igt@i915_module_load@reload.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-byt-n2820/igt@i915_module_load@reload.html
    - fi-bsw-kefka:       [PASS][41] -> [INCOMPLETE][42] ([k.org#204565])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-bsw-kefka/igt@i915_module_load@reload.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-bsw-kefka/igt@i915_module_load@reload.html
    - fi-bdw-5557u:       [PASS][43] -> [INCOMPLETE][44] ([k.org#204565])
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-bdw-5557u/igt@i915_module_load@reload.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-bdw-5557u/igt@i915_module_load@reload.html
    - fi-glk-dsi:         [PASS][45] -> [INCOMPLETE][46] ([i915#58] / [k.org#198133] / [k.org#204565])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-glk-dsi/igt@i915_module_load@reload.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-glk-dsi/igt@i915_module_load@reload.html
    - fi-kbl-x1275:       [PASS][47] -> [INCOMPLETE][48] ([k.org#204565])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-kbl-x1275/igt@i915_module_load@reload.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-kbl-x1275/igt@i915_module_load@reload.html
    - fi-snb-2600:        [PASS][49] -> [INCOMPLETE][50] ([i915#82])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-snb-2600/igt@i915_module_load@reload.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-snb-2600/igt@i915_module_load@reload.html
    - fi-skl-guc:         [PASS][51] -> [INCOMPLETE][52] ([k.org#204565])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-skl-guc/igt@i915_module_load@reload.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-skl-guc/igt@i915_module_load@reload.html
    - fi-kbl-guc:         [PASS][53] -> [INCOMPLETE][54] ([k.org#204565])
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-kbl-guc/igt@i915_module_load@reload.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-kbl-guc/igt@i915_module_load@reload.html
    - fi-cfl-8109u:       [PASS][55] -> [INCOMPLETE][56] ([k.org#204565])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-cfl-8109u/igt@i915_module_load@reload.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-cfl-8109u/igt@i915_module_load@reload.html
    - fi-icl-y:           [PASS][57] -> [INCOMPLETE][58] ([k.org#204565])
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-icl-y/igt@i915_module_load@reload.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-icl-y/igt@i915_module_load@reload.html
    - fi-bsw-nick:        [PASS][59] -> [INCOMPLETE][60] ([k.org#204565])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-bsw-nick/igt@i915_module_load@reload.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-bsw-nick/igt@i915_module_load@reload.html
    - fi-kbl-7500u:       [PASS][61] -> [INCOMPLETE][62] ([k.org#204565])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-kbl-7500u/igt@i915_module_load@reload.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-kbl-7500u/igt@i915_module_load@reload.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@coherency:
    - fi-bwr-2160:        [INCOMPLETE][63] ([i915#489]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8529/fi-bwr-2160/igt@i915_selftest@live@coherency.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/fi-bwr-2160/igt@i915_selftest@live@coherency.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489
  [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
  [i915#66]: https://gitlab.freedesktop.org/drm/intel/issues/66
  [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
  [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
  [k.org#204565]: https://bugzilla.kernel.org/show_bug.cgi?id=204565


Participating hosts (45 -> 42)
------------------------------

  Additional (2): fi-hsw-4770 fi-cfl-guc 
  Missing    (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8529 -> Patchwork_17769

  CI-20190529: 20190529
  CI_DRM_8529: 9ae23ae1b437ee0d75ed2153eca05ecbd8c417bd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5676: ff03d458f708583c8f9296f97c38df312055651a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17769: b3a03dd149460b1f30c388fad8295ca278d5c8b4 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

b3a03dd14946 drm/i915/gt: Force the GT reset on shutdown

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17769/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/gt: Force the GT reset on shutdown

[Chris Wilson]

Before we return control to the system, and letting it reuse all the
pages being accessed by HW, we must disable the HW. At the moment, we
dare not reset the GPU if it will clobber the display, but once we know
the display has been disabled, we can proceed with the reset as we
shutdown the module. We know the next user must reinitialise the HW for
their purpose.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/489
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
---
 drivers/gpu/drm/i915/gt/intel_gt.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index f069551e412f..4eb81e54ffed 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -628,6 +628,12 @@ void intel_gt_driver_release(struct intel_gt *gt)
 
 void intel_gt_driver_late_release(struct intel_gt *gt)
 {
+	intel_wakeref_t wakeref;
+
+	/* Scrub all HW state upon release */
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		__intel_gt_reset(gt, ALL_ENGINES);
+
 	/* We need to wait for inflight RCU frees to release their grip */
 	rcu_barrier();
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Force the GT reset on shutdown (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/gt: Force the GT reset on shutdown (rev2)
URL   : https://patchwork.freedesktop.org/series/77633/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8530 -> Patchwork_17771
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_17771 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_17771, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_17771:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@reload:
    - fi-apl-guc:         [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-apl-guc/igt@i915_module_load@reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-apl-guc/igt@i915_module_load@reload.html
    - fi-snb-2520m:       [PASS][3] -> [INCOMPLETE][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-snb-2520m/igt@i915_module_load@reload.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-snb-2520m/igt@i915_module_load@reload.html
    - fi-kbl-soraka:      [PASS][5] -> [INCOMPLETE][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-kbl-soraka/igt@i915_module_load@reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-kbl-soraka/igt@i915_module_load@reload.html
    - fi-bsw-n3050:       [PASS][7] -> [INCOMPLETE][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-bsw-n3050/igt@i915_module_load@reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-bsw-n3050/igt@i915_module_load@reload.html
    - fi-ilk-650:         [PASS][9] -> [INCOMPLETE][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-ilk-650/igt@i915_module_load@reload.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-ilk-650/igt@i915_module_load@reload.html
    - fi-ivb-3770:        [PASS][11] -> [INCOMPLETE][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-ivb-3770/igt@i915_module_load@reload.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-ivb-3770/igt@i915_module_load@reload.html
    - fi-bsw-kefka:       [PASS][13] -> [INCOMPLETE][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-bsw-kefka/igt@i915_module_load@reload.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-bsw-kefka/igt@i915_module_load@reload.html
    - fi-bsw-nick:        [PASS][15] -> [INCOMPLETE][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-bsw-nick/igt@i915_module_load@reload.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-bsw-nick/igt@i915_module_load@reload.html

  * igt@i915_selftest@live@uncore:
    - fi-bxt-dsi:         [PASS][17] -> [INCOMPLETE][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-bxt-dsi/igt@i915_selftest@live@uncore.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-bxt-dsi/igt@i915_selftest@live@uncore.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live@gem_contexts:
    - {fi-ehl-1}:         [PASS][19] -> [INCOMPLETE][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-ehl-1/igt@i915_selftest@live@gem_contexts.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-ehl-1/igt@i915_selftest@live@gem_contexts.html

  
Known issues
------------

  Here are the changes found in Patchwork_17771 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload:
    - fi-byt-j1900:       [PASS][21] -> [INCOMPLETE][22] ([i915#45])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-byt-j1900/igt@i915_module_load@reload.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-byt-j1900/igt@i915_module_load@reload.html
    - fi-elk-e7500:       [PASS][23] -> [INCOMPLETE][24] ([i915#66])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-elk-e7500/igt@i915_module_load@reload.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-elk-e7500/igt@i915_module_load@reload.html
    - fi-byt-n2820:       [PASS][25] -> [INCOMPLETE][26] ([i915#45])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-byt-n2820/igt@i915_module_load@reload.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-byt-n2820/igt@i915_module_load@reload.html
    - fi-glk-dsi:         [PASS][27] -> [INCOMPLETE][28] ([i915#58] / [k.org#198133])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-glk-dsi/igt@i915_module_load@reload.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-glk-dsi/igt@i915_module_load@reload.html
    - fi-snb-2600:        [PASS][29] -> [INCOMPLETE][30] ([i915#82])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8530/fi-snb-2600/igt@i915_module_load@reload.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/fi-snb-2600/igt@i915_module_load@reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
  [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
  [i915#66]: https://gitlab.freedesktop.org/drm/intel/issues/66
  [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (49 -> 44)
------------------------------

  Additional (2): fi-kbl-7560u fi-whl-u 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8530 -> Patchwork_17771

  CI-20190529: 20190529
  CI_DRM_8530: 5837860f93ba9d456fc0432300968332c0aa65b4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5678: c1f30ee09ac2e7eb3e8e90245239731a169a6050 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17771: f1b3cd50fac20e040d89e7fb466f0c059e365c38 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

f1b3cd50fac2 drm/i915/gt: Force the GT reset on shutdown

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17771/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/gt: Force the GT reset on shutdown

[Chris Wilson]

Before we return control to the system, and letting it reuse all the
pages being accessed by HW, we must disable the HW. At the moment, we
dare not reset the GPU if it will clobber the display, but once we know
the display has been disabled, we can proceed with the reset as we
shutdown the module. We know the next user must reinitialise the HW for
their purpose.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/489
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
---
 drivers/gpu/drm/i915/gt/intel_gt.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index f069551e412f..ebc29b6ee86c 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -616,6 +616,11 @@ void intel_gt_driver_unregister(struct intel_gt *gt)
 void intel_gt_driver_release(struct intel_gt *gt)
 {
 	struct i915_address_space *vm;
+	intel_wakeref_t wakeref;
+
+	/* Scrub all HW state upon release */
+	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
+		__intel_gt_reset(gt, ALL_ENGINES);
 
 	vm = fetch_and_zero(&gt->vm);
 	if (vm) /* FIXME being called twice on error paths :( */
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Force the GT reset on shutdown (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/gt: Force the GT reset on shutdown (rev3)
URL   : https://patchwork.freedesktop.org/series/77633/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8532 -> Patchwork_17773
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/index.html


Changes
-------

  No changes found


Participating hosts (50 -> 44)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_8532 -> Patchwork_17773

  CI-20190529: 20190529
  CI_DRM_8532: b1b6bf3b5bb13d79e0264498dfb7f71656149870 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5678: c1f30ee09ac2e7eb3e8e90245239731a169a6050 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17773: 07c36cc6f9acbb3e23aa80a03cf69063566dff38 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

07c36cc6f9ac drm/i915/gt: Force the GT reset on shutdown

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Force the GT reset on shutdown (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/gt: Force the GT reset on shutdown (rev3)
URL   : https://patchwork.freedesktop.org/series/77633/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8532_full -> Patchwork_17773_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_17773_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@legacy-engines-mixed-process@render:
    - shard-skl:          [PASS][1] -> [FAIL][2] ([i915#1528])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-skl1/igt@gem_ctx_persistence@legacy-engines-mixed-process@render.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-skl6/igt@gem_ctx_persistence@legacy-engines-mixed-process@render.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-skl:          [PASS][3] -> [INCOMPLETE][4] ([i915#151] / [i915#69])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-skl10/igt@i915_pm_rpm@system-suspend-modeset.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-skl9/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([i915#180])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
    - shard-skl:          [PASS][7] -> [FAIL][8] ([i915#54])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109441]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-iclb7/igt@kms_psr@psr2_cursor_render.html

  
#### Possible fixes ####

  * igt@kms_big_fb@x-tiled-64bpp-rotate-180:
    - shard-glk:          [FAIL][13] ([i915#1119] / [i915#118] / [i915#95]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-glk7/igt@kms_big_fb@x-tiled-64bpp-rotate-180.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-apl:          [DMESG-WARN][15] ([i915#180]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-apl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-apl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][17] ([fdo#109349]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * {igt@kms_flip@2x-plain-flip-ts-check@bc-hdmi-a1-hdmi-a2}:
    - shard-glk:          [FAIL][19] ([i915#1928]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-glk6/igt@kms_flip@2x-plain-flip-ts-check@bc-hdmi-a1-hdmi-a2.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-glk7/igt@kms_flip@2x-plain-flip-ts-check@bc-hdmi-a1-hdmi-a2.html

  * {igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1}:
    - shard-skl:          [FAIL][21] ([i915#1928]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-kbl:          [DMESG-WARN][23] ([i915#180]) -> [PASS][24] +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [FAIL][25] ([fdo#108145] / [i915#265]) -> [PASS][26] +3 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [SKIP][27] ([fdo#109441]) -> [PASS][28] +2 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

  
#### Warnings ####

  * igt@kms_content_protection@atomic-dpms:
    - shard-apl:          [TIMEOUT][29] ([i915#1319] / [i915#1635]) -> [TIMEOUT][30] ([i915#1319])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-apl2/igt@kms_content_protection@atomic-dpms.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-apl6/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@lic:
    - shard-apl:          [TIMEOUT][31] ([i915#1319] / [i915#1635]) -> [DMESG-FAIL][32] ([fdo#110321])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-apl6/igt@kms_content_protection@lic.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-apl6/igt@kms_content_protection@lic.html

  * igt@kms_content_protection@srm:
    - shard-apl:          [TIMEOUT][33] ([i915#1319] / [i915#1635]) -> [FAIL][34] ([fdo#110321])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-apl6/igt@kms_content_protection@srm.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-apl7/igt@kms_content_protection@srm.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
    - shard-glk:          [DMESG-FAIL][35] ([i915#1925]) -> [DMESG-WARN][36] ([i915#1926]) +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8532/shard-glk7/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/shard-glk9/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
  [i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
  [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
  [i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
  [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1925]: https://gitlab.freedesktop.org/drm/intel/issues/1925
  [i915#1926]: https://gitlab.freedesktop.org/drm/intel/issues/1926
  [i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (11 -> 11)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_8532 -> Patchwork_17773

  CI-20190529: 20190529
  CI_DRM_8532: b1b6bf3b5bb13d79e0264498dfb7f71656149870 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5678: c1f30ee09ac2e7eb3e8e90245239731a169a6050 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_17773: 07c36cc6f9acbb3e23aa80a03cf69063566dff38 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17773/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gt: Force the GT reset on shutdown

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Before we return control to the system, and letting it reuse all the
> pages being accessed by HW, we must disable the HW. At the moment, we
> dare not reset the GPU if it will clobber the display, but once we know
> the display has been disabled, we can proceed with the reset as we
> shutdown the module. We know the next user must reinitialise the HW for
> their purpose.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/489
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@kernel.org

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_gt.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> index f069551e412f..ebc29b6ee86c 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -616,6 +616,11 @@ void intel_gt_driver_unregister(struct intel_gt *gt)
>  void intel_gt_driver_release(struct intel_gt *gt)
>  {
>  	struct i915_address_space *vm;
> +	intel_wakeref_t wakeref;
> +
> +	/* Scrub all HW state upon release */
> +	with_intel_runtime_pm(gt->uncore->rpm, wakeref)
> +		__intel_gt_reset(gt, ALL_ENGINES);
>  
>  	vm = fetch_and_zero(&gt->vm);
>  	if (vm) /* FIXME being called twice on error paths :( */
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx